From: Paul Gortmaker <paul.gortmaker@windriver.com> To: linux-kernel@vger.kernel.org Cc: Paul Gortmaker <paul.gortmaker@windriver.com>, Linus Walleij <linus.walleij@linaro.org>, Beniamino Galvani <b.galvani@gmail.com>, Carlo Caione <carlo@endlessm.com>, Masahiro Yamada <yamada.masahiro@socionext.com>, Antoine Tenart <antoine.tenart@free-electrons.com>, linux-gpio@vger.kernel.org Subject: [PATCH 3/8] drivers/pinctrl: make meson/pinctrl-meson.c explicitly non-modular Date: Mon, 29 Feb 2016 15:48:39 -0500 [thread overview] Message-ID: <1456778924-20730-4-git-send-email-paul.gortmaker@windriver.com> (raw) In-Reply-To: <1456778924-20730-1-git-send-email-paul.gortmaker@windriver.com> The Kconfig currently controlling compilation of this code is: drivers/pinctrl/Kconfig:config PINCTRL_MESON drivers/pinctrl/Kconfig: bool ...meaning that it currently is not being built as a module by anyone. Lets remove the couple traces of modularity so that when reading the driver there is no doubt it is builtin-only. Since module_platform_driver() uses the same init level priority as builtin_platform_driver() the init ordering remains unchanged with this commit. We don't replace module.h with init.h since the file already has that. Also note that MODULE_DEVICE_TABLE is a no-op for non-modular code. We also delete the MODULE_LICENSE tag etc. since all that information is already contained at the top of the file in the comments. Cc: Linus Walleij <linus.walleij@linaro.org> Cc: Beniamino Galvani <b.galvani@gmail.com> Cc: Carlo Caione <carlo@endlessm.com> Cc: Masahiro Yamada <yamada.masahiro@socionext.com> Cc: Antoine Tenart <antoine.tenart@free-electrons.com> Cc: linux-gpio@vger.kernel.org Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com> --- drivers/pinctrl/meson/pinctrl-meson.c | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/drivers/pinctrl/meson/pinctrl-meson.c b/drivers/pinctrl/meson/pinctrl-meson.c index 50cab27c64d4..3dd1a446f6f4 100644 --- a/drivers/pinctrl/meson/pinctrl-meson.c +++ b/drivers/pinctrl/meson/pinctrl-meson.c @@ -49,7 +49,6 @@ #include <linux/gpio.h> #include <linux/init.h> #include <linux/io.h> -#include <linux/module.h> #include <linux/of.h> #include <linux/of_address.h> #include <linux/pinctrl/pinconf-generic.h> @@ -546,7 +545,6 @@ static const struct of_device_id meson_pinctrl_dt_match[] = { }, { }, }; -MODULE_DEVICE_TABLE(of, meson_pinctrl_dt_match); static int meson_gpiolib_register(struct meson_pinctrl *pc) { @@ -754,8 +752,4 @@ static struct platform_driver meson_pinctrl_driver = { .of_match_table = meson_pinctrl_dt_match, }, }; -module_platform_driver(meson_pinctrl_driver); - -MODULE_AUTHOR("Beniamino Galvani <b.galvani@gmail.com>"); -MODULE_DESCRIPTION("Amlogic Meson pinctrl driver"); -MODULE_LICENSE("GPL v2"); +builtin_platform_driver(meson_pinctrl_driver); -- 2.6.1
WARNING: multiple messages have this Message-ID (diff)
From: Paul Gortmaker <paul.gortmaker@windriver.com> To: <linux-kernel@vger.kernel.org> Cc: Paul Gortmaker <paul.gortmaker@windriver.com>, Linus Walleij <linus.walleij@linaro.org>, Beniamino Galvani <b.galvani@gmail.com>, Carlo Caione <carlo@endlessm.com>, Masahiro Yamada <yamada.masahiro@socionext.com>, Antoine Tenart <antoine.tenart@free-electrons.com>, <linux-gpio@vger.kernel.org> Subject: [PATCH 3/8] drivers/pinctrl: make meson/pinctrl-meson.c explicitly non-modular Date: Mon, 29 Feb 2016 15:48:39 -0500 [thread overview] Message-ID: <1456778924-20730-4-git-send-email-paul.gortmaker@windriver.com> (raw) In-Reply-To: <1456778924-20730-1-git-send-email-paul.gortmaker@windriver.com> The Kconfig currently controlling compilation of this code is: drivers/pinctrl/Kconfig:config PINCTRL_MESON drivers/pinctrl/Kconfig: bool ...meaning that it currently is not being built as a module by anyone. Lets remove the couple traces of modularity so that when reading the driver there is no doubt it is builtin-only. Since module_platform_driver() uses the same init level priority as builtin_platform_driver() the init ordering remains unchanged with this commit. We don't replace module.h with init.h since the file already has that. Also note that MODULE_DEVICE_TABLE is a no-op for non-modular code. We also delete the MODULE_LICENSE tag etc. since all that information is already contained at the top of the file in the comments. Cc: Linus Walleij <linus.walleij@linaro.org> Cc: Beniamino Galvani <b.galvani@gmail.com> Cc: Carlo Caione <carlo@endlessm.com> Cc: Masahiro Yamada <yamada.masahiro@socionext.com> Cc: Antoine Tenart <antoine.tenart@free-electrons.com> Cc: linux-gpio@vger.kernel.org Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com> --- drivers/pinctrl/meson/pinctrl-meson.c | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/drivers/pinctrl/meson/pinctrl-meson.c b/drivers/pinctrl/meson/pinctrl-meson.c index 50cab27c64d4..3dd1a446f6f4 100644 --- a/drivers/pinctrl/meson/pinctrl-meson.c +++ b/drivers/pinctrl/meson/pinctrl-meson.c @@ -49,7 +49,6 @@ #include <linux/gpio.h> #include <linux/init.h> #include <linux/io.h> -#include <linux/module.h> #include <linux/of.h> #include <linux/of_address.h> #include <linux/pinctrl/pinconf-generic.h> @@ -546,7 +545,6 @@ static const struct of_device_id meson_pinctrl_dt_match[] = { }, { }, }; -MODULE_DEVICE_TABLE(of, meson_pinctrl_dt_match); static int meson_gpiolib_register(struct meson_pinctrl *pc) { @@ -754,8 +752,4 @@ static struct platform_driver meson_pinctrl_driver = { .of_match_table = meson_pinctrl_dt_match, }, }; -module_platform_driver(meson_pinctrl_driver); - -MODULE_AUTHOR("Beniamino Galvani <b.galvani@gmail.com>"); -MODULE_DESCRIPTION("Amlogic Meson pinctrl driver"); -MODULE_LICENSE("GPL v2"); +builtin_platform_driver(meson_pinctrl_driver); -- 2.6.1
next prev parent reply other threads:[~2016-02-29 20:49 UTC|newest] Thread overview: 58+ messages / expand[flat|nested] mbox.gz Atom feed top 2016-02-29 20:48 [PATCH 0/8] drivers/pinctrl: remove truly orphaned module code Paul Gortmaker 2016-02-29 20:48 ` Paul Gortmaker 2016-02-29 20:48 ` Paul Gortmaker 2016-02-29 20:48 ` [PATCH 1/8] drivers/pinctrl: sunxi/pinctrl-sunxi.c does not need module.h Paul Gortmaker 2016-02-29 20:48 ` Paul Gortmaker 2016-02-29 20:48 ` Paul Gortmaker 2016-03-01 7:13 ` Maxime Ripard 2016-03-01 7:13 ` Maxime Ripard 2016-03-09 2:59 ` Linus Walleij 2016-03-09 2:59 ` Linus Walleij 2016-03-09 2:59 ` Linus Walleij [not found] ` <1456778924-20730-1-git-send-email-paul.gortmaker-CWA4WttNNZF54TAoqtyWWQ@public.gmane.org> 2016-02-29 20:48 ` [PATCH 2/8] drivers/pinctrl: make mediatek/pinctrl-mt6397 driver explicitly non-modular Paul Gortmaker 2016-02-29 20:48 ` Paul Gortmaker [not found] ` <1456778924-20730-3-git-send-email-paul.gortmaker-CWA4WttNNZF54TAoqtyWWQ@public.gmane.org> 2016-03-01 20:02 ` Hongzhou Yang 2016-03-01 20:02 ` Hongzhou Yang 2016-03-09 3:01 ` Linus Walleij 2016-03-09 3:01 ` Linus Walleij 2016-02-29 20:48 ` Paul Gortmaker [this message] 2016-02-29 20:48 ` [PATCH 3/8] drivers/pinctrl: make meson/pinctrl-meson.c " Paul Gortmaker 2016-03-09 3:04 ` Linus Walleij 2016-02-29 20:48 ` [PATCH 4/8] drivers/pinctrl: make sh-pfc/core.c " Paul Gortmaker 2016-02-29 20:48 ` Paul Gortmaker 2016-02-29 22:00 ` Laurent Pinchart 2016-03-02 11:05 ` Geert Uytterhoeven 2016-03-09 3:24 ` Linus Walleij 2016-02-29 20:48 ` [PATCH 5/8] drivers/pinctrl: make stm32/pinctrl-stm32f429.c " Paul Gortmaker 2016-02-29 20:48 ` Paul Gortmaker 2016-02-29 20:48 ` Paul Gortmaker 2016-03-01 9:01 ` Maxime Coquelin 2016-03-01 9:01 ` Maxime Coquelin 2016-03-01 9:01 ` Maxime Coquelin 2016-03-09 3:25 ` Linus Walleij 2016-03-09 3:25 ` Linus Walleij 2016-03-09 3:25 ` Linus Walleij 2016-02-29 20:48 ` [PATCH 6/8] drivers/pinctrl: make sunxi/pinctrl-sun[4-9]* " Paul Gortmaker 2016-02-29 20:48 ` Paul Gortmaker 2016-02-29 20:48 ` Paul Gortmaker 2016-03-01 7:14 ` Maxime Ripard 2016-03-01 7:14 ` Maxime Ripard 2016-02-29 20:48 ` [PATCH 7/8] drivers/pinctrl: make sunxi/pinctrl-sun9i-a80-r.c " Paul Gortmaker 2016-02-29 20:48 ` Paul Gortmaker 2016-02-29 20:48 ` Paul Gortmaker 2016-03-01 7:14 ` Maxime Ripard 2016-03-01 7:14 ` Maxime Ripard 2016-03-09 3:28 ` Linus Walleij 2016-03-09 3:28 ` Linus Walleij 2016-03-09 3:28 ` Linus Walleij 2016-02-29 20:48 ` [PATCH 8/8] drivers/pinctrl: clean up samsung modular vs. non-modular distinctions Paul Gortmaker 2016-02-29 20:48 ` Paul Gortmaker 2016-02-29 20:48 ` Paul Gortmaker 2016-03-15 8:50 ` Linus Walleij 2016-03-15 8:50 ` Linus Walleij 2016-03-15 8:50 ` Linus Walleij 2016-03-15 13:20 ` Paul Gortmaker 2016-03-15 13:20 ` Paul Gortmaker 2016-03-15 13:20 ` Paul Gortmaker 2016-03-15 10:10 ` Sylwester Nawrocki 2016-03-15 10:10 ` Sylwester Nawrocki
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1456778924-20730-4-git-send-email-paul.gortmaker@windriver.com \ --to=paul.gortmaker@windriver.com \ --cc=antoine.tenart@free-electrons.com \ --cc=b.galvani@gmail.com \ --cc=carlo@endlessm.com \ --cc=linus.walleij@linaro.org \ --cc=linux-gpio@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=yamada.masahiro@socionext.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.