From: Sylwester Nawrocki <s.nawrocki@samsung.com>
To: Paul Gortmaker <paul.gortmaker@windriver.com>
Cc: linux-kernel@vger.kernel.org, Tomasz Figa <tomasz.figa@gmail.com>,
Thomas Abraham <thomas.ab@samsung.com>,
Linus Walleij <linus.walleij@linaro.org>,
linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org, linux-gpio@vger.kernel.org
Subject: Re: [PATCH 8/8] drivers/pinctrl: clean up samsung modular vs. non-modular distinctions
Date: Tue, 15 Mar 2016 11:10:20 +0100 [thread overview]
Message-ID: <56E7DF8C.4030005@samsung.com> (raw)
In-Reply-To: <1456778924-20730-9-git-send-email-paul.gortmaker@windriver.com>
On 02/29/2016 09:48 PM, Paul Gortmaker wrote:
> Fixups here tend to be more all over the map vs. some of the other
> repeated/systematic ones we've seen elsewhere.
>
> We remove module.h from code that isn't doing anything modular at
> all; if they have __init sections, then replace it with init.h
>
> A couple drivers have module_exit() code that is essentially orphaned,
> and so we remove that.
>
> There are no module_init replacements, so we have no concerns wrt.
> initcall ordering changes as per some of the other cleanups.
>
> Also note that MODULE_DEVICE_TABLE is a no-op for non-modular code.
>
> We also delete the MODULE_LICENSE tag etc. since all that information
> was (or is now) contained at the top of the file in the comments.
>
> Cc: Tomasz Figa <tomasz.figa@gmail.com>
> Cc: Thomas Abraham <thomas.ab@samsung.com>
> Cc: Linus Walleij <linus.walleij@linaro.org>
> Cc: linux-arm-kernel@lists.infradead.org
> Cc: linux-samsung-soc@vger.kernel.org
> Cc: linux-gpio@vger.kernel.org
> Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
> ---
> drivers/pinctrl/samsung/pinctrl-exynos.c | 1 -
> drivers/pinctrl/samsung/pinctrl-exynos5440.c | 15 +++------------
> drivers/pinctrl/samsung/pinctrl-s3c24xx.c | 2 +-
> drivers/pinctrl/samsung/pinctrl-s3c64xx.c | 2 +-
> drivers/pinctrl/samsung/pinctrl-samsung.c | 12 +-----------
> 5 files changed, 6 insertions(+), 26 deletions(-)
Acked-by: Sylwester Nawrocki <s.nawrocki@samsung.com>
--
Thanks,
Sylwester
WARNING: multiple messages have this Message-ID (diff)
From: s.nawrocki@samsung.com (Sylwester Nawrocki)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 8/8] drivers/pinctrl: clean up samsung modular vs. non-modular distinctions
Date: Tue, 15 Mar 2016 11:10:20 +0100 [thread overview]
Message-ID: <56E7DF8C.4030005@samsung.com> (raw)
In-Reply-To: <1456778924-20730-9-git-send-email-paul.gortmaker@windriver.com>
On 02/29/2016 09:48 PM, Paul Gortmaker wrote:
> Fixups here tend to be more all over the map vs. some of the other
> repeated/systematic ones we've seen elsewhere.
>
> We remove module.h from code that isn't doing anything modular at
> all; if they have __init sections, then replace it with init.h
>
> A couple drivers have module_exit() code that is essentially orphaned,
> and so we remove that.
>
> There are no module_init replacements, so we have no concerns wrt.
> initcall ordering changes as per some of the other cleanups.
>
> Also note that MODULE_DEVICE_TABLE is a no-op for non-modular code.
>
> We also delete the MODULE_LICENSE tag etc. since all that information
> was (or is now) contained at the top of the file in the comments.
>
> Cc: Tomasz Figa <tomasz.figa@gmail.com>
> Cc: Thomas Abraham <thomas.ab@samsung.com>
> Cc: Linus Walleij <linus.walleij@linaro.org>
> Cc: linux-arm-kernel at lists.infradead.org
> Cc: linux-samsung-soc at vger.kernel.org
> Cc: linux-gpio at vger.kernel.org
> Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
> ---
> drivers/pinctrl/samsung/pinctrl-exynos.c | 1 -
> drivers/pinctrl/samsung/pinctrl-exynos5440.c | 15 +++------------
> drivers/pinctrl/samsung/pinctrl-s3c24xx.c | 2 +-
> drivers/pinctrl/samsung/pinctrl-s3c64xx.c | 2 +-
> drivers/pinctrl/samsung/pinctrl-samsung.c | 12 +-----------
> 5 files changed, 6 insertions(+), 26 deletions(-)
Acked-by: Sylwester Nawrocki <s.nawrocki@samsung.com>
--
Thanks,
Sylwester
next prev parent reply other threads:[~2016-03-15 10:10 UTC|newest]
Thread overview: 58+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-29 20:48 [PATCH 0/8] drivers/pinctrl: remove truly orphaned module code Paul Gortmaker
2016-02-29 20:48 ` Paul Gortmaker
2016-02-29 20:48 ` Paul Gortmaker
2016-02-29 20:48 ` [PATCH 1/8] drivers/pinctrl: sunxi/pinctrl-sunxi.c does not need module.h Paul Gortmaker
2016-02-29 20:48 ` Paul Gortmaker
2016-02-29 20:48 ` Paul Gortmaker
2016-03-01 7:13 ` Maxime Ripard
2016-03-01 7:13 ` Maxime Ripard
2016-03-09 2:59 ` Linus Walleij
2016-03-09 2:59 ` Linus Walleij
2016-03-09 2:59 ` Linus Walleij
[not found] ` <1456778924-20730-1-git-send-email-paul.gortmaker-CWA4WttNNZF54TAoqtyWWQ@public.gmane.org>
2016-02-29 20:48 ` [PATCH 2/8] drivers/pinctrl: make mediatek/pinctrl-mt6397 driver explicitly non-modular Paul Gortmaker
2016-02-29 20:48 ` Paul Gortmaker
[not found] ` <1456778924-20730-3-git-send-email-paul.gortmaker-CWA4WttNNZF54TAoqtyWWQ@public.gmane.org>
2016-03-01 20:02 ` Hongzhou Yang
2016-03-01 20:02 ` Hongzhou Yang
2016-03-09 3:01 ` Linus Walleij
2016-03-09 3:01 ` Linus Walleij
2016-02-29 20:48 ` [PATCH 3/8] drivers/pinctrl: make meson/pinctrl-meson.c " Paul Gortmaker
2016-02-29 20:48 ` Paul Gortmaker
2016-03-09 3:04 ` Linus Walleij
2016-02-29 20:48 ` [PATCH 4/8] drivers/pinctrl: make sh-pfc/core.c " Paul Gortmaker
2016-02-29 20:48 ` Paul Gortmaker
2016-02-29 22:00 ` Laurent Pinchart
2016-03-02 11:05 ` Geert Uytterhoeven
2016-03-09 3:24 ` Linus Walleij
2016-02-29 20:48 ` [PATCH 5/8] drivers/pinctrl: make stm32/pinctrl-stm32f429.c " Paul Gortmaker
2016-02-29 20:48 ` Paul Gortmaker
2016-02-29 20:48 ` Paul Gortmaker
2016-03-01 9:01 ` Maxime Coquelin
2016-03-01 9:01 ` Maxime Coquelin
2016-03-01 9:01 ` Maxime Coquelin
2016-03-09 3:25 ` Linus Walleij
2016-03-09 3:25 ` Linus Walleij
2016-03-09 3:25 ` Linus Walleij
2016-02-29 20:48 ` [PATCH 6/8] drivers/pinctrl: make sunxi/pinctrl-sun[4-9]* " Paul Gortmaker
2016-02-29 20:48 ` Paul Gortmaker
2016-02-29 20:48 ` Paul Gortmaker
2016-03-01 7:14 ` Maxime Ripard
2016-03-01 7:14 ` Maxime Ripard
2016-02-29 20:48 ` [PATCH 7/8] drivers/pinctrl: make sunxi/pinctrl-sun9i-a80-r.c " Paul Gortmaker
2016-02-29 20:48 ` Paul Gortmaker
2016-02-29 20:48 ` Paul Gortmaker
2016-03-01 7:14 ` Maxime Ripard
2016-03-01 7:14 ` Maxime Ripard
2016-03-09 3:28 ` Linus Walleij
2016-03-09 3:28 ` Linus Walleij
2016-03-09 3:28 ` Linus Walleij
2016-02-29 20:48 ` [PATCH 8/8] drivers/pinctrl: clean up samsung modular vs. non-modular distinctions Paul Gortmaker
2016-02-29 20:48 ` Paul Gortmaker
2016-02-29 20:48 ` Paul Gortmaker
2016-03-15 8:50 ` Linus Walleij
2016-03-15 8:50 ` Linus Walleij
2016-03-15 8:50 ` Linus Walleij
2016-03-15 13:20 ` Paul Gortmaker
2016-03-15 13:20 ` Paul Gortmaker
2016-03-15 13:20 ` Paul Gortmaker
2016-03-15 10:10 ` Sylwester Nawrocki [this message]
2016-03-15 10:10 ` Sylwester Nawrocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56E7DF8C.4030005@samsung.com \
--to=s.nawrocki@samsung.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=paul.gortmaker@windriver.com \
--cc=thomas.ab@samsung.com \
--cc=tomasz.figa@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.