From: Richard Weinberger <richard@nod.at> To: linux-mtd@lists.infradead.org Cc: linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, boris.brezillon@free-electrons.com, maxime.ripard@free-electrons.com, david@sigma-star.at, david@fromorbit.com, dedekind1@gmail.com, alex@nextthing.co, akpm@linux-foundation.org, sasha.levin@oracle.com, iamjoonsoo.kim@lge.com, rvaswani@codeaurora.org, tony.luck@intel.com, shailendra.capricorn@gmail.com, "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>, Richard Weinberger <richard@nod.at> Subject: [PATCH] UBIFS: Implement ->migratepage() Date: Wed, 16 Mar 2016 23:55:19 +0100 [thread overview] Message-ID: <1458168919-11597-1-git-send-email-richard@nod.at> (raw) In-Reply-To: <56E9C658.1020903@nod.at> From: "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com> When using CMA during page migrations UBIFS might get confused and the following assert triggers: UBIFS assert failed in ubifs_set_page_dirty at 1451 (pid 436) UBIFS is using PagePrivate() which can have different meanings across filesystems. Therefore the generic page migration code cannot handle this case correctly. We have to implement our own migration function which basically does a plain copy but also duplicates the page private flag. Signed-off-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com> [rw: Massaged changelog] Signed-off-by: Richard Weinberger <richard@nod.at> --- fs/ubifs/file.c | 20 ++++++++++++++++++++ 1 file changed, 20 insertions(+) diff --git a/fs/ubifs/file.c b/fs/ubifs/file.c index 0edc128..48b2944 100644 --- a/fs/ubifs/file.c +++ b/fs/ubifs/file.c @@ -52,6 +52,7 @@ #include "ubifs.h" #include <linux/mount.h> #include <linux/slab.h> +#include <linux/migrate.h> static int read_block(struct inode *inode, void *addr, unsigned int block, struct ubifs_data_node *dn) @@ -1452,6 +1453,24 @@ static int ubifs_set_page_dirty(struct page *page) return ret; } +static int ubifs_migrate_page(struct address_space *mapping, + struct page *newpage, struct page *page, enum migrate_mode mode) +{ + int rc; + + rc = migrate_page_move_mapping(mapping, newpage, page, NULL, mode, 0); + if (rc != MIGRATEPAGE_SUCCESS) + return rc; + + if (PagePrivate(page)) { + ClearPagePrivate(page); + SetPagePrivate(newpage); + } + + migrate_page_copy(newpage, page); + return MIGRATEPAGE_SUCCESS; +} + static int ubifs_releasepage(struct page *page, gfp_t unused_gfp_flags) { /* @@ -1591,6 +1610,7 @@ const struct address_space_operations ubifs_file_address_operations = { .write_end = ubifs_write_end, .invalidatepage = ubifs_invalidatepage, .set_page_dirty = ubifs_set_page_dirty, + .migratepage = ubifs_migrate_page, .releasepage = ubifs_releasepage, }; -- 2.5.0
WARNING: multiple messages have this Message-ID (diff)
From: Richard Weinberger <richard@nod.at> To: linux-mtd@lists.infradead.org Cc: linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, boris.brezillon@free-electrons.com, maxime.ripard@free-electrons.com, david@sigma-star.at, david@fromorbit.com, dedekind1@gmail.com, alex@nextthing.co, akpm@linux-foundation.org, sasha.levin@oracle.com, iamjoonsoo.kim@lge.com, rvaswani@codeaurora.org, tony.luck@intel.com, shailendra.capricorn@gmail.com, "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>, Richard Weinberger <richard@nod.at> Subject: [PATCH] UBIFS: Implement ->migratepage() Date: Wed, 16 Mar 2016 23:55:19 +0100 [thread overview] Message-ID: <1458168919-11597-1-git-send-email-richard@nod.at> (raw) In-Reply-To: <56E9C658.1020903@nod.at> From: "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com> When using CMA during page migrations UBIFS might get confused and the following assert triggers: UBIFS assert failed in ubifs_set_page_dirty at 1451 (pid 436) UBIFS is using PagePrivate() which can have different meanings across filesystems. Therefore the generic page migration code cannot handle this case correctly. We have to implement our own migration function which basically does a plain copy but also duplicates the page private flag. Signed-off-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com> [rw: Massaged changelog] Signed-off-by: Richard Weinberger <richard@nod.at> --- fs/ubifs/file.c | 20 ++++++++++++++++++++ 1 file changed, 20 insertions(+) diff --git a/fs/ubifs/file.c b/fs/ubifs/file.c index 0edc128..48b2944 100644 --- a/fs/ubifs/file.c +++ b/fs/ubifs/file.c @@ -52,6 +52,7 @@ #include "ubifs.h" #include <linux/mount.h> #include <linux/slab.h> +#include <linux/migrate.h> static int read_block(struct inode *inode, void *addr, unsigned int block, struct ubifs_data_node *dn) @@ -1452,6 +1453,24 @@ static int ubifs_set_page_dirty(struct page *page) return ret; } +static int ubifs_migrate_page(struct address_space *mapping, + struct page *newpage, struct page *page, enum migrate_mode mode) +{ + int rc; + + rc = migrate_page_move_mapping(mapping, newpage, page, NULL, mode, 0); + if (rc != MIGRATEPAGE_SUCCESS) + return rc; + + if (PagePrivate(page)) { + ClearPagePrivate(page); + SetPagePrivate(newpage); + } + + migrate_page_copy(newpage, page); + return MIGRATEPAGE_SUCCESS; +} + static int ubifs_releasepage(struct page *page, gfp_t unused_gfp_flags) { /* @@ -1591,6 +1610,7 @@ const struct address_space_operations ubifs_file_address_operations = { .write_end = ubifs_write_end, .invalidatepage = ubifs_invalidatepage, .set_page_dirty = ubifs_set_page_dirty, + .migratepage = ubifs_migrate_page, .releasepage = ubifs_releasepage, }; -- 2.5.0 -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2016-03-16 22:55 UTC|newest] Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top 2016-03-15 14:16 Page migration issue with UBIFS Richard Weinberger 2016-03-15 14:16 ` Richard Weinberger 2016-03-15 15:17 ` Kirill A. Shutemov 2016-03-15 15:17 ` Kirill A. Shutemov 2016-03-15 15:25 ` Richard Weinberger 2016-03-15 15:25 ` Richard Weinberger 2016-03-15 15:35 ` Christoph Hellwig 2016-03-15 15:35 ` Christoph Hellwig 2016-03-15 15:47 ` Kirill A. Shutemov 2016-03-15 15:47 ` Kirill A. Shutemov 2016-03-15 15:32 ` Richard Weinberger 2016-03-15 15:32 ` Richard Weinberger 2016-03-15 15:37 ` Christoph Hellwig 2016-03-15 15:37 ` Christoph Hellwig 2016-03-15 16:02 ` Richard Weinberger 2016-03-15 16:02 ` Richard Weinberger 2016-03-15 23:18 ` Richard Weinberger 2016-03-15 23:18 ` Richard Weinberger 2016-03-16 14:21 ` Kirill A. Shutemov 2016-03-16 14:21 ` Kirill A. Shutemov 2016-03-16 14:27 ` Kirill A. Shutemov 2016-03-16 14:27 ` Kirill A. Shutemov 2016-03-16 20:47 ` Richard Weinberger 2016-03-16 20:47 ` Richard Weinberger 2016-03-16 22:55 ` Richard Weinberger [this message] 2016-03-16 22:55 ` [PATCH] UBIFS: Implement ->migratepage() Richard Weinberger 2016-03-16 23:12 ` kbuild test robot 2016-03-16 23:12 ` kbuild test robot 2016-03-17 4:39 ` kbuild test robot 2016-03-17 4:39 ` kbuild test robot 2016-03-17 8:09 ` Richard Weinberger 2016-03-17 8:09 ` Richard Weinberger 2016-03-17 9:57 ` Vlastimil Babka 2016-03-17 9:57 ` Vlastimil Babka 2016-03-25 22:53 ` Richard Weinberger 2016-03-25 22:53 ` Richard Weinberger 2016-03-17 7:11 ` Page migration issue with UBIFS Joonsoo Kim 2016-03-17 7:11 ` Joonsoo Kim 2016-03-17 8:13 ` Richard Weinberger 2016-03-17 8:13 ` Richard Weinberger 2016-03-17 15:17 ` Joonsoo Kim 2016-03-17 15:17 ` Joonsoo Kim 2016-03-21 23:00 ` Andrew Morton 2016-03-21 23:00 ` Andrew Morton 2016-03-21 23:06 ` Richard Weinberger 2016-03-21 23:06 ` Richard Weinberger 2016-03-21 15:28 ` Christoph Hellwig 2016-03-21 15:28 ` Christoph Hellwig 2016-03-17 15:25 ` Boris Brezillon 2016-03-17 15:25 ` Boris Brezillon
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1458168919-11597-1-git-send-email-richard@nod.at \ --to=richard@nod.at \ --cc=akpm@linux-foundation.org \ --cc=alex@nextthing.co \ --cc=boris.brezillon@free-electrons.com \ --cc=david@fromorbit.com \ --cc=david@sigma-star.at \ --cc=dedekind1@gmail.com \ --cc=iamjoonsoo.kim@lge.com \ --cc=kirill.shutemov@linux.intel.com \ --cc=linux-fsdevel@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mm@kvack.org \ --cc=linux-mtd@lists.infradead.org \ --cc=maxime.ripard@free-electrons.com \ --cc=rvaswani@codeaurora.org \ --cc=sasha.levin@oracle.com \ --cc=shailendra.capricorn@gmail.com \ --cc=tony.luck@intel.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.