From: Caesar Wang <wxt@rock-chips.com>
To: edubezval@gmail.com, linux-pm@vger.kernel.org
Cc: Heiko Stuebner <heiko@sntech.de>,
dianders@chromium.org, briannorris@google.com,
smbarber@google.com, linux-rockchip@lists.infradead.org,
cf@rock-chips.com, huangtao@rock-chips.com,
dmitry.torokhov@gmail.com, javi.merino@arm.com, peter@piie.net,
rocky.hao@rock-chips.com, Sascha Hauer <s.hauer@pengutronix.de>,
Caesar Wang <wxt@rock-chips.com>, Zhang Rui <rui.zhang@intel.com>,
linux-kernel@vger.kernel.org
Subject: [PATCH v6 4/5] thermal: bang-bang governor: act on lower trip boundary
Date: Wed, 22 Jun 2016 16:42:04 +0800 [thread overview]
Message-ID: <1466584925-4829-5-git-send-email-wxt@rock-chips.com> (raw)
In-Reply-To: <1466584925-4829-1-git-send-email-wxt@rock-chips.com>
From: Sascha Hauer <s.hauer@pengutronix.de>
With interrupt driven thermal zones we pass the lower and upper
temperature on which shall be acted, so in the governor we have to act on
the exact lower temperature to be consistent. Otherwise an interrupt maybe
generated on the exact lower temperature, but the bang bang governor does
not react since The polling driven zones have to be one step cooler before
the governor reacts.
Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
Signed-off-by: Caesar Wang <wxt@rock-chips.com>
Cc: Zhang Rui <rui.zhang@intel.com>
Cc: Eduardo Valentin <edubezval@gmail.com>
Cc: linux-pm@vger.kernel.org
Acked-by: Peter Feuerer <peter@piie.net>
---
Changes in v6: None
Changes in v5: None
Changes in v4: None
Changes in v3:
- Add the peter's ACK.
Changes in v2:
- Update the commit for patch[v2 4/5].
drivers/thermal/gov_bang_bang.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/thermal/gov_bang_bang.c b/drivers/thermal/gov_bang_bang.c
index fc52016..5073871 100644
--- a/drivers/thermal/gov_bang_bang.c
+++ b/drivers/thermal/gov_bang_bang.c
@@ -65,7 +65,7 @@ static void thermal_zone_trip_update(struct thermal_zone_device *tz, int trip)
if (instance->target == 0 && tz->temperature >= trip_temp)
instance->target = 1;
else if (instance->target == 1 &&
- tz->temperature < trip_temp - trip_hyst)
+ tz->temperature <= trip_temp - trip_hyst)
instance->target = 0;
dev_dbg(&instance->cdev->device, "target=%d\n",
--
1.9.1
WARNING: multiple messages have this Message-ID (diff)
From: Caesar Wang <wxt-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
To: edubezval-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
linux-pm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Cc: huangtao-TNX95d0MmH7DzftRWevZcw@public.gmane.org,
javi.merino-5wv7dgnIgG8@public.gmane.org,
Heiko Stuebner <heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org>,
Sascha Hauer <s.hauer-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>,
dmitry.torokhov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
peter-p08lbbvQ7EI@public.gmane.org,
dianders-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
smbarber-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org,
cf-TNX95d0MmH7DzftRWevZcw@public.gmane.org,
briannorris-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org,
rocky.hao-TNX95d0MmH7DzftRWevZcw@public.gmane.org,
Zhang Rui <rui.zhang-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>,
Caesar Wang <wxt-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
Subject: [PATCH v6 4/5] thermal: bang-bang governor: act on lower trip boundary
Date: Wed, 22 Jun 2016 16:42:04 +0800 [thread overview]
Message-ID: <1466584925-4829-5-git-send-email-wxt@rock-chips.com> (raw)
In-Reply-To: <1466584925-4829-1-git-send-email-wxt-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
From: Sascha Hauer <s.hauer-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
With interrupt driven thermal zones we pass the lower and upper
temperature on which shall be acted, so in the governor we have to act on
the exact lower temperature to be consistent. Otherwise an interrupt maybe
generated on the exact lower temperature, but the bang bang governor does
not react since The polling driven zones have to be one step cooler before
the governor reacts.
Signed-off-by: Sascha Hauer <s.hauer-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
Signed-off-by: Caesar Wang <wxt-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
Cc: Zhang Rui <rui.zhang-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Cc: Eduardo Valentin <edubezval-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: linux-pm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Acked-by: Peter Feuerer <peter-p08lbbvQ7EI@public.gmane.org>
---
Changes in v6: None
Changes in v5: None
Changes in v4: None
Changes in v3:
- Add the peter's ACK.
Changes in v2:
- Update the commit for patch[v2 4/5].
drivers/thermal/gov_bang_bang.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/thermal/gov_bang_bang.c b/drivers/thermal/gov_bang_bang.c
index fc52016..5073871 100644
--- a/drivers/thermal/gov_bang_bang.c
+++ b/drivers/thermal/gov_bang_bang.c
@@ -65,7 +65,7 @@ static void thermal_zone_trip_update(struct thermal_zone_device *tz, int trip)
if (instance->target == 0 && tz->temperature >= trip_temp)
instance->target = 1;
else if (instance->target == 1 &&
- tz->temperature < trip_temp - trip_hyst)
+ tz->temperature <= trip_temp - trip_hyst)
instance->target = 0;
dev_dbg(&instance->cdev->device, "target=%d\n",
--
1.9.1
next prev parent reply other threads:[~2016-06-22 9:39 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-22 8:42 [PATCH v6 0/5] Thermal: Support for hardware-tracked trip points Caesar Wang
2016-06-22 8:42 ` Caesar Wang
2016-06-22 8:42 ` Caesar Wang
2016-06-22 8:42 ` [PATCH v6 1/5] thermal: Add support " Caesar Wang
2016-06-22 8:42 ` Caesar Wang
2016-06-22 8:42 ` [PATCH v6 2/5] thermal: of: implement .set_trips for device tree thermal zones Caesar Wang
2016-06-22 8:42 ` Caesar Wang
2016-06-22 8:42 ` [PATCH v6 3/5] thermal: streamline get_trend callbacks Caesar Wang
2016-06-22 8:42 ` Caesar Wang
2016-07-02 2:41 ` Eduardo Valentin
2016-06-22 8:42 ` Caesar Wang [this message]
2016-06-22 8:42 ` [PATCH v6 4/5] thermal: bang-bang governor: act on lower trip boundary Caesar Wang
2016-06-22 8:42 ` [PATCH v6 5/5] thermal: rockchip: add the set_trips function Caesar Wang
2016-06-22 8:42 ` Caesar Wang
2016-06-22 8:42 ` Caesar Wang
2016-06-22 10:13 ` [PATCH 1/2] thermal: rockchip: fixes the period time for tsadc Caesar Wang
2016-06-22 10:13 ` Caesar Wang
2016-06-22 10:13 ` [PATCH 2/2] thermal: rockchip: fixes the exception interrupts Caesar Wang
2016-06-22 10:13 ` Caesar Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1466584925-4829-5-git-send-email-wxt@rock-chips.com \
--to=wxt@rock-chips.com \
--cc=briannorris@google.com \
--cc=cf@rock-chips.com \
--cc=dianders@chromium.org \
--cc=dmitry.torokhov@gmail.com \
--cc=edubezval@gmail.com \
--cc=heiko@sntech.de \
--cc=huangtao@rock-chips.com \
--cc=javi.merino@arm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=peter@piie.net \
--cc=rocky.hao@rock-chips.com \
--cc=rui.zhang@intel.com \
--cc=s.hauer@pengutronix.de \
--cc=smbarber@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.