From: Doug Goldstein <cardoe@cardoe.com>
To: xen-devel@lists.xen.org
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
Doug Goldstein <cardoe@cardoe.com>,
Jan Beulich <jbeulich@suse.com>
Subject: [PATCH 6/9] x86/mtrr: drop unused mtrr_ops struct
Date: Tue, 16 Aug 2016 18:28:26 -0500 [thread overview]
Message-ID: <1471390109-10407-7-git-send-email-cardoe@cardoe.com> (raw)
In-Reply-To: <1471390109-10407-1-git-send-email-cardoe@cardoe.com>
There are no users of the mtrr_ops struct or any of the callers on it so
drop those.
Signed-off-by: Doug Goldstein <cardoe@cardoe.com>
---
xen/arch/x86/cpu/mtrr/generic.c | 12 ------------
xen/arch/x86/cpu/mtrr/mtrr.h | 23 -----------------------
2 files changed, 35 deletions(-)
diff --git a/xen/arch/x86/cpu/mtrr/generic.c b/xen/arch/x86/cpu/mtrr/generic.c
index 45d4def..1d67035 100644
--- a/xen/arch/x86/cpu/mtrr/generic.c
+++ b/xen/arch/x86/cpu/mtrr/generic.c
@@ -560,15 +560,3 @@ int positive_have_wrcomb(void)
{
return 1;
}
-
-/* generic structure...
- */
-const struct mtrr_ops generic_mtrr_ops = {
- .use_intel_if = 1,
- .set_all = mtrr_generic_set_all,
- .get = mtrr_generic_get,
- .get_free_region = mtrr_generic_get_free_region,
- .set = mtrr_generic_set,
- .validate_add_page = mtrr_generic_validate_add_page,
- .have_wrcomb = mtrr_generic_have_wrcomb,
-};
diff --git a/xen/arch/x86/cpu/mtrr/mtrr.h b/xen/arch/x86/cpu/mtrr/mtrr.h
index 25f4867..9391fc5 100644
--- a/xen/arch/x86/cpu/mtrr/mtrr.h
+++ b/xen/arch/x86/cpu/mtrr/mtrr.h
@@ -11,24 +11,6 @@
#define MTRR_CHANGE_MASK_VARIABLE 0x02
#define MTRR_CHANGE_MASK_DEFTYPE 0x04
-
-struct mtrr_ops {
- u32 vendor;
- u32 use_intel_if;
-// void (*init)(void);
- void (*set)(unsigned int reg, unsigned long base,
- unsigned long size, mtrr_type type);
- void (*set_all)(void);
-
- void (*get)(unsigned int reg, unsigned long *base,
- unsigned long *size, mtrr_type * type);
- int (*get_free_region)(unsigned long base, unsigned long size,
- int replace_reg);
- int (*validate_add_page)(unsigned long base, unsigned long size,
- unsigned int type);
- int (*have_wrcomb)(void);
-};
-
void mtrr_generic_get(unsigned int reg, unsigned long *base,
unsigned long *size, mtrr_type *type);
int mtrr_generic_get_free_region(unsigned long base, unsigned long size,
@@ -40,8 +22,6 @@ void mtrr_generic_set(unsigned int reg, unsigned long base,
unsigned long size, mtrr_type type);
int mtrr_generic_have_wrcomb(void);
-extern const struct mtrr_ops generic_mtrr_ops;
-
extern int positive_have_wrcomb(void);
/* library functions for processor-specific routines */
@@ -58,10 +38,7 @@ void set_mtrr_prepare_save(struct set_mtrr_context *ctxt);
void get_mtrr_state(void);
-extern void set_mtrr_ops(const struct mtrr_ops *);
-
extern u64 size_or_mask, size_and_mask;
-extern const struct mtrr_ops *mtrr_if;
extern unsigned int num_var_ranges;
--
2.7.3
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
next prev parent reply other threads:[~2016-08-16 23:28 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-16 23:28 [PATCH 0/9] x86/mtrr: basic cleanups Doug Goldstein
2016-08-16 23:28 ` [PATCH 1/9] x86/mtrr: prefix fns with mtrr and drop static Doug Goldstein
2016-08-17 12:36 ` Jan Beulich
2016-08-18 1:38 ` Doug Goldstein
2016-08-18 9:34 ` Jan Beulich
2016-08-16 23:28 ` [PATCH 2/9] x86/mtrr: drop mtrr_if indirection Doug Goldstein
2016-08-17 12:49 ` Jan Beulich
2016-08-18 1:59 ` Doug Goldstein
2016-08-18 9:37 ` Jan Beulich
2016-08-18 9:40 ` Andrew Cooper
2016-08-16 23:28 ` [PATCH 3/9] x86/mtrr: drop have_wrcomb() wrapper Doug Goldstein
2016-08-17 12:52 ` Jan Beulich
2016-08-16 23:28 ` [PATCH 4/9] x86/mtrr: drop unnecessary use_intel() macro Doug Goldstein
2016-08-17 12:53 ` Jan Beulich
2016-08-16 23:28 ` [PATCH 5/9] x86/mtrr: drop unused is_cpu() macro Doug Goldstein
2016-08-17 13:18 ` Jan Beulich
2016-08-16 23:28 ` Doug Goldstein [this message]
2016-08-17 13:19 ` [PATCH 6/9] x86/mtrr: drop unused mtrr_ops struct Jan Beulich
2016-08-16 23:28 ` [PATCH 7/9] x86/mtrr: drop unused positive_have_wrcomb() Doug Goldstein
2016-08-17 13:21 ` Jan Beulich
2016-08-16 23:28 ` [PATCH 8/9] x86/mtrr: drop unused func prototypes and struct Doug Goldstein
2016-08-17 13:23 ` Jan Beulich
2016-08-16 23:28 ` [PATCH 9/9] x86/mtrr: use stdbool instead of int + define Doug Goldstein
2016-08-17 13:29 ` Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1471390109-10407-7-git-send-email-cardoe@cardoe.com \
--to=cardoe@cardoe.com \
--cc=andrew.cooper3@citrix.com \
--cc=jbeulich@suse.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.