From: Doug Goldstein <cardoe@cardoe.com>
To: Jan Beulich <JBeulich@suse.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>, xen-devel@lists.xen.org
Subject: Re: [PATCH 1/9] x86/mtrr: prefix fns with mtrr and drop static
Date: Wed, 17 Aug 2016 20:38:28 -0500 [thread overview]
Message-ID: <61b107ed-7ce6-e201-368a-b2af77d596d6@cardoe.com> (raw)
In-Reply-To: <57B476560200007800106AAE@prv-mh.provo.novell.com>
[-- Attachment #1.1.1: Type: text/plain, Size: 1021 bytes --]
On 8/17/16 7:36 AM, Jan Beulich wrote:
>>>> On 17.08.16 at 01:28, <cardoe@cardoe.com> wrote:
>> For the functions that make up the interface to the MTRR code, drop the
>> static keyword and prefix them all with mtrr for improved clarity when
>> they're called outside this file. This also required adjusting or
>> providing function prototypes to make them callable.
>
> I can see why you want to do this for non-static functions, but I can't
> see why static ones would need to get altered (unless you mean to call
> them directly in subsequent patches, in which case the rationale above
> should be adjusted). Nor can I see why the two functions previously
> having been non-static can't simply be made static, without changing
> their names, as the patch demonstrates that they don't have callers
> in other CUs.
>
> Jan
>
I've added:
Future changes will directly call these functions instead of using the
indirect call through the ops structure.
Does that work?
--
Doug Goldstein
[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 959 bytes --]
[-- Attachment #2: Type: text/plain, Size: 127 bytes --]
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
next prev parent reply other threads:[~2016-08-18 1:38 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-16 23:28 [PATCH 0/9] x86/mtrr: basic cleanups Doug Goldstein
2016-08-16 23:28 ` [PATCH 1/9] x86/mtrr: prefix fns with mtrr and drop static Doug Goldstein
2016-08-17 12:36 ` Jan Beulich
2016-08-18 1:38 ` Doug Goldstein [this message]
2016-08-18 9:34 ` Jan Beulich
2016-08-16 23:28 ` [PATCH 2/9] x86/mtrr: drop mtrr_if indirection Doug Goldstein
2016-08-17 12:49 ` Jan Beulich
2016-08-18 1:59 ` Doug Goldstein
2016-08-18 9:37 ` Jan Beulich
2016-08-18 9:40 ` Andrew Cooper
2016-08-16 23:28 ` [PATCH 3/9] x86/mtrr: drop have_wrcomb() wrapper Doug Goldstein
2016-08-17 12:52 ` Jan Beulich
2016-08-16 23:28 ` [PATCH 4/9] x86/mtrr: drop unnecessary use_intel() macro Doug Goldstein
2016-08-17 12:53 ` Jan Beulich
2016-08-16 23:28 ` [PATCH 5/9] x86/mtrr: drop unused is_cpu() macro Doug Goldstein
2016-08-17 13:18 ` Jan Beulich
2016-08-16 23:28 ` [PATCH 6/9] x86/mtrr: drop unused mtrr_ops struct Doug Goldstein
2016-08-17 13:19 ` Jan Beulich
2016-08-16 23:28 ` [PATCH 7/9] x86/mtrr: drop unused positive_have_wrcomb() Doug Goldstein
2016-08-17 13:21 ` Jan Beulich
2016-08-16 23:28 ` [PATCH 8/9] x86/mtrr: drop unused func prototypes and struct Doug Goldstein
2016-08-17 13:23 ` Jan Beulich
2016-08-16 23:28 ` [PATCH 9/9] x86/mtrr: use stdbool instead of int + define Doug Goldstein
2016-08-17 13:29 ` Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=61b107ed-7ce6-e201-368a-b2af77d596d6@cardoe.com \
--to=cardoe@cardoe.com \
--cc=JBeulich@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.