From: "Jan Beulich" <JBeulich@suse.com>
To: Doug Goldstein <cardoe@cardoe.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>, xen-devel@lists.xen.org
Subject: Re: [PATCH 9/9] x86/mtrr: use stdbool instead of int + define
Date: Wed, 17 Aug 2016 07:29:08 -0600 [thread overview]
Message-ID: <57B482C40200007800106B44@prv-mh.provo.novell.com> (raw)
In-Reply-To: <1471390109-10407-10-git-send-email-cardoe@cardoe.com>
>>> On 17.08.16 at 01:28, <cardoe@cardoe.com> wrote:
> --- a/xen/arch/x86/cpu/mtrr/generic.c
> +++ b/xen/arch/x86/cpu/mtrr/generic.c
> @@ -3,6 +3,7 @@
> #include <xen/lib.h>
> #include <xen/init.h>
> #include <xen/mm.h>
> +#include <xen/stdbool.h>
Is this really needed, with xen/types.h already including it?
> @@ -237,7 +238,7 @@ static void mtrr_wrmsr(unsigned int msr, uint64_t msr_content)
> * \param changed pointer which indicates whether the MTRR needed to be changed
> * \param msrwords pointer to the MSR values which the MSR should have
> */
> -static void set_fixed_range(int msr, int * changed, unsigned int * msrwords)
> +static void set_fixed_range(int msr, bool * changed, unsigned int * msrwords)
Please drop the stray blanks while touching this.
> @@ -478,7 +479,7 @@ void mtrr_generic_set(unsigned int reg, unsigned long base,
> <base> The base address of the region.
> <size> The size of the region. If this is 0 the region is disabled.
> <type> The type of the region.
> - <do_safe> If TRUE, do the change safely. If FALSE, safety measures should
> + <do_safe> If true, do the change safely. If false, safety measures should
> be done externally.
Please drop this stale comment portion instead of adjusting it.
Jan
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
prev parent reply other threads:[~2016-08-17 13:29 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-16 23:28 [PATCH 0/9] x86/mtrr: basic cleanups Doug Goldstein
2016-08-16 23:28 ` [PATCH 1/9] x86/mtrr: prefix fns with mtrr and drop static Doug Goldstein
2016-08-17 12:36 ` Jan Beulich
2016-08-18 1:38 ` Doug Goldstein
2016-08-18 9:34 ` Jan Beulich
2016-08-16 23:28 ` [PATCH 2/9] x86/mtrr: drop mtrr_if indirection Doug Goldstein
2016-08-17 12:49 ` Jan Beulich
2016-08-18 1:59 ` Doug Goldstein
2016-08-18 9:37 ` Jan Beulich
2016-08-18 9:40 ` Andrew Cooper
2016-08-16 23:28 ` [PATCH 3/9] x86/mtrr: drop have_wrcomb() wrapper Doug Goldstein
2016-08-17 12:52 ` Jan Beulich
2016-08-16 23:28 ` [PATCH 4/9] x86/mtrr: drop unnecessary use_intel() macro Doug Goldstein
2016-08-17 12:53 ` Jan Beulich
2016-08-16 23:28 ` [PATCH 5/9] x86/mtrr: drop unused is_cpu() macro Doug Goldstein
2016-08-17 13:18 ` Jan Beulich
2016-08-16 23:28 ` [PATCH 6/9] x86/mtrr: drop unused mtrr_ops struct Doug Goldstein
2016-08-17 13:19 ` Jan Beulich
2016-08-16 23:28 ` [PATCH 7/9] x86/mtrr: drop unused positive_have_wrcomb() Doug Goldstein
2016-08-17 13:21 ` Jan Beulich
2016-08-16 23:28 ` [PATCH 8/9] x86/mtrr: drop unused func prototypes and struct Doug Goldstein
2016-08-17 13:23 ` Jan Beulich
2016-08-16 23:28 ` [PATCH 9/9] x86/mtrr: use stdbool instead of int + define Doug Goldstein
2016-08-17 13:29 ` Jan Beulich [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57B482C40200007800106B44@prv-mh.provo.novell.com \
--to=jbeulich@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=cardoe@cardoe.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.