All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kishon Vijay Abraham I <kishon@ti.com>
To: Bjorn Helgaas <bhelgaas@google.com>,
	Joao Pinto <Joao.Pinto@synopsys.com>, <linux-pci@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>, <linux-omap@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>
Cc: <nsekhar@ti.com>, <kishon@ti.com>,
	Niklas Cassel <niklas.cassel@axis.com>
Subject: [RESEND PATCH v3 3/7] PCI: dwc: artpec6: Populate cpu_addr_fixup ops
Date: Thu, 9 Mar 2017 12:09:01 +0530	[thread overview]
Message-ID: <1489041545-15730-4-git-send-email-kishon@ti.com> (raw)
In-Reply-To: <1489041545-15730-1-git-send-email-kishon@ti.com>

Populate cpu_addr_fixup ops to extract the least 28 bits of the
corresponding cpu address.

Cc: Niklas Cassel <niklas.cassel@axis.com>
Acked-by: Joao Pinto <jpinto@synopsys.com>
Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com>
---
 drivers/pci/dwc/pcie-artpec6.c |   15 ++++++++++-----
 1 file changed, 10 insertions(+), 5 deletions(-)

diff --git a/drivers/pci/dwc/pcie-artpec6.c b/drivers/pci/dwc/pcie-artpec6.c
index fcd3ef8..5b3b3af 100644
--- a/drivers/pci/dwc/pcie-artpec6.c
+++ b/drivers/pci/dwc/pcie-artpec6.c
@@ -78,6 +78,11 @@ static void artpec6_pcie_writel(struct artpec6_pcie *artpec6_pcie, u32 offset, u
 	regmap_write(artpec6_pcie->regmap, offset, val);
 }
 
+static u64 artpec6_pcie_cpu_addr_fixup(u64 pci_addr)
+{
+	return pci_addr & ARTPEC6_CPU_TO_BUS_ADDR;
+}
+
 static int artpec6_pcie_establish_link(struct artpec6_pcie *artpec6_pcie)
 {
 	struct dw_pcie *pci = artpec6_pcie->pci;
@@ -142,11 +147,6 @@ static int artpec6_pcie_establish_link(struct artpec6_pcie *artpec6_pcie)
 	 */
 	dw_pcie_writel_dbi(pci, MISC_CONTROL_1_OFF, DBI_RO_WR_EN);
 
-	pp->io_base &= ARTPEC6_CPU_TO_BUS_ADDR;
-	pp->mem_base &= ARTPEC6_CPU_TO_BUS_ADDR;
-	pp->cfg0_base &= ARTPEC6_CPU_TO_BUS_ADDR;
-	pp->cfg1_base &= ARTPEC6_CPU_TO_BUS_ADDR;
-
 	/* setup root complex */
 	dw_pcie_setup_rc(pp);
 
@@ -234,6 +234,10 @@ static int artpec6_add_pcie_port(struct artpec6_pcie *artpec6_pcie,
 	return 0;
 }
 
+static const struct dw_pcie_ops dw_pcie_ops = {
+	.cpu_addr_fixup = artpec6_pcie_cpu_addr_fixup,
+};
+
 static int artpec6_pcie_probe(struct platform_device *pdev)
 {
 	struct device *dev = &pdev->dev;
@@ -252,6 +256,7 @@ static int artpec6_pcie_probe(struct platform_device *pdev)
 		return -ENOMEM;
 
 	pci->dev = dev;
+	pci->ops = &dw_pcie_ops;
 
 	artpec6_pcie->pci = pci;
 
-- 
1.7.9.5

WARNING: multiple messages have this Message-ID (diff)
From: Kishon Vijay Abraham I <kishon@ti.com>
To: Bjorn Helgaas <bhelgaas@google.com>,
	Joao Pinto <Joao.Pinto@synopsys.com>,
	linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Cc: nsekhar@ti.com, kishon@ti.com, Niklas Cassel <niklas.cassel@axis.com>
Subject: [RESEND PATCH v3 3/7] PCI: dwc: artpec6: Populate cpu_addr_fixup ops
Date: Thu, 9 Mar 2017 12:09:01 +0530	[thread overview]
Message-ID: <1489041545-15730-4-git-send-email-kishon@ti.com> (raw)
In-Reply-To: <1489041545-15730-1-git-send-email-kishon@ti.com>

Populate cpu_addr_fixup ops to extract the least 28 bits of the
corresponding cpu address.

Cc: Niklas Cassel <niklas.cassel@axis.com>
Acked-by: Joao Pinto <jpinto@synopsys.com>
Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com>
---
 drivers/pci/dwc/pcie-artpec6.c |   15 ++++++++++-----
 1 file changed, 10 insertions(+), 5 deletions(-)

diff --git a/drivers/pci/dwc/pcie-artpec6.c b/drivers/pci/dwc/pcie-artpec6.c
index fcd3ef8..5b3b3af 100644
--- a/drivers/pci/dwc/pcie-artpec6.c
+++ b/drivers/pci/dwc/pcie-artpec6.c
@@ -78,6 +78,11 @@ static void artpec6_pcie_writel(struct artpec6_pcie *artpec6_pcie, u32 offset, u
 	regmap_write(artpec6_pcie->regmap, offset, val);
 }
 
+static u64 artpec6_pcie_cpu_addr_fixup(u64 pci_addr)
+{
+	return pci_addr & ARTPEC6_CPU_TO_BUS_ADDR;
+}
+
 static int artpec6_pcie_establish_link(struct artpec6_pcie *artpec6_pcie)
 {
 	struct dw_pcie *pci = artpec6_pcie->pci;
@@ -142,11 +147,6 @@ static int artpec6_pcie_establish_link(struct artpec6_pcie *artpec6_pcie)
 	 */
 	dw_pcie_writel_dbi(pci, MISC_CONTROL_1_OFF, DBI_RO_WR_EN);
 
-	pp->io_base &= ARTPEC6_CPU_TO_BUS_ADDR;
-	pp->mem_base &= ARTPEC6_CPU_TO_BUS_ADDR;
-	pp->cfg0_base &= ARTPEC6_CPU_TO_BUS_ADDR;
-	pp->cfg1_base &= ARTPEC6_CPU_TO_BUS_ADDR;
-
 	/* setup root complex */
 	dw_pcie_setup_rc(pp);
 
@@ -234,6 +234,10 @@ static int artpec6_add_pcie_port(struct artpec6_pcie *artpec6_pcie,
 	return 0;
 }
 
+static const struct dw_pcie_ops dw_pcie_ops = {
+	.cpu_addr_fixup = artpec6_pcie_cpu_addr_fixup,
+};
+
 static int artpec6_pcie_probe(struct platform_device *pdev)
 {
 	struct device *dev = &pdev->dev;
@@ -252,6 +256,7 @@ static int artpec6_pcie_probe(struct platform_device *pdev)
 		return -ENOMEM;
 
 	pci->dev = dev;
+	pci->ops = &dw_pcie_ops;
 
 	artpec6_pcie->pci = pci;
 
-- 
1.7.9.5

WARNING: multiple messages have this Message-ID (diff)
From: kishon@ti.com (Kishon Vijay Abraham I)
To: linux-arm-kernel@lists.infradead.org
Subject: [RESEND PATCH v3 3/7] PCI: dwc: artpec6: Populate cpu_addr_fixup ops
Date: Thu, 9 Mar 2017 12:09:01 +0530	[thread overview]
Message-ID: <1489041545-15730-4-git-send-email-kishon@ti.com> (raw)
In-Reply-To: <1489041545-15730-1-git-send-email-kishon@ti.com>

Populate cpu_addr_fixup ops to extract the least 28 bits of the
corresponding cpu address.

Cc: Niklas Cassel <niklas.cassel@axis.com>
Acked-by: Joao Pinto <jpinto@synopsys.com>
Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com>
---
 drivers/pci/dwc/pcie-artpec6.c |   15 ++++++++++-----
 1 file changed, 10 insertions(+), 5 deletions(-)

diff --git a/drivers/pci/dwc/pcie-artpec6.c b/drivers/pci/dwc/pcie-artpec6.c
index fcd3ef8..5b3b3af 100644
--- a/drivers/pci/dwc/pcie-artpec6.c
+++ b/drivers/pci/dwc/pcie-artpec6.c
@@ -78,6 +78,11 @@ static void artpec6_pcie_writel(struct artpec6_pcie *artpec6_pcie, u32 offset, u
 	regmap_write(artpec6_pcie->regmap, offset, val);
 }
 
+static u64 artpec6_pcie_cpu_addr_fixup(u64 pci_addr)
+{
+	return pci_addr & ARTPEC6_CPU_TO_BUS_ADDR;
+}
+
 static int artpec6_pcie_establish_link(struct artpec6_pcie *artpec6_pcie)
 {
 	struct dw_pcie *pci = artpec6_pcie->pci;
@@ -142,11 +147,6 @@ static int artpec6_pcie_establish_link(struct artpec6_pcie *artpec6_pcie)
 	 */
 	dw_pcie_writel_dbi(pci, MISC_CONTROL_1_OFF, DBI_RO_WR_EN);
 
-	pp->io_base &= ARTPEC6_CPU_TO_BUS_ADDR;
-	pp->mem_base &= ARTPEC6_CPU_TO_BUS_ADDR;
-	pp->cfg0_base &= ARTPEC6_CPU_TO_BUS_ADDR;
-	pp->cfg1_base &= ARTPEC6_CPU_TO_BUS_ADDR;
-
 	/* setup root complex */
 	dw_pcie_setup_rc(pp);
 
@@ -234,6 +234,10 @@ static int artpec6_add_pcie_port(struct artpec6_pcie *artpec6_pcie,
 	return 0;
 }
 
+static const struct dw_pcie_ops dw_pcie_ops = {
+	.cpu_addr_fixup = artpec6_pcie_cpu_addr_fixup,
+};
+
 static int artpec6_pcie_probe(struct platform_device *pdev)
 {
 	struct device *dev = &pdev->dev;
@@ -252,6 +256,7 @@ static int artpec6_pcie_probe(struct platform_device *pdev)
 		return -ENOMEM;
 
 	pci->dev = dev;
+	pci->ops = &dw_pcie_ops;
 
 	artpec6_pcie->pci = pci;
 
-- 
1.7.9.5

  parent reply	other threads:[~2017-03-09  6:40 UTC|newest]

Thread overview: 92+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-09  6:38 [RESEND PATCH v3 0/7] PCI: dwc: Miscellaneous fixes and cleanups Kishon Vijay Abraham I
2017-03-09  6:38 ` Kishon Vijay Abraham I
2017-03-09  6:38 ` Kishon Vijay Abraham I
2017-03-09  6:38 ` Kishon Vijay Abraham I
2017-03-09  6:38 ` [RESEND PATCH v3 1/7] PCI: dwc: designware: Add new *ops* for cpu addr fixup Kishon Vijay Abraham I
2017-03-09  6:38   ` Kishon Vijay Abraham I
2017-03-09  6:38   ` Kishon Vijay Abraham I
2017-03-09  6:38   ` Kishon Vijay Abraham I
2017-03-09  6:39 ` [RESEND PATCH v3 2/7] PCI: dwc: dra7xx: Populate cpu_addr_fixup ops Kishon Vijay Abraham I
2017-03-09  6:39   ` Kishon Vijay Abraham I
2017-03-09  6:39   ` Kishon Vijay Abraham I
2017-03-09  6:39   ` Kishon Vijay Abraham I
2017-03-09  6:39 ` Kishon Vijay Abraham I [this message]
2017-03-09  6:39   ` [RESEND PATCH v3 3/7] PCI: dwc: artpec6: " Kishon Vijay Abraham I
2017-03-09  6:39   ` Kishon Vijay Abraham I
2017-03-09 10:21   ` Niklas Cassel
2017-03-09 10:21     ` Niklas Cassel
2017-03-09 10:21     ` Niklas Cassel
2017-03-09 10:21     ` Niklas Cassel
2017-03-09  6:39 ` [RESEND PATCH v3 4/7] PCI: dwc: all: Modify dbi accessors to take dbi_base as argument Kishon Vijay Abraham I
2017-03-09  6:39   ` Kishon Vijay Abraham I
2017-03-09  6:39   ` Kishon Vijay Abraham I
2017-03-09 14:48   ` Niklas Cassel
2017-03-09 14:48     ` Niklas Cassel
2017-03-09 14:48     ` Niklas Cassel
2017-03-09 14:48     ` Niklas Cassel
2017-03-09 15:05     ` Niklas Cassel
2017-03-09 15:05       ` Niklas Cassel
2017-03-09 15:05       ` Niklas Cassel
2017-03-09 15:05       ` Niklas Cassel
2017-03-10 11:36       ` Kishon Vijay Abraham I
2017-03-10 11:36         ` Kishon Vijay Abraham I
2017-03-10 11:36         ` Kishon Vijay Abraham I
2017-03-10 11:36         ` Kishon Vijay Abraham I
2017-03-10 12:23         ` Niklas Cassel
2017-03-10 12:23           ` Niklas Cassel
2017-03-10 12:23           ` Niklas Cassel
2017-03-10 12:23           ` Niklas Cassel
2017-03-10 12:30         ` Joao Pinto
2017-03-10 12:30           ` Joao Pinto
2017-03-10 12:30           ` Joao Pinto
2017-03-10 12:30           ` Joao Pinto
2017-03-10 12:31         ` Niklas Cassel
2017-03-10 12:31           ` Niklas Cassel
2017-03-10 12:31           ` Niklas Cassel
2017-03-10 12:31           ` Niklas Cassel
2017-03-10 12:56           ` Kishon Vijay Abraham I
2017-03-10 12:56             ` Kishon Vijay Abraham I
2017-03-10 12:56             ` Kishon Vijay Abraham I
2017-03-10 12:56             ` Kishon Vijay Abraham I
2017-03-10 15:47             ` Niklas Cassel
2017-03-10 15:47               ` Niklas Cassel
2017-03-10 15:47               ` Niklas Cassel
2017-03-10 15:47               ` Niklas Cassel
2017-03-13  5:30               ` Kishon Vijay Abraham I
2017-03-13  5:30                 ` Kishon Vijay Abraham I
2017-03-13  5:30                 ` Kishon Vijay Abraham I
2017-03-13  5:30                 ` Kishon Vijay Abraham I
2017-03-09  6:39 ` [RESEND PATCH v3 5/7] PCI: dwc: all: Modify dbi accessors to access data of 4/2/1 bytes Kishon Vijay Abraham I
2017-03-09  6:39   ` Kishon Vijay Abraham I
2017-03-09  6:39   ` Kishon Vijay Abraham I
2017-03-09 14:48   ` Niklas Cassel
2017-03-09 14:48     ` Niklas Cassel
2017-03-09 14:48     ` Niklas Cassel
2017-03-09 14:48     ` Niklas Cassel
2017-03-10 12:04     ` Kishon Vijay Abraham I
2017-03-10 12:04       ` Kishon Vijay Abraham I
2017-03-10 12:04       ` Kishon Vijay Abraham I
2017-03-10 12:04       ` Kishon Vijay Abraham I
2017-03-10 12:56       ` Niklas Cassel
2017-03-10 12:56         ` Niklas Cassel
2017-03-10 12:56         ` Niklas Cassel
2017-03-10 12:56         ` Niklas Cassel
2017-03-10 13:04         ` Kishon Vijay Abraham I
2017-03-10 13:04           ` Kishon Vijay Abraham I
2017-03-10 13:04           ` Kishon Vijay Abraham I
2017-03-10 13:04           ` Kishon Vijay Abraham I
2017-03-10 14:59           ` Niklas Cassel
2017-03-10 14:59             ` Niklas Cassel
2017-03-10 14:59             ` Niklas Cassel
2017-03-10 14:59             ` Niklas Cassel
2017-03-09  6:39 ` [RESEND PATCH v3 6/7] PCI: dwc: designware: Move _unroll configurations to a separate function Kishon Vijay Abraham I
2017-03-09  6:39   ` Kishon Vijay Abraham I
2017-03-09  6:39   ` Kishon Vijay Abraham I
2017-03-09  6:39   ` Kishon Vijay Abraham I
2017-03-09 12:25   ` Joao Pinto
2017-03-09 12:25     ` Joao Pinto
2017-03-09 12:25     ` Joao Pinto
2017-03-09 12:25     ` Joao Pinto
2017-03-09  6:39 ` [RESEND PATCH v3 7/7] PCI: dwc: dra7xx: Push request_irq call to the bottom of probe Kishon Vijay Abraham I
2017-03-09  6:39   ` Kishon Vijay Abraham I
2017-03-09  6:39   ` Kishon Vijay Abraham I

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1489041545-15730-4-git-send-email-kishon@ti.com \
    --to=kishon@ti.com \
    --cc=Joao.Pinto@synopsys.com \
    --cc=bhelgaas@google.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=niklas.cassel@axis.com \
    --cc=nsekhar@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.