From: Julia Lawall <Julia.Lawall@lip6.fr> To: Mauro Carvalho Chehab <mchehab@kernel.org> Cc: bhumirks@gmail.com, kernel-janitors@vger.kernel.org, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, linux-media@vger.kernel.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: [PATCH 3/6] staging: atomisp: constify video_subdev structures Date: Tue, 8 Aug 2017 12:58:29 +0200 [thread overview] Message-ID: <1502189912-28794-4-git-send-email-Julia.Lawall@lip6.fr> (raw) In-Reply-To: <1502189912-28794-1-git-send-email-Julia.Lawall@lip6.fr> These structures are both stored in fields of v4l2_subdev_ops structures, all of which are const, so these structures can be const as well. Done with the help of Coccinelle. Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr> --- drivers/staging/media/atomisp/i2c/ap1302.c | 2 +- drivers/staging/media/atomisp/i2c/mt9m114.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/media/atomisp/i2c/ap1302.c b/drivers/staging/media/atomisp/i2c/ap1302.c index bacffbe..de687c6 100644 --- a/drivers/staging/media/atomisp/i2c/ap1302.c +++ b/drivers/staging/media/atomisp/i2c/ap1302.c @@ -1098,7 +1098,7 @@ static long ap1302_ioctl(struct v4l2_subdev *sd, unsigned int cmd, void *arg) }, }; -static struct v4l2_subdev_sensor_ops ap1302_sensor_ops = { +static const struct v4l2_subdev_sensor_ops ap1302_sensor_ops = { .g_skip_frames = ap1302_g_skip_frames, }; diff --git a/drivers/staging/media/atomisp/i2c/mt9m114.c b/drivers/staging/media/atomisp/i2c/mt9m114.c index 448e072..36a0636 100644 --- a/drivers/staging/media/atomisp/i2c/mt9m114.c +++ b/drivers/staging/media/atomisp/i2c/mt9m114.c @@ -1806,7 +1806,7 @@ static int mt9m114_g_skip_frames(struct v4l2_subdev *sd, u32 *frames) .g_frame_interval = mt9m114_g_frame_interval, }; -static struct v4l2_subdev_sensor_ops mt9m114_sensor_ops = { +static const struct v4l2_subdev_sensor_ops mt9m114_sensor_ops = { .g_skip_frames = mt9m114_g_skip_frames, };
WARNING: multiple messages have this Message-ID (diff)
From: Julia Lawall <Julia.Lawall@lip6.fr> To: Mauro Carvalho Chehab <mchehab@kernel.org> Cc: bhumirks@gmail.com, kernel-janitors@vger.kernel.org, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, linux-media@vger.kernel.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: [PATCH 3/6] staging: atomisp: constify video_subdev structures Date: Tue, 08 Aug 2017 10:58:29 +0000 [thread overview] Message-ID: <1502189912-28794-4-git-send-email-Julia.Lawall@lip6.fr> (raw) In-Reply-To: <1502189912-28794-1-git-send-email-Julia.Lawall@lip6.fr> These structures are both stored in fields of v4l2_subdev_ops structures, all of which are const, so these structures can be const as well. Done with the help of Coccinelle. Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr> --- drivers/staging/media/atomisp/i2c/ap1302.c | 2 +- drivers/staging/media/atomisp/i2c/mt9m114.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/media/atomisp/i2c/ap1302.c b/drivers/staging/media/atomisp/i2c/ap1302.c index bacffbe..de687c6 100644 --- a/drivers/staging/media/atomisp/i2c/ap1302.c +++ b/drivers/staging/media/atomisp/i2c/ap1302.c @@ -1098,7 +1098,7 @@ static long ap1302_ioctl(struct v4l2_subdev *sd, unsigned int cmd, void *arg) }, }; -static struct v4l2_subdev_sensor_ops ap1302_sensor_ops = { +static const struct v4l2_subdev_sensor_ops ap1302_sensor_ops = { .g_skip_frames = ap1302_g_skip_frames, }; diff --git a/drivers/staging/media/atomisp/i2c/mt9m114.c b/drivers/staging/media/atomisp/i2c/mt9m114.c index 448e072..36a0636 100644 --- a/drivers/staging/media/atomisp/i2c/mt9m114.c +++ b/drivers/staging/media/atomisp/i2c/mt9m114.c @@ -1806,7 +1806,7 @@ static int mt9m114_g_skip_frames(struct v4l2_subdev *sd, u32 *frames) .g_frame_interval = mt9m114_g_frame_interval, }; -static struct v4l2_subdev_sensor_ops mt9m114_sensor_ops = { +static const struct v4l2_subdev_sensor_ops mt9m114_sensor_ops = { .g_skip_frames = mt9m114_g_skip_frames, };
next prev parent reply other threads:[~2017-08-08 11:26 UTC|newest] Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top 2017-08-08 10:58 [PATCH 0/6] constify video_subdev structures Julia Lawall 2017-08-08 10:58 ` Julia Lawall 2017-08-08 10:58 ` Julia Lawall 2017-08-08 10:58 ` [PATCH 1/6] [media] v4l: mt9t001: " Julia Lawall 2017-08-08 10:58 ` Julia Lawall 2017-08-08 22:07 ` Laurent Pinchart 2017-08-08 22:07 ` Laurent Pinchart 2017-08-08 10:58 ` [PATCH 2/6] [media] vimc: " Julia Lawall 2017-08-08 10:58 ` Julia Lawall 2017-08-08 10:58 ` Julia Lawall [this message] 2017-08-08 10:58 ` [PATCH 3/6] staging: atomisp: " Julia Lawall 2017-08-08 10:58 ` [PATCH 4/6] [media] media: mt9m111: " Julia Lawall 2017-08-08 10:58 ` Julia Lawall 2017-08-08 10:58 ` [PATCH 5/6] [media] exynos4-is: " Julia Lawall 2017-08-08 10:58 ` Julia Lawall 2017-08-08 10:58 ` Julia Lawall [not found] ` <CGME20170808123709epcas2p229a31cfa19e3a5bf3986e547162e2613@epcas2p2.samsung.com> 2017-08-08 12:37 ` Sylwester Nawrocki 2017-08-08 12:37 ` Sylwester Nawrocki 2017-08-08 12:37 ` Sylwester Nawrocki 2017-08-08 10:58 ` [PATCH 6/6] [media] uvcvideo: " Julia Lawall 2017-08-08 10:58 ` Julia Lawall 2017-08-08 12:49 ` Laurent Pinchart 2017-08-08 12:49 ` Laurent Pinchart 2017-08-08 12:49 ` Julia Lawall 2017-08-08 12:49 ` Julia Lawall
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1502189912-28794-4-git-send-email-Julia.Lawall@lip6.fr \ --to=julia.lawall@lip6.fr \ --cc=bhumirks@gmail.com \ --cc=devel@driverdev.osuosl.org \ --cc=gregkh@linuxfoundation.org \ --cc=kernel-janitors@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-media@vger.kernel.org \ --cc=mchehab@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.