From: Julia Lawall <julia.lawall@lip6.fr> To: Laurent Pinchart <laurent.pinchart@ideasonboard.com> Cc: bhumirks@gmail.com, kernel-janitors@vger.kernel.org, Mauro Carvalho Chehab <mchehab@kernel.org>, linux-media@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 6/6] [media] uvcvideo: constify video_subdev structures Date: Tue, 8 Aug 2017 14:49:39 +0200 (CEST) [thread overview] Message-ID: <alpine.DEB.2.20.1708081449060.28470@hadrien> (raw) In-Reply-To: <2365094.bHN9TxZSFH@avalon> On Tue, 8 Aug 2017, Laurent Pinchart wrote: > Hi Julia, > > Thank you for the patch. > > On Tuesday 08 Aug 2017 12:58:32 Julia Lawall wrote: > > uvc_subdev_ops is only passed as the second argument of > > v4l2_subdev_init, which is const, so uvc_subdev_ops can be > > const as well. > > > > Done with the help of Coccinelle. > > > > Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr> > > Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > > and applied to my tree (with the first word of the commit message after the > prefix capitalized to match the rest of the driver's commit messages, let me > know if that's a problem :-)). No, of course not. I will try to watch out for that in the future. julia > > > > --- > > drivers/media/usb/uvc/uvc_entity.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/media/usb/uvc/uvc_entity.c > > b/drivers/media/usb/uvc/uvc_entity.c index ac386bb..554063c 100644 > > --- a/drivers/media/usb/uvc/uvc_entity.c > > +++ b/drivers/media/usb/uvc/uvc_entity.c > > @@ -61,7 +61,7 @@ static int uvc_mc_create_links(struct uvc_video_chain > > *chain, return 0; > > } > > > > -static struct v4l2_subdev_ops uvc_subdev_ops = { > > +static const struct v4l2_subdev_ops uvc_subdev_ops = { > > }; > > > > void uvc_mc_cleanup_entity(struct uvc_entity *entity) > > -- > Regards, > > Laurent Pinchart > >
WARNING: multiple messages have this Message-ID (diff)
From: Julia Lawall <julia.lawall@lip6.fr> To: Laurent Pinchart <laurent.pinchart@ideasonboard.com> Cc: bhumirks@gmail.com, kernel-janitors@vger.kernel.org, Mauro Carvalho Chehab <mchehab@kernel.org>, linux-media@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 6/6] [media] uvcvideo: constify video_subdev structures Date: Tue, 08 Aug 2017 12:49:39 +0000 [thread overview] Message-ID: <alpine.DEB.2.20.1708081449060.28470@hadrien> (raw) In-Reply-To: <2365094.bHN9TxZSFH@avalon> On Tue, 8 Aug 2017, Laurent Pinchart wrote: > Hi Julia, > > Thank you for the patch. > > On Tuesday 08 Aug 2017 12:58:32 Julia Lawall wrote: > > uvc_subdev_ops is only passed as the second argument of > > v4l2_subdev_init, which is const, so uvc_subdev_ops can be > > const as well. > > > > Done with the help of Coccinelle. > > > > Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr> > > Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > > and applied to my tree (with the first word of the commit message after the > prefix capitalized to match the rest of the driver's commit messages, let me > know if that's a problem :-)). No, of course not. I will try to watch out for that in the future. julia > > > > --- > > drivers/media/usb/uvc/uvc_entity.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/media/usb/uvc/uvc_entity.c > > b/drivers/media/usb/uvc/uvc_entity.c index ac386bb..554063c 100644 > > --- a/drivers/media/usb/uvc/uvc_entity.c > > +++ b/drivers/media/usb/uvc/uvc_entity.c > > @@ -61,7 +61,7 @@ static int uvc_mc_create_links(struct uvc_video_chain > > *chain, return 0; > > } > > > > -static struct v4l2_subdev_ops uvc_subdev_ops = { > > +static const struct v4l2_subdev_ops uvc_subdev_ops = { > > }; > > > > void uvc_mc_cleanup_entity(struct uvc_entity *entity) > > -- > Regards, > > Laurent Pinchart > >
next prev parent reply other threads:[~2017-08-08 12:49 UTC|newest] Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top 2017-08-08 10:58 [PATCH 0/6] constify video_subdev structures Julia Lawall 2017-08-08 10:58 ` Julia Lawall 2017-08-08 10:58 ` Julia Lawall 2017-08-08 10:58 ` [PATCH 1/6] [media] v4l: mt9t001: " Julia Lawall 2017-08-08 10:58 ` Julia Lawall 2017-08-08 22:07 ` Laurent Pinchart 2017-08-08 22:07 ` Laurent Pinchart 2017-08-08 10:58 ` [PATCH 2/6] [media] vimc: " Julia Lawall 2017-08-08 10:58 ` Julia Lawall 2017-08-08 10:58 ` [PATCH 3/6] staging: atomisp: " Julia Lawall 2017-08-08 10:58 ` Julia Lawall 2017-08-08 10:58 ` [PATCH 4/6] [media] media: mt9m111: " Julia Lawall 2017-08-08 10:58 ` Julia Lawall 2017-08-08 10:58 ` [PATCH 5/6] [media] exynos4-is: " Julia Lawall 2017-08-08 10:58 ` Julia Lawall 2017-08-08 10:58 ` Julia Lawall [not found] ` <CGME20170808123709epcas2p229a31cfa19e3a5bf3986e547162e2613@epcas2p2.samsung.com> 2017-08-08 12:37 ` Sylwester Nawrocki 2017-08-08 12:37 ` Sylwester Nawrocki 2017-08-08 12:37 ` Sylwester Nawrocki 2017-08-08 10:58 ` [PATCH 6/6] [media] uvcvideo: " Julia Lawall 2017-08-08 10:58 ` Julia Lawall 2017-08-08 12:49 ` Laurent Pinchart 2017-08-08 12:49 ` Laurent Pinchart 2017-08-08 12:49 ` Julia Lawall [this message] 2017-08-08 12:49 ` Julia Lawall
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=alpine.DEB.2.20.1708081449060.28470@hadrien \ --to=julia.lawall@lip6.fr \ --cc=bhumirks@gmail.com \ --cc=kernel-janitors@vger.kernel.org \ --cc=laurent.pinchart@ideasonboard.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-media@vger.kernel.org \ --cc=mchehab@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.