From: Dave Jiang <dave.jiang@intel.com> To: darrick.wong@oracle.com Cc: linux-nvdimm@lists.01.org, david@fromorbit.com, linux-xfs@vger.kernel.org, linux-ext4@vger.kernel.org Subject: [PATCH v6 3/3] xfs: reject removal of realtime flag when datadev doesn't support DAX Date: Fri, 16 Feb 2018 10:04:26 -0700 [thread overview] Message-ID: <151880066614.43131.15847174332875373188.stgit@djiang5-desk3.ch.intel.com> (raw) In-Reply-To: <151880058592.43131.558230052922233871.stgit@djiang5-desk3.ch.intel.com> In a situation where the rt_dev is DAX and data_dev is not DAX, if the user requests to remove the realtime flag via ioctl we can no longer support DAX for that file. Dynamic changing of S_DAX on the inode is not supported due to various complications in the existing implementation. Therefore until we address the dynamic S_DAX change issues, we must disallow realtime flag being removed. Signed-off-by: Dave Jiang <dave.jiang@intel.com> Reviewed-by: Christoph Hellwig <hch@lst.de> --- fs/xfs/xfs_ioctl.c | 14 ++++++++++++++ 1 file changed, 14 insertions(+) diff --git a/fs/xfs/xfs_ioctl.c b/fs/xfs/xfs_ioctl.c index 2c70a0a4f59f..edd97d527fe8 100644 --- a/fs/xfs/xfs_ioctl.c +++ b/fs/xfs/xfs_ioctl.c @@ -1030,6 +1030,20 @@ xfs_ioctl_setattr_xflags( { struct xfs_mount *mp = ip->i_mount; uint64_t di_flags2; + struct inode *inode = VFS_I(ip); + struct super_block *sb = inode->i_sb; + + /* + * In the case that the inode is realtime, and we are trying to remove + * the realtime flag, and the rtdev supports DAX but the datadev does + * not support DAX, we can't allow the realtime flag to be removed + * since we do not support dynamic S_DAX flag removal yet. + */ + if (XFS_IS_REALTIME_INODE(ip) && + !(fa->fsx_xflags & FS_XFLAG_REALTIME) && + bdev_dax_supported(mp->m_rtdev_targp->bt_bdev, sb->s_blocksize) && + !bdev_dax_supported(mp->m_ddev_targp->bt_bdev, sb->s_blocksize)) + return -ENOTSUPP; /* Can't change realtime flag if any extents are allocated. */ if ((ip->i_d.di_nextents || ip->i_delayed_blks) && _______________________________________________ Linux-nvdimm mailing list Linux-nvdimm@lists.01.org https://lists.01.org/mailman/listinfo/linux-nvdimm
WARNING: multiple messages have this Message-ID (diff)
From: Dave Jiang <dave.jiang@intel.com> To: darrick.wong@oracle.com Cc: linux-nvdimm@lists.01.org, david@fromorbit.com, linux-xfs@vger.kernel.org, ross.zwisler@linux.intel.com, linux-ext4@vger.kernel.org, dan.j.williams@intel.com Subject: [PATCH v6 3/3] xfs: reject removal of realtime flag when datadev doesn't support DAX Date: Fri, 16 Feb 2018 10:04:26 -0700 [thread overview] Message-ID: <151880066614.43131.15847174332875373188.stgit@djiang5-desk3.ch.intel.com> (raw) In-Reply-To: <151880058592.43131.558230052922233871.stgit@djiang5-desk3.ch.intel.com> In a situation where the rt_dev is DAX and data_dev is not DAX, if the user requests to remove the realtime flag via ioctl we can no longer support DAX for that file. Dynamic changing of S_DAX on the inode is not supported due to various complications in the existing implementation. Therefore until we address the dynamic S_DAX change issues, we must disallow realtime flag being removed. Signed-off-by: Dave Jiang <dave.jiang@intel.com> Reviewed-by: Christoph Hellwig <hch@lst.de> --- fs/xfs/xfs_ioctl.c | 14 ++++++++++++++ 1 file changed, 14 insertions(+) diff --git a/fs/xfs/xfs_ioctl.c b/fs/xfs/xfs_ioctl.c index 2c70a0a4f59f..edd97d527fe8 100644 --- a/fs/xfs/xfs_ioctl.c +++ b/fs/xfs/xfs_ioctl.c @@ -1030,6 +1030,20 @@ xfs_ioctl_setattr_xflags( { struct xfs_mount *mp = ip->i_mount; uint64_t di_flags2; + struct inode *inode = VFS_I(ip); + struct super_block *sb = inode->i_sb; + + /* + * In the case that the inode is realtime, and we are trying to remove + * the realtime flag, and the rtdev supports DAX but the datadev does + * not support DAX, we can't allow the realtime flag to be removed + * since we do not support dynamic S_DAX flag removal yet. + */ + if (XFS_IS_REALTIME_INODE(ip) && + !(fa->fsx_xflags & FS_XFLAG_REALTIME) && + bdev_dax_supported(mp->m_rtdev_targp->bt_bdev, sb->s_blocksize) && + !bdev_dax_supported(mp->m_ddev_targp->bt_bdev, sb->s_blocksize)) + return -ENOTSUPP; /* Can't change realtime flag if any extents are allocated. */ if ((ip->i_d.di_nextents || ip->i_delayed_blks) &&
next prev parent reply other threads:[~2018-02-16 16:58 UTC|newest] Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-02-16 17:04 [PATCH v6 0/3] minimal DAX support for XFS realtime device Dave Jiang 2018-02-16 17:04 ` Dave Jiang 2018-02-16 17:04 ` [PATCH v6 1/3] fs: allow per-device dax status checking for filesystems Dave Jiang 2018-02-16 17:04 ` Dave Jiang 2018-02-16 17:04 ` Dave Jiang 2018-02-20 0:24 ` kbuild test robot 2018-02-20 0:24 ` kbuild test robot 2018-02-20 0:24 ` kbuild test robot 2018-02-16 17:04 ` [PATCH v6 2/3] dax: change bdev_dax_supported() to support boolean returns Dave Jiang 2018-02-16 17:04 ` Dave Jiang 2018-02-16 17:04 ` Dave Jiang 2018-02-16 17:26 ` Darrick J. Wong 2018-02-16 17:26 ` Darrick J. Wong 2018-02-16 17:26 ` Darrick J. Wong 2018-02-16 17:04 ` Dave Jiang [this message] 2018-02-16 17:04 ` [PATCH v6 3/3] xfs: reject removal of realtime flag when datadev doesn't support DAX Dave Jiang 2018-02-16 17:22 ` Darrick J. Wong 2018-02-16 17:22 ` Darrick J. Wong 2018-02-18 0:23 ` Dave Chinner 2018-02-18 0:23 ` Dave Chinner 2018-02-20 23:01 ` Darrick J. Wong 2018-02-20 23:01 ` Darrick J. Wong 2018-02-20 23:01 ` Darrick J. Wong 2018-02-20 23:15 ` Dave Chinner 2018-02-20 23:15 ` Dave Chinner 2018-02-20 23:15 ` Dave Chinner 2018-02-20 23:23 ` Darrick J. Wong 2018-02-20 23:23 ` Darrick J. Wong 2018-02-20 23:23 ` Darrick J. Wong 2018-02-27 16:46 ` Dave Jiang 2018-02-27 16:46 ` Dave Jiang 2018-02-27 16:46 ` Dave Jiang 2018-02-27 17:14 ` Darrick J. Wong 2018-02-27 17:14 ` Darrick J. Wong 2018-02-27 17:14 ` Darrick J. Wong
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=151880066614.43131.15847174332875373188.stgit@djiang5-desk3.ch.intel.com \ --to=dave.jiang@intel.com \ --cc=darrick.wong@oracle.com \ --cc=david@fromorbit.com \ --cc=linux-ext4@vger.kernel.org \ --cc=linux-nvdimm@lists.01.org \ --cc=linux-xfs@vger.kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.