From: kbuild test robot <lkp@intel.com>
To: Dave Jiang <dave.jiang@intel.com>
Cc: linux-nvdimm@lists.01.org, darrick.wong@oracle.com,
david@fromorbit.com, linux-xfs@vger.kernel.org,
kbuild-all@01.org, linux-ext4@vger.kernel.org
Subject: Re: [PATCH v6 1/3] fs: allow per-device dax status checking for filesystems
Date: Tue, 20 Feb 2018 08:24:33 +0800 [thread overview]
Message-ID: <201802200834.rXDUV1nU%fengguang.wu@intel.com> (raw)
In-Reply-To: <151880065504.43131.6695118308172421769.stgit@djiang5-desk3.ch.intel.com>
Hi Darrick,
I love your patch! Yet something to improve:
[auto build test ERROR on linus/master]
[also build test ERROR on v4.16-rc2 next-20180219]
[cannot apply to dgc-xfs/for-next]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
url: https://github.com/0day-ci/linux/commits/Dave-Jiang/fs-allow-per-device-dax-status-checking-for-filesystems/20180219-121644
config: x86_64-randconfig-s5-02200659 (attached as .config)
compiler: gcc-7 (Debian 7.3.0-1) 7.3.0
reproduce:
# save the attached .config to linux build tree
make ARCH=x86_64
All errors (new ones prefixed by >>):
>> drivers/dax/super.c:85:5: error: redefinition of 'bdev_dax_supported'
int bdev_dax_supported(struct block_device *bdev, int blocksize)
^~~~~~~~~~~~~~~~~~
In file included from drivers/dax/super.c:23:0:
include/linux/dax.h:56:19: note: previous definition of 'bdev_dax_supported' was here
static inline int bdev_dax_supported(struct block_device *bdev,
^~~~~~~~~~~~~~~~~~
vim +/bdev_dax_supported +85 drivers/dax/super.c
74
75 /**
76 * bdev_dax_supported() - Check if the device supports dax for filesystem
77 * @bdev: block device to check
78 * @blocksize: The block size of the device
79 *
80 * This is a library function for filesystems to check if the block device
81 * can be mounted with dax option.
82 *
83 * Return: negative errno if unsupported, 0 if supported.
84 */
> 85 int bdev_dax_supported(struct block_device *bdev, int blocksize)
86 {
87 struct dax_device *dax_dev;
88 pgoff_t pgoff;
89 int err, id;
90 void *kaddr;
91 pfn_t pfn;
92 long len;
93 char buf[BDEVNAME_SIZE];
94
95 if (blocksize != PAGE_SIZE) {
96 pr_debug("%s: error: unsupported blocksize for dax\n",
97 bdevname(bdev, buf));
98 return -EINVAL;
99 }
100
101 err = bdev_dax_pgoff(bdev, 0, PAGE_SIZE, &pgoff);
102 if (err) {
103 pr_debug("%s: error: unaligned partition for dax\n",
104 bdevname(bdev, buf));
105 return err;
106 }
107
108 dax_dev = dax_get_by_host(bdev->bd_disk->disk_name);
109 if (!dax_dev) {
110 pr_debug("%s: error: device does not support dax\n",
111 bdevname(bdev, buf));
112 return -EOPNOTSUPP;
113 }
114
115 id = dax_read_lock();
116 len = dax_direct_access(dax_dev, pgoff, 1, &kaddr, &pfn);
117 dax_read_unlock(id);
118
119 put_dax(dax_dev);
120
121 if (len < 1) {
122 pr_debug("%s: error: dax access failed (%ld)\n",
123 bdevname(bdev, buf), len);
124 return len < 0 ? len : -EIO;
125 }
126
127 if ((IS_ENABLED(CONFIG_FS_DAX_LIMITED) && pfn_t_special(pfn))
128 || pfn_t_devmap(pfn))
129 /* pass */;
130 else {
131 pr_debug("%s: error: dax support not enabled\n",
132 bdevname(bdev, buf));
133 return -EOPNOTSUPP;
134 }
135
136 return 0;
137 }
138 EXPORT_SYMBOL_GPL(bdev_dax_supported);
139 #endif
140
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
_______________________________________________
Linux-nvdimm mailing list
Linux-nvdimm@lists.01.org
https://lists.01.org/mailman/listinfo/linux-nvdimm
WARNING: multiple messages have this Message-ID (diff)
From: kbuild test robot <lkp-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
To: Dave Jiang <dave.jiang-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Cc: linux-nvdimm-hn68Rpc1hR1g9hUCZPvPmw@public.gmane.org,
darrick.wong-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org,
david-FqsqvQoI3Ljby3iVrkZq2A@public.gmane.org,
linux-xfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
kbuild-all-JC7UmRfGjtg@public.gmane.org,
linux-ext4-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH v6 1/3] fs: allow per-device dax status checking for filesystems
Date: Tue, 20 Feb 2018 08:24:33 +0800 [thread overview]
Message-ID: <201802200834.rXDUV1nU%fengguang.wu@intel.com> (raw)
In-Reply-To: <151880065504.43131.6695118308172421769.stgit-Cxk7aZI4ujnJARH06PadV2t3HXsI98Cx0E9HWUfgJXw@public.gmane.org>
Hi Darrick,
I love your patch! Yet something to improve:
[auto build test ERROR on linus/master]
[also build test ERROR on v4.16-rc2 next-20180219]
[cannot apply to dgc-xfs/for-next]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
url: https://github.com/0day-ci/linux/commits/Dave-Jiang/fs-allow-per-device-dax-status-checking-for-filesystems/20180219-121644
config: x86_64-randconfig-s5-02200659 (attached as .config)
compiler: gcc-7 (Debian 7.3.0-1) 7.3.0
reproduce:
# save the attached .config to linux build tree
make ARCH=x86_64
All errors (new ones prefixed by >>):
>> drivers/dax/super.c:85:5: error: redefinition of 'bdev_dax_supported'
int bdev_dax_supported(struct block_device *bdev, int blocksize)
^~~~~~~~~~~~~~~~~~
In file included from drivers/dax/super.c:23:0:
include/linux/dax.h:56:19: note: previous definition of 'bdev_dax_supported' was here
static inline int bdev_dax_supported(struct block_device *bdev,
^~~~~~~~~~~~~~~~~~
vim +/bdev_dax_supported +85 drivers/dax/super.c
74
75 /**
76 * bdev_dax_supported() - Check if the device supports dax for filesystem
77 * @bdev: block device to check
78 * @blocksize: The block size of the device
79 *
80 * This is a library function for filesystems to check if the block device
81 * can be mounted with dax option.
82 *
83 * Return: negative errno if unsupported, 0 if supported.
84 */
> 85 int bdev_dax_supported(struct block_device *bdev, int blocksize)
86 {
87 struct dax_device *dax_dev;
88 pgoff_t pgoff;
89 int err, id;
90 void *kaddr;
91 pfn_t pfn;
92 long len;
93 char buf[BDEVNAME_SIZE];
94
95 if (blocksize != PAGE_SIZE) {
96 pr_debug("%s: error: unsupported blocksize for dax\n",
97 bdevname(bdev, buf));
98 return -EINVAL;
99 }
100
101 err = bdev_dax_pgoff(bdev, 0, PAGE_SIZE, &pgoff);
102 if (err) {
103 pr_debug("%s: error: unaligned partition for dax\n",
104 bdevname(bdev, buf));
105 return err;
106 }
107
108 dax_dev = dax_get_by_host(bdev->bd_disk->disk_name);
109 if (!dax_dev) {
110 pr_debug("%s: error: device does not support dax\n",
111 bdevname(bdev, buf));
112 return -EOPNOTSUPP;
113 }
114
115 id = dax_read_lock();
116 len = dax_direct_access(dax_dev, pgoff, 1, &kaddr, &pfn);
117 dax_read_unlock(id);
118
119 put_dax(dax_dev);
120
121 if (len < 1) {
122 pr_debug("%s: error: dax access failed (%ld)\n",
123 bdevname(bdev, buf), len);
124 return len < 0 ? len : -EIO;
125 }
126
127 if ((IS_ENABLED(CONFIG_FS_DAX_LIMITED) && pfn_t_special(pfn))
128 || pfn_t_devmap(pfn))
129 /* pass */;
130 else {
131 pr_debug("%s: error: dax support not enabled\n",
132 bdevname(bdev, buf));
133 return -EOPNOTSUPP;
134 }
135
136 return 0;
137 }
138 EXPORT_SYMBOL_GPL(bdev_dax_supported);
139 #endif
140
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
WARNING: multiple messages have this Message-ID (diff)
From: kbuild test robot <lkp@intel.com>
To: Dave Jiang <dave.jiang@intel.com>
Cc: kbuild-all@01.org, darrick.wong@oracle.com,
linux-nvdimm@lists.01.org, david@fromorbit.com,
linux-xfs@vger.kernel.org, ross.zwisler@linux.intel.com,
linux-ext4@vger.kernel.org, dan.j.williams@intel.com
Subject: Re: [PATCH v6 1/3] fs: allow per-device dax status checking for filesystems
Date: Tue, 20 Feb 2018 08:24:33 +0800 [thread overview]
Message-ID: <201802200834.rXDUV1nU%fengguang.wu@intel.com> (raw)
In-Reply-To: <151880065504.43131.6695118308172421769.stgit@djiang5-desk3.ch.intel.com>
[-- Attachment #1: Type: text/plain, Size: 3278 bytes --]
Hi Darrick,
I love your patch! Yet something to improve:
[auto build test ERROR on linus/master]
[also build test ERROR on v4.16-rc2 next-20180219]
[cannot apply to dgc-xfs/for-next]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
url: https://github.com/0day-ci/linux/commits/Dave-Jiang/fs-allow-per-device-dax-status-checking-for-filesystems/20180219-121644
config: x86_64-randconfig-s5-02200659 (attached as .config)
compiler: gcc-7 (Debian 7.3.0-1) 7.3.0
reproduce:
# save the attached .config to linux build tree
make ARCH=x86_64
All errors (new ones prefixed by >>):
>> drivers/dax/super.c:85:5: error: redefinition of 'bdev_dax_supported'
int bdev_dax_supported(struct block_device *bdev, int blocksize)
^~~~~~~~~~~~~~~~~~
In file included from drivers/dax/super.c:23:0:
include/linux/dax.h:56:19: note: previous definition of 'bdev_dax_supported' was here
static inline int bdev_dax_supported(struct block_device *bdev,
^~~~~~~~~~~~~~~~~~
vim +/bdev_dax_supported +85 drivers/dax/super.c
74
75 /**
76 * bdev_dax_supported() - Check if the device supports dax for filesystem
77 * @bdev: block device to check
78 * @blocksize: The block size of the device
79 *
80 * This is a library function for filesystems to check if the block device
81 * can be mounted with dax option.
82 *
83 * Return: negative errno if unsupported, 0 if supported.
84 */
> 85 int bdev_dax_supported(struct block_device *bdev, int blocksize)
86 {
87 struct dax_device *dax_dev;
88 pgoff_t pgoff;
89 int err, id;
90 void *kaddr;
91 pfn_t pfn;
92 long len;
93 char buf[BDEVNAME_SIZE];
94
95 if (blocksize != PAGE_SIZE) {
96 pr_debug("%s: error: unsupported blocksize for dax\n",
97 bdevname(bdev, buf));
98 return -EINVAL;
99 }
100
101 err = bdev_dax_pgoff(bdev, 0, PAGE_SIZE, &pgoff);
102 if (err) {
103 pr_debug("%s: error: unaligned partition for dax\n",
104 bdevname(bdev, buf));
105 return err;
106 }
107
108 dax_dev = dax_get_by_host(bdev->bd_disk->disk_name);
109 if (!dax_dev) {
110 pr_debug("%s: error: device does not support dax\n",
111 bdevname(bdev, buf));
112 return -EOPNOTSUPP;
113 }
114
115 id = dax_read_lock();
116 len = dax_direct_access(dax_dev, pgoff, 1, &kaddr, &pfn);
117 dax_read_unlock(id);
118
119 put_dax(dax_dev);
120
121 if (len < 1) {
122 pr_debug("%s: error: dax access failed (%ld)\n",
123 bdevname(bdev, buf), len);
124 return len < 0 ? len : -EIO;
125 }
126
127 if ((IS_ENABLED(CONFIG_FS_DAX_LIMITED) && pfn_t_special(pfn))
128 || pfn_t_devmap(pfn))
129 /* pass */;
130 else {
131 pr_debug("%s: error: dax support not enabled\n",
132 bdevname(bdev, buf));
133 return -EOPNOTSUPP;
134 }
135
136 return 0;
137 }
138 EXPORT_SYMBOL_GPL(bdev_dax_supported);
139 #endif
140
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 29181 bytes --]
next prev parent reply other threads:[~2018-02-20 0:19 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-16 17:04 [PATCH v6 0/3] minimal DAX support for XFS realtime device Dave Jiang
2018-02-16 17:04 ` Dave Jiang
2018-02-16 17:04 ` [PATCH v6 1/3] fs: allow per-device dax status checking for filesystems Dave Jiang
2018-02-16 17:04 ` Dave Jiang
2018-02-16 17:04 ` Dave Jiang
2018-02-20 0:24 ` kbuild test robot [this message]
2018-02-20 0:24 ` kbuild test robot
2018-02-20 0:24 ` kbuild test robot
2018-02-16 17:04 ` [PATCH v6 2/3] dax: change bdev_dax_supported() to support boolean returns Dave Jiang
2018-02-16 17:04 ` Dave Jiang
2018-02-16 17:04 ` Dave Jiang
2018-02-16 17:26 ` Darrick J. Wong
2018-02-16 17:26 ` Darrick J. Wong
2018-02-16 17:26 ` Darrick J. Wong
2018-02-16 17:04 ` [PATCH v6 3/3] xfs: reject removal of realtime flag when datadev doesn't support DAX Dave Jiang
2018-02-16 17:04 ` Dave Jiang
2018-02-16 17:22 ` Darrick J. Wong
2018-02-16 17:22 ` Darrick J. Wong
2018-02-18 0:23 ` Dave Chinner
2018-02-18 0:23 ` Dave Chinner
2018-02-20 23:01 ` Darrick J. Wong
2018-02-20 23:01 ` Darrick J. Wong
2018-02-20 23:01 ` Darrick J. Wong
2018-02-20 23:15 ` Dave Chinner
2018-02-20 23:15 ` Dave Chinner
2018-02-20 23:15 ` Dave Chinner
2018-02-20 23:23 ` Darrick J. Wong
2018-02-20 23:23 ` Darrick J. Wong
2018-02-20 23:23 ` Darrick J. Wong
2018-02-27 16:46 ` Dave Jiang
2018-02-27 16:46 ` Dave Jiang
2018-02-27 16:46 ` Dave Jiang
2018-02-27 17:14 ` Darrick J. Wong
2018-02-27 17:14 ` Darrick J. Wong
2018-02-27 17:14 ` Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201802200834.rXDUV1nU%fengguang.wu@intel.com \
--to=lkp@intel.com \
--cc=darrick.wong@oracle.com \
--cc=dave.jiang@intel.com \
--cc=david@fromorbit.com \
--cc=kbuild-all@01.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-nvdimm@lists.01.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.