From: Stu Hsieh <stu.hsieh@mediatek.com>
To: CK Hu <ck.hu@mediatek.com>
Cc: Philipp Zabel <p.zabel@pengutronix.de>,
David Airlie <airlied@linux.ie>, Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
<dri-devel@lists.freedesktop.org>, <devicetree@vger.kernel.org>,
<linux-kernel@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-mediatek@lists.infradead.org>,
<srv_heupstream@mediatek.com>
Subject: Re: [PATCH 26/28] drm/mediatek: add DPI1/DSI1/DSI2/DSI3 in comp_init
Date: Wed, 13 Jun 2018 16:05:55 +0800 [thread overview]
Message-ID: <1528877155.11190.36.camel@mtksdccf07> (raw)
In-Reply-To: <1528875305.30263.14.camel@mtksdaap41>
Hi, CK:
On Wed, 2018-06-13 at 15:35 +0800, CK Hu wrote:
> Hi, Stu:
>
> On Mon, 2018-06-11 at 11:26 +0800, Stu Hsieh wrote:
> > This patch add components DPI1/DSI1/DSI2/DSI3 in comp_init.
> > Because the some parameter for these components initialized
> > in their driver.
> >
> > Signed-off-by: Stu Hsieh <stu.hsieh@mediatek.com>
> > ---
> > drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c | 4 ++++
> > 1 file changed, 4 insertions(+)
> >
> > diff --git a/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c b/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c
> > index 22f4c72fa785..ff974d82a4a6 100644
> > --- a/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c
> > +++ b/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c
> > @@ -278,7 +278,11 @@ int mtk_ddp_comp_init(struct device *dev, struct device_node *node,
> >
> > if (comp_id == DDP_COMPONENT_BLS ||
> > comp_id == DDP_COMPONENT_DPI0 ||
> > + comp_id == DDP_COMPONENT_DPI1 ||
>
> Why not move this modification to the patch 'add component DPI1'?
>
> > comp_id == DDP_COMPONENT_DSI0 ||
> > + comp_id == DDP_COMPONENT_DSI1 ||
> > + comp_id == DDP_COMPONENT_DSI2 ||
>
> Why not move this modification to the patch 'add component DSI2'?
>
> > + comp_id == DDP_COMPONENT_DSI3 ||
>
> Why not move this modification to the patch 'add component DSI3'?
>
> Regards,
> CK
>
ok
Regard,
Stu
> > comp_id == DDP_COMPONENT_PWM0) {
> > comp->regs = NULL;
> > comp->clk = NULL;
>
>
WARNING: multiple messages have this Message-ID (diff)
From: Stu Hsieh <stu.hsieh@mediatek.com>
To: CK Hu <ck.hu@mediatek.com>
Cc: Mark Rutland <mark.rutland@arm.com>,
devicetree@vger.kernel.org, srv_heupstream@mediatek.com,
David Airlie <airlied@linux.ie>,
linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
Rob Herring <robh+dt@kernel.org>,
linux-mediatek@lists.infradead.org,
Matthias Brugger <matthias.bgg@gmail.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 26/28] drm/mediatek: add DPI1/DSI1/DSI2/DSI3 in comp_init
Date: Wed, 13 Jun 2018 16:05:55 +0800 [thread overview]
Message-ID: <1528877155.11190.36.camel@mtksdccf07> (raw)
In-Reply-To: <1528875305.30263.14.camel@mtksdaap41>
Hi, CK:
On Wed, 2018-06-13 at 15:35 +0800, CK Hu wrote:
> Hi, Stu:
>
> On Mon, 2018-06-11 at 11:26 +0800, Stu Hsieh wrote:
> > This patch add components DPI1/DSI1/DSI2/DSI3 in comp_init.
> > Because the some parameter for these components initialized
> > in their driver.
> >
> > Signed-off-by: Stu Hsieh <stu.hsieh@mediatek.com>
> > ---
> > drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c | 4 ++++
> > 1 file changed, 4 insertions(+)
> >
> > diff --git a/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c b/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c
> > index 22f4c72fa785..ff974d82a4a6 100644
> > --- a/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c
> > +++ b/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c
> > @@ -278,7 +278,11 @@ int mtk_ddp_comp_init(struct device *dev, struct device_node *node,
> >
> > if (comp_id == DDP_COMPONENT_BLS ||
> > comp_id == DDP_COMPONENT_DPI0 ||
> > + comp_id == DDP_COMPONENT_DPI1 ||
>
> Why not move this modification to the patch 'add component DPI1'?
>
> > comp_id == DDP_COMPONENT_DSI0 ||
> > + comp_id == DDP_COMPONENT_DSI1 ||
> > + comp_id == DDP_COMPONENT_DSI2 ||
>
> Why not move this modification to the patch 'add component DSI2'?
>
> > + comp_id == DDP_COMPONENT_DSI3 ||
>
> Why not move this modification to the patch 'add component DSI3'?
>
> Regards,
> CK
>
ok
Regard,
Stu
> > comp_id == DDP_COMPONENT_PWM0) {
> > comp->regs = NULL;
> > comp->clk = NULL;
>
>
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
WARNING: multiple messages have this Message-ID (diff)
From: stu.hsieh@mediatek.com (Stu Hsieh)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 26/28] drm/mediatek: add DPI1/DSI1/DSI2/DSI3 in comp_init
Date: Wed, 13 Jun 2018 16:05:55 +0800 [thread overview]
Message-ID: <1528877155.11190.36.camel@mtksdccf07> (raw)
In-Reply-To: <1528875305.30263.14.camel@mtksdaap41>
Hi, CK:
On Wed, 2018-06-13 at 15:35 +0800, CK Hu wrote:
> Hi, Stu:
>
> On Mon, 2018-06-11 at 11:26 +0800, Stu Hsieh wrote:
> > This patch add components DPI1/DSI1/DSI2/DSI3 in comp_init.
> > Because the some parameter for these components initialized
> > in their driver.
> >
> > Signed-off-by: Stu Hsieh <stu.hsieh@mediatek.com>
> > ---
> > drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c | 4 ++++
> > 1 file changed, 4 insertions(+)
> >
> > diff --git a/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c b/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c
> > index 22f4c72fa785..ff974d82a4a6 100644
> > --- a/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c
> > +++ b/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c
> > @@ -278,7 +278,11 @@ int mtk_ddp_comp_init(struct device *dev, struct device_node *node,
> >
> > if (comp_id == DDP_COMPONENT_BLS ||
> > comp_id == DDP_COMPONENT_DPI0 ||
> > + comp_id == DDP_COMPONENT_DPI1 ||
>
> Why not move this modification to the patch 'add component DPI1'?
>
> > comp_id == DDP_COMPONENT_DSI0 ||
> > + comp_id == DDP_COMPONENT_DSI1 ||
> > + comp_id == DDP_COMPONENT_DSI2 ||
>
> Why not move this modification to the patch 'add component DSI2'?
>
> > + comp_id == DDP_COMPONENT_DSI3 ||
>
> Why not move this modification to the patch 'add component DSI3'?
>
> Regards,
> CK
>
ok
Regard,
Stu
> > comp_id == DDP_COMPONENT_PWM0) {
> > comp->regs = NULL;
> > comp->clk = NULL;
>
>
next prev parent reply other threads:[~2018-06-13 8:06 UTC|newest]
Thread overview: 189+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-11 3:25 [PATCH v5 00/28] Add support for mediatek SOC MT2712 Stu Hsieh
2018-06-11 3:25 ` Stu Hsieh
2018-06-11 3:25 ` Stu Hsieh
2018-06-11 3:25 ` [PATCH 01/28] drm/mediatek: update dt-bindings for mt2712 Stu Hsieh
2018-06-11 3:25 ` Stu Hsieh
2018-06-11 3:25 ` Stu Hsieh
2018-06-11 3:25 ` [PATCH 02/28] drm/mediatek: support maximum 64 mutex mod Stu Hsieh
2018-06-11 3:25 ` Stu Hsieh
2018-06-11 3:25 ` Stu Hsieh
2018-06-11 3:25 ` [PATCH 03/28] drm/mediatek: add ddp component AAL1 Stu Hsieh
2018-06-11 3:25 ` Stu Hsieh
2018-06-11 3:25 ` Stu Hsieh
2018-06-11 3:25 ` [PATCH 04/28] drm/mediatek: add ddp component OD1 Stu Hsieh
2018-06-11 3:25 ` Stu Hsieh
2018-06-11 3:25 ` Stu Hsieh
2018-06-13 5:27 ` CK Hu
2018-06-13 5:27 ` CK Hu
2018-06-13 5:27 ` CK Hu
2018-06-11 3:25 ` [PATCH 05/28] drm/mediatek: add ddp component PWM1 Stu Hsieh
2018-06-11 3:25 ` Stu Hsieh
2018-06-11 3:25 ` Stu Hsieh
2018-06-11 3:25 ` [PATCH 06/28] drm/mediatek: add ddp component PWM2 Stu Hsieh
2018-06-11 3:25 ` Stu Hsieh
2018-06-11 3:25 ` Stu Hsieh
2018-06-11 3:25 ` [PATCH 07/28] drm/mediatek: add component DPI1 Stu Hsieh
2018-06-11 3:25 ` Stu Hsieh
2018-06-11 3:25 ` Stu Hsieh
2018-06-13 5:29 ` CK Hu
2018-06-13 5:29 ` CK Hu
2018-06-13 5:29 ` CK Hu
2018-06-11 3:26 ` [PATCH 08/28] drm/mediatek: add component DSI2 Stu Hsieh
2018-06-11 3:26 ` Stu Hsieh
2018-06-11 3:26 ` Stu Hsieh
2018-06-13 5:30 ` CK Hu
2018-06-13 5:30 ` CK Hu
2018-06-13 5:30 ` CK Hu
2018-06-11 3:26 ` [PATCH 09/28] drm/mediatek: add component DSI3 Stu Hsieh
2018-06-11 3:26 ` Stu Hsieh
2018-06-11 3:26 ` Stu Hsieh
2018-06-13 5:31 ` CK Hu
2018-06-13 5:31 ` CK Hu
2018-06-13 5:31 ` CK Hu
2018-06-11 3:26 ` [PATCH 10/28] drm/mediatek: add connection from OD1 to RDMA1 Stu Hsieh
2018-06-11 3:26 ` Stu Hsieh
2018-06-11 3:26 ` Stu Hsieh
2018-06-11 3:26 ` [PATCH 11/28] drm/mediatek: add connection from RDMA0 to DPI0 Stu Hsieh
2018-06-11 3:26 ` Stu Hsieh
2018-06-11 3:26 ` Stu Hsieh
2018-06-13 5:38 ` CK Hu
2018-06-13 5:38 ` CK Hu
2018-06-13 5:38 ` CK Hu
2018-06-11 3:26 ` [PATCH 12/28] drm/mediatek: add connection from RDMA0 to DSI2 Stu Hsieh
2018-06-11 3:26 ` Stu Hsieh
2018-06-11 3:26 ` Stu Hsieh
2018-06-13 5:39 ` CK Hu
2018-06-13 5:39 ` CK Hu
2018-06-13 5:39 ` CK Hu
2018-06-11 3:26 ` [PATCH 13/28] drm/mediatek: add connection from RDMA0 to DSI3 Stu Hsieh
2018-06-11 3:26 ` Stu Hsieh
2018-06-11 3:26 ` Stu Hsieh
2018-06-13 5:45 ` CK Hu
2018-06-13 5:45 ` CK Hu
2018-06-13 5:45 ` CK Hu
2018-06-13 7:46 ` Stu Hsieh
2018-06-13 7:46 ` Stu Hsieh
2018-06-13 7:46 ` Stu Hsieh
2018-06-13 8:05 ` CK Hu
2018-06-13 8:05 ` CK Hu
2018-06-13 8:05 ` CK Hu
2018-06-13 8:52 ` Stu Hsieh
2018-06-13 8:52 ` Stu Hsieh
2018-06-13 8:52 ` Stu Hsieh
2018-06-11 3:26 ` [PATCH 14/28] drm/mediatek: add connection from RDMA1 to DPI1 Stu Hsieh
2018-06-11 3:26 ` Stu Hsieh
2018-06-11 3:26 ` Stu Hsieh
2018-06-13 6:13 ` CK Hu
2018-06-13 6:13 ` CK Hu
2018-06-13 6:13 ` CK Hu
2018-06-13 7:56 ` Stu Hsieh
2018-06-13 7:56 ` Stu Hsieh
2018-06-13 7:56 ` Stu Hsieh
2018-06-13 8:27 ` CK Hu
2018-06-13 8:27 ` CK Hu
2018-06-13 8:27 ` CK Hu
2018-06-13 8:53 ` Stu Hsieh
2018-06-13 8:53 ` Stu Hsieh
2018-06-13 8:53 ` Stu Hsieh
2018-06-11 3:26 ` [PATCH 15/28] drm/mediatek: add connection from RDMA1 to DSI1 Stu Hsieh
2018-06-11 3:26 ` Stu Hsieh
2018-06-11 3:26 ` Stu Hsieh
2018-06-13 6:44 ` CK Hu
2018-06-13 6:44 ` CK Hu
2018-06-13 6:44 ` CK Hu
2018-06-13 6:59 ` CK Hu
2018-06-13 6:59 ` CK Hu
2018-06-13 6:59 ` CK Hu
2018-06-11 3:26 ` [PATCH 16/28] drm/mediatek: add connection from RDMA1 to DSI2 Stu Hsieh
2018-06-11 3:26 ` Stu Hsieh
2018-06-11 3:26 ` Stu Hsieh
2018-06-13 7:00 ` CK Hu
2018-06-13 7:00 ` CK Hu
2018-06-13 7:00 ` CK Hu
2018-06-11 3:26 ` [PATCH 17/28] drm/mediatek: add connection from RDMA1 to DSI3 Stu Hsieh
2018-06-11 3:26 ` Stu Hsieh
2018-06-11 3:26 ` Stu Hsieh
2018-06-13 7:04 ` CK Hu
2018-06-13 7:04 ` CK Hu
2018-06-13 7:04 ` CK Hu
2018-06-11 3:26 ` [PATCH 18/28] drm/mediatek: add connection from RDMA2 to DPI0 Stu Hsieh
2018-06-11 3:26 ` Stu Hsieh
2018-06-11 3:26 ` Stu Hsieh
2018-06-13 7:07 ` CK Hu
2018-06-13 7:07 ` CK Hu
2018-06-13 7:07 ` CK Hu
2018-06-11 3:26 ` [PATCH 19/28] drm/mediatek: add connection from RDMA2 to DPI1 Stu Hsieh
2018-06-11 3:26 ` Stu Hsieh
2018-06-11 3:26 ` Stu Hsieh
2018-06-13 7:13 ` CK Hu
2018-06-13 7:13 ` CK Hu
2018-06-13 7:13 ` CK Hu
2018-06-13 8:01 ` Stu Hsieh
2018-06-13 8:01 ` Stu Hsieh
2018-06-13 8:01 ` Stu Hsieh
2018-06-13 8:14 ` CK Hu
2018-06-13 8:14 ` CK Hu
2018-06-13 8:14 ` CK Hu
2018-06-13 8:58 ` Stu Hsieh
2018-06-13 8:58 ` Stu Hsieh
2018-06-13 8:58 ` Stu Hsieh
2018-06-13 9:01 ` CK Hu
2018-06-13 9:01 ` CK Hu
2018-06-13 9:01 ` CK Hu
2018-06-11 3:26 ` [PATCH 20/28] drm/mediatek: add connection from RDMA2 to DSI1 Stu Hsieh
2018-06-11 3:26 ` Stu Hsieh
2018-06-11 3:26 ` Stu Hsieh
2018-06-13 7:17 ` CK Hu
2018-06-13 7:17 ` CK Hu
2018-06-13 7:17 ` CK Hu
2018-06-11 3:26 ` [PATCH 21/28] drm/mediatek: add connection from RDMA2 to DSI2 Stu Hsieh
2018-06-11 3:26 ` Stu Hsieh
2018-06-11 3:26 ` Stu Hsieh
2018-06-13 7:18 ` CK Hu
2018-06-13 7:18 ` CK Hu
2018-06-13 7:18 ` CK Hu
2018-06-11 3:26 ` [PATCH 22/28] drm/mediatek: add connection from RDMA2 to DSI3 Stu Hsieh
2018-06-11 3:26 ` Stu Hsieh
2018-06-11 3:26 ` Stu Hsieh
2018-06-13 7:19 ` CK Hu
2018-06-13 7:19 ` CK Hu
2018-06-13 7:19 ` CK Hu
2018-06-11 3:26 ` [PATCH 23/28] drm/mediatek: add DPI1 support for mutex Stu Hsieh
2018-06-11 3:26 ` Stu Hsieh
2018-06-11 3:26 ` Stu Hsieh
2018-06-13 7:22 ` CK Hu
2018-06-13 7:22 ` CK Hu
2018-06-13 7:22 ` CK Hu
2018-06-11 3:26 ` [PATCH 24/28] drm/mediatek: add DSI2 " Stu Hsieh
2018-06-11 3:26 ` Stu Hsieh
2018-06-11 3:26 ` Stu Hsieh
2018-06-13 7:22 ` CK Hu
2018-06-13 7:22 ` CK Hu
2018-06-13 7:22 ` CK Hu
2018-06-11 3:26 ` [PATCH 25/28] drm/mediatek: add DSI3 " Stu Hsieh
2018-06-11 3:26 ` Stu Hsieh
2018-06-11 3:26 ` Stu Hsieh
2018-06-13 7:22 ` CK Hu
2018-06-13 7:22 ` CK Hu
2018-06-13 7:22 ` CK Hu
2018-06-11 3:26 ` [PATCH 26/28] drm/mediatek: add DPI1/DSI1/DSI2/DSI3 in comp_init Stu Hsieh
2018-06-11 3:26 ` Stu Hsieh
2018-06-11 3:26 ` Stu Hsieh
2018-06-13 7:35 ` CK Hu
2018-06-13 7:35 ` CK Hu
2018-06-13 7:35 ` CK Hu
2018-06-13 8:05 ` Stu Hsieh [this message]
2018-06-13 8:05 ` Stu Hsieh
2018-06-13 8:05 ` Stu Hsieh
2018-06-11 3:26 ` [PATCH 27/28] drm/mediatek: add third ddp path Stu Hsieh
2018-06-11 3:26 ` Stu Hsieh
2018-06-11 3:26 ` Stu Hsieh
2018-06-13 7:38 ` CK Hu
2018-06-13 7:38 ` CK Hu
2018-06-13 7:38 ` CK Hu
2018-06-11 3:26 ` [PATCH 28/28] drm/mediatek: Add support for mediatek SOC MT2712 Stu Hsieh
2018-06-11 3:26 ` Stu Hsieh
2018-06-11 3:26 ` Stu Hsieh
2018-06-13 7:48 ` CK Hu
2018-06-13 7:48 ` CK Hu
2018-06-13 7:48 ` CK Hu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1528877155.11190.36.camel@mtksdccf07 \
--to=stu.hsieh@mediatek.com \
--cc=airlied@linux.ie \
--cc=ck.hu@mediatek.com \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=matthias.bgg@gmail.com \
--cc=p.zabel@pengutronix.de \
--cc=robh+dt@kernel.org \
--cc=srv_heupstream@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.