From: Philipp Zabel <p.zabel@pengutronix.de>
To: Alexandru Gheorghe <alexandru-cosmin.gheorghe@arm.com>,
seanpaul@chromium.org, airlied@linux.ie,
dri-devel@lists.freedesktop.org, liviu.dudau@arm.com,
brian.starkey@arm.com, malidp@foss.arm.com,
ville.syrjala@linux.intel.com, daniel@ffwll.ch,
gustavo@padovan.org, maarten.lankhorst@linux.intel.com,
alexander.deucher@amd.com, christian.koenig@amd.com,
David1.Zhou@amd.com, harry.wentland@amd.com,
andrey.grodzovsky@amd.com, Tony.Cheng@amd.com,
sunpeng.li@amd.com, shirish.s@amd.com,
boris.brezillon@bootlin.com, nicolas.ferre@microchip.com,
alexandre.belloni@bootlin.com, inki.dae@samsung.com,
jy0922.shim@samsung.com, sw0312.kim@samsung.com,
kyungmin.park@samsung.com, kgene@kernel.org, krzk@kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org,
laurent.pinchart@ideasonboard.com, maxime.ripard@bootlin.com,
wens@csie.org, eric@anholt.net
Cc: nd@arm.com
Subject: Re: [PATCH v3 06/10] drm/imx: Use __drm_atomic_helper_plane_reset instead of copying the logic
Date: Mon, 06 Aug 2018 08:29:13 +0200 [thread overview]
Message-ID: <1533536953.4204.3.camel@pengutronix.de> (raw)
In-Reply-To: <20180804161530.12275-7-alexandru-cosmin.gheorghe@arm.com>
Hi Alexandru,
On Sat, 2018-08-04 at 17:15 +0100, Alexandru Gheorghe wrote:
> A new helper function(__drm_atomic_helper_plane_reset) has been added
> for linking a plane with its state and resetting the core
> properties(alpha, rotation, etc.) to their default values.
> Use that instead of duplicating the logic.
>
> Signed-off-by: Alexandru Gheorghe <alexandru-cosmin.gheorghe@arm.com>
> ---
> drivers/gpu/drm/imx/ipuv3-plane.c | 8 +++-----
> 1 file changed, 3 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/gpu/drm/imx/ipuv3-plane.c b/drivers/gpu/drm/imx/ipuv3-plane.c
> index 203f247d4854..1bd4de03ce9e 100644
> --- a/drivers/gpu/drm/imx/ipuv3-plane.c
> +++ b/drivers/gpu/drm/imx/ipuv3-plane.c
> @@ -281,16 +281,14 @@ static void ipu_plane_state_reset(struct drm_plane *plane)
> ipu_state = to_ipu_plane_state(plane->state);
> __drm_atomic_helper_plane_destroy_state(plane->state);
> kfree(ipu_state);
> + plane->state = NULL;
> }
>
> ipu_state = kzalloc(sizeof(*ipu_state), GFP_KERNEL);
>
> - if (ipu_state) {
> - ipu_state->base.plane = plane;
> - ipu_state->base.rotation = DRM_MODE_ROTATE_0;
> - }
> + if (ipu_state)
> + __drm_atomic_helper_plane_reset(plane, &ipu_state->base);
>
Could you remove this white line as well?
> - plane->state = &ipu_state->base;
> }
>
> static struct drm_plane_state *
Acked-by: Philipp Zabel <p.zabel@pengutronix.de>
to be merged through drm-misc together with the other changes.
regards
Philipp
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
WARNING: multiple messages have this Message-ID (diff)
From: p.zabel@pengutronix.de (Philipp Zabel)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 06/10] drm/imx: Use __drm_atomic_helper_plane_reset instead of copying the logic
Date: Mon, 06 Aug 2018 08:29:13 +0200 [thread overview]
Message-ID: <1533536953.4204.3.camel@pengutronix.de> (raw)
In-Reply-To: <20180804161530.12275-7-alexandru-cosmin.gheorghe@arm.com>
Hi Alexandru,
On Sat, 2018-08-04 at 17:15 +0100, Alexandru Gheorghe wrote:
> A new helper function(__drm_atomic_helper_plane_reset) has been added
> for linking a plane with its state and resetting the core
> properties(alpha, rotation, etc.) to their default values.
> Use that instead of duplicating the logic.
>
> Signed-off-by: Alexandru Gheorghe <alexandru-cosmin.gheorghe@arm.com>
> ---
> drivers/gpu/drm/imx/ipuv3-plane.c | 8 +++-----
> 1 file changed, 3 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/gpu/drm/imx/ipuv3-plane.c b/drivers/gpu/drm/imx/ipuv3-plane.c
> index 203f247d4854..1bd4de03ce9e 100644
> --- a/drivers/gpu/drm/imx/ipuv3-plane.c
> +++ b/drivers/gpu/drm/imx/ipuv3-plane.c
> @@ -281,16 +281,14 @@ static void ipu_plane_state_reset(struct drm_plane *plane)
> ipu_state = to_ipu_plane_state(plane->state);
> __drm_atomic_helper_plane_destroy_state(plane->state);
> kfree(ipu_state);
> + plane->state = NULL;
> }
>
> ipu_state = kzalloc(sizeof(*ipu_state), GFP_KERNEL);
>
> - if (ipu_state) {
> - ipu_state->base.plane = plane;
> - ipu_state->base.rotation = DRM_MODE_ROTATE_0;
> - }
> + if (ipu_state)
> + __drm_atomic_helper_plane_reset(plane, &ipu_state->base);
>
Could you remove this white line as well?
> - plane->state = &ipu_state->base;
> }
>
> static struct drm_plane_state *
Acked-by: Philipp Zabel <p.zabel@pengutronix.de>
to be merged through drm-misc together with the other changes.
regards
Philipp
next prev parent reply other threads:[~2018-08-06 6:29 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-04 16:15 [PATCH v3 00/10] Add helper for plane reset Alexandru Gheorghe
2018-08-04 16:15 ` Alexandru Gheorghe
2018-08-04 16:15 ` [PATCH v3 01/10] drm/atomic: Add __drm_atomic_helper_plane_reset Alexandru Gheorghe
2018-08-04 16:15 ` Alexandru Gheorghe
2018-08-06 6:29 ` Philipp Zabel
2018-08-06 6:29 ` Philipp Zabel
2018-08-04 16:15 ` [PATCH v3 02/10] drm/amd/display: Use __drm_atomic_helper_plane_reset instead of copying the logic Alexandru Gheorghe
2018-08-04 16:15 ` Alexandru Gheorghe
2018-08-04 16:15 ` [PATCH v3 03/10] drm: mali-dp: " Alexandru Gheorghe
2018-08-04 16:15 ` Alexandru Gheorghe
2018-08-04 16:15 ` [PATCH v3 04/10] drm: atmel-hlcdc: " Alexandru Gheorghe
2018-08-04 16:15 ` Alexandru Gheorghe
2018-08-04 16:15 ` [PATCH v3 05/10] drm/exynos: " Alexandru Gheorghe
2018-08-04 16:15 ` Alexandru Gheorghe
2018-08-04 16:15 ` [PATCH v3 06/10] drm/imx: " Alexandru Gheorghe
2018-08-04 16:15 ` Alexandru Gheorghe
2018-08-06 6:29 ` Philipp Zabel [this message]
2018-08-06 6:29 ` Philipp Zabel
2018-08-06 8:53 ` Alexandru-Cosmin Gheorghe
2018-08-06 8:53 ` Alexandru-Cosmin Gheorghe
2018-08-04 16:15 ` [PATCH v3 07/10] drm: rcar-du: " Alexandru Gheorghe
2018-08-04 16:15 ` Alexandru Gheorghe
2018-08-04 16:15 ` [PATCH v3 08/10] drm/sun4i: " Alexandru Gheorghe
2018-08-04 16:15 ` Alexandru Gheorghe
2018-08-04 16:15 ` [PATCH v3 09/10] drm/vc4: " Alexandru Gheorghe
2018-08-04 16:15 ` Alexandru Gheorghe
2018-08-06 19:58 ` Eric Anholt
2018-08-06 19:58 ` Eric Anholt
2018-08-08 18:16 ` Alexandru-Cosmin Gheorghe
2018-08-04 16:15 ` [PATCH v3 10/10] drm/vmwgfx: " Alexandru Gheorghe
2018-08-04 16:15 ` Alexandru Gheorghe
2018-08-06 16:57 ` Sinclair Yeh
2018-08-06 16:57 ` Sinclair Yeh
2018-08-07 8:03 ` Alexandru-Cosmin Gheorghe
2018-08-07 8:03 ` Alexandru-Cosmin Gheorghe
2018-08-07 13:25 ` Sinclair Yeh
2018-08-07 13:25 ` Sinclair Yeh
2018-08-06 11:07 ` [PATCH v3 00/10] Add helper for plane reset Alexandru-Cosmin Gheorghe
2018-08-06 11:07 ` Alexandru-Cosmin Gheorghe
2018-08-06 11:45 ` Laurent Pinchart
2018-08-06 11:45 ` Laurent Pinchart
2018-08-06 12:20 ` Alexandru-Cosmin Gheorghe
2018-08-06 12:20 ` Alexandru-Cosmin Gheorghe
2018-08-06 12:28 ` Laurent Pinchart
2018-08-06 12:28 ` Laurent Pinchart
2018-08-06 15:48 ` Daniel Vetter
2018-08-06 15:48 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1533536953.4204.3.camel@pengutronix.de \
--to=p.zabel@pengutronix.de \
--cc=David1.Zhou@amd.com \
--cc=Tony.Cheng@amd.com \
--cc=airlied@linux.ie \
--cc=alexander.deucher@amd.com \
--cc=alexandre.belloni@bootlin.com \
--cc=alexandru-cosmin.gheorghe@arm.com \
--cc=andrey.grodzovsky@amd.com \
--cc=boris.brezillon@bootlin.com \
--cc=brian.starkey@arm.com \
--cc=christian.koenig@amd.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=eric@anholt.net \
--cc=gustavo@padovan.org \
--cc=harry.wentland@amd.com \
--cc=inki.dae@samsung.com \
--cc=jy0922.shim@samsung.com \
--cc=kgene@kernel.org \
--cc=krzk@kernel.org \
--cc=kyungmin.park@samsung.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=liviu.dudau@arm.com \
--cc=maarten.lankhorst@linux.intel.com \
--cc=malidp@foss.arm.com \
--cc=maxime.ripard@bootlin.com \
--cc=nd@arm.com \
--cc=nicolas.ferre@microchip.com \
--cc=seanpaul@chromium.org \
--cc=shirish.s@amd.com \
--cc=sunpeng.li@amd.com \
--cc=sw0312.kim@samsung.com \
--cc=ville.syrjala@linux.intel.com \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.