From: Laurent Pinchart <laurent.pinchart@ideasonboard.com> To: Alexandru-Cosmin Gheorghe <Alexandru-Cosmin.Gheorghe@arm.com> Cc: alexandre.belloni@bootlin.com, airlied@linux.ie, liviu.dudau@arm.com, dri-devel@lists.freedesktop.org, thellstrom@vmware.com, krzk@kernel.org, maxime.ripard@bootlin.com, wens@csie.org, kgene@kernel.org, malidp@foss.arm.com, linux-graphics-maintainer@vmware.com, sunpeng.li@amd.com, boris.brezillon@bootlin.com, linux-samsung-soc@vger.kernel.org, nd@arm.com, Tony.Cheng@amd.com, linux-arm-kernel@lists.infradead.org, sw0312.kim@samsung.com, nicolas.ferre@microchip.com, shirish.s@amd.com, kyungmin.park@samsung.com, alexander.deucher@amd.com, christian.koenig@amd.com Subject: Re: [PATCH v3 00/10] Add helper for plane reset Date: Mon, 06 Aug 2018 14:45:42 +0300 [thread overview] Message-ID: <15977863.ZBGtPEODRU@avalon> (raw) In-Reply-To: <20180806110727.GA3314@e114479-lin.cambridge.arm.com> Hi Alex, On Monday, 6 August 2018 14:07:27 EEST Alexandru-Cosmin Gheorghe wrote: > Hi, > > On Sat, Aug 04, 2018 at 05:15:20PM +0100, Alexandru Gheorghe wrote: > > No significant change since v2, fixed a spelling mistake and > > added/removed some newlines in 01 and 07 patches. > > > > I plan to apply the first patch of the series and the patches for > > the drivers maintained through drm-misc(that go Reviewed/Ack) in > > drm-misc-next on Monday. > > > > For the other drivers please let me know if you want me to push them > > in drm-misc-next as well. > > Pushed the following patch to drm-misc-next: > > drm/atomic: Add __drm_atomic_helper_plane_reset > drm: mali-dp: Use __drm_atomic_helper_plane_reset instead of copying the > logic > drm: atmel-hlcdc: Use __drm_atomic_helper_plane_reset instead of copying the > logic > drm/imx: Use __drm_atomic_helper_plane_reset instead of copying the logic > drm/sun4i: Use __drm_atomic_helper_plane_reset instead of copying the logic I've acked the rcar-du part, could it be merged with the rest of the code ? > > Changes since v1: > > - Make __drm_atomic_helper_plane_reset consistent with the other > > helpers and require that both plane and state not be NULL, > > suggested by Boris Brezillon and Philipp Zabel. Drivers already > > check for that. > > > > - Add a proper commit message for driver changes. > > > > Drivers that subclass drm_plane need to copy the logic for linking the > > drm_plane with its state and to initialize core properties to their > > default values. E.g (alpha and rotation) > > > > Having a helper to reset the plane_state makes sense because of multiple > > reasons: > > 1. Eliminate code duplication. > > 2. Add a single place for initializing core properties to their > > default values, no need for driver to do it if what the helper sets > > makes sense for them. > > 3. No need to debug the driver when you enable a core property and > > observe it doesn't have a proper default value. > > > > Tested with mali-dp the other drivers are just built-tested. > > > > Alexandru Gheorghe (10): > > drm/atomic: Add __drm_atomic_helper_plane_reset > > drm/amd/display: Use __drm_atomic_helper_plane_reset instead of > > copying the logic > > drm: mali-dp: Use __drm_atomic_helper_plane_reset instead of copying > > the logic > > drm: atmel-hlcdc: Use __drm_atomic_helper_plane_reset instead of > > copying the logic > > drm/exynos: Use __drm_atomic_helper_plane_reset instead of copying the > > logic > > drm/imx: Use __drm_atomic_helper_plane_reset instead of copying the > > logic > > drm: rcar-du: Use __drm_atomic_helper_plane_reset instead of copying > > the logic > > drm/sun4i: Use __drm_atomic_helper_plane_reset instead of copying the > > logic > > drm/vc4: Use __drm_atomic_helper_plane_reset instead of copying the > > logic > > drm/vmwgfx: Use __drm_atomic_helper_plane_reset instead of copying the > > logic > > > > .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 7 ++-- > > drivers/gpu/drm/arm/malidp_planes.c | 7 ++-- > > .../gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c | 5 +-- > > drivers/gpu/drm/drm_atomic_helper.c | 33 ++++++++++++++----- > > drivers/gpu/drm/exynos/exynos_drm_plane.c | 3 +- > > drivers/gpu/drm/imx/ipuv3-plane.c | 8 ++--- > > drivers/gpu/drm/rcar-du/rcar_du_plane.c | 6 ++-- > > drivers/gpu/drm/rcar-du/rcar_du_vsp.c | 5 +-- > > drivers/gpu/drm/sun4i/sun4i_layer.c | 4 +-- > > drivers/gpu/drm/vc4/vc4_plane.c | 4 +-- > > drivers/gpu/drm/vmwgfx/vmwgfx_kms.c | 4 +-- > > include/drm/drm_atomic_helper.h | 2 ++ > > 12 files changed, 41 insertions(+), 47 deletions(-) -- Regards, Laurent Pinchart _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
WARNING: multiple messages have this Message-ID (diff)
From: laurent.pinchart@ideasonboard.com (Laurent Pinchart) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH v3 00/10] Add helper for plane reset Date: Mon, 06 Aug 2018 14:45:42 +0300 [thread overview] Message-ID: <15977863.ZBGtPEODRU@avalon> (raw) In-Reply-To: <20180806110727.GA3314@e114479-lin.cambridge.arm.com> Hi Alex, On Monday, 6 August 2018 14:07:27 EEST Alexandru-Cosmin Gheorghe wrote: > Hi, > > On Sat, Aug 04, 2018 at 05:15:20PM +0100, Alexandru Gheorghe wrote: > > No significant change since v2, fixed a spelling mistake and > > added/removed some newlines in 01 and 07 patches. > > > > I plan to apply the first patch of the series and the patches for > > the drivers maintained through drm-misc(that go Reviewed/Ack) in > > drm-misc-next on Monday. > > > > For the other drivers please let me know if you want me to push them > > in drm-misc-next as well. > > Pushed the following patch to drm-misc-next: > > drm/atomic: Add __drm_atomic_helper_plane_reset > drm: mali-dp: Use __drm_atomic_helper_plane_reset instead of copying the > logic > drm: atmel-hlcdc: Use __drm_atomic_helper_plane_reset instead of copying the > logic > drm/imx: Use __drm_atomic_helper_plane_reset instead of copying the logic > drm/sun4i: Use __drm_atomic_helper_plane_reset instead of copying the logic I've acked the rcar-du part, could it be merged with the rest of the code ? > > Changes since v1: > > - Make __drm_atomic_helper_plane_reset consistent with the other > > helpers and require that both plane and state not be NULL, > > suggested by Boris Brezillon and Philipp Zabel. Drivers already > > check for that. > > > > - Add a proper commit message for driver changes. > > > > Drivers that subclass drm_plane need to copy the logic for linking the > > drm_plane with its state and to initialize core properties to their > > default values. E.g (alpha and rotation) > > > > Having a helper to reset the plane_state makes sense because of multiple > > reasons: > > 1. Eliminate code duplication. > > 2. Add a single place for initializing core properties to their > > default values, no need for driver to do it if what the helper sets > > makes sense for them. > > 3. No need to debug the driver when you enable a core property and > > observe it doesn't have a proper default value. > > > > Tested with mali-dp the other drivers are just built-tested. > > > > Alexandru Gheorghe (10): > > drm/atomic: Add __drm_atomic_helper_plane_reset > > drm/amd/display: Use __drm_atomic_helper_plane_reset instead of > > copying the logic > > drm: mali-dp: Use __drm_atomic_helper_plane_reset instead of copying > > the logic > > drm: atmel-hlcdc: Use __drm_atomic_helper_plane_reset instead of > > copying the logic > > drm/exynos: Use __drm_atomic_helper_plane_reset instead of copying the > > logic > > drm/imx: Use __drm_atomic_helper_plane_reset instead of copying the > > logic > > drm: rcar-du: Use __drm_atomic_helper_plane_reset instead of copying > > the logic > > drm/sun4i: Use __drm_atomic_helper_plane_reset instead of copying the > > logic > > drm/vc4: Use __drm_atomic_helper_plane_reset instead of copying the > > logic > > drm/vmwgfx: Use __drm_atomic_helper_plane_reset instead of copying the > > logic > > > > .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 7 ++-- > > drivers/gpu/drm/arm/malidp_planes.c | 7 ++-- > > .../gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c | 5 +-- > > drivers/gpu/drm/drm_atomic_helper.c | 33 ++++++++++++++----- > > drivers/gpu/drm/exynos/exynos_drm_plane.c | 3 +- > > drivers/gpu/drm/imx/ipuv3-plane.c | 8 ++--- > > drivers/gpu/drm/rcar-du/rcar_du_plane.c | 6 ++-- > > drivers/gpu/drm/rcar-du/rcar_du_vsp.c | 5 +-- > > drivers/gpu/drm/sun4i/sun4i_layer.c | 4 +-- > > drivers/gpu/drm/vc4/vc4_plane.c | 4 +-- > > drivers/gpu/drm/vmwgfx/vmwgfx_kms.c | 4 +-- > > include/drm/drm_atomic_helper.h | 2 ++ > > 12 files changed, 41 insertions(+), 47 deletions(-) -- Regards, Laurent Pinchart
next prev parent reply other threads:[~2018-08-06 11:45 UTC|newest] Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-08-04 16:15 [PATCH v3 00/10] Add helper for plane reset Alexandru Gheorghe 2018-08-04 16:15 ` Alexandru Gheorghe 2018-08-04 16:15 ` [PATCH v3 01/10] drm/atomic: Add __drm_atomic_helper_plane_reset Alexandru Gheorghe 2018-08-04 16:15 ` Alexandru Gheorghe 2018-08-06 6:29 ` Philipp Zabel 2018-08-06 6:29 ` Philipp Zabel 2018-08-04 16:15 ` [PATCH v3 02/10] drm/amd/display: Use __drm_atomic_helper_plane_reset instead of copying the logic Alexandru Gheorghe 2018-08-04 16:15 ` Alexandru Gheorghe 2018-08-04 16:15 ` [PATCH v3 03/10] drm: mali-dp: " Alexandru Gheorghe 2018-08-04 16:15 ` Alexandru Gheorghe 2018-08-04 16:15 ` [PATCH v3 04/10] drm: atmel-hlcdc: " Alexandru Gheorghe 2018-08-04 16:15 ` Alexandru Gheorghe 2018-08-04 16:15 ` [PATCH v3 05/10] drm/exynos: " Alexandru Gheorghe 2018-08-04 16:15 ` Alexandru Gheorghe 2018-08-04 16:15 ` [PATCH v3 06/10] drm/imx: " Alexandru Gheorghe 2018-08-04 16:15 ` Alexandru Gheorghe 2018-08-06 6:29 ` Philipp Zabel 2018-08-06 6:29 ` Philipp Zabel 2018-08-06 8:53 ` Alexandru-Cosmin Gheorghe 2018-08-06 8:53 ` Alexandru-Cosmin Gheorghe 2018-08-04 16:15 ` [PATCH v3 07/10] drm: rcar-du: " Alexandru Gheorghe 2018-08-04 16:15 ` Alexandru Gheorghe 2018-08-04 16:15 ` [PATCH v3 08/10] drm/sun4i: " Alexandru Gheorghe 2018-08-04 16:15 ` Alexandru Gheorghe 2018-08-04 16:15 ` [PATCH v3 09/10] drm/vc4: " Alexandru Gheorghe 2018-08-04 16:15 ` Alexandru Gheorghe 2018-08-06 19:58 ` Eric Anholt 2018-08-06 19:58 ` Eric Anholt 2018-08-08 18:16 ` Alexandru-Cosmin Gheorghe 2018-08-04 16:15 ` [PATCH v3 10/10] drm/vmwgfx: " Alexandru Gheorghe 2018-08-04 16:15 ` Alexandru Gheorghe 2018-08-06 16:57 ` Sinclair Yeh 2018-08-06 16:57 ` Sinclair Yeh 2018-08-07 8:03 ` Alexandru-Cosmin Gheorghe 2018-08-07 8:03 ` Alexandru-Cosmin Gheorghe 2018-08-07 13:25 ` Sinclair Yeh 2018-08-07 13:25 ` Sinclair Yeh 2018-08-06 11:07 ` [PATCH v3 00/10] Add helper for plane reset Alexandru-Cosmin Gheorghe 2018-08-06 11:07 ` Alexandru-Cosmin Gheorghe 2018-08-06 11:45 ` Laurent Pinchart [this message] 2018-08-06 11:45 ` Laurent Pinchart 2018-08-06 12:20 ` Alexandru-Cosmin Gheorghe 2018-08-06 12:20 ` Alexandru-Cosmin Gheorghe 2018-08-06 12:28 ` Laurent Pinchart 2018-08-06 12:28 ` Laurent Pinchart 2018-08-06 15:48 ` Daniel Vetter 2018-08-06 15:48 ` Daniel Vetter
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=15977863.ZBGtPEODRU@avalon \ --to=laurent.pinchart@ideasonboard.com \ --cc=Alexandru-Cosmin.Gheorghe@arm.com \ --cc=Tony.Cheng@amd.com \ --cc=airlied@linux.ie \ --cc=alexander.deucher@amd.com \ --cc=alexandre.belloni@bootlin.com \ --cc=boris.brezillon@bootlin.com \ --cc=christian.koenig@amd.com \ --cc=dri-devel@lists.freedesktop.org \ --cc=kgene@kernel.org \ --cc=krzk@kernel.org \ --cc=kyungmin.park@samsung.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-graphics-maintainer@vmware.com \ --cc=linux-samsung-soc@vger.kernel.org \ --cc=liviu.dudau@arm.com \ --cc=malidp@foss.arm.com \ --cc=maxime.ripard@bootlin.com \ --cc=nd@arm.com \ --cc=nicolas.ferre@microchip.com \ --cc=shirish.s@amd.com \ --cc=sunpeng.li@amd.com \ --cc=sw0312.kim@samsung.com \ --cc=thellstrom@vmware.com \ --cc=wens@csie.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.