From: frowand.list@gmail.com
To: Rob Herring <robh+dt@kernel.org>,
Pantelis Antoniou <pantelis.antoniou@konsulko.com>,
Michael Ellerman <mpe@ellerman.id.au>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Paul Mackerras <paulus@samba.org>, Alan Tull <atull@kernel.org>,
Moritz Fischer <mdf@kernel.org>
Cc: linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
devicetree@vger.kernel.org, linux-fpga@vger.kernel.org
Subject: [PATCH v5 14/18] of: unittest: remove unused of_unittest_apply_overlay() argument
Date: Thu, 18 Oct 2018 15:46:32 -0700 [thread overview]
Message-ID: <1539902796-8382-15-git-send-email-frowand.list@gmail.com> (raw)
In-Reply-To: <1539902796-8382-1-git-send-email-frowand.list@gmail.com>
From: Frank Rowand <frank.rowand@sony.com>
Argument unittest_nr is not used in of_unittest_apply_overlay(),
remove it.
Signed-off-by: Frank Rowand <frank.rowand@sony.com>
---
drivers/of/unittest.c | 7 +++----
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/drivers/of/unittest.c b/drivers/of/unittest.c
index efd9c947f192..6d80f474c8f2 100644
--- a/drivers/of/unittest.c
+++ b/drivers/of/unittest.c
@@ -1419,8 +1419,7 @@ static void of_unittest_destroy_tracked_overlays(void)
} while (defers > 0);
}
-static int __init of_unittest_apply_overlay(int overlay_nr, int unittest_nr,
- int *overlay_id)
+static int __init of_unittest_apply_overlay(int overlay_nr, int *overlay_id)
{
const char *overlay_name;
@@ -1453,7 +1452,7 @@ static int __init of_unittest_apply_overlay_check(int overlay_nr,
}
ovcs_id = 0;
- ret = of_unittest_apply_overlay(overlay_nr, unittest_nr, &ovcs_id);
+ ret = of_unittest_apply_overlay(overlay_nr, &ovcs_id);
if (ret != 0) {
/* of_unittest_apply_overlay already called unittest() */
return ret;
@@ -1489,7 +1488,7 @@ static int __init of_unittest_apply_revert_overlay_check(int overlay_nr,
/* apply the overlay */
ovcs_id = 0;
- ret = of_unittest_apply_overlay(overlay_nr, unittest_nr, &ovcs_id);
+ ret = of_unittest_apply_overlay(overlay_nr, &ovcs_id);
if (ret != 0) {
/* of_unittest_apply_overlay already called unittest() */
return ret;
--
Frank Rowand <frank.rowand@sony.com>
WARNING: multiple messages have this Message-ID (diff)
From: frowand.list@gmail.com
To: Rob Herring <robh+dt@kernel.org>,
Pantelis Antoniou <pantelis.antoniou@konsulko.com>,
Michael Ellerman <mpe@ellerman.id.au>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Paul Mackerras <paulus@samba.org>, Alan Tull <atull@kernel.org>,
Moritz Fischer <mdf@kernel.org>
Cc: devicetree@vger.kernel.org, linux-fpga@vger.kernel.org,
linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org
Subject: [PATCH v5 14/18] of: unittest: remove unused of_unittest_apply_overlay() argument
Date: Thu, 18 Oct 2018 15:46:32 -0700 [thread overview]
Message-ID: <1539902796-8382-15-git-send-email-frowand.list@gmail.com> (raw)
In-Reply-To: <1539902796-8382-1-git-send-email-frowand.list@gmail.com>
From: Frank Rowand <frank.rowand@sony.com>
Argument unittest_nr is not used in of_unittest_apply_overlay(),
remove it.
Signed-off-by: Frank Rowand <frank.rowand@sony.com>
---
drivers/of/unittest.c | 7 +++----
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/drivers/of/unittest.c b/drivers/of/unittest.c
index efd9c947f192..6d80f474c8f2 100644
--- a/drivers/of/unittest.c
+++ b/drivers/of/unittest.c
@@ -1419,8 +1419,7 @@ static void of_unittest_destroy_tracked_overlays(void)
} while (defers > 0);
}
-static int __init of_unittest_apply_overlay(int overlay_nr, int unittest_nr,
- int *overlay_id)
+static int __init of_unittest_apply_overlay(int overlay_nr, int *overlay_id)
{
const char *overlay_name;
@@ -1453,7 +1452,7 @@ static int __init of_unittest_apply_overlay_check(int overlay_nr,
}
ovcs_id = 0;
- ret = of_unittest_apply_overlay(overlay_nr, unittest_nr, &ovcs_id);
+ ret = of_unittest_apply_overlay(overlay_nr, &ovcs_id);
if (ret != 0) {
/* of_unittest_apply_overlay already called unittest() */
return ret;
@@ -1489,7 +1488,7 @@ static int __init of_unittest_apply_revert_overlay_check(int overlay_nr,
/* apply the overlay */
ovcs_id = 0;
- ret = of_unittest_apply_overlay(overlay_nr, unittest_nr, &ovcs_id);
+ ret = of_unittest_apply_overlay(overlay_nr, &ovcs_id);
if (ret != 0) {
/* of_unittest_apply_overlay already called unittest() */
return ret;
--
Frank Rowand <frank.rowand@sony.com>
next prev parent reply other threads:[~2018-10-18 22:48 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-18 22:46 [PATCH v5 00/18] of: overlay: validation checks, subsequent fixes frowand.list
2018-10-18 22:46 ` frowand.list
2018-10-18 22:46 ` [PATCH v5 01/18] of: overlay: add tests to validate kfrees from overlay removal frowand.list
2018-10-18 22:46 ` frowand.list
2018-10-18 22:46 ` [PATCH v5 02/18] of: overlay: add missing of_node_put() after add new node to changeset frowand.list
2018-10-18 22:46 ` frowand.list
2018-10-18 22:46 ` [PATCH v5 03/18] of: overlay: add missing of_node_get() in __of_attach_node_sysfs frowand.list
2018-10-18 22:46 ` frowand.list
2018-10-18 22:46 ` [PATCH v5 04/18] powerpc/pseries: add of_node_put() in dlpar_detach_node() frowand.list
2018-10-18 22:46 ` frowand.list
2018-10-18 22:46 ` [PATCH v5 05/18] of: overlay: use prop add changeset entry for property in new nodes frowand.list
2018-10-18 22:46 ` frowand.list
2018-10-18 22:46 ` [PATCH v5 06/18] of: overlay: do not duplicate properties from overlay for " frowand.list
2018-10-18 22:46 ` frowand.list
2018-10-18 22:46 ` [PATCH v5 07/18] of: dynamic: change type of of_{at,de}tach_node() to void frowand.list
2018-10-18 22:46 ` [PATCH v5 07/18] of: dynamic: change type of of_{at, de}tach_node() " frowand.list
2018-10-18 22:46 ` [PATCH v5 08/18] of: overlay: reorder fields in struct fragment frowand.list
2018-10-18 22:46 ` frowand.list
2018-10-18 22:46 ` [PATCH v5 09/18] of: overlay: validate overlay properties #address-cells and #size-cells frowand.list
2018-10-18 22:46 ` frowand.list
2018-10-18 22:46 ` [PATCH v5 10/18] of: overlay: make all pr_debug() and pr_err() messages unique frowand.list
2018-10-18 22:46 ` frowand.list
2018-10-18 22:46 ` [PATCH v5 11/18] of: overlay: test case of two fragments adding same node frowand.list
2018-10-18 22:46 ` frowand.list
2018-10-18 22:46 ` [PATCH v5 12/18] of: overlay: check prevents multiple fragments add or delete " frowand.list
2018-10-18 22:46 ` frowand.list
2018-10-18 22:46 ` [PATCH v5 13/18] of: overlay: check prevents multiple fragments touching same property frowand.list
2018-10-18 22:46 ` frowand.list
2018-10-18 22:46 ` frowand.list [this message]
2018-10-18 22:46 ` [PATCH v5 14/18] of: unittest: remove unused of_unittest_apply_overlay() argument frowand.list
2018-10-18 22:46 ` [PATCH v5 15/18] of: overlay: set node fields from properties when add new overlay node frowand.list
2018-10-18 22:46 ` frowand.list
2018-10-18 22:46 ` [PATCH v5 16/18] of: unittest: allow base devicetree to have symbol metadata frowand.list
2018-10-18 22:46 ` frowand.list
2018-10-18 22:46 ` [PATCH v5 17/18] of: unittest: find overlays[] entry by name instead of index frowand.list
2018-10-18 22:46 ` frowand.list
2018-10-18 22:46 ` [PATCH v5 18/18] of: unittest: initialize args before calling of_*parse_*() frowand.list
2018-10-18 22:46 ` frowand.list
2018-10-19 5:00 ` [PATCH v5 00/18] of: overlay: validation checks, subsequent fixes Frank Rowand
2018-10-19 5:00 ` Frank Rowand
2018-10-22 21:24 ` Alan Tull
2018-10-22 21:24 ` Alan Tull
2018-10-22 21:24 ` Alan Tull
2018-10-24 19:57 ` Rob Herring
2018-10-24 19:57 ` Rob Herring
2018-10-25 15:25 ` Alan Tull
2018-10-25 15:25 ` Alan Tull
2018-10-25 15:25 ` Alan Tull
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1539902796-8382-15-git-send-email-frowand.list@gmail.com \
--to=frowand.list@gmail.com \
--cc=atull@kernel.org \
--cc=benh@kernel.crashing.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-fpga@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mdf@kernel.org \
--cc=mpe@ellerman.id.au \
--cc=pantelis.antoniou@konsulko.com \
--cc=paulus@samba.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.