From: Weiyi Lu <weiyi.lu@mediatek.com>
To: Stephen Boyd <sboyd@kernel.org>
Cc: Nicolas Boichat <drinkcat@chromium.org>,
Matthias Brugger <matthias.bgg@gmail.com>, <sboyd@codeaurora.org>,
Rob Herring <robh@kernel.org>, <jamesjj.liao@mediatek.com>,
<fan.chen@mediatek.com>,
linux-arm Mailing List <linux-arm-kernel@lists.infradead.org>,
lkml <linux-kernel@vger.kernel.org>,
<linux-mediatek@lists.infradead.org>, <linux-clk@vger.kernel.org>,
<srv_heupstream@mediatek.com>, <owen.chen@mediatek.com>,
<mars.cheng@mediatek.com>
Subject: Re: [PATCH v1 04/11] soc: mediatek: add new flow for mtcmos power.
Date: Wed, 21 Nov 2018 17:21:04 +0800 [thread overview]
Message-ID: <1542792064.20593.2.camel@mtksdaap41> (raw)
In-Reply-To: <154278766192.88331.16232130563413450456@swboyd.mtv.corp.google.com>
On Wed, 2018-11-21 at 00:07 -0800, Stephen Boyd wrote:
> Quoting Weiyi Lu (2018-11-19 18:37:34)
> > On Tue, 2018-11-13 at 11:31 -0800, Nicolas Boichat wrote:
> > > On Mon, Nov 5, 2018 at 10:42 PM Weiyi Lu <weiyi.lu@mediatek.com> wrote:
>
> > > > @@ -226,6 +397,7 @@ static int scpsys_power_on(struct generic_pm_domain *genpd)
> > > > if (ret < 0)
> > > > goto err_pwr_ack;
> > > >
> > > > +
> > >
> > > Drop this.
> > Why do we try to drop this? Once the power-on step fail, the following
> > steps should not be permitted.
>
> I just see a whitespace addition that doesn't do anything. I suspect
> it's a style nitpick and common practice to not include spurious diffs
> in the patch. So remove this hunk?
>
Oops! I missed the extra whitespace. I will remove it. Many thanks.
WARNING: multiple messages have this Message-ID (diff)
From: Weiyi Lu <weiyi.lu@mediatek.com>
To: Stephen Boyd <sboyd@kernel.org>
Cc: Nicolas Boichat <drinkcat@chromium.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
sboyd@codeaurora.org, Rob Herring <robh@kernel.org>,
jamesjj.liao@mediatek.com, fan.chen@mediatek.com,
linux-arm Mailing List <linux-arm-kernel@lists.infradead.org>,
lkml <linux-kernel@vger.kernel.org>,
linux-mediatek@lists.infradead.org, linux-clk@vger.kernel.org,
srv_heupstream@mediatek.com, owen.chen@mediatek.com,
mars.cheng@mediatek.com
Subject: Re: [PATCH v1 04/11] soc: mediatek: add new flow for mtcmos power.
Date: Wed, 21 Nov 2018 17:21:04 +0800 [thread overview]
Message-ID: <1542792064.20593.2.camel@mtksdaap41> (raw)
In-Reply-To: <154278766192.88331.16232130563413450456@swboyd.mtv.corp.google.com>
On Wed, 2018-11-21 at 00:07 -0800, Stephen Boyd wrote:
> Quoting Weiyi Lu (2018-11-19 18:37:34)
> > On Tue, 2018-11-13 at 11:31 -0800, Nicolas Boichat wrote:
> > > On Mon, Nov 5, 2018 at 10:42 PM Weiyi Lu <weiyi.lu@mediatek.com> wrote:
>
> > > > @@ -226,6 +397,7 @@ static int scpsys_power_on(struct generic_pm_domain *genpd)
> > > > if (ret < 0)
> > > > goto err_pwr_ack;
> > > >
> > > > +
> > >
> > > Drop this.
> > Why do we try to drop this? Once the power-on step fail, the following
> > steps should not be permitted.
>
> I just see a whitespace addition that doesn't do anything. I suspect
> it's a style nitpick and common practice to not include spurious diffs
> in the patch. So remove this hunk?
>
Oops! I missed the extra whitespace. I will remove it. Many thanks.
WARNING: multiple messages have this Message-ID (diff)
From: weiyi.lu@mediatek.com (Weiyi Lu)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v1 04/11] soc: mediatek: add new flow for mtcmos power.
Date: Wed, 21 Nov 2018 17:21:04 +0800 [thread overview]
Message-ID: <1542792064.20593.2.camel@mtksdaap41> (raw)
In-Reply-To: <154278766192.88331.16232130563413450456@swboyd.mtv.corp.google.com>
On Wed, 2018-11-21 at 00:07 -0800, Stephen Boyd wrote:
> Quoting Weiyi Lu (2018-11-19 18:37:34)
> > On Tue, 2018-11-13 at 11:31 -0800, Nicolas Boichat wrote:
> > > On Mon, Nov 5, 2018 at 10:42 PM Weiyi Lu <weiyi.lu@mediatek.com> wrote:
>
> > > > @@ -226,6 +397,7 @@ static int scpsys_power_on(struct generic_pm_domain *genpd)
> > > > if (ret < 0)
> > > > goto err_pwr_ack;
> > > >
> > > > +
> > >
> > > Drop this.
> > Why do we try to drop this? Once the power-on step fail, the following
> > steps should not be permitted.
>
> I just see a whitespace addition that doesn't do anything. I suspect
> it's a style nitpick and common practice to not include spurious diffs
> in the patch. So remove this hunk?
>
Oops! I missed the extra whitespace. I will remove it. Many thanks.
next prev parent reply other threads:[~2018-11-21 9:21 UTC|newest]
Thread overview: 71+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-06 6:41 [PATCH v1 00/11] Mediatek MT8183 clock and scpsys support Weiyi Lu
2018-11-06 6:41 ` Weiyi Lu
2018-11-06 6:41 ` Weiyi Lu
2018-11-06 6:41 ` Weiyi Lu
2018-11-06 6:41 ` Weiyi Lu
2018-11-06 6:41 ` Weiyi Lu
2018-11-06 6:41 ` [PATCH v1 01/11] clk: mediatek: add new clkmux register API Weiyi Lu
2018-11-06 6:41 ` Weiyi Lu
2018-11-06 6:41 ` Weiyi Lu
2018-11-13 16:00 ` Nicolas Boichat
2018-11-13 16:00 ` Nicolas Boichat
2018-11-20 6:34 ` Weiyi Lu
2018-11-20 6:34 ` Weiyi Lu
2018-11-20 6:34 ` Weiyi Lu
2018-11-06 6:41 ` [PATCH v1 02/11] clk: mediatek: add new member to mtk_pll_data Weiyi Lu
2018-11-06 6:41 ` Weiyi Lu
2018-11-06 6:41 ` Weiyi Lu
2018-11-13 16:18 ` Nicolas Boichat
2018-11-13 16:18 ` Nicolas Boichat
2018-11-20 3:51 ` Weiyi Lu
2018-11-20 3:51 ` Weiyi Lu
2018-11-20 3:51 ` Weiyi Lu
2018-11-21 8:03 ` Stephen Boyd
2018-11-21 8:03 ` Stephen Boyd
2018-11-06 6:41 ` [PATCH v1 03/11] clk: mediatek: Disable tuner_en before change PLL rate Weiyi Lu
2018-11-06 6:41 ` Weiyi Lu
2018-11-06 6:41 ` Weiyi Lu
2018-11-06 6:41 ` [PATCH v1 04/11] soc: mediatek: add new flow for mtcmos power Weiyi Lu
2018-11-06 6:41 ` Weiyi Lu
2018-11-06 6:41 ` Weiyi Lu
2018-11-13 19:31 ` Nicolas Boichat
2018-11-13 19:31 ` Nicolas Boichat
2018-11-20 2:37 ` Weiyi Lu
2018-11-20 2:37 ` Weiyi Lu
2018-11-20 2:37 ` Weiyi Lu
2018-11-21 8:07 ` Stephen Boyd
2018-11-21 8:07 ` Stephen Boyd
2018-11-21 9:21 ` Weiyi Lu [this message]
2018-11-21 9:21 ` Weiyi Lu
2018-11-21 9:21 ` Weiyi Lu
2018-11-06 6:42 ` [PATCH v1 05/11] dt-bindings: ARM: Mediatek: Document bindings for MT8183 Weiyi Lu
2018-11-06 6:42 ` Weiyi Lu
2018-11-06 6:42 ` Weiyi Lu
2018-11-06 6:42 ` [PATCH v1 06/11] clk: mediatek: Add dt-bindings for MT8183 clocks Weiyi Lu
2018-11-06 6:42 ` Weiyi Lu
2018-11-06 6:42 ` Weiyi Lu
2018-11-06 6:42 ` [PATCH v1 07/11] clk: mediatek: Add flags support for mtk_gate data Weiyi Lu
2018-11-06 6:42 ` Weiyi Lu
2018-11-06 6:42 ` Weiyi Lu
2018-11-06 6:42 ` [PATCH v1 08/11] clk: mediatek: Add MT8183 clock support Weiyi Lu
2018-11-06 6:42 ` Weiyi Lu
2018-11-06 6:42 ` Weiyi Lu
2018-11-14 6:25 ` Nicolas Boichat
2018-11-14 6:25 ` Nicolas Boichat
2018-11-19 4:14 ` Weiyi Lu
2018-11-19 4:14 ` Weiyi Lu
2018-11-19 4:14 ` Weiyi Lu
2018-11-06 6:42 ` [PATCH v1 09/11] dt-bindings: soc: fix typo of MT8173 power dt-bindings Weiyi Lu
2018-11-06 6:42 ` Weiyi Lu
2018-11-06 6:42 ` Weiyi Lu
2018-11-06 6:42 ` [PATCH v1 10/11] dt-bindings: soc: Add MT8183 " Weiyi Lu
2018-11-06 6:42 ` Weiyi Lu
2018-11-06 6:42 ` Weiyi Lu
2018-11-06 6:42 ` [PATCH v1 11/11] soc: mediatek: Add MT8183 scpsys support Weiyi Lu
2018-11-06 6:42 ` Weiyi Lu
2018-11-06 6:42 ` Weiyi Lu
2018-11-13 19:35 ` Nicolas Boichat
2018-11-13 19:35 ` Nicolas Boichat
2018-11-19 3:59 ` Weiyi Lu
2018-11-19 3:59 ` Weiyi Lu
2018-11-19 3:59 ` Weiyi Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1542792064.20593.2.camel@mtksdaap41 \
--to=weiyi.lu@mediatek.com \
--cc=drinkcat@chromium.org \
--cc=fan.chen@mediatek.com \
--cc=jamesjj.liao@mediatek.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=mars.cheng@mediatek.com \
--cc=matthias.bgg@gmail.com \
--cc=owen.chen@mediatek.com \
--cc=robh@kernel.org \
--cc=sboyd@codeaurora.org \
--cc=sboyd@kernel.org \
--cc=srv_heupstream@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.