From: Lucas Stach <l.stach@pengutronix.de> To: Aisheng Dong <aisheng.dong@nxp.com>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org> Cc: "linux-arm-kernel@lists.infradead.org" <linux-arm-kernel@lists.infradead.org>, "shawnguo@kernel.org" <shawnguo@kernel.org>, dl-linux-imx <linux-imx@nxp.com>, "robh+dt@kernel.org" <robh+dt@kernel.org>, "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>, "tglx@linutronix.de" <tglx@linutronix.de>, Marc Zyngier <marc.zyngier@arm.com> Subject: Re: [PATCH 1/4] dt-binding: irq: imx-irqsteer: use irq number per channel instead of group number Date: Fri, 18 Jan 2019 09:48:11 +0100 [thread overview] Message-ID: <1547801291.2626.3.camel@pengutronix.de> (raw) In-Reply-To: <1547797668-30342-2-git-send-email-aisheng.dong@nxp.com> Am Freitag, den 18.01.2019, 07:53 +0000 schrieb Aisheng Dong: > Not all 64 interrupts may be used in one group. e.g. most irqsteer in > imx8qxp and imx8qm subsystems supports only 32 interrupts. > > As the IP integration parameters are Channel number and interrupts number, > let's use fsl,irqs-per-chan to represents how many interrupts supported > by this irqsteer channel. Sorry, but total NACK. I've got to great lengths with dumping the actually implemented register layout on i.MX8M and AFAICS the IRQs are always managed in groups of 64 IRQs, even if less than that are connected as input IRQs. This is what the actually present register set on i.MX8M tells us. Regards, Lucas > Cc: Marc Zyngier <marc.zyngier@arm.com> > > Cc: Rob Herring <robh+dt@kernel.org> > > Cc: Lucas Stach <l.stach@pengutronix.de> > > Cc: Shawn Guo <shawnguo@kernel.org> > Cc: devicetree@vger.kernel.org > > Signed-off-by: Dong Aisheng <aisheng.dong@nxp.com> > --- > .../devicetree/bindings/interrupt-controller/fsl,irqsteer.txt | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/Documentation/devicetree/bindings/interrupt-controller/fsl,irqsteer.txt b/Documentation/devicetree/bindings/interrupt-controller/fsl,irqsteer.txt > index 45790ce..eaabcda 100644 > --- a/Documentation/devicetree/bindings/interrupt-controller/fsl,irqsteer.txt > +++ b/Documentation/devicetree/bindings/interrupt-controller/fsl,irqsteer.txt > @@ -16,8 +16,8 @@ Required properties: > - #interrupt-cells: Specifies the number of cells needed to encode an > interrupt source. The value must be 1. > - fsl,channel: The output channel that all input IRQs should be steered into. > -- fsl,irq-groups: Number of IRQ groups managed by this controller instance. > - Each group manages 64 input interrupts. > +- fsl,irqs-per-chan: Number of input interrupts per channel. Should be multiple of 32 > + input interrupts and up to 512 interrupts. > > Example: > > @@ -28,7 +28,7 @@ Example: > > clocks = <&clk IMX8MQ_CLK_DISP_APB_ROOT>; > > clock-names = "ipg"; > > fsl,channel = <0>; > > - fsl,irq-groups = <1>; > > + fsl,irqs-per-chan= <64>; > > interrupt-controller; > > #interrupt-cells = <1>; > > };
WARNING: multiple messages have this Message-ID (diff)
From: Lucas Stach <l.stach@pengutronix.de> To: Aisheng Dong <aisheng.dong@nxp.com>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org> Cc: "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>, Marc Zyngier <marc.zyngier@arm.com>, "robh+dt@kernel.org" <robh+dt@kernel.org>, dl-linux-imx <linux-imx@nxp.com>, "tglx@linutronix.de" <tglx@linutronix.de>, "shawnguo@kernel.org" <shawnguo@kernel.org>, "linux-arm-kernel@lists.infradead.org" <linux-arm-kernel@lists.infradead.org> Subject: Re: [PATCH 1/4] dt-binding: irq: imx-irqsteer: use irq number per channel instead of group number Date: Fri, 18 Jan 2019 09:48:11 +0100 [thread overview] Message-ID: <1547801291.2626.3.camel@pengutronix.de> (raw) In-Reply-To: <1547797668-30342-2-git-send-email-aisheng.dong@nxp.com> Am Freitag, den 18.01.2019, 07:53 +0000 schrieb Aisheng Dong: > Not all 64 interrupts may be used in one group. e.g. most irqsteer in > imx8qxp and imx8qm subsystems supports only 32 interrupts. > > As the IP integration parameters are Channel number and interrupts number, > let's use fsl,irqs-per-chan to represents how many interrupts supported > by this irqsteer channel. Sorry, but total NACK. I've got to great lengths with dumping the actually implemented register layout on i.MX8M and AFAICS the IRQs are always managed in groups of 64 IRQs, even if less than that are connected as input IRQs. This is what the actually present register set on i.MX8M tells us. Regards, Lucas > Cc: Marc Zyngier <marc.zyngier@arm.com> > > Cc: Rob Herring <robh+dt@kernel.org> > > Cc: Lucas Stach <l.stach@pengutronix.de> > > Cc: Shawn Guo <shawnguo@kernel.org> > Cc: devicetree@vger.kernel.org > > Signed-off-by: Dong Aisheng <aisheng.dong@nxp.com> > --- > .../devicetree/bindings/interrupt-controller/fsl,irqsteer.txt | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/Documentation/devicetree/bindings/interrupt-controller/fsl,irqsteer.txt b/Documentation/devicetree/bindings/interrupt-controller/fsl,irqsteer.txt > index 45790ce..eaabcda 100644 > --- a/Documentation/devicetree/bindings/interrupt-controller/fsl,irqsteer.txt > +++ b/Documentation/devicetree/bindings/interrupt-controller/fsl,irqsteer.txt > @@ -16,8 +16,8 @@ Required properties: > - #interrupt-cells: Specifies the number of cells needed to encode an > interrupt source. The value must be 1. > - fsl,channel: The output channel that all input IRQs should be steered into. > -- fsl,irq-groups: Number of IRQ groups managed by this controller instance. > - Each group manages 64 input interrupts. > +- fsl,irqs-per-chan: Number of input interrupts per channel. Should be multiple of 32 > + input interrupts and up to 512 interrupts. > > Example: > > @@ -28,7 +28,7 @@ Example: > > clocks = <&clk IMX8MQ_CLK_DISP_APB_ROOT>; > > clock-names = "ipg"; > > fsl,channel = <0>; > > - fsl,irq-groups = <1>; > > + fsl,irqs-per-chan= <64>; > > interrupt-controller; > > #interrupt-cells = <1>; > > }; _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-01-18 8:48 UTC|newest] Thread overview: 84+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-01-18 7:53 [PATCH 0/4] irq: imx-irqsteer: add 32 interrupts chan and multi outputs support Aisheng Dong 2019-01-18 7:53 ` Aisheng Dong 2019-01-18 7:53 ` Aisheng Dong 2019-01-18 7:53 ` [PATCH 1/4] dt-binding: irq: imx-irqsteer: use irq number per channel instead of group number Aisheng Dong 2019-01-18 7:53 ` Aisheng Dong 2019-01-18 7:53 ` Aisheng Dong 2019-01-18 8:48 ` Lucas Stach [this message] 2019-01-18 8:48 ` Lucas Stach 2019-01-18 8:48 ` Lucas Stach 2019-01-18 9:39 ` Marc Zyngier 2019-01-18 9:39 ` Marc Zyngier 2019-01-18 9:39 ` Marc Zyngier 2019-01-18 9:46 ` Aisheng Dong 2019-01-18 9:46 ` Aisheng Dong 2019-01-18 9:46 ` Aisheng Dong 2019-01-18 10:12 ` Marc Zyngier 2019-01-18 10:12 ` Marc Zyngier 2019-01-18 10:12 ` Marc Zyngier 2019-01-22 10:56 ` Aisheng Dong 2019-01-22 10:56 ` Aisheng Dong 2019-01-22 10:56 ` Aisheng Dong 2019-01-22 11:05 ` Lucas Stach 2019-01-22 11:05 ` Lucas Stach 2019-01-22 11:05 ` Lucas Stach 2019-01-22 11:48 ` Marc Zyngier 2019-01-22 11:48 ` Marc Zyngier 2019-01-22 11:48 ` Marc Zyngier 2019-01-18 9:45 ` Aisheng Dong 2019-01-18 9:45 ` Aisheng Dong 2019-01-18 9:45 ` Aisheng Dong 2019-01-18 7:53 ` [PATCH 2/4] dt-bindings: irq: imx-irqsteer: add multi output interrupts support Aisheng Dong 2019-01-18 7:53 ` Aisheng Dong 2019-01-18 7:53 ` Aisheng Dong 2019-01-25 10:46 ` Lucas Stach 2019-01-25 10:46 ` Lucas Stach 2019-01-25 10:46 ` Lucas Stach 2019-01-27 14:05 ` Dong Aisheng 2019-01-27 14:05 ` Dong Aisheng 2019-01-27 14:05 ` Dong Aisheng 2019-01-18 7:53 ` [PATCH 3/4] irq: imx-irqsteer: change to use reg_num instead of irq_group Aisheng Dong 2019-01-18 7:53 ` Aisheng Dong 2019-01-18 7:53 ` Aisheng Dong 2019-01-18 7:53 ` [PATCH 4/4] irq: imx: irqsteer: add multi output interrupts support Aisheng Dong 2019-01-18 7:53 ` Aisheng Dong 2019-01-18 7:53 ` Aisheng Dong 2019-01-18 8:53 ` Lucas Stach 2019-01-18 8:53 ` Lucas Stach 2019-01-18 8:53 ` Lucas Stach 2019-01-18 9:54 ` Aisheng Dong 2019-01-18 9:54 ` Aisheng Dong 2019-01-18 9:54 ` Aisheng Dong 2019-01-18 10:22 ` Lucas Stach 2019-01-18 10:22 ` Lucas Stach 2019-01-18 10:22 ` Lucas Stach 2019-01-22 10:39 ` Aisheng Dong 2019-01-22 10:39 ` Aisheng Dong 2019-01-22 10:39 ` Aisheng Dong 2019-01-22 10:59 ` Lucas Stach 2019-01-22 10:59 ` Lucas Stach 2019-01-22 10:59 ` Lucas Stach 2019-01-22 12:03 ` Aisheng Dong 2019-01-22 12:03 ` Aisheng Dong 2019-01-22 12:03 ` Aisheng Dong 2019-01-22 12:52 ` Lucas Stach 2019-01-22 12:52 ` Lucas Stach 2019-01-22 12:52 ` Lucas Stach 2019-01-22 13:17 ` Aisheng Dong 2019-01-22 13:17 ` Aisheng Dong 2019-01-22 13:17 ` Aisheng Dong 2019-01-25 10:42 ` Lucas Stach 2019-01-25 10:42 ` Lucas Stach 2019-01-25 10:42 ` Lucas Stach 2019-01-27 10:38 ` Dong Aisheng 2019-01-27 10:38 ` Dong Aisheng 2019-01-27 10:38 ` Dong Aisheng 2019-01-22 12:50 ` Aisheng Dong 2019-01-22 12:50 ` Aisheng Dong 2019-01-22 12:50 ` Aisheng Dong 2019-01-25 10:54 ` Lucas Stach 2019-01-25 10:54 ` Lucas Stach 2019-01-25 10:54 ` Lucas Stach 2019-01-27 14:02 ` Dong Aisheng 2019-01-27 14:02 ` Dong Aisheng 2019-01-27 14:02 ` Dong Aisheng
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1547801291.2626.3.camel@pengutronix.de \ --to=l.stach@pengutronix.de \ --cc=aisheng.dong@nxp.com \ --cc=devicetree@vger.kernel.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-imx@nxp.com \ --cc=linux-kernel@vger.kernel.org \ --cc=marc.zyngier@arm.com \ --cc=robh+dt@kernel.org \ --cc=shawnguo@kernel.org \ --cc=tglx@linutronix.de \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.