From: Aisheng Dong <aisheng.dong@nxp.com> To: Marc Zyngier <marc.zyngier@arm.com>, Lucas Stach <l.stach@pengutronix.de>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org> Cc: "linux-arm-kernel@lists.infradead.org" <linux-arm-kernel@lists.infradead.org>, "shawnguo@kernel.org" <shawnguo@kernel.org>, dl-linux-imx <linux-imx@nxp.com>, "robh+dt@kernel.org" <robh+dt@kernel.org>, "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>, "tglx@linutronix.de" <tglx@linutronix.de> Subject: RE: [PATCH 1/4] dt-binding: irq: imx-irqsteer: use irq number per channel instead of group number Date: Tue, 22 Jan 2019 10:56:42 +0000 [thread overview] Message-ID: <AM0PR04MB421189505D3F196A82DEF19A80980@AM0PR04MB4211.eurprd04.prod.outlook.com> (raw) In-Reply-To: <ef6eb38d-8e74-a55d-6d78-516d81fa957f@arm.com> > From: Marc Zyngier [mailto:marc.zyngier@arm.com] > Sent: Friday, January 18, 2019 6:12 PM [...] > >> From: Marc Zyngier [mailto:marc.zyngier@arm.com] > >> Sent: Friday, January 18, 2019 5:39 PM On 18/01/2019 08:48, Lucas > >> Stach wrote: > >>> Am Freitag, den 18.01.2019, 07:53 +0000 schrieb Aisheng Dong: > >>>> Not all 64 interrupts may be used in one group. e.g. most irqsteer > >>>> in imx8qxp and imx8qm subsystems supports only 32 interrupts. > >>>> > >>>> As the IP integration parameters are Channel number and interrupts > >>>> number, let's use fsl,irqs-per-chan to represents how many > >>>> interrupts supported by this irqsteer channel. > >>> > >>> Sorry, but total NACK. I've got to great lengths with dumping the > >>> actually implemented register layout on i.MX8M and AFAICS the IRQs > >>> are always managed in groups of 64 IRQs, even if less than that are > >>> connected as input IRQs. This is what the actually present register > >>> set on i.MX8M tells us. > >> > >> Also, I'd really like the DT bindings not to change at every release. > >> So whatever change (if any) has to be done for this driver to support > >> existing HW, please make sure that the DT bindings are kept as stable as > possible. > >> > > > > Sorry I should clarify it a bit. > > There's still no users in Devicetree. > > So I guess we can update it, right? Or not? > > What do you mean by no users? This driver is in 5.0, and I assume people are > using it one way or another. Not having a platform in the kernel tree is pretty > much irrelevant, as the kernel tree is not a canonical repository of existing > platforms. > I understand the concern. Theoretically yes, but it's very unlikely that there's already an out of tree users wants to use it for a long term as we're still at the very initial stage. And the most important reason is that current using actually is wrong. We can also choose to mark it as 'depreciated' and keep the backward compatibility in driver, but I'm not sure whether it's worthy to do it as we may add a lot ugly code in driver benefits no users. Ideas? Regards Dong Aisheng > Thanks, > > M. > -- > Jazz is not dead. It just smells funny...
WARNING: multiple messages have this Message-ID (diff)
From: Aisheng Dong <aisheng.dong@nxp.com> To: Marc Zyngier <marc.zyngier@arm.com>, Lucas Stach <l.stach@pengutronix.de>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org> Cc: "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>, "robh+dt@kernel.org" <robh+dt@kernel.org>, dl-linux-imx <linux-imx@nxp.com>, "tglx@linutronix.de" <tglx@linutronix.de>, "shawnguo@kernel.org" <shawnguo@kernel.org>, "linux-arm-kernel@lists.infradead.org" <linux-arm-kernel@lists.infradead.org> Subject: RE: [PATCH 1/4] dt-binding: irq: imx-irqsteer: use irq number per channel instead of group number Date: Tue, 22 Jan 2019 10:56:42 +0000 [thread overview] Message-ID: <AM0PR04MB421189505D3F196A82DEF19A80980@AM0PR04MB4211.eurprd04.prod.outlook.com> (raw) In-Reply-To: <ef6eb38d-8e74-a55d-6d78-516d81fa957f@arm.com> > From: Marc Zyngier [mailto:marc.zyngier@arm.com] > Sent: Friday, January 18, 2019 6:12 PM [...] > >> From: Marc Zyngier [mailto:marc.zyngier@arm.com] > >> Sent: Friday, January 18, 2019 5:39 PM On 18/01/2019 08:48, Lucas > >> Stach wrote: > >>> Am Freitag, den 18.01.2019, 07:53 +0000 schrieb Aisheng Dong: > >>>> Not all 64 interrupts may be used in one group. e.g. most irqsteer > >>>> in imx8qxp and imx8qm subsystems supports only 32 interrupts. > >>>> > >>>> As the IP integration parameters are Channel number and interrupts > >>>> number, let's use fsl,irqs-per-chan to represents how many > >>>> interrupts supported by this irqsteer channel. > >>> > >>> Sorry, but total NACK. I've got to great lengths with dumping the > >>> actually implemented register layout on i.MX8M and AFAICS the IRQs > >>> are always managed in groups of 64 IRQs, even if less than that are > >>> connected as input IRQs. This is what the actually present register > >>> set on i.MX8M tells us. > >> > >> Also, I'd really like the DT bindings not to change at every release. > >> So whatever change (if any) has to be done for this driver to support > >> existing HW, please make sure that the DT bindings are kept as stable as > possible. > >> > > > > Sorry I should clarify it a bit. > > There's still no users in Devicetree. > > So I guess we can update it, right? Or not? > > What do you mean by no users? This driver is in 5.0, and I assume people are > using it one way or another. Not having a platform in the kernel tree is pretty > much irrelevant, as the kernel tree is not a canonical repository of existing > platforms. > I understand the concern. Theoretically yes, but it's very unlikely that there's already an out of tree users wants to use it for a long term as we're still at the very initial stage. And the most important reason is that current using actually is wrong. We can also choose to mark it as 'depreciated' and keep the backward compatibility in driver, but I'm not sure whether it's worthy to do it as we may add a lot ugly code in driver benefits no users. Ideas? Regards Dong Aisheng > Thanks, > > M. > -- > Jazz is not dead. It just smells funny... _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-01-22 10:56 UTC|newest] Thread overview: 84+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-01-18 7:53 [PATCH 0/4] irq: imx-irqsteer: add 32 interrupts chan and multi outputs support Aisheng Dong 2019-01-18 7:53 ` Aisheng Dong 2019-01-18 7:53 ` Aisheng Dong 2019-01-18 7:53 ` [PATCH 1/4] dt-binding: irq: imx-irqsteer: use irq number per channel instead of group number Aisheng Dong 2019-01-18 7:53 ` Aisheng Dong 2019-01-18 7:53 ` Aisheng Dong 2019-01-18 8:48 ` Lucas Stach 2019-01-18 8:48 ` Lucas Stach 2019-01-18 8:48 ` Lucas Stach 2019-01-18 9:39 ` Marc Zyngier 2019-01-18 9:39 ` Marc Zyngier 2019-01-18 9:39 ` Marc Zyngier 2019-01-18 9:46 ` Aisheng Dong 2019-01-18 9:46 ` Aisheng Dong 2019-01-18 9:46 ` Aisheng Dong 2019-01-18 10:12 ` Marc Zyngier 2019-01-18 10:12 ` Marc Zyngier 2019-01-18 10:12 ` Marc Zyngier 2019-01-22 10:56 ` Aisheng Dong [this message] 2019-01-22 10:56 ` Aisheng Dong 2019-01-22 10:56 ` Aisheng Dong 2019-01-22 11:05 ` Lucas Stach 2019-01-22 11:05 ` Lucas Stach 2019-01-22 11:05 ` Lucas Stach 2019-01-22 11:48 ` Marc Zyngier 2019-01-22 11:48 ` Marc Zyngier 2019-01-22 11:48 ` Marc Zyngier 2019-01-18 9:45 ` Aisheng Dong 2019-01-18 9:45 ` Aisheng Dong 2019-01-18 9:45 ` Aisheng Dong 2019-01-18 7:53 ` [PATCH 2/4] dt-bindings: irq: imx-irqsteer: add multi output interrupts support Aisheng Dong 2019-01-18 7:53 ` Aisheng Dong 2019-01-18 7:53 ` Aisheng Dong 2019-01-25 10:46 ` Lucas Stach 2019-01-25 10:46 ` Lucas Stach 2019-01-25 10:46 ` Lucas Stach 2019-01-27 14:05 ` Dong Aisheng 2019-01-27 14:05 ` Dong Aisheng 2019-01-27 14:05 ` Dong Aisheng 2019-01-18 7:53 ` [PATCH 3/4] irq: imx-irqsteer: change to use reg_num instead of irq_group Aisheng Dong 2019-01-18 7:53 ` Aisheng Dong 2019-01-18 7:53 ` Aisheng Dong 2019-01-18 7:53 ` [PATCH 4/4] irq: imx: irqsteer: add multi output interrupts support Aisheng Dong 2019-01-18 7:53 ` Aisheng Dong 2019-01-18 7:53 ` Aisheng Dong 2019-01-18 8:53 ` Lucas Stach 2019-01-18 8:53 ` Lucas Stach 2019-01-18 8:53 ` Lucas Stach 2019-01-18 9:54 ` Aisheng Dong 2019-01-18 9:54 ` Aisheng Dong 2019-01-18 9:54 ` Aisheng Dong 2019-01-18 10:22 ` Lucas Stach 2019-01-18 10:22 ` Lucas Stach 2019-01-18 10:22 ` Lucas Stach 2019-01-22 10:39 ` Aisheng Dong 2019-01-22 10:39 ` Aisheng Dong 2019-01-22 10:39 ` Aisheng Dong 2019-01-22 10:59 ` Lucas Stach 2019-01-22 10:59 ` Lucas Stach 2019-01-22 10:59 ` Lucas Stach 2019-01-22 12:03 ` Aisheng Dong 2019-01-22 12:03 ` Aisheng Dong 2019-01-22 12:03 ` Aisheng Dong 2019-01-22 12:52 ` Lucas Stach 2019-01-22 12:52 ` Lucas Stach 2019-01-22 12:52 ` Lucas Stach 2019-01-22 13:17 ` Aisheng Dong 2019-01-22 13:17 ` Aisheng Dong 2019-01-22 13:17 ` Aisheng Dong 2019-01-25 10:42 ` Lucas Stach 2019-01-25 10:42 ` Lucas Stach 2019-01-25 10:42 ` Lucas Stach 2019-01-27 10:38 ` Dong Aisheng 2019-01-27 10:38 ` Dong Aisheng 2019-01-27 10:38 ` Dong Aisheng 2019-01-22 12:50 ` Aisheng Dong 2019-01-22 12:50 ` Aisheng Dong 2019-01-22 12:50 ` Aisheng Dong 2019-01-25 10:54 ` Lucas Stach 2019-01-25 10:54 ` Lucas Stach 2019-01-25 10:54 ` Lucas Stach 2019-01-27 14:02 ` Dong Aisheng 2019-01-27 14:02 ` Dong Aisheng 2019-01-27 14:02 ` Dong Aisheng
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=AM0PR04MB421189505D3F196A82DEF19A80980@AM0PR04MB4211.eurprd04.prod.outlook.com \ --to=aisheng.dong@nxp.com \ --cc=devicetree@vger.kernel.org \ --cc=l.stach@pengutronix.de \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-imx@nxp.com \ --cc=linux-kernel@vger.kernel.org \ --cc=marc.zyngier@arm.com \ --cc=robh+dt@kernel.org \ --cc=shawnguo@kernel.org \ --cc=tglx@linutronix.de \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.