All of lore.kernel.org
 help / color / mirror / Atom feed
From: <Eugen.Hristev@microchip.com>
To: <linux-media@vger.kernel.org>, <hverkuil@xs4all.nl>,
	<Nicolas.Ferre@microchip.com>,
	<linux-arm-kernel@lists.infradead.org>,
	<linux-kernel@vger.kernel.org>, <mchehab@kernel.org>
Cc: <ksloat@aampglobal.com>, <Eugen.Hristev@microchip.com>
Subject: [PATCH 0/7] media: atmel: atmel-isc: new features
Date: Tue, 9 Apr 2019 11:07:19 +0000	[thread overview]
Message-ID: <1554807715-2353-1-git-send-email-eugen.hristev@microchip.com> (raw)

From: Eugen Hristev <eugen.hristev@microchip.com>

This series includes feature rework, feature additions and bug fixes for the
atmel-isc driver.
It applies only on top of my previous patchset:
media: atmel: atmel-isc: removed ARGB32 added ABGR32 and XBGR32
media: atmel: atmel-isc: reworked driver and formats
available at:
https://git.linuxtv.org/hverkuil/media_tree.git/commit/?h=for-v5.2b&id=03ef1b56cba6ad17f6ead13c85a81e0e80fbc9d1

One open question is regarding the WHITE_BALANCE error returns: it would seem
logical to return EAGAIN or EBUSY, but this is not compliant with
v4l2-compliance.
Does it make sense to return success on every occasion? even if the
DO_WHITE_BALANCE does nothing?
In this series I used the return EAGAIN or EBUSY from the v4l2-ctrls, but I
can change if always success is a better way of returning (even if normally
a return value serves this exact purpose - return some code )

Eugen Hristev (7):
  media: atmel: atmel-isc: add safe checks and fixed wrong ISC state in
    error case
  media: atmel: atmel-isc: reworked white balance feature
  media: v4l2-ctrl: fix flags for DO_WHITE_BALANCE
  media: atmel: atmel-isc: add support for DO_WHITE_BALANCE
  media: atmel: atmel-isc: limit incoming pixels per frame
  media: atmel: atmel-isc: fix INIT_WORK misplacement
  media: atmel: atmel-isc: fix asd memory allocation

 drivers/media/platform/atmel/atmel-isc-regs.h |  25 +-
 drivers/media/platform/atmel/atmel-isc.c      | 346 +++++++++++++++++++++++---
 drivers/media/v4l2-core/v4l2-ctrls.c          |   1 +
 3 files changed, 336 insertions(+), 36 deletions(-)

-- 
2.7.4


WARNING: multiple messages have this Message-ID (diff)
From: <Eugen.Hristev@microchip.com>
To: <linux-media@vger.kernel.org>, <hverkuil@xs4all.nl>,
	<Nicolas.Ferre@microchip.com>,
	<linux-arm-kernel@lists.infradead.org>,
	<linux-kernel@vger.kernel.org>, <mchehab@kernel.org>
Cc: Eugen.Hristev@microchip.com, ksloat@aampglobal.com
Subject: [PATCH 0/7] media: atmel: atmel-isc: new features
Date: Tue, 9 Apr 2019 11:07:19 +0000	[thread overview]
Message-ID: <1554807715-2353-1-git-send-email-eugen.hristev@microchip.com> (raw)

From: Eugen Hristev <eugen.hristev@microchip.com>

This series includes feature rework, feature additions and bug fixes for the
atmel-isc driver.
It applies only on top of my previous patchset:
media: atmel: atmel-isc: removed ARGB32 added ABGR32 and XBGR32
media: atmel: atmel-isc: reworked driver and formats
available at:
https://git.linuxtv.org/hverkuil/media_tree.git/commit/?h=for-v5.2b&id=03ef1b56cba6ad17f6ead13c85a81e0e80fbc9d1

One open question is regarding the WHITE_BALANCE error returns: it would seem
logical to return EAGAIN or EBUSY, but this is not compliant with
v4l2-compliance.
Does it make sense to return success on every occasion? even if the
DO_WHITE_BALANCE does nothing?
In this series I used the return EAGAIN or EBUSY from the v4l2-ctrls, but I
can change if always success is a better way of returning (even if normally
a return value serves this exact purpose - return some code )

Eugen Hristev (7):
  media: atmel: atmel-isc: add safe checks and fixed wrong ISC state in
    error case
  media: atmel: atmel-isc: reworked white balance feature
  media: v4l2-ctrl: fix flags for DO_WHITE_BALANCE
  media: atmel: atmel-isc: add support for DO_WHITE_BALANCE
  media: atmel: atmel-isc: limit incoming pixels per frame
  media: atmel: atmel-isc: fix INIT_WORK misplacement
  media: atmel: atmel-isc: fix asd memory allocation

 drivers/media/platform/atmel/atmel-isc-regs.h |  25 +-
 drivers/media/platform/atmel/atmel-isc.c      | 346 +++++++++++++++++++++++---
 drivers/media/v4l2-core/v4l2-ctrls.c          |   1 +
 3 files changed, 336 insertions(+), 36 deletions(-)

-- 
2.7.4

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

             reply	other threads:[~2019-04-09 11:07 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-09 11:07 Eugen.Hristev [this message]
2019-04-09 11:07 ` [PATCH 0/7] media: atmel: atmel-isc: new features Eugen.Hristev
2019-04-09 11:07 ` [PATCH 1/7] media: atmel: atmel-isc: add safe checks and fixed wrong ISC state in error case Eugen.Hristev
2019-04-09 11:07   ` Eugen.Hristev
2019-04-10 14:19   ` Hans Verkuil
2019-04-10 14:19     ` Hans Verkuil
2019-04-09 11:07 ` [PATCH 2/7] media: atmel: atmel-isc: reworked white balance feature Eugen.Hristev
2019-04-09 11:07   ` Eugen.Hristev
2019-04-09 11:07 ` [PATCH 3/7] media: v4l2-ctrl: fix flags for DO_WHITE_BALANCE Eugen.Hristev
2019-04-09 11:07   ` Eugen.Hristev
2019-04-09 11:07 ` [PATCH 4/7] media: atmel: atmel-isc: add support " Eugen.Hristev
2019-04-09 11:07   ` Eugen.Hristev
2019-04-10 14:26   ` Hans Verkuil
2019-04-10 14:26     ` Hans Verkuil
2019-04-15  6:43     ` Eugen.Hristev
2019-04-15  6:43       ` Eugen.Hristev
2019-04-23 13:11       ` Hans Verkuil
2019-04-23 13:11         ` Hans Verkuil
2019-04-23 13:19         ` Eugen.Hristev
2019-04-23 13:19           ` Eugen.Hristev
2019-04-09 11:07 ` [PATCH 5/7] media: atmel: atmel-isc: limit incoming pixels per frame Eugen.Hristev
2019-04-09 11:07   ` Eugen.Hristev
2019-04-09 11:07 ` [PATCH 6/7] media: atmel: atmel-isc: fix INIT_WORK misplacement Eugen.Hristev
2019-04-09 11:07   ` Eugen.Hristev
2019-04-09 11:07 ` [PATCH 7/7] media: atmel: atmel-isc: fix asd memory allocation Eugen.Hristev
2019-04-09 11:07   ` Eugen.Hristev
2019-04-10 14:31 ` [PATCH 0/7] media: atmel: atmel-isc: new features Hans Verkuil
2019-04-10 14:31   ` Hans Verkuil

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1554807715-2353-1-git-send-email-eugen.hristev@microchip.com \
    --to=eugen.hristev@microchip.com \
    --cc=Nicolas.Ferre@microchip.com \
    --cc=hverkuil@xs4all.nl \
    --cc=ksloat@aampglobal.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=mchehab@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.