Re: [PATCH 0/7] media: atmel: atmel-isc: new features

From: Hans Verkuil <hverkuil@xs4all.nl>
To: Eugen.Hristev@microchip.com, linux-media@vger.kernel.org,
	Nicolas.Ferre@microchip.com,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, mchehab@kernel.org
Cc: ksloat@aampglobal.com
Subject: Re: [PATCH 0/7] media: atmel: atmel-isc: new features
Date: Wed, 10 Apr 2019 16:31:36 +0200	[thread overview]
Message-ID: <588f729b-0234-0019-ec40-54aa8a89da6b@xs4all.nl> (raw)
In-Reply-To: <1554807715-2353-1-git-send-email-eugen.hristev@microchip.com>

On 4/9/19 1:07 PM, Eugen.Hristev@microchip.com wrote:
> From: Eugen Hristev <eugen.hristev@microchip.com>
> 
> This series includes feature rework, feature additions and bug fixes for the
> atmel-isc driver.
> It applies only on top of my previous patchset:
> media: atmel: atmel-isc: removed ARGB32 added ABGR32 and XBGR32
> media: atmel: atmel-isc: reworked driver and formats
> available at:
> https://git.linuxtv.org/hverkuil/media_tree.git/commit/?h=for-v5.2b&id=03ef1b56cba6ad17f6ead13c85a81e0e80fbc9d1
> 
> One open question is regarding the WHITE_BALANCE error returns: it would seem
> logical to return EAGAIN or EBUSY, but this is not compliant with
> v4l2-compliance.
> Does it make sense to return success on every occasion? even if the
> DO_WHITE_BALANCE does nothing?
> In this series I used the return EAGAIN or EBUSY from the v4l2-ctrls, but I
> can change if always success is a better way of returning (even if normally
> a return value serves this exact purpose - return some code )

See my comments. Use v4l2_ctrl_activate() instead to mark controls active
or inactive and the control framework will do the rest.

I think it would speed up matters if you split up your series: one series
containing just fixes (I can merged those quickly) and one for the new
functionality.

Regards,

	Hans

> 
> Eugen Hristev (7):
>   media: atmel: atmel-isc: add safe checks and fixed wrong ISC state in
>     error case
>   media: atmel: atmel-isc: reworked white balance feature
>   media: v4l2-ctrl: fix flags for DO_WHITE_BALANCE
>   media: atmel: atmel-isc: add support for DO_WHITE_BALANCE
>   media: atmel: atmel-isc: limit incoming pixels per frame
>   media: atmel: atmel-isc: fix INIT_WORK misplacement
>   media: atmel: atmel-isc: fix asd memory allocation
> 
>  drivers/media/platform/atmel/atmel-isc-regs.h |  25 +-
>  drivers/media/platform/atmel/atmel-isc.c      | 346 +++++++++++++++++++++++---
>  drivers/media/v4l2-core/v4l2-ctrls.c          |   1 +
>  3 files changed, 336 insertions(+), 36 deletions(-)
> 