From: Chris Wilson <chris@chris-wilson.co.uk>
To: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>,
intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH v2 0/8] RPM Encapsulation
Date: Wed, 12 Jun 2019 23:24:30 +0100 [thread overview]
Message-ID: <156037827065.10298.7641905618266319260@skylake-alporthouse-com> (raw)
In-Reply-To: <20190612183748.7693-1-daniele.ceraolospurio@intel.com>
Quoting Daniele Ceraolo Spurio (2019-06-12 19:37:39)
> Rebased series after the display power code has been split out.
> Mostly the same as V1, just small fixes based on review comments
> and CI results. The last patch is new.
>
> The series grows the code a bit, but I believe it is worth it for the
> extra logical encapsulation. With all debug options disabled:
>
> add/remove: 0/0 grow/shrink: 92/14 up/down: 1225/-162 (1063)
> Total: Before=1266893, After=1267956, chg +0.08%
>
> Daniele Ceraolo Spurio (8):
> drm/i915: prefer i915_runtime_pm in intel_runtime function
> drm/i915: Remove rpm asserts that use i915
> drm/i915: make enable/disable rpm assert function use the rpm
> structure
> drm/i915: move and rename i915_runtime_pm
> drm/i915: move a few more functions to accept the rpm structure
> drm/i915: update rpm_get/put to use the rpm structure
> drm/i915: update with_intel_runtime_pm to use the rpm structure
> drm/i915: make intel_wakeref work on the rpm struct
Looks fine. I can't think of any neat way to avoid the extra offsets, so
we'll just have to think of a better way of dividing up the driver to
avoid loading unneeded code.
Preemptive Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
on the series as nothing leapt out at me from the mechanical churn.
Please cc Imre on the rebase in case he has a good reason to restructure
it differently.
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
prev parent reply other threads:[~2019-06-12 22:24 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-12 18:37 [PATCH v2 0/8] RPM Encapsulation Daniele Ceraolo Spurio
2019-06-12 18:37 ` [PATCH v2 1/8] drm/i915: prefer i915_runtime_pm in intel_runtime function Daniele Ceraolo Spurio
2019-06-12 22:10 ` Chris Wilson
2019-06-12 18:37 ` [PATCH v2 2/8] drm/i915: Remove rpm asserts that use i915 Daniele Ceraolo Spurio
2019-06-12 18:37 ` [PATCH v2 3/8] drm/i915: make enable/disable rpm assert function use the rpm structure Daniele Ceraolo Spurio
2019-06-12 18:37 ` [PATCH v2 4/8] drm/i915: move and rename i915_runtime_pm Daniele Ceraolo Spurio
2019-06-12 22:14 ` Chris Wilson
2019-06-12 22:16 ` Daniele Ceraolo Spurio
2019-06-12 18:37 ` [PATCH v2 5/8] drm/i915: move a few more functions to accept the rpm structure Daniele Ceraolo Spurio
2019-06-12 18:37 ` [PATCH v2 6/8] drm/i915: update rpm_get/put to use " Daniele Ceraolo Spurio
2019-06-12 18:37 ` [PATCH v2 7/8] drm/i915: update with_intel_runtime_pm " Daniele Ceraolo Spurio
2019-06-12 18:37 ` [PATCH v2 8/8] drm/i915: make intel_wakeref work on the rpm struct Daniele Ceraolo Spurio
2019-06-12 22:18 ` Chris Wilson
2019-06-12 19:24 ` ✗ Fi.CI.BAT: failure for RPM Encapsulation Patchwork
2019-06-12 22:24 ` Chris Wilson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=156037827065.10298.7641905618266319260@skylake-alporthouse-com \
--to=chris@chris-wilson.co.uk \
--cc=daniele.ceraolospurio@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.