From: CK Hu <ck.hu@mediatek.com>
To: <yongqiang.niu@mediatek.com>
Cc: Philipp Zabel <p.zabel@pengutronix.de>,
Rob Herring <robh+dt@kernel.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
"David Airlie" <airlied@linux.ie>,
Daniel Vetter <daniel@ffwll.ch>,
Mark Rutland <mark.rutland@arm.com>,
<dri-devel@lists.freedesktop.org>, <devicetree@vger.kernel.org>,
<linux-kernel@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-mediatek@lists.infradead.org>
Subject: Re: [PATCH v5, 24/32] drm/mediatek: add clock property check before get it
Date: Fri, 30 Aug 2019 14:11:42 +0800 [thread overview]
Message-ID: <1567145502.5942.15.camel@mtksdaap41> (raw)
In-Reply-To: <1567090254-15566-25-git-send-email-yongqiang.niu@mediatek.com>
Hi, Yongqiang:
On Thu, 2019-08-29 at 22:50 +0800, yongqiang.niu@mediatek.com wrote:
> From: Yongqiang Niu <yongqiang.niu@mediatek.com>
>
> This patch add clock property check before get it
>
> Signed-off-by: Yongqiang Niu <yongqiang.niu@mediatek.com>
> ---
> drivers/gpu/drm/mediatek/mtk_drm_ddp.c | 10 ++++++----
> 1 file changed, 6 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/mediatek/mtk_drm_ddp.c b/drivers/gpu/drm/mediatek/mtk_drm_ddp.c
> index a5a6689..effc24a 100644
> --- a/drivers/gpu/drm/mediatek/mtk_drm_ddp.c
> +++ b/drivers/gpu/drm/mediatek/mtk_drm_ddp.c
> @@ -657,10 +657,12 @@ static int mtk_ddp_probe(struct platform_device *pdev)
> for (i = 0; i < 10; i++)
> ddp->mutex[i].id = i;
>
> - ddp->clk = devm_clk_get(dev, NULL);
> - if (IS_ERR(ddp->clk)) {
> - dev_err(dev, "Failed to get clock\n");
> - return PTR_ERR(ddp->clk);
> + if (of_find_property(dev->of_node, "clocks", &i)) {
> + ddp->clk = devm_clk_get(dev, NULL);
> + if (IS_ERR(ddp->clk)) {
> + dev_err(dev, "Failed to get clock\n");
> + return PTR_ERR(ddp->clk);
> + }
Only "mediatek,mt8133-disp-mutex" has no clock property. For other SoC,
clock property is required. So I think this exception is just for
mt8183.
Regards,
CK
> }
>
> regs = platform_get_resource(pdev, IORESOURCE_MEM, 0);
WARNING: multiple messages have this Message-ID (diff)
From: CK Hu <ck.hu@mediatek.com>
To: yongqiang.niu@mediatek.com
Cc: Mark Rutland <mark.rutland@arm.com>,
devicetree@vger.kernel.org,
Philipp Zabel <p.zabel@pengutronix.de>,
David Airlie <airlied@linux.ie>,
linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
Rob Herring <robh+dt@kernel.org>,
linux-mediatek@lists.infradead.org,
Daniel Vetter <daniel@ffwll.ch>,
Matthias Brugger <matthias.bgg@gmail.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v5, 24/32] drm/mediatek: add clock property check before get it
Date: Fri, 30 Aug 2019 14:11:42 +0800 [thread overview]
Message-ID: <1567145502.5942.15.camel@mtksdaap41> (raw)
In-Reply-To: <1567090254-15566-25-git-send-email-yongqiang.niu@mediatek.com>
Hi, Yongqiang:
On Thu, 2019-08-29 at 22:50 +0800, yongqiang.niu@mediatek.com wrote:
> From: Yongqiang Niu <yongqiang.niu@mediatek.com>
>
> This patch add clock property check before get it
>
> Signed-off-by: Yongqiang Niu <yongqiang.niu@mediatek.com>
> ---
> drivers/gpu/drm/mediatek/mtk_drm_ddp.c | 10 ++++++----
> 1 file changed, 6 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/mediatek/mtk_drm_ddp.c b/drivers/gpu/drm/mediatek/mtk_drm_ddp.c
> index a5a6689..effc24a 100644
> --- a/drivers/gpu/drm/mediatek/mtk_drm_ddp.c
> +++ b/drivers/gpu/drm/mediatek/mtk_drm_ddp.c
> @@ -657,10 +657,12 @@ static int mtk_ddp_probe(struct platform_device *pdev)
> for (i = 0; i < 10; i++)
> ddp->mutex[i].id = i;
>
> - ddp->clk = devm_clk_get(dev, NULL);
> - if (IS_ERR(ddp->clk)) {
> - dev_err(dev, "Failed to get clock\n");
> - return PTR_ERR(ddp->clk);
> + if (of_find_property(dev->of_node, "clocks", &i)) {
> + ddp->clk = devm_clk_get(dev, NULL);
> + if (IS_ERR(ddp->clk)) {
> + dev_err(dev, "Failed to get clock\n");
> + return PTR_ERR(ddp->clk);
> + }
Only "mediatek,mt8133-disp-mutex" has no clock property. For other SoC,
clock property is required. So I think this exception is just for
mt8183.
Regards,
CK
> }
>
> regs = platform_get_resource(pdev, IORESOURCE_MEM, 0);
WARNING: multiple messages have this Message-ID (diff)
From: CK Hu <ck.hu@mediatek.com>
To: <yongqiang.niu@mediatek.com>
Cc: Mark Rutland <mark.rutland@arm.com>,
devicetree@vger.kernel.org,
Philipp Zabel <p.zabel@pengutronix.de>,
David Airlie <airlied@linux.ie>,
linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
Rob Herring <robh+dt@kernel.org>,
linux-mediatek@lists.infradead.org,
Daniel Vetter <daniel@ffwll.ch>,
Matthias Brugger <matthias.bgg@gmail.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v5, 24/32] drm/mediatek: add clock property check before get it
Date: Fri, 30 Aug 2019 14:11:42 +0800 [thread overview]
Message-ID: <1567145502.5942.15.camel@mtksdaap41> (raw)
In-Reply-To: <1567090254-15566-25-git-send-email-yongqiang.niu@mediatek.com>
Hi, Yongqiang:
On Thu, 2019-08-29 at 22:50 +0800, yongqiang.niu@mediatek.com wrote:
> From: Yongqiang Niu <yongqiang.niu@mediatek.com>
>
> This patch add clock property check before get it
>
> Signed-off-by: Yongqiang Niu <yongqiang.niu@mediatek.com>
> ---
> drivers/gpu/drm/mediatek/mtk_drm_ddp.c | 10 ++++++----
> 1 file changed, 6 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/mediatek/mtk_drm_ddp.c b/drivers/gpu/drm/mediatek/mtk_drm_ddp.c
> index a5a6689..effc24a 100644
> --- a/drivers/gpu/drm/mediatek/mtk_drm_ddp.c
> +++ b/drivers/gpu/drm/mediatek/mtk_drm_ddp.c
> @@ -657,10 +657,12 @@ static int mtk_ddp_probe(struct platform_device *pdev)
> for (i = 0; i < 10; i++)
> ddp->mutex[i].id = i;
>
> - ddp->clk = devm_clk_get(dev, NULL);
> - if (IS_ERR(ddp->clk)) {
> - dev_err(dev, "Failed to get clock\n");
> - return PTR_ERR(ddp->clk);
> + if (of_find_property(dev->of_node, "clocks", &i)) {
> + ddp->clk = devm_clk_get(dev, NULL);
> + if (IS_ERR(ddp->clk)) {
> + dev_err(dev, "Failed to get clock\n");
> + return PTR_ERR(ddp->clk);
> + }
Only "mediatek,mt8133-disp-mutex" has no clock property. For other SoC,
clock property is required. So I think this exception is just for
mt8183.
Regards,
CK
> }
>
> regs = platform_get_resource(pdev, IORESOURCE_MEM, 0);
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-08-30 6:12 UTC|newest]
Thread overview: 217+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-29 14:50 [PATCH v5, 00/32] add drm support for MT8183 yongqiang.niu
2019-08-29 14:50 ` yongqiang.niu
2019-08-29 14:50 ` yongqiang.niu
2019-08-29 14:50 ` [PATCH v5, 01/32] dt-bindings: mediatek: add binding for mt8183 display yongqiang.niu
2019-08-29 14:50 ` yongqiang.niu
2019-08-29 14:50 ` yongqiang.niu-NuS5LvNUpcJWk0Htik3J/w
2019-08-30 5:15 ` CK Hu
2019-08-30 5:15 ` CK Hu
2019-08-30 5:15 ` CK Hu
2019-08-29 14:50 ` [PATCH v5, 02/32] dt-bindings: mediatek: add ovl_2l description " yongqiang.niu
2019-08-29 14:50 ` yongqiang.niu
2019-08-29 14:50 ` yongqiang.niu
2019-09-04 1:44 ` CK Hu
2019-09-04 1:44 ` CK Hu
2019-09-04 1:44 ` CK Hu
2019-08-29 14:50 ` [PATCH v5, 03/32] dt-bindings: mediatek: add ccorr " yongqiang.niu
2019-08-29 14:50 ` yongqiang.niu
2019-08-29 14:50 ` yongqiang.niu
2019-09-04 1:44 ` CK Hu
2019-09-04 1:44 ` CK Hu
2019-09-04 1:44 ` CK Hu
2019-08-29 14:50 ` [PATCH v5, 04/32] dt-bindings: mediatek: add dither " yongqiang.niu
2019-08-29 14:50 ` yongqiang.niu
2019-08-29 14:50 ` yongqiang.niu
2019-09-04 1:45 ` CK Hu
2019-09-04 1:45 ` CK Hu
2019-09-04 1:45 ` CK Hu
2019-08-29 14:50 ` [PATCH v5, 05/32] dt-bindings: mediatek: add mutex " yongqiang.niu
2019-08-29 14:50 ` yongqiang.niu
2019-08-29 14:50 ` yongqiang.niu
2019-09-02 13:38 ` Rob Herring
2019-09-02 13:38 ` Rob Herring
2019-09-02 13:38 ` Rob Herring
2019-09-04 1:45 ` CK Hu
2019-09-04 1:45 ` CK Hu
2019-09-04 1:45 ` CK Hu
2019-08-29 14:50 ` [PATCH v5, 06/32] arm64: dts: add display nodes for mt8183 yongqiang.niu
2019-08-29 14:50 ` yongqiang.niu
2019-08-29 14:50 ` yongqiang.niu
2019-08-29 14:50 ` [PATCH v5, 07/32] drm/mediatek: add mutex mod into ddp private data yongqiang.niu
2019-08-29 14:50 ` yongqiang.niu
2019-08-29 14:50 ` yongqiang.niu
2019-10-09 9:31 ` CK Hu
2019-10-09 9:31 ` CK Hu
2019-10-09 9:31 ` CK Hu
2019-08-29 14:50 ` [PATCH v5, 08/32] drm/mediatek: add mutex mod register offset " yongqiang.niu
2019-08-29 14:50 ` yongqiang.niu
2019-08-29 14:50 ` yongqiang.niu-NuS5LvNUpcJWk0Htik3J/w
2019-10-09 9:32 ` CK Hu
2019-10-09 9:32 ` CK Hu
2019-10-09 9:32 ` CK Hu
2019-08-29 14:50 ` [PATCH v5, 09/32] drm/mediatek: add mutex sof " yongqiang.niu
2019-08-29 14:50 ` yongqiang.niu
2019-08-29 14:50 ` yongqiang.niu
2019-10-09 9:33 ` CK Hu
2019-10-09 9:33 ` CK Hu
2019-10-09 9:33 ` CK Hu
2019-08-29 14:50 ` [PATCH v5, 10/32] drm/mediatek: add mutex sof register offset " yongqiang.niu
2019-08-29 14:50 ` yongqiang.niu
2019-08-29 14:50 ` yongqiang.niu
2019-10-09 9:33 ` CK Hu
2019-10-09 9:33 ` CK Hu
2019-10-09 9:33 ` CK Hu
2019-08-29 14:50 ` [PATCH v5, 11/32] drm/mediatek: split DISP_REG_CONFIG_DSI_SEL setting into another use case yongqiang.niu
2019-08-29 14:50 ` yongqiang.niu
2019-08-29 14:50 ` yongqiang.niu
2019-08-30 5:21 ` CK Hu
2019-08-30 5:21 ` CK Hu
2019-08-30 5:21 ` CK Hu
2019-08-29 14:50 ` [PATCH v5, 12/32] drm/mediatek: add mmsys private data for ddp path config yongqiang.niu
2019-08-29 14:50 ` yongqiang.niu
2019-08-29 14:50 ` yongqiang.niu
2019-08-30 5:27 ` CK Hu
2019-08-30 5:27 ` CK Hu
2019-08-30 5:27 ` CK Hu
2019-08-30 5:40 ` CK Hu
2019-08-30 5:40 ` CK Hu
2019-08-30 5:40 ` CK Hu
2019-08-29 14:50 ` [PATCH v5, 13/32] drm/mediatek: move rdma sout from mtk_ddp_mout_en into mtk_ddp_sout_sel yongqiang.niu
2019-08-29 14:50 ` yongqiang.niu
2019-08-29 14:50 ` yongqiang.niu
2019-08-30 5:41 ` CK Hu
2019-08-30 5:41 ` CK Hu
2019-08-30 5:41 ` CK Hu
2019-08-29 14:50 ` [PATCH v5, 14/32] drm/mediatek: add ddp component CCORR yongqiang.niu
2019-08-29 14:50 ` yongqiang.niu
2019-08-29 14:50 ` yongqiang.niu
2019-10-09 9:10 ` CK Hu
2019-10-09 9:10 ` CK Hu
2019-10-09 9:10 ` CK Hu
2019-08-29 14:50 ` [PATCH v5, 15/32] drm/mediatek: add commponent OVL_2L0 yongqiang.niu
2019-08-29 14:50 ` yongqiang.niu
2019-08-29 14:50 ` yongqiang.niu
2019-10-09 9:17 ` CK Hu
2019-10-09 9:17 ` CK Hu
2019-10-09 9:17 ` CK Hu
2019-08-29 14:50 ` [PATCH v5, 16/32] drm/mediatek: add component OVL_2L1 yongqiang.niu
2019-08-29 14:50 ` yongqiang.niu
2019-08-29 14:50 ` yongqiang.niu
2019-10-09 9:18 ` CK Hu
2019-10-09 9:18 ` CK Hu
2019-10-09 9:18 ` CK Hu
2019-08-29 14:50 ` [PATCH v5, 17/32] drm/mediatek: add component DITHER yongqiang.niu
2019-08-29 14:50 ` yongqiang.niu
2019-08-29 14:50 ` yongqiang.niu
2019-10-09 9:11 ` CK Hu
2019-10-09 9:11 ` CK Hu
2019-10-09 9:11 ` CK Hu
2019-08-29 14:50 ` [PATCH v5, 18/32] drm/mediatek: add gmc_bits for ovl private data yongqiang.niu
2019-08-29 14:50 ` yongqiang.niu
2019-08-29 14:50 ` yongqiang.niu
2019-10-09 9:19 ` CK Hu
2019-10-09 9:19 ` CK Hu
2019-10-09 9:19 ` CK Hu
2019-08-29 14:50 ` [PATCH v5, 19/32] drm/medaitek: add layer_nr " yongqiang.niu
2019-08-29 14:50 ` yongqiang.niu
2019-08-29 14:50 ` yongqiang.niu
2019-10-09 9:20 ` CK Hu
2019-10-09 9:20 ` CK Hu
2019-10-09 9:20 ` CK Hu
2019-08-29 14:50 ` [PATCH v5, 20/32] drm/mediatek: add function to background color input select for ovl/ovl_2l direct link yongqiang.niu
2019-08-29 14:50 ` yongqiang.niu
2019-08-29 14:50 ` yongqiang.niu
2019-10-09 9:24 ` CK Hu
2019-10-09 9:24 ` CK Hu
2019-10-09 9:24 ` CK Hu
2019-08-29 14:50 ` [PATCH v5, 21/32] drm/mediatek: add background color input select function for ovl/ovl_2l yongqiang.niu
2019-08-29 14:50 ` yongqiang.niu
2019-08-29 14:50 ` yongqiang.niu
2019-10-09 9:24 ` CK Hu
2019-10-09 9:24 ` CK Hu
2019-10-09 9:24 ` CK Hu
2019-08-29 14:50 ` [PATCH v5, 22/32] drm/mediatek: add ovl0/ovl_2l0 usecase yongqiang.niu
2019-08-29 14:50 ` yongqiang.niu
2019-08-29 14:50 ` yongqiang.niu
2019-08-30 5:58 ` CK Hu
2019-08-30 5:58 ` CK Hu
2019-08-30 5:58 ` CK Hu
2019-09-02 8:11 ` CK Hu
2019-09-02 8:11 ` CK Hu
2019-09-02 8:11 ` CK Hu
2019-10-09 9:29 ` CK Hu
2019-10-09 9:29 ` CK Hu
2019-10-09 9:29 ` CK Hu
2019-08-29 14:50 ` [PATCH v5, 23/32] drm/mediatek: distinguish ovl and ovl_2l by layer_nr yongqiang.niu
2019-08-29 14:50 ` yongqiang.niu
2019-08-29 14:50 ` yongqiang.niu
2019-10-09 9:28 ` CK Hu
2019-10-09 9:28 ` CK Hu
2019-10-09 9:28 ` CK Hu
2019-08-29 14:50 ` [PATCH v5, 24/32] drm/mediatek: add clock property check before get it yongqiang.niu
2019-08-29 14:50 ` yongqiang.niu
2019-08-29 14:50 ` yongqiang.niu
2019-08-30 6:11 ` CK Hu [this message]
2019-08-30 6:11 ` CK Hu
2019-08-30 6:11 ` CK Hu
2019-10-09 9:36 ` CK Hu
2019-10-09 9:36 ` CK Hu
2019-10-09 9:36 ` CK Hu
2019-08-29 14:50 ` [PATCH v5, 25/32] drm/mediatek: add connection from OVL0 to OVL_2L0 yongqiang.niu
2019-08-29 14:50 ` yongqiang.niu
2019-08-29 14:50 ` yongqiang.niu
2019-08-30 6:20 ` CK Hu
2019-08-30 6:20 ` CK Hu
2019-08-30 6:20 ` CK Hu
2019-08-29 14:50 ` [PATCH v5, 26/32] drm/mediatek: add connection from RDMA0 to COLOR0 yongqiang.niu
2019-08-29 14:50 ` yongqiang.niu
2019-08-29 14:50 ` yongqiang.niu
2019-08-30 6:23 ` CK Hu
2019-08-30 6:23 ` CK Hu
2019-08-30 6:23 ` CK Hu
2019-08-29 14:50 ` [PATCH v5, 27/32] drm/mediatek: add connection from RDMA1 to DSI0 yongqiang.niu
2019-08-29 14:50 ` yongqiang.niu
2019-08-29 14:50 ` yongqiang.niu
2019-08-30 6:25 ` CK Hu
2019-08-30 6:25 ` CK Hu
2019-08-30 6:25 ` CK Hu
2019-08-29 14:50 ` [PATCH v5, 28/32] drm/mediatek: add connection from OVL_2L0 to RDMA0 yongqiang.niu
2019-08-29 14:50 ` yongqiang.niu
2019-08-29 14:50 ` yongqiang.niu
2019-08-30 6:30 ` CK Hu
2019-08-30 6:30 ` CK Hu
2019-08-30 6:30 ` CK Hu
2019-08-29 14:50 ` [PATCH v5, 29/32] drm/mediatek: add connection from OVL_2L1 to RDMA1 yongqiang.niu
2019-08-29 14:50 ` yongqiang.niu
2019-08-29 14:50 ` yongqiang.niu
2019-08-30 6:33 ` CK Hu
2019-08-30 6:33 ` CK Hu
2019-08-30 6:33 ` CK Hu
2019-08-29 14:50 ` [PATCH v5, 30/32] drm/mediatek: add connection from DITHER0 to DSI0 yongqiang.niu
2019-08-29 14:50 ` yongqiang.niu
2019-08-29 14:50 ` yongqiang.niu
2019-08-30 6:34 ` CK Hu
2019-08-30 6:34 ` CK Hu
2019-08-30 6:34 ` CK Hu
2019-08-29 14:50 ` [PATCH v5, 31/32] drm/mediatek: add connection from RDMA0 " yongqiang.niu
2019-08-29 14:50 ` yongqiang.niu
2019-08-29 14:50 ` yongqiang.niu
2019-08-30 6:36 ` CK Hu
2019-08-30 6:36 ` CK Hu
2019-08-30 6:36 ` CK Hu
2019-08-29 14:50 ` [PATCH v5, 32/32] drm/mediatek: add support for mediatek SOC MT8183 yongqiang.niu
2019-08-29 14:50 ` yongqiang.niu
2019-08-29 14:50 ` yongqiang.niu
2019-08-30 6:38 ` CK Hu
2019-08-30 6:38 ` CK Hu
2019-08-30 6:38 ` CK Hu
2019-09-05 7:17 ` CK Hu
2019-09-05 7:17 ` CK Hu
2019-09-05 7:17 ` CK Hu
2020-05-21 10:52 ` Matthias Brugger
2020-05-21 10:52 ` Matthias Brugger
2020-05-21 10:52 ` Matthias Brugger
2020-05-21 10:52 ` Matthias Brugger
2019-10-09 9:47 ` [PATCH v5, 00/32] add drm support for MT8183 CK Hu
2019-10-09 9:47 ` CK Hu
2019-10-09 9:47 ` CK Hu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1567145502.5942.15.camel@mtksdaap41 \
--to=ck.hu@mediatek.com \
--cc=airlied@linux.ie \
--cc=daniel@ffwll.ch \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=matthias.bgg@gmail.com \
--cc=p.zabel@pengutronix.de \
--cc=robh+dt@kernel.org \
--cc=yongqiang.niu@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.