From: Jiaxin Yu <jiaxin.yu@mediatek.com>
To: <broonie@kernel.org>, <mark.rutland@arm.com>,
<robh+dt@kernel.org>, <linux@roeck-us.net>,
<wim@linux-watchdog.org>
Cc: alsa-devel@alsa-project.org, yong.liang@mediatek.com,
lgirdwood@gmail.com, jiaxin.yu@mediatek.com, tzungbi@google.com,
linux-mediatek@lists.infradead.org, eason.yen@mediatek.com,
linux-arm-kernel@lists.infradead.org
Subject: [alsa-devel] [PATCH v2 4/4] ASoC: mt8183: fix audio playback slowly after playback during bootup
Date: Fri, 27 Sep 2019 18:31:57 +0800 [thread overview]
Message-ID: <1569580317-21181-5-git-send-email-jiaxin.yu@mediatek.com> (raw)
In-Reply-To: <1569580317-21181-1-git-send-email-jiaxin.yu@mediatek.com>
Before regmap_reinit_cache we must reset audio regs as default values.
So we use reset controller unit(toprgu) to reset audio hw.
Signed-off-by: Jiaxin Yu <jiaxin.yu@mediatek.com>
---
sound/soc/mediatek/mt8183/mt8183-afe-pcm.c | 15 +++++++++++++++
1 file changed, 15 insertions(+)
diff --git a/sound/soc/mediatek/mt8183/mt8183-afe-pcm.c b/sound/soc/mediatek/mt8183/mt8183-afe-pcm.c
index 4a31106d3471..721632386a50 100644
--- a/sound/soc/mediatek/mt8183/mt8183-afe-pcm.c
+++ b/sound/soc/mediatek/mt8183/mt8183-afe-pcm.c
@@ -11,6 +11,7 @@
#include <linux/of.h>
#include <linux/of_address.h>
#include <linux/pm_runtime.h>
+#include <linux/reset.h>
#include "mt8183-afe-common.h"
#include "mt8183-afe-clk.h"
@@ -1089,6 +1090,7 @@ static int mt8183_afe_pcm_dev_probe(struct platform_device *pdev)
struct mtk_base_afe *afe;
struct mt8183_afe_private *afe_priv;
struct device *dev;
+ struct reset_control *rstc;
int i, irq_id, ret;
afe = devm_kzalloc(&pdev->dev, sizeof(*afe), GFP_KERNEL);
@@ -1126,6 +1128,19 @@ static int mt8183_afe_pcm_dev_probe(struct platform_device *pdev)
return ret;
}
+ rstc = devm_reset_control_get(dev, "audiosys");
+ if (IS_ERR(rstc)) {
+ ret = PTR_ERR(rstc);
+ dev_err(dev, "could not get audiosys reset:%d\n", ret);
+ return ret;
+ }
+
+ ret = reset_control_reset(rstc);
+ if (ret) {
+ dev_err(dev, "failed to trigger audio reset:%d\n", ret);
+ return ret;
+ }
+
/* enable clock for regcache get default value from hw */
afe_priv->pm_runtime_bypass_reg_ctl = true;
pm_runtime_get_sync(&pdev->dev);
--
2.18.0
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel
WARNING: multiple messages have this Message-ID (diff)
From: Jiaxin Yu <jiaxin.yu@mediatek.com>
To: broonie@kernel.org, mark.rutland@arm.com, robh+dt@kernel.org,
linux@roeck-us.net, wim@linux-watchdog.org
Cc: alsa-devel@alsa-project.org, yong.liang@mediatek.com,
lgirdwood@gmail.com, jiaxin.yu@mediatek.com, perex@perex.cz,
tzungbi@google.com, linux-mediatek@lists.infradead.org,
eason.yen@mediatek.com, linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 4/4] ASoC: mt8183: fix audio playback slowly after playback during bootup
Date: Fri, 27 Sep 2019 18:31:57 +0800 [thread overview]
Message-ID: <1569580317-21181-5-git-send-email-jiaxin.yu@mediatek.com> (raw)
In-Reply-To: <1569580317-21181-1-git-send-email-jiaxin.yu@mediatek.com>
Before regmap_reinit_cache we must reset audio regs as default values.
So we use reset controller unit(toprgu) to reset audio hw.
Signed-off-by: Jiaxin Yu <jiaxin.yu@mediatek.com>
---
sound/soc/mediatek/mt8183/mt8183-afe-pcm.c | 15 +++++++++++++++
1 file changed, 15 insertions(+)
diff --git a/sound/soc/mediatek/mt8183/mt8183-afe-pcm.c b/sound/soc/mediatek/mt8183/mt8183-afe-pcm.c
index 4a31106d3471..721632386a50 100644
--- a/sound/soc/mediatek/mt8183/mt8183-afe-pcm.c
+++ b/sound/soc/mediatek/mt8183/mt8183-afe-pcm.c
@@ -11,6 +11,7 @@
#include <linux/of.h>
#include <linux/of_address.h>
#include <linux/pm_runtime.h>
+#include <linux/reset.h>
#include "mt8183-afe-common.h"
#include "mt8183-afe-clk.h"
@@ -1089,6 +1090,7 @@ static int mt8183_afe_pcm_dev_probe(struct platform_device *pdev)
struct mtk_base_afe *afe;
struct mt8183_afe_private *afe_priv;
struct device *dev;
+ struct reset_control *rstc;
int i, irq_id, ret;
afe = devm_kzalloc(&pdev->dev, sizeof(*afe), GFP_KERNEL);
@@ -1126,6 +1128,19 @@ static int mt8183_afe_pcm_dev_probe(struct platform_device *pdev)
return ret;
}
+ rstc = devm_reset_control_get(dev, "audiosys");
+ if (IS_ERR(rstc)) {
+ ret = PTR_ERR(rstc);
+ dev_err(dev, "could not get audiosys reset:%d\n", ret);
+ return ret;
+ }
+
+ ret = reset_control_reset(rstc);
+ if (ret) {
+ dev_err(dev, "failed to trigger audio reset:%d\n", ret);
+ return ret;
+ }
+
/* enable clock for regcache get default value from hw */
afe_priv->pm_runtime_bypass_reg_ctl = true;
pm_runtime_get_sync(&pdev->dev);
--
2.18.0
WARNING: multiple messages have this Message-ID (diff)
From: Jiaxin Yu <jiaxin.yu@mediatek.com>
To: <broonie@kernel.org>, <mark.rutland@arm.com>,
<robh+dt@kernel.org>, <linux@roeck-us.net>,
<wim@linux-watchdog.org>
Cc: alsa-devel@alsa-project.org, yong.liang@mediatek.com,
lgirdwood@gmail.com, jiaxin.yu@mediatek.com, perex@perex.cz,
tzungbi@google.com, linux-mediatek@lists.infradead.org,
eason.yen@mediatek.com, linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 4/4] ASoC: mt8183: fix audio playback slowly after playback during bootup
Date: Fri, 27 Sep 2019 18:31:57 +0800 [thread overview]
Message-ID: <1569580317-21181-5-git-send-email-jiaxin.yu@mediatek.com> (raw)
In-Reply-To: <1569580317-21181-1-git-send-email-jiaxin.yu@mediatek.com>
Before regmap_reinit_cache we must reset audio regs as default values.
So we use reset controller unit(toprgu) to reset audio hw.
Signed-off-by: Jiaxin Yu <jiaxin.yu@mediatek.com>
---
sound/soc/mediatek/mt8183/mt8183-afe-pcm.c | 15 +++++++++++++++
1 file changed, 15 insertions(+)
diff --git a/sound/soc/mediatek/mt8183/mt8183-afe-pcm.c b/sound/soc/mediatek/mt8183/mt8183-afe-pcm.c
index 4a31106d3471..721632386a50 100644
--- a/sound/soc/mediatek/mt8183/mt8183-afe-pcm.c
+++ b/sound/soc/mediatek/mt8183/mt8183-afe-pcm.c
@@ -11,6 +11,7 @@
#include <linux/of.h>
#include <linux/of_address.h>
#include <linux/pm_runtime.h>
+#include <linux/reset.h>
#include "mt8183-afe-common.h"
#include "mt8183-afe-clk.h"
@@ -1089,6 +1090,7 @@ static int mt8183_afe_pcm_dev_probe(struct platform_device *pdev)
struct mtk_base_afe *afe;
struct mt8183_afe_private *afe_priv;
struct device *dev;
+ struct reset_control *rstc;
int i, irq_id, ret;
afe = devm_kzalloc(&pdev->dev, sizeof(*afe), GFP_KERNEL);
@@ -1126,6 +1128,19 @@ static int mt8183_afe_pcm_dev_probe(struct platform_device *pdev)
return ret;
}
+ rstc = devm_reset_control_get(dev, "audiosys");
+ if (IS_ERR(rstc)) {
+ ret = PTR_ERR(rstc);
+ dev_err(dev, "could not get audiosys reset:%d\n", ret);
+ return ret;
+ }
+
+ ret = reset_control_reset(rstc);
+ if (ret) {
+ dev_err(dev, "failed to trigger audio reset:%d\n", ret);
+ return ret;
+ }
+
/* enable clock for regcache get default value from hw */
afe_priv->pm_runtime_bypass_reg_ctl = true;
pm_runtime_get_sync(&pdev->dev);
--
2.18.0
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-09-27 10:34 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-27 10:31 [alsa-devel] [PATCH v2 0/4] ASoC: mt8183: fix audio playback slowly after playback Jiaxin Yu
2019-09-27 10:31 ` Jiaxin Yu
2019-09-27 10:31 ` Jiaxin Yu
2019-09-27 10:31 ` [alsa-devel] [PATCH v2 1/4] dt-bindings: mediatek: mt8183: Add #reset-cells Jiaxin Yu
2019-09-27 10:31 ` Jiaxin Yu
2019-09-27 10:31 ` Jiaxin Yu
2019-09-27 10:31 ` [alsa-devel] [PATCH v2 2/4] watchdog: mtk_wdt: mt8183: Add reset controller Jiaxin Yu
2019-09-27 10:31 ` Jiaxin Yu
2019-09-27 10:31 ` Jiaxin Yu
2019-09-28 17:49 ` [alsa-devel] " Guenter Roeck
2019-09-28 17:49 ` Guenter Roeck
2019-09-28 17:49 ` Guenter Roeck
2019-09-30 8:17 ` [alsa-devel] " Yingjoe Chen
2019-09-30 8:17 ` Yingjoe Chen
2019-09-30 8:17 ` Yingjoe Chen
2019-10-03 13:49 ` [alsa-devel] " Guenter Roeck
2019-10-03 13:49 ` Guenter Roeck
2019-10-03 13:49 ` Guenter Roeck
2019-10-05 5:59 ` [alsa-devel] " Yingjoe Chen
2019-10-05 5:59 ` Yingjoe Chen
2019-10-05 5:59 ` Yingjoe Chen
2019-10-05 14:46 ` [alsa-devel] " Guenter Roeck
2019-10-05 14:46 ` Guenter Roeck
2019-10-05 14:46 ` Guenter Roeck
2019-10-08 14:08 ` [alsa-devel] " Philipp Zabel
2019-10-08 14:08 ` Philipp Zabel
2019-10-08 14:08 ` Philipp Zabel
2019-10-05 5:50 ` [alsa-devel] " Yingjoe Chen
2019-10-05 5:50 ` Yingjoe Chen
2019-10-05 5:50 ` Yingjoe Chen
2019-09-27 10:31 ` [alsa-devel] [PATCH v2 3/4] dt-bindings: medaitek: mt8183: add property "resets" && "reset-names" Jiaxin Yu
2019-09-27 10:31 ` Jiaxin Yu
2019-09-27 10:31 ` Jiaxin Yu
2019-10-08 12:53 ` [alsa-devel] Applied "dt-bindings: medaitek: mt8183: add property "resets" && "reset-names"" to the asoc tree Mark Brown
2019-10-08 12:53 ` Mark Brown
2019-10-08 12:53 ` Mark Brown
2019-09-27 10:31 ` Jiaxin Yu [this message]
2019-09-27 10:31 ` [PATCH v2 4/4] ASoC: mt8183: fix audio playback slowly after playback during bootup Jiaxin Yu
2019-09-27 10:31 ` Jiaxin Yu
2019-10-05 6:07 ` [alsa-devel] " Yingjoe Chen
2019-10-05 6:07 ` Yingjoe Chen
2019-10-05 6:07 ` Yingjoe Chen
2019-10-08 12:11 ` [alsa-devel] " Mark Brown
2019-10-08 12:11 ` Mark Brown
2019-10-08 12:53 ` [alsa-devel] Applied "ASoC: mt8183: fix audio playback slowly after playback during bootup" to the asoc tree Mark Brown
2019-10-08 12:53 ` Mark Brown
2019-10-08 12:53 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1569580317-21181-5-git-send-email-jiaxin.yu@mediatek.com \
--to=jiaxin.yu@mediatek.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=eason.yen@mediatek.com \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux@roeck-us.net \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=tzungbi@google.com \
--cc=wim@linux-watchdog.org \
--cc=yong.liang@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.