From: Mark Brown <broonie@kernel.org>
To: Jiaxin Yu <jiaxin.yu@mediatek.com>
Cc: mark.rutland@arm.com, alsa-devel@alsa-project.org,
yong.liang@mediatek.com, lgirdwood@gmail.com, tzungbi@google.com,
robh+dt@kernel.org, linux-mediatek@lists.infradead.org,
linux-arm-kernel@lists.infradead.org, eason.yen@mediatek.com,
wim@linux-watchdog.org, linux@roeck-us.net
Subject: Re: [alsa-devel] [PATCH v2 4/4] ASoC: mt8183: fix audio playback slowly after playback during bootup
Date: Tue, 8 Oct 2019 13:11:35 +0100 [thread overview]
Message-ID: <20191008121135.GH4382@sirena.co.uk> (raw)
In-Reply-To: <1569580317-21181-5-git-send-email-jiaxin.yu@mediatek.com>
[-- Attachment #1.1: Type: text/plain, Size: 703 bytes --]
On Fri, Sep 27, 2019 at 06:31:57PM +0800, Jiaxin Yu wrote:
> + rstc = devm_reset_control_get(dev, "audiosys");
> + if (IS_ERR(rstc)) {
> + ret = PTR_ERR(rstc);
> + dev_err(dev, "could not get audiosys reset:%d\n", ret);
> + return ret;
> + }
> +
> + ret = reset_control_reset(rstc);
> + if (ret) {
> + dev_err(dev, "failed to trigger audio reset:%d\n", ret);
> + return ret;
> + }
This means that we're going to be incompatible with old DT bindings that
don't specify a reset controller. I don't know how widely used these
bindings are so we may be able to get away with this and I'll apply but
we shouldn't be doing it, the code might need to be fixed to make this
optional if people complain.
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
[-- Attachment #2: Type: text/plain, Size: 161 bytes --]
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel
WARNING: multiple messages have this Message-ID (diff)
From: Mark Brown <broonie@kernel.org>
To: Jiaxin Yu <jiaxin.yu@mediatek.com>
Cc: mark.rutland@arm.com, alsa-devel@alsa-project.org,
yong.liang@mediatek.com, lgirdwood@gmail.com, perex@perex.cz,
tzungbi@google.com, robh+dt@kernel.org,
linux-mediatek@lists.infradead.org,
linux-arm-kernel@lists.infradead.org, eason.yen@mediatek.com,
wim@linux-watchdog.org, linux@roeck-us.net
Subject: Re: [PATCH v2 4/4] ASoC: mt8183: fix audio playback slowly after playback during bootup
Date: Tue, 8 Oct 2019 13:11:35 +0100 [thread overview]
Message-ID: <20191008121135.GH4382@sirena.co.uk> (raw)
In-Reply-To: <1569580317-21181-5-git-send-email-jiaxin.yu@mediatek.com>
[-- Attachment #1.1: Type: text/plain, Size: 703 bytes --]
On Fri, Sep 27, 2019 at 06:31:57PM +0800, Jiaxin Yu wrote:
> + rstc = devm_reset_control_get(dev, "audiosys");
> + if (IS_ERR(rstc)) {
> + ret = PTR_ERR(rstc);
> + dev_err(dev, "could not get audiosys reset:%d\n", ret);
> + return ret;
> + }
> +
> + ret = reset_control_reset(rstc);
> + if (ret) {
> + dev_err(dev, "failed to trigger audio reset:%d\n", ret);
> + return ret;
> + }
This means that we're going to be incompatible with old DT bindings that
don't specify a reset controller. I don't know how widely used these
bindings are so we may be able to get away with this and I'll apply but
we shouldn't be doing it, the code might need to be fixed to make this
optional if people complain.
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-10-08 12:12 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-27 10:31 [alsa-devel] [PATCH v2 0/4] ASoC: mt8183: fix audio playback slowly after playback Jiaxin Yu
2019-09-27 10:31 ` Jiaxin Yu
2019-09-27 10:31 ` Jiaxin Yu
2019-09-27 10:31 ` [alsa-devel] [PATCH v2 1/4] dt-bindings: mediatek: mt8183: Add #reset-cells Jiaxin Yu
2019-09-27 10:31 ` Jiaxin Yu
2019-09-27 10:31 ` Jiaxin Yu
2019-09-27 10:31 ` [alsa-devel] [PATCH v2 2/4] watchdog: mtk_wdt: mt8183: Add reset controller Jiaxin Yu
2019-09-27 10:31 ` Jiaxin Yu
2019-09-27 10:31 ` Jiaxin Yu
2019-09-28 17:49 ` [alsa-devel] " Guenter Roeck
2019-09-28 17:49 ` Guenter Roeck
2019-09-28 17:49 ` Guenter Roeck
2019-09-30 8:17 ` [alsa-devel] " Yingjoe Chen
2019-09-30 8:17 ` Yingjoe Chen
2019-09-30 8:17 ` Yingjoe Chen
2019-10-03 13:49 ` [alsa-devel] " Guenter Roeck
2019-10-03 13:49 ` Guenter Roeck
2019-10-03 13:49 ` Guenter Roeck
2019-10-05 5:59 ` [alsa-devel] " Yingjoe Chen
2019-10-05 5:59 ` Yingjoe Chen
2019-10-05 5:59 ` Yingjoe Chen
2019-10-05 14:46 ` [alsa-devel] " Guenter Roeck
2019-10-05 14:46 ` Guenter Roeck
2019-10-05 14:46 ` Guenter Roeck
2019-10-08 14:08 ` [alsa-devel] " Philipp Zabel
2019-10-08 14:08 ` Philipp Zabel
2019-10-08 14:08 ` Philipp Zabel
2019-10-05 5:50 ` [alsa-devel] " Yingjoe Chen
2019-10-05 5:50 ` Yingjoe Chen
2019-10-05 5:50 ` Yingjoe Chen
2019-09-27 10:31 ` [alsa-devel] [PATCH v2 3/4] dt-bindings: medaitek: mt8183: add property "resets" && "reset-names" Jiaxin Yu
2019-09-27 10:31 ` Jiaxin Yu
2019-09-27 10:31 ` Jiaxin Yu
2019-10-08 12:53 ` [alsa-devel] Applied "dt-bindings: medaitek: mt8183: add property "resets" && "reset-names"" to the asoc tree Mark Brown
2019-10-08 12:53 ` Mark Brown
2019-10-08 12:53 ` Mark Brown
2019-09-27 10:31 ` [alsa-devel] [PATCH v2 4/4] ASoC: mt8183: fix audio playback slowly after playback during bootup Jiaxin Yu
2019-09-27 10:31 ` Jiaxin Yu
2019-09-27 10:31 ` Jiaxin Yu
2019-10-05 6:07 ` [alsa-devel] " Yingjoe Chen
2019-10-05 6:07 ` Yingjoe Chen
2019-10-05 6:07 ` Yingjoe Chen
2019-10-08 12:11 ` Mark Brown [this message]
2019-10-08 12:11 ` Mark Brown
2019-10-08 12:53 ` [alsa-devel] Applied "ASoC: mt8183: fix audio playback slowly after playback during bootup" to the asoc tree Mark Brown
2019-10-08 12:53 ` Mark Brown
2019-10-08 12:53 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191008121135.GH4382@sirena.co.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=eason.yen@mediatek.com \
--cc=jiaxin.yu@mediatek.com \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux@roeck-us.net \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=tzungbi@google.com \
--cc=wim@linux-watchdog.org \
--cc=yong.liang@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.