✗ Fi.CI.CHECKPATCH: warning for series starting with [01/25] drm/i915: Protect context while grabbing its name for the request

From: Patchwork <patchwork@emeril.freedesktop.org>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: intel-gfx@lists.freedesktop.org
Subject: ✗ Fi.CI.CHECKPATCH: warning for series starting with [01/25] drm/i915: Protect context while grabbing its name for the request
Date: Sun, 10 Nov 2019 19:20:17 -0000	[thread overview]
Message-ID: <157341361710.30748.9006294968806655042@emeril.freedesktop.org> (raw)
In-Reply-To: <20191110185806.17413-1-chris@chris-wilson.co.uk>

== Series Details ==

Series: series starting with [01/25] drm/i915: Protect context while grabbing its name for the request
URL   : https://patchwork.freedesktop.org/series/69265/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
d402853e5a38 drm/i915: Protect context while grabbing its name for the request
e706176a5dae drm/i915/gem: Embed context/timeline name inside the GEM context
89d01350666e drm/i915/gem: Update context name on closing
74b9f809093a drm/i915/execlists: Move reset_active() from schedule-out to schedule-in
8597020d9819 drm/i915/pmu: "Frequency" is reported as accumulated cycles
8ffe8c84ba2d drm/i915/userptr: Handle unlocked gup retries
811a6595d3bf drm/i915: Cancel context if it hangs after it is closed
8e956214275b drm/i915: Show guilty context name on GPU reset
21290981206b drm/i915/icl: Refine PG_HYSTERESIS
bcc3edea4030 drm/i915/execlists: Reduce barrier on context switch to a wmb()
-:12: WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#12: 
References: cf66b8a0ba14 ("drm/i915/execlists: Apply a full mb before execution for Braswell")

-:12: ERROR:GIT_COMMIT_ID: Please use git commit description style 'commit <12+ chars of sha1> ("<title line>")' - ie: 'commit cf66b8a0ba14 ("drm/i915/execlists: Apply a full mb before execution for Braswell")'
#12: 
References: cf66b8a0ba14 ("drm/i915/execlists: Apply a full mb before execution for Braswell")

-:32: WARNING:MEMORY_BARRIER: memory barrier without comment
#32: FILE: drivers/gpu/drm/i915/gt/intel_lrc.c:1222:
+	wmb();

total: 1 errors, 2 warnings, 0 checks, 14 lines checked
e17d42d0553a drm/i915/gem: Silence sparse for RCU protection inside the constructor
-:4: WARNING:EMAIL_SUBJECT: A patch subject line should describe the change not the tool that found it
#4: 
Subject: [PATCH] drm/i915/gem: Silence sparse for RCU protection inside the

total: 0 errors, 1 warnings, 0 checks, 18 lines checked
63571679d026 drm/i915/userptr: Try to acquire the page lock around set_page_dirty()
-:29: WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#29: 
References: cb6d7c7dc7ff ("drm/i915/userptr: Acquire the page lock around set_page_dirty()")

-:29: ERROR:GIT_COMMIT_ID: Please use git commit description style 'commit <12+ chars of sha1> ("<title line>")' - ie: 'commit cb6d7c7dc7ff ("drm/i915/userptr: Acquire the page lock around set_page_dirty()")'
#29: 
References: cb6d7c7dc7ff ("drm/i915/userptr: Acquire the page lock around set_page_dirty()")

-:30: ERROR:GIT_COMMIT_ID: Please use git commit description style 'commit <12+ chars of sha1> ("<title line>")' - ie: 'commit 505a8ec7e11a ("Revert "drm/i915/userptr: Acquire the page lock around set_page_dirty()"")'
#30: 
References: 505a8ec7e11a ("Revert "drm/i915/userptr: Acquire the page lock around set_page_dirty()"")

-:31: ERROR:GIT_COMMIT_ID: Please use git commit description style 'commit <12+ chars of sha1> ("<title line>")' - ie: 'commit 6dcc693bc57f ("ext4: warn when page is dirtied without buffers")'
#31: 
References: 6dcc693bc57f ("ext4: warn when page is dirtied without buffers")

total: 3 errors, 1 warnings, 0 checks, 29 lines checked
9a8128fc6b6d drm/i915: Taint the kernel on dumping the GEM ftrace buffer
c4d1df46aa33 drm/i915/selftests: Exercise parallel blit operations on a single ctx
70a6a580819c drm/i915/selftests: Perform some basic cycle counting of MI ops
-:448: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating?
#448: 
new file mode 100644

-:487: ERROR:BRACKET_SPACE: space prohibited before open square bracket '['
#487: FILE: drivers/gpu/drm/i915/selftests/i915_selftest.c:87:
+#define selftest(n, f) [perf_##n] = { .name = #n, { .live = f } },

-:491: CHECK:LINE_SPACING: Please use a blank line after function/struct/union/enum declarations
#491: FILE: drivers/gpu/drm/i915/selftests/i915_selftest.c:91:
+};
+#undef selftest

-:502: WARNING:TRAILING_SEMICOLON: macros should not use a trailing semicolon
#502: FILE: drivers/gpu/drm/i915/selftests/i915_selftest.c:110:
+#define selftest_0(n, func, id) \
+module_param_named(id, perf_selftests[perf_##n].enabled, bool, 0400);

total: 1 errors, 2 warnings, 1 checks, 492 lines checked
9170551737a6 drm/i915/selftests: Mock the engine sorting for easy validation
-:27: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating?
#27: 
new file mode 100644

-:32: WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1
#32: FILE: drivers/gpu/drm/i915/gt/selftest_engine_user.c:1:
+/*

-:33: WARNING:SPDX_LICENSE_TAG: Misplaced SPDX-License-Identifier tag - use line 1 instead
#33: FILE: drivers/gpu/drm/i915/gt/selftest_engine_user.c:2:
+ * SPDX-License-Identifier: MIT

total: 0 errors, 3 warnings, 0 checks, 102 lines checked
563d91c23fe1 drm/i915/selftests: Fill all the drm_vma_manager holes
e7e9c7fc78b8 Revert "drm/i915: use a separate context for gpu relocs"
-:11: WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#11: 
References: 8a9a982767b7 ("drm/i915: use a separate context for gpu relocs")

-:11: ERROR:GIT_COMMIT_ID: Please use git commit description style 'commit <12+ chars of sha1> ("<title line>")' - ie: 'commit 8a9a982767b7 ("drm/i915: use a separate context for gpu relocs")'
#11: 
References: 8a9a982767b7 ("drm/i915: use a separate context for gpu relocs")

-:12: ERROR:GIT_COMMIT_ID: Please use git commit description style 'commit <12+ chars of sha1> ("<title line>")' - ie: 'commit c45e788d95b4 ("drm/i915/tgl: Suspend pre-parser across GTT invalidations")'
#12: 
References: c45e788d95b4 ("drm/i915/tgl: Suspend pre-parser across GTT invalidations")

total: 2 errors, 1 warnings, 0 checks, 60 lines checked
e83e488e9a35 drm/i915: Use a ctor for TYPESAFE_BY_RCU i915_request
2065cdcd7800 drm/i915: Drop GEM context as a direct link from i915_request
4df638d19932 drm/i915: Push the use-semaphore marker onto the intel_context
fa3a89c6ffbc drm/i915: Remove i915->kernel_context
f17cf5f6dde5 drm/i915: Move i915_gem_init_contexts() earlier
d850cd095bf6 drm/i915/uc: Use an internal buffer for firmware images
dd9db518d142 drm/i915/gt: Pull GT initialisation under intel_gt_init()

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx