From: Mimi Zohar <zohar@linux.ibm.com>
To: Lakshmi Ramasubramanian <nramas@linux.microsoft.com>,
linux-integrity@vger.kernel.org
Cc: eric.snowberg@oracle.com, dhowells@redhat.com,
mathew.j.martineau@linux.intel.com, matthewgarrett@google.com,
sashal@kernel.org, jamorris@linux.microsoft.com,
linux-kernel@vger.kernel.org, keyrings@vger.kernel.org
Subject: Re: [PATCH v10 1/6] IMA: Check IMA policy flag
Date: Wed, 11 Dec 2019 00:03:18 +0000 [thread overview]
Message-ID: <1576022598.4579.50.camel@linux.ibm.com> (raw)
In-Reply-To: <6385347a-bc40-7717-f9ad-8ed7dd7fee51@linux.microsoft.com>
On Tue, 2019-12-10 at 15:29 -0800, Lakshmi Ramasubramanian wrote:
> On 12/10/19 2:42 PM, Mimi Zohar wrote:
>
> > Patch descriptions aren't suppose to be written as pseudo code. Start
> > with the current status and problem description.
> >
> > For example, "process_buffer_measurement() may be called prior to IMA being initialized, which would result in a kernel panic. This patch ..."
> >
> > Mimi
>
> I'll update the patch description in this one and in the other patches
> per your comments.
>
> Are you done reviewing all the patches in this set?
>
> Other than the one code change per your comment on "[PATCH v10 5/6]"
> there are no other code changes I need to make?
> Just wanted to confirm.
>
> [PATCH v10 5/6] IMA: Add support to limit measuring keys
> => With the additional "uid" support this isn't necessarily true any
> more.
Yes, other than the code change needed for this and the patch
descriptions, it looks good. Am continuing with reviewing the other
patch set - queueing "key" measurements.
Mimi
WARNING: multiple messages have this Message-ID (diff)
From: Mimi Zohar <zohar@linux.ibm.com>
To: Lakshmi Ramasubramanian <nramas@linux.microsoft.com>,
linux-integrity@vger.kernel.org
Cc: eric.snowberg@oracle.com, dhowells@redhat.com,
mathew.j.martineau@linux.intel.com, matthewgarrett@google.com,
sashal@kernel.org, jamorris@linux.microsoft.com,
linux-kernel@vger.kernel.org, keyrings@vger.kernel.org
Subject: Re: [PATCH v10 1/6] IMA: Check IMA policy flag
Date: Tue, 10 Dec 2019 19:03:18 -0500 [thread overview]
Message-ID: <1576022598.4579.50.camel@linux.ibm.com> (raw)
In-Reply-To: <6385347a-bc40-7717-f9ad-8ed7dd7fee51@linux.microsoft.com>
On Tue, 2019-12-10 at 15:29 -0800, Lakshmi Ramasubramanian wrote:
> On 12/10/19 2:42 PM, Mimi Zohar wrote:
>
> > Patch descriptions aren't suppose to be written as pseudo code. Start
> > with the current status and problem description.
> >
> > For example, "process_buffer_measurement() may be called prior to IMA being initialized, which would result in a kernel panic. This patch ..."
> >
> > Mimi
>
> I'll update the patch description in this one and in the other patches
> per your comments.
>
> Are you done reviewing all the patches in this set?
>
> Other than the one code change per your comment on "[PATCH v10 5/6]"
> there are no other code changes I need to make?
> Just wanted to confirm.
>
> [PATCH v10 5/6] IMA: Add support to limit measuring keys
> => With the additional "uid" support this isn't necessarily true any
> more.
Yes, other than the code change needed for this and the patch
descriptions, it looks good. Am continuing with reviewing the other
patch set - queueing "key" measurements.
Mimi
next prev parent reply other threads:[~2019-12-11 0:03 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-04 22:41 [PATCH v10 0/6] KEYS: Measure keys when they are created or updated Lakshmi Ramasubramanian
2019-12-04 22:41 ` Lakshmi Ramasubramanian
2019-12-04 22:41 ` [PATCH v10 1/6] IMA: Check IMA policy flag Lakshmi Ramasubramanian
2019-12-04 22:41 ` Lakshmi Ramasubramanian
2019-12-10 22:42 ` Mimi Zohar
2019-12-10 22:42 ` Mimi Zohar
2019-12-10 23:29 ` Lakshmi Ramasubramanian
2019-12-10 23:29 ` Lakshmi Ramasubramanian
2019-12-11 0:03 ` Mimi Zohar [this message]
2019-12-11 0:03 ` Mimi Zohar
2019-12-04 22:41 ` [PATCH v10 2/6] IMA: Add KEY_CHECK func to measure keys Lakshmi Ramasubramanian
2019-12-04 22:41 ` Lakshmi Ramasubramanian
2019-12-04 22:41 ` [PATCH v10 3/6] IMA: Define an IMA hook " Lakshmi Ramasubramanian
2019-12-04 22:41 ` Lakshmi Ramasubramanian
2019-12-10 22:42 ` Mimi Zohar
2019-12-10 22:42 ` Mimi Zohar
2019-12-04 22:41 ` [PATCH v10 4/6] KEYS: Call the " Lakshmi Ramasubramanian
2019-12-04 22:41 ` Lakshmi Ramasubramanian
2019-12-10 22:43 ` Mimi Zohar
2019-12-10 22:43 ` Mimi Zohar
2019-12-04 22:41 ` [PATCH v10 5/6] IMA: Add support to limit measuring keys Lakshmi Ramasubramanian
2019-12-04 22:41 ` Lakshmi Ramasubramanian
2019-12-10 22:43 ` Mimi Zohar
2019-12-10 22:43 ` Mimi Zohar
2019-12-10 23:23 ` Lakshmi Ramasubramanian
2019-12-10 23:23 ` Lakshmi Ramasubramanian
2019-12-04 22:41 ` [PATCH v10 6/6] IMA: Read keyrings= option from the IMA policy Lakshmi Ramasubramanian
2019-12-04 22:41 ` Lakshmi Ramasubramanian
2019-12-10 22:43 ` Mimi Zohar
2019-12-10 22:43 ` Mimi Zohar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1576022598.4579.50.camel@linux.ibm.com \
--to=zohar@linux.ibm.com \
--cc=dhowells@redhat.com \
--cc=eric.snowberg@oracle.com \
--cc=jamorris@linux.microsoft.com \
--cc=keyrings@vger.kernel.org \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mathew.j.martineau@linux.intel.com \
--cc=matthewgarrett@google.com \
--cc=nramas@linux.microsoft.com \
--cc=sashal@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.