From: Jitao Shi <jitao.shi@mediatek.com>
To: Rob Herring <robh@kernel.org>
Cc: Mark Rutland <mark.rutland@arm.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
Daniel Vetter <daniel@ffwll.ch>, David Airlie <airlied@linux.ie>,
<dri-devel@lists.freedesktop.org>, <linux-kernel@vger.kernel.org>,
<linux-mediatek@lists.infradead.org>,
<devicetree@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<srv_heupstream@mediatek.com>, <yingjoe.chen@mediatek.com>,
<eddie.huang@mediatek.com>, <cawa.cheng@mediatek.com>,
<bibby.hsieh@mediatek.com>, <ck.hu@mediatek.com>,
<stonea168@163.com>, <huijuan.xie@mediatek.com>
Subject: Re: [PATCH v3 1/4] dt-bindings: display: mediatek: add property to control mipi tx drive current
Date: Tue, 31 Mar 2020 15:09:53 +0800 [thread overview]
Message-ID: <1585638593.31955.5.camel@mszsdaap41> (raw)
In-Reply-To: <20200323220033.GA29463@bogus>
On Mon, 2020-03-23 at 16:00 -0600, Rob Herring wrote:
> On Wed, Mar 11, 2020 at 03:40:29PM +0800, Jitao Shi wrote:
> > Add a property to control mipi tx drive current:
> > "drive-strength-microamp"
> >
> > Signed-off-by: Jitao Shi <jitao.shi@mediatek.com>
> > ---
> > .../devicetree/bindings/display/mediatek/mediatek,dsi.txt | 4 ++++
> > 1 file changed, 4 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/display/mediatek/mediatek,dsi.txt b/Documentation/devicetree/bindings/display/mediatek/mediatek,dsi.txt
> > index a19a6cc375ed..d501f9ff4b1f 100644
> > --- a/Documentation/devicetree/bindings/display/mediatek/mediatek,dsi.txt
> > +++ b/Documentation/devicetree/bindings/display/mediatek/mediatek,dsi.txt
> > @@ -33,6 +33,9 @@ Required properties:
> > - #clock-cells: must be <0>;
> > - #phy-cells: must be <0>.
> >
> > +Optional properties:
> > +- drive-strength-microamp: adjust driving current, should be 1 ~ 0xF
>
> TBC, 1-0xf is in units of microamps? So a max drive strength of 15uA?
> Seems a bit low.
>
The minimum amp is 3000 macroamps, step is 200macroamps.
So the drive current is 3000 + 200 * drive-strength-microamp amps.
I will update "drive-strength-microamp" define next version.
BR
Jitao
> > +
> > Example:
> >
> > mipi_tx0: mipi-dphy@10215000 {
> > @@ -42,6 +45,7 @@ mipi_tx0: mipi-dphy@10215000 {
> > clock-output-names = "mipi_tx0_pll";
> > #clock-cells = <0>;
> > #phy-cells = <0>;
> > + drive-strength-microamp = <0x8>;
> > };
> >
> > dsi0: dsi@1401b000 {
> > --
> > 2.21.0
WARNING: multiple messages have this Message-ID (diff)
From: Jitao Shi <jitao.shi@mediatek.com>
To: Rob Herring <robh@kernel.org>
Cc: Mark Rutland <mark.rutland@arm.com>,
devicetree@vger.kernel.org, bibby.hsieh@mediatek.com,
srv_heupstream@mediatek.com, David Airlie <airlied@linux.ie>,
huijuan.xie@mediatek.com, stonea168@163.com,
linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
cawa.cheng@mediatek.com, ck.hu@mediatek.com,
linux-mediatek@lists.infradead.org,
Daniel Vetter <daniel@ffwll.ch>,
Matthias Brugger <matthias.bgg@gmail.com>,
yingjoe.chen@mediatek.com, eddie.huang@mediatek.com,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v3 1/4] dt-bindings: display: mediatek: add property to control mipi tx drive current
Date: Tue, 31 Mar 2020 15:09:53 +0800 [thread overview]
Message-ID: <1585638593.31955.5.camel@mszsdaap41> (raw)
In-Reply-To: <20200323220033.GA29463@bogus>
On Mon, 2020-03-23 at 16:00 -0600, Rob Herring wrote:
> On Wed, Mar 11, 2020 at 03:40:29PM +0800, Jitao Shi wrote:
> > Add a property to control mipi tx drive current:
> > "drive-strength-microamp"
> >
> > Signed-off-by: Jitao Shi <jitao.shi@mediatek.com>
> > ---
> > .../devicetree/bindings/display/mediatek/mediatek,dsi.txt | 4 ++++
> > 1 file changed, 4 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/display/mediatek/mediatek,dsi.txt b/Documentation/devicetree/bindings/display/mediatek/mediatek,dsi.txt
> > index a19a6cc375ed..d501f9ff4b1f 100644
> > --- a/Documentation/devicetree/bindings/display/mediatek/mediatek,dsi.txt
> > +++ b/Documentation/devicetree/bindings/display/mediatek/mediatek,dsi.txt
> > @@ -33,6 +33,9 @@ Required properties:
> > - #clock-cells: must be <0>;
> > - #phy-cells: must be <0>.
> >
> > +Optional properties:
> > +- drive-strength-microamp: adjust driving current, should be 1 ~ 0xF
>
> TBC, 1-0xf is in units of microamps? So a max drive strength of 15uA?
> Seems a bit low.
>
The minimum amp is 3000 macroamps, step is 200macroamps.
So the drive current is 3000 + 200 * drive-strength-microamp amps.
I will update "drive-strength-microamp" define next version.
BR
Jitao
> > +
> > Example:
> >
> > mipi_tx0: mipi-dphy@10215000 {
> > @@ -42,6 +45,7 @@ mipi_tx0: mipi-dphy@10215000 {
> > clock-output-names = "mipi_tx0_pll";
> > #clock-cells = <0>;
> > #phy-cells = <0>;
> > + drive-strength-microamp = <0x8>;
> > };
> >
> > dsi0: dsi@1401b000 {
> > --
> > 2.21.0
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
WARNING: multiple messages have this Message-ID (diff)
From: Jitao Shi <jitao.shi@mediatek.com>
To: Rob Herring <robh@kernel.org>
Cc: Mark Rutland <mark.rutland@arm.com>,
devicetree@vger.kernel.org, bibby.hsieh@mediatek.com,
srv_heupstream@mediatek.com, David Airlie <airlied@linux.ie>,
huijuan.xie@mediatek.com, stonea168@163.com,
linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
cawa.cheng@mediatek.com, ck.hu@mediatek.com,
linux-mediatek@lists.infradead.org,
Daniel Vetter <daniel@ffwll.ch>,
Matthias Brugger <matthias.bgg@gmail.com>,
yingjoe.chen@mediatek.com, eddie.huang@mediatek.com,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v3 1/4] dt-bindings: display: mediatek: add property to control mipi tx drive current
Date: Tue, 31 Mar 2020 15:09:53 +0800 [thread overview]
Message-ID: <1585638593.31955.5.camel@mszsdaap41> (raw)
In-Reply-To: <20200323220033.GA29463@bogus>
On Mon, 2020-03-23 at 16:00 -0600, Rob Herring wrote:
> On Wed, Mar 11, 2020 at 03:40:29PM +0800, Jitao Shi wrote:
> > Add a property to control mipi tx drive current:
> > "drive-strength-microamp"
> >
> > Signed-off-by: Jitao Shi <jitao.shi@mediatek.com>
> > ---
> > .../devicetree/bindings/display/mediatek/mediatek,dsi.txt | 4 ++++
> > 1 file changed, 4 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/display/mediatek/mediatek,dsi.txt b/Documentation/devicetree/bindings/display/mediatek/mediatek,dsi.txt
> > index a19a6cc375ed..d501f9ff4b1f 100644
> > --- a/Documentation/devicetree/bindings/display/mediatek/mediatek,dsi.txt
> > +++ b/Documentation/devicetree/bindings/display/mediatek/mediatek,dsi.txt
> > @@ -33,6 +33,9 @@ Required properties:
> > - #clock-cells: must be <0>;
> > - #phy-cells: must be <0>.
> >
> > +Optional properties:
> > +- drive-strength-microamp: adjust driving current, should be 1 ~ 0xF
>
> TBC, 1-0xf is in units of microamps? So a max drive strength of 15uA?
> Seems a bit low.
>
The minimum amp is 3000 macroamps, step is 200macroamps.
So the drive current is 3000 + 200 * drive-strength-microamp amps.
I will update "drive-strength-microamp" define next version.
BR
Jitao
> > +
> > Example:
> >
> > mipi_tx0: mipi-dphy@10215000 {
> > @@ -42,6 +45,7 @@ mipi_tx0: mipi-dphy@10215000 {
> > clock-output-names = "mipi_tx0_pll";
> > #clock-cells = <0>;
> > #phy-cells = <0>;
> > + drive-strength-microamp = <0x8>;
> > };
> >
> > dsi0: dsi@1401b000 {
> > --
> > 2.21.0
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Jitao Shi <jitao.shi@mediatek.com>
To: Rob Herring <robh@kernel.org>
Cc: Mark Rutland <mark.rutland@arm.com>,
devicetree@vger.kernel.org, srv_heupstream@mediatek.com,
David Airlie <airlied@linux.ie>,
huijuan.xie@mediatek.com, stonea168@163.com,
linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
cawa.cheng@mediatek.com, linux-mediatek@lists.infradead.org,
Matthias Brugger <matthias.bgg@gmail.com>,
yingjoe.chen@mediatek.com, eddie.huang@mediatek.com,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v3 1/4] dt-bindings: display: mediatek: add property to control mipi tx drive current
Date: Tue, 31 Mar 2020 15:09:53 +0800 [thread overview]
Message-ID: <1585638593.31955.5.camel@mszsdaap41> (raw)
In-Reply-To: <20200323220033.GA29463@bogus>
On Mon, 2020-03-23 at 16:00 -0600, Rob Herring wrote:
> On Wed, Mar 11, 2020 at 03:40:29PM +0800, Jitao Shi wrote:
> > Add a property to control mipi tx drive current:
> > "drive-strength-microamp"
> >
> > Signed-off-by: Jitao Shi <jitao.shi@mediatek.com>
> > ---
> > .../devicetree/bindings/display/mediatek/mediatek,dsi.txt | 4 ++++
> > 1 file changed, 4 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/display/mediatek/mediatek,dsi.txt b/Documentation/devicetree/bindings/display/mediatek/mediatek,dsi.txt
> > index a19a6cc375ed..d501f9ff4b1f 100644
> > --- a/Documentation/devicetree/bindings/display/mediatek/mediatek,dsi.txt
> > +++ b/Documentation/devicetree/bindings/display/mediatek/mediatek,dsi.txt
> > @@ -33,6 +33,9 @@ Required properties:
> > - #clock-cells: must be <0>;
> > - #phy-cells: must be <0>.
> >
> > +Optional properties:
> > +- drive-strength-microamp: adjust driving current, should be 1 ~ 0xF
>
> TBC, 1-0xf is in units of microamps? So a max drive strength of 15uA?
> Seems a bit low.
>
The minimum amp is 3000 macroamps, step is 200macroamps.
So the drive current is 3000 + 200 * drive-strength-microamp amps.
I will update "drive-strength-microamp" define next version.
BR
Jitao
> > +
> > Example:
> >
> > mipi_tx0: mipi-dphy@10215000 {
> > @@ -42,6 +45,7 @@ mipi_tx0: mipi-dphy@10215000 {
> > clock-output-names = "mipi_tx0_pll";
> > #clock-cells = <0>;
> > #phy-cells = <0>;
> > + drive-strength-microamp = <0x8>;
> > };
> >
> > dsi0: dsi@1401b000 {
> > --
> > 2.21.0
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2020-03-31 7:10 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-11 7:40 [PATCH v3 0/4] Config mipi tx drive current and impedance Jitao Shi
2020-03-11 7:40 ` Jitao Shi
2020-03-11 7:40 ` Jitao Shi
2020-03-11 7:40 ` Jitao Shi
2020-03-11 7:40 ` [PATCH v3 1/4] dt-bindings: display: mediatek: add property to control mipi tx drive current Jitao Shi
2020-03-11 7:40 ` Jitao Shi
2020-03-11 7:40 ` Jitao Shi
2020-03-11 7:40 ` Jitao Shi
2020-03-23 22:00 ` Rob Herring
2020-03-23 22:00 ` Rob Herring
2020-03-23 22:00 ` Rob Herring
2020-03-23 22:00 ` Rob Herring
2020-03-31 7:09 ` Jitao Shi [this message]
2020-03-31 7:09 ` Jitao Shi
2020-03-31 7:09 ` Jitao Shi
2020-03-31 7:09 ` Jitao Shi
2020-03-11 7:40 ` [PATCH v3 2/4] dt-bindings: display: mediatek: get mipitx calibration data from nvmem Jitao Shi
2020-03-11 7:40 ` Jitao Shi
2020-03-11 7:40 ` Jitao Shi
2020-03-11 7:40 ` Jitao Shi
2020-03-23 22:01 ` Rob Herring
2020-03-23 22:01 ` Rob Herring
2020-03-23 22:01 ` Rob Herring
2020-03-23 22:01 ` Rob Herring
2020-03-11 7:40 ` [PATCH v3 3/4] drm/mediatek: add the mipitx driving control Jitao Shi
2020-03-11 7:40 ` Jitao Shi
2020-03-11 7:40 ` Jitao Shi
2020-03-11 7:40 ` Jitao Shi
2020-03-11 7:40 ` [PATCH v3 4/4] drm/mediatek: config mipitx impedance with calibration data Jitao Shi
2020-03-11 7:40 ` Jitao Shi
2020-03-11 7:40 ` Jitao Shi
2020-03-11 7:40 ` Jitao Shi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1585638593.31955.5.camel@mszsdaap41 \
--to=jitao.shi@mediatek.com \
--cc=airlied@linux.ie \
--cc=bibby.hsieh@mediatek.com \
--cc=cawa.cheng@mediatek.com \
--cc=ck.hu@mediatek.com \
--cc=daniel@ffwll.ch \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=eddie.huang@mediatek.com \
--cc=huijuan.xie@mediatek.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=matthias.bgg@gmail.com \
--cc=robh@kernel.org \
--cc=srv_heupstream@mediatek.com \
--cc=stonea168@163.com \
--cc=yingjoe.chen@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.