All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sameer Pujar <spujar@nvidia.com>
To: broonie@kernel.org, perex@perex.cz, tiwai@suse.com,
	kuninori.morimoto.gx@renesas.com, robh+dt@kernel.org,
	lgirdwood@gmail.com
Cc: thierry.reding@gmail.com, jonathanh@nvidia.com,
	alsa-devel@alsa-project.org, linux-tegra@vger.kernel.org,
	linux-kernel@vger.kernel.org, sharadg@nvidia.com,
	mkumard@nvidia.com, viswanathl@nvidia.com, rlokhande@nvidia.com,
	dramesh@nvidia.com, atalambedu@nvidia.com, nwartikar@nvidia.com,
	swarren@nvidia.com, nicoleotsuka@gmail.com,
	Sameer Pujar <spujar@nvidia.com>
Subject: [PATCH 01/10] ASoC: soc-core: Fix component name_prefix parsing
Date: Sun, 19 Jul 2020 10:40:08 +0530	[thread overview]
Message-ID: <1595135417-16589-2-git-send-email-spujar@nvidia.com> (raw)
In-Reply-To: <1595135417-16589-1-git-send-email-spujar@nvidia.com>

The "prefix" can be defined in DAI link node or it can be specified as
part of the component node itself. Currently "sound-name-prefix" defined
in a component is not taking effect. Actually the property is not getting
parsed. It can be fixed by parsing "sound-name-prefix" property whenever
"prefix" is missing in DAI link Codec node.

Signed-off-by: Sameer Pujar <spujar@nvidia.com>
---
 sound/soc/soc-core.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/sound/soc/soc-core.c b/sound/soc/soc-core.c
index 7c58e45..a4efcbe 100644
--- a/sound/soc/soc-core.c
+++ b/sound/soc/soc-core.c
@@ -1110,7 +1110,8 @@ static void soc_set_name_prefix(struct snd_soc_card *card,
 	for (i = 0; i < card->num_configs; i++) {
 		struct snd_soc_codec_conf *map = &card->codec_conf[i];
 
-		if (snd_soc_is_matching_component(&map->dlc, component)) {
+		if (snd_soc_is_matching_component(&map->dlc, component) &&
+		    map->name_prefix) {
 			component->name_prefix = map->name_prefix;
 			return;
 		}
-- 
2.7.4

WARNING: multiple messages have this Message-ID (diff)
From: Sameer Pujar <spujar@nvidia.com>
To: <broonie@kernel.org>, <perex@perex.cz>, <tiwai@suse.com>,
	<kuninori.morimoto.gx@renesas.com>, <robh+dt@kernel.org>,
	<lgirdwood@gmail.com>
Cc: <thierry.reding@gmail.com>, <jonathanh@nvidia.com>,
	<alsa-devel@alsa-project.org>, <linux-tegra@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>, <sharadg@nvidia.com>,
	<mkumard@nvidia.com>, <viswanathl@nvidia.com>,
	<rlokhande@nvidia.com>, <dramesh@nvidia.com>,
	<atalambedu@nvidia.com>, <nwartikar@nvidia.com>,
	<swarren@nvidia.com>, <nicoleotsuka@gmail.com>,
	Sameer Pujar <spujar@nvidia.com>
Subject: [PATCH 01/10] ASoC: soc-core: Fix component name_prefix parsing
Date: Sun, 19 Jul 2020 10:40:08 +0530	[thread overview]
Message-ID: <1595135417-16589-2-git-send-email-spujar@nvidia.com> (raw)
In-Reply-To: <1595135417-16589-1-git-send-email-spujar@nvidia.com>

The "prefix" can be defined in DAI link node or it can be specified as
part of the component node itself. Currently "sound-name-prefix" defined
in a component is not taking effect. Actually the property is not getting
parsed. It can be fixed by parsing "sound-name-prefix" property whenever
"prefix" is missing in DAI link Codec node.

Signed-off-by: Sameer Pujar <spujar@nvidia.com>
---
 sound/soc/soc-core.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/sound/soc/soc-core.c b/sound/soc/soc-core.c
index 7c58e45..a4efcbe 100644
--- a/sound/soc/soc-core.c
+++ b/sound/soc/soc-core.c
@@ -1110,7 +1110,8 @@ static void soc_set_name_prefix(struct snd_soc_card *card,
 	for (i = 0; i < card->num_configs; i++) {
 		struct snd_soc_codec_conf *map = &card->codec_conf[i];
 
-		if (snd_soc_is_matching_component(&map->dlc, component)) {
+		if (snd_soc_is_matching_component(&map->dlc, component) &&
+		    map->name_prefix) {
 			component->name_prefix = map->name_prefix;
 			return;
 		}
-- 
2.7.4


WARNING: multiple messages have this Message-ID (diff)
From: Sameer Pujar <spujar@nvidia.com>
To: <broonie@kernel.org>, <perex@perex.cz>, <tiwai@suse.com>,
	<kuninori.morimoto.gx@renesas.com>, <robh+dt@kernel.org>,
	<lgirdwood@gmail.com>
Cc: nicoleotsuka@gmail.com, alsa-devel@alsa-project.org,
	swarren@nvidia.com, Sameer Pujar <spujar@nvidia.com>,
	nwartikar@nvidia.com, linux-kernel@vger.kernel.org,
	jonathanh@nvidia.com, viswanathl@nvidia.com, sharadg@nvidia.com,
	thierry.reding@gmail.com, atalambedu@nvidia.com,
	linux-tegra@vger.kernel.org, rlokhande@nvidia.com,
	mkumard@nvidia.com, dramesh@nvidia.com
Subject: [PATCH 01/10] ASoC: soc-core: Fix component name_prefix parsing
Date: Sun, 19 Jul 2020 10:40:08 +0530	[thread overview]
Message-ID: <1595135417-16589-2-git-send-email-spujar@nvidia.com> (raw)
In-Reply-To: <1595135417-16589-1-git-send-email-spujar@nvidia.com>

The "prefix" can be defined in DAI link node or it can be specified as
part of the component node itself. Currently "sound-name-prefix" defined
in a component is not taking effect. Actually the property is not getting
parsed. It can be fixed by parsing "sound-name-prefix" property whenever
"prefix" is missing in DAI link Codec node.

Signed-off-by: Sameer Pujar <spujar@nvidia.com>
---
 sound/soc/soc-core.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/sound/soc/soc-core.c b/sound/soc/soc-core.c
index 7c58e45..a4efcbe 100644
--- a/sound/soc/soc-core.c
+++ b/sound/soc/soc-core.c
@@ -1110,7 +1110,8 @@ static void soc_set_name_prefix(struct snd_soc_card *card,
 	for (i = 0; i < card->num_configs; i++) {
 		struct snd_soc_codec_conf *map = &card->codec_conf[i];
 
-		if (snd_soc_is_matching_component(&map->dlc, component)) {
+		if (snd_soc_is_matching_component(&map->dlc, component) &&
+		    map->name_prefix) {
 			component->name_prefix = map->name_prefix;
 			return;
 		}
-- 
2.7.4


  reply	other threads:[~2020-07-19  5:10 UTC|newest]

Thread overview: 55+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-19  5:10 [PATCH 00/10] Audio graph card updates and usage with Tegra210 audio Sameer Pujar
2020-07-19  5:10 ` Sameer Pujar
2020-07-19  5:10 ` Sameer Pujar
2020-07-19  5:10 ` Sameer Pujar [this message]
2020-07-19  5:10   ` [PATCH 01/10] ASoC: soc-core: Fix component name_prefix parsing Sameer Pujar
2020-07-19  5:10   ` Sameer Pujar
     [not found] ` <1595135417-16589-1-git-send-email-spujar-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2020-07-19  5:10   ` [PATCH 02/10] ASoC: audio-graph: Use of_node and DAI for DPCM DAI link names Sameer Pujar
2020-07-19  5:10     ` Sameer Pujar
2020-07-19  5:10     ` Sameer Pujar
2020-07-19  5:10   ` [PATCH 03/10] ASoC: audio-graph: Support Codec with multiple endpoints Sameer Pujar
2020-07-19  5:10     ` Sameer Pujar
2020-07-19  5:10     ` Sameer Pujar
     [not found]     ` <1595135417-16589-4-git-send-email-spujar-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2020-07-19 23:37       ` Kuninori Morimoto
2020-07-19 23:37         ` Kuninori Morimoto
2020-07-19 23:37         ` Kuninori Morimoto
     [not found]         ` <87365n2i2z.wl-kuninori.morimoto.gx-zM6kxYcvzFBBDgjK7y7TUQ@public.gmane.org>
2020-07-20  4:14           ` Sameer Pujar
2020-07-20  4:14             ` Sameer Pujar
2020-07-20  4:14             ` Sameer Pujar
     [not found]             ` <870feaf2-3aa2-dbb8-f883-9b6cfcb36d82-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2020-07-20  5:13               ` Kuninori Morimoto
2020-07-20  5:13                 ` Kuninori Morimoto
2020-07-20  5:13                 ` Kuninori Morimoto
2020-08-03 12:02                 ` Sameer Pujar
2020-08-03 12:02                   ` Sameer Pujar
2020-07-19  5:10   ` [PATCH 04/10] ASoC: audio-graph: Support for empty end point Sameer Pujar
2020-07-19  5:10     ` Sameer Pujar
2020-07-19  5:10     ` Sameer Pujar
2020-07-19  5:10   ` [PATCH 05/10] ASoC: audio-graph: Identify 'no_pcm' DAI links for DPCM Sameer Pujar
2020-07-19  5:10     ` Sameer Pujar
2020-07-19  5:10     ` Sameer Pujar
2020-07-19  5:10   ` [PATCH 06/10] ASoC: soc-pcm: Get all BEs along DAPM path Sameer Pujar
2020-07-19  5:10     ` Sameer Pujar
2020-07-19  5:10     ` Sameer Pujar
2020-07-19  5:10   ` [PATCH 07/10] ASoC: dt-bindings: audio-graph-card: Support for component chaining Sameer Pujar
2020-07-19  5:10     ` Sameer Pujar
2020-07-19  5:10     ` Sameer Pujar
2020-07-19  5:10   ` [PATCH 08/10] ASoC: audio-graph: Add support " Sameer Pujar
2020-07-19  5:10     ` Sameer Pujar
2020-07-19  5:10     ` Sameer Pujar
2020-07-19  5:10   ` [PATCH 09/10] arm64: tegra: Audio graph header for Tegra210 Sameer Pujar
2020-07-19  5:10     ` Sameer Pujar
2020-07-19  5:10     ` Sameer Pujar
     [not found]     ` <1595135417-16589-10-git-send-email-spujar-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2020-07-20  0:10       ` Kuninori Morimoto
2020-07-20  0:10         ` Kuninori Morimoto
2020-07-20  0:10         ` Kuninori Morimoto
     [not found]         ` <871rl72gjb.wl-kuninori.morimoto.gx-zM6kxYcvzFBBDgjK7y7TUQ@public.gmane.org>
2020-07-20  4:17           ` Sameer Pujar
2020-07-20  4:17             ` Sameer Pujar
2020-07-20  4:17             ` Sameer Pujar
     [not found]             ` <b5484f5d-6ed4-e04b-3e62-8f4f3893ed67-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2020-07-20  4:51               ` Kuninori Morimoto
2020-07-20  4:51                 ` Kuninori Morimoto
2020-07-20  4:51                 ` Kuninori Morimoto
2020-08-03 12:06                 ` Sameer Pujar
2020-08-03 12:06                   ` Sameer Pujar
2020-07-19  5:10   ` [PATCH 10/10] arm64: tegra: Audio graph sound card for Jetson Nano and TX1 Sameer Pujar
2020-07-19  5:10     ` Sameer Pujar
2020-07-19  5:10     ` Sameer Pujar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1595135417-16589-2-git-send-email-spujar@nvidia.com \
    --to=spujar@nvidia.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=atalambedu@nvidia.com \
    --cc=broonie@kernel.org \
    --cc=dramesh@nvidia.com \
    --cc=jonathanh@nvidia.com \
    --cc=kuninori.morimoto.gx@renesas.com \
    --cc=lgirdwood@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tegra@vger.kernel.org \
    --cc=mkumard@nvidia.com \
    --cc=nicoleotsuka@gmail.com \
    --cc=nwartikar@nvidia.com \
    --cc=perex@perex.cz \
    --cc=rlokhande@nvidia.com \
    --cc=robh+dt@kernel.org \
    --cc=sharadg@nvidia.com \
    --cc=swarren@nvidia.com \
    --cc=thierry.reding@gmail.com \
    --cc=tiwai@suse.com \
    --cc=viswanathl@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.