From: Sameer Pujar <spujar-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
To: Kuninori Morimoto
<kuninori.morimoto.gx-zM6kxYcvzFBBDgjK7y7TUQ@public.gmane.org>
Cc: spujar-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org,
broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
perex-/Fr2/VpizcU@public.gmane.org,
tiwai-IBi9RG/b67k@public.gmane.org,
robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
lgirdwood-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
jonathanh-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org,
alsa-devel-K7yf7f+aM1XWsZ/bQMPhNw@public.gmane.org,
linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
sharadg-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org,
mkumard-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org,
viswanathl-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org,
rlokhande-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org,
dramesh-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org,
atalambedu-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org,
nwartikar-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org,
swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org,
nicoleotsuka-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org
Subject: Re: [PATCH 03/10] ASoC: audio-graph: Support Codec with multiple endpoints
Date: Mon, 20 Jul 2020 09:44:02 +0530 [thread overview]
Message-ID: <870feaf2-3aa2-dbb8-f883-9b6cfcb36d82@nvidia.com> (raw)
In-Reply-To: <87365n2i2z.wl-kuninori.morimoto.gx-zM6kxYcvzFBBDgjK7y7TUQ@public.gmane.org>
On 7/20/2020 5:07 AM, Kuninori Morimoto wrote:
> External email: Use caution opening links or attachments
>
>
> Hi Sameer
>
>> If a Codec port has multiple endpoints, only first endpoint gets parsed
>> and remaining are ignored. This can be fixed by removing 'dup_codec' flag
>> passed to graph_dai_link_of_dpcm() and thus it loops over all endpoints
>> of Codec. Similarly graph_count_dpcm() is updated as well.
>>
>> Signed-off-by: Sameer Pujar <spujar-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
>> ---
>> sound/soc/generic/audio-graph-card.c | 28 +++++++++-------------------
>> 1 file changed, 9 insertions(+), 19 deletions(-)
>>
>> diff --git a/sound/soc/generic/audio-graph-card.c b/sound/soc/generic/audio-graph-card.c
>> index 1e20562..b1903f9 100644
>> --- a/sound/soc/generic/audio-graph-card.c
>> +++ b/sound/soc/generic/audio-graph-card.c
>> @@ -201,8 +201,7 @@ static void graph_parse_mclk_fs(struct device_node *top,
>> static int graph_dai_link_of_dpcm(struct asoc_simple_priv *priv,
>> struct device_node *cpu_ep,
>> struct device_node *codec_ep,
>> - struct link_info *li,
>> - int dup_codec)
>> + struct link_info *li)
> This patch breaks DPCM connection which is used for MIXer
Could you please elaborate a bit more as to what is broken with this?
The problem I am trying to solve here is to have multiple endpoints for
Codec port.
>
> Thank you for your help !!
>
> Best regards
> ---
> Kuninori Morimoto
WARNING: multiple messages have this Message-ID (diff)
From: Sameer Pujar <spujar@nvidia.com>
To: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Cc: <spujar@nvidia.com>, <broonie@kernel.org>, <perex@perex.cz>,
<tiwai@suse.com>, <robh+dt@kernel.org>, <lgirdwood@gmail.com>,
<thierry.reding@gmail.com>, <jonathanh@nvidia.com>,
<alsa-devel@alsa-project.org>, <linux-tegra@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <sharadg@nvidia.com>,
<mkumard@nvidia.com>, <viswanathl@nvidia.com>,
<rlokhande@nvidia.com>, <dramesh@nvidia.com>,
<atalambedu@nvidia.com>, <nwartikar@nvidia.com>,
<swarren@nvidia.com>, <nicoleotsuka@gmail.com>
Subject: Re: [PATCH 03/10] ASoC: audio-graph: Support Codec with multiple endpoints
Date: Mon, 20 Jul 2020 09:44:02 +0530 [thread overview]
Message-ID: <870feaf2-3aa2-dbb8-f883-9b6cfcb36d82@nvidia.com> (raw)
In-Reply-To: <87365n2i2z.wl-kuninori.morimoto.gx@renesas.com>
On 7/20/2020 5:07 AM, Kuninori Morimoto wrote:
> External email: Use caution opening links or attachments
>
>
> Hi Sameer
>
>> If a Codec port has multiple endpoints, only first endpoint gets parsed
>> and remaining are ignored. This can be fixed by removing 'dup_codec' flag
>> passed to graph_dai_link_of_dpcm() and thus it loops over all endpoints
>> of Codec. Similarly graph_count_dpcm() is updated as well.
>>
>> Signed-off-by: Sameer Pujar <spujar@nvidia.com>
>> ---
>> sound/soc/generic/audio-graph-card.c | 28 +++++++++-------------------
>> 1 file changed, 9 insertions(+), 19 deletions(-)
>>
>> diff --git a/sound/soc/generic/audio-graph-card.c b/sound/soc/generic/audio-graph-card.c
>> index 1e20562..b1903f9 100644
>> --- a/sound/soc/generic/audio-graph-card.c
>> +++ b/sound/soc/generic/audio-graph-card.c
>> @@ -201,8 +201,7 @@ static void graph_parse_mclk_fs(struct device_node *top,
>> static int graph_dai_link_of_dpcm(struct asoc_simple_priv *priv,
>> struct device_node *cpu_ep,
>> struct device_node *codec_ep,
>> - struct link_info *li,
>> - int dup_codec)
>> + struct link_info *li)
> This patch breaks DPCM connection which is used for MIXer
Could you please elaborate a bit more as to what is broken with this?
The problem I am trying to solve here is to have multiple endpoints for
Codec port.
>
> Thank you for your help !!
>
> Best regards
> ---
> Kuninori Morimoto
WARNING: multiple messages have this Message-ID (diff)
From: Sameer Pujar <spujar@nvidia.com>
To: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Cc: jonathanh@nvidia.com, nicoleotsuka@gmail.com,
alsa-devel@alsa-project.org, atalambedu@nvidia.com,
swarren@nvidia.com, linux-kernel@vger.kernel.org,
spujar@nvidia.com, nwartikar@nvidia.com, lgirdwood@gmail.com,
robh+dt@kernel.org, tiwai@suse.com, viswanathl@nvidia.com,
sharadg@nvidia.com, broonie@kernel.org, thierry.reding@gmail.com,
linux-tegra@vger.kernel.org, rlokhande@nvidia.com,
mkumard@nvidia.com, dramesh@nvidia.com
Subject: Re: [PATCH 03/10] ASoC: audio-graph: Support Codec with multiple endpoints
Date: Mon, 20 Jul 2020 09:44:02 +0530 [thread overview]
Message-ID: <870feaf2-3aa2-dbb8-f883-9b6cfcb36d82@nvidia.com> (raw)
In-Reply-To: <87365n2i2z.wl-kuninori.morimoto.gx@renesas.com>
On 7/20/2020 5:07 AM, Kuninori Morimoto wrote:
> External email: Use caution opening links or attachments
>
>
> Hi Sameer
>
>> If a Codec port has multiple endpoints, only first endpoint gets parsed
>> and remaining are ignored. This can be fixed by removing 'dup_codec' flag
>> passed to graph_dai_link_of_dpcm() and thus it loops over all endpoints
>> of Codec. Similarly graph_count_dpcm() is updated as well.
>>
>> Signed-off-by: Sameer Pujar <spujar@nvidia.com>
>> ---
>> sound/soc/generic/audio-graph-card.c | 28 +++++++++-------------------
>> 1 file changed, 9 insertions(+), 19 deletions(-)
>>
>> diff --git a/sound/soc/generic/audio-graph-card.c b/sound/soc/generic/audio-graph-card.c
>> index 1e20562..b1903f9 100644
>> --- a/sound/soc/generic/audio-graph-card.c
>> +++ b/sound/soc/generic/audio-graph-card.c
>> @@ -201,8 +201,7 @@ static void graph_parse_mclk_fs(struct device_node *top,
>> static int graph_dai_link_of_dpcm(struct asoc_simple_priv *priv,
>> struct device_node *cpu_ep,
>> struct device_node *codec_ep,
>> - struct link_info *li,
>> - int dup_codec)
>> + struct link_info *li)
> This patch breaks DPCM connection which is used for MIXer
Could you please elaborate a bit more as to what is broken with this?
The problem I am trying to solve here is to have multiple endpoints for
Codec port.
>
> Thank you for your help !!
>
> Best regards
> ---
> Kuninori Morimoto
next prev parent reply other threads:[~2020-07-20 4:14 UTC|newest]
Thread overview: 55+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-19 5:10 [PATCH 00/10] Audio graph card updates and usage with Tegra210 audio Sameer Pujar
2020-07-19 5:10 ` Sameer Pujar
2020-07-19 5:10 ` Sameer Pujar
2020-07-19 5:10 ` [PATCH 01/10] ASoC: soc-core: Fix component name_prefix parsing Sameer Pujar
2020-07-19 5:10 ` Sameer Pujar
2020-07-19 5:10 ` Sameer Pujar
[not found] ` <1595135417-16589-1-git-send-email-spujar-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2020-07-19 5:10 ` [PATCH 02/10] ASoC: audio-graph: Use of_node and DAI for DPCM DAI link names Sameer Pujar
2020-07-19 5:10 ` Sameer Pujar
2020-07-19 5:10 ` Sameer Pujar
2020-07-19 5:10 ` [PATCH 03/10] ASoC: audio-graph: Support Codec with multiple endpoints Sameer Pujar
2020-07-19 5:10 ` Sameer Pujar
2020-07-19 5:10 ` Sameer Pujar
[not found] ` <1595135417-16589-4-git-send-email-spujar-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2020-07-19 23:37 ` Kuninori Morimoto
2020-07-19 23:37 ` Kuninori Morimoto
2020-07-19 23:37 ` Kuninori Morimoto
[not found] ` <87365n2i2z.wl-kuninori.morimoto.gx-zM6kxYcvzFBBDgjK7y7TUQ@public.gmane.org>
2020-07-20 4:14 ` Sameer Pujar [this message]
2020-07-20 4:14 ` Sameer Pujar
2020-07-20 4:14 ` Sameer Pujar
[not found] ` <870feaf2-3aa2-dbb8-f883-9b6cfcb36d82-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2020-07-20 5:13 ` Kuninori Morimoto
2020-07-20 5:13 ` Kuninori Morimoto
2020-07-20 5:13 ` Kuninori Morimoto
2020-08-03 12:02 ` Sameer Pujar
2020-08-03 12:02 ` Sameer Pujar
2020-07-19 5:10 ` [PATCH 04/10] ASoC: audio-graph: Support for empty end point Sameer Pujar
2020-07-19 5:10 ` Sameer Pujar
2020-07-19 5:10 ` Sameer Pujar
2020-07-19 5:10 ` [PATCH 05/10] ASoC: audio-graph: Identify 'no_pcm' DAI links for DPCM Sameer Pujar
2020-07-19 5:10 ` Sameer Pujar
2020-07-19 5:10 ` Sameer Pujar
2020-07-19 5:10 ` [PATCH 06/10] ASoC: soc-pcm: Get all BEs along DAPM path Sameer Pujar
2020-07-19 5:10 ` Sameer Pujar
2020-07-19 5:10 ` Sameer Pujar
2020-07-19 5:10 ` [PATCH 07/10] ASoC: dt-bindings: audio-graph-card: Support for component chaining Sameer Pujar
2020-07-19 5:10 ` Sameer Pujar
2020-07-19 5:10 ` Sameer Pujar
2020-07-19 5:10 ` [PATCH 08/10] ASoC: audio-graph: Add support " Sameer Pujar
2020-07-19 5:10 ` Sameer Pujar
2020-07-19 5:10 ` Sameer Pujar
2020-07-19 5:10 ` [PATCH 09/10] arm64: tegra: Audio graph header for Tegra210 Sameer Pujar
2020-07-19 5:10 ` Sameer Pujar
2020-07-19 5:10 ` Sameer Pujar
[not found] ` <1595135417-16589-10-git-send-email-spujar-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2020-07-20 0:10 ` Kuninori Morimoto
2020-07-20 0:10 ` Kuninori Morimoto
2020-07-20 0:10 ` Kuninori Morimoto
[not found] ` <871rl72gjb.wl-kuninori.morimoto.gx-zM6kxYcvzFBBDgjK7y7TUQ@public.gmane.org>
2020-07-20 4:17 ` Sameer Pujar
2020-07-20 4:17 ` Sameer Pujar
2020-07-20 4:17 ` Sameer Pujar
[not found] ` <b5484f5d-6ed4-e04b-3e62-8f4f3893ed67-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2020-07-20 4:51 ` Kuninori Morimoto
2020-07-20 4:51 ` Kuninori Morimoto
2020-07-20 4:51 ` Kuninori Morimoto
2020-08-03 12:06 ` Sameer Pujar
2020-08-03 12:06 ` Sameer Pujar
2020-07-19 5:10 ` [PATCH 10/10] arm64: tegra: Audio graph sound card for Jetson Nano and TX1 Sameer Pujar
2020-07-19 5:10 ` Sameer Pujar
2020-07-19 5:10 ` Sameer Pujar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=870feaf2-3aa2-dbb8-f883-9b6cfcb36d82@nvidia.com \
--to=spujar-ddmlm1+adcrqt0dzr+alfa@public.gmane.org \
--cc=alsa-devel-K7yf7f+aM1XWsZ/bQMPhNw@public.gmane.org \
--cc=atalambedu-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
--cc=broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=dramesh-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
--cc=jonathanh-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
--cc=kuninori.morimoto.gx-zM6kxYcvzFBBDgjK7y7TUQ@public.gmane.org \
--cc=lgirdwood-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=mkumard-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
--cc=nicoleotsuka-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=nwartikar-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
--cc=perex-/Fr2/VpizcU@public.gmane.org \
--cc=rlokhande-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
--cc=robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=sharadg-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
--cc=swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
--cc=thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=tiwai-IBi9RG/b67k@public.gmane.org \
--cc=viswanathl-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.