From: Liu Yi L <yi.l.liu@intel.com> To: alex.williamson@redhat.com, eric.auger@redhat.com, baolu.lu@linux.intel.com, joro@8bytes.org Cc: kevin.tian@intel.com, jacob.jun.pan@linux.intel.com, ashok.raj@intel.com, yi.l.liu@intel.com, jun.j.tian@intel.com, yi.y.sun@intel.com, jean-philippe@linaro.org, peterx@redhat.com, hao.wu@intel.com, stefanha@gmail.com, iommu@lists.linux-foundation.org, kvm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v6 06/15] iommu/vt-d: Support setting ioasid set to domain Date: Mon, 27 Jul 2020 23:27:35 -0700 [thread overview] Message-ID: <1595917664-33276-7-git-send-email-yi.l.liu@intel.com> (raw) In-Reply-To: <1595917664-33276-1-git-send-email-yi.l.liu@intel.com> From IOMMU p.o.v., PASIDs allocated and managed by external components (e.g. VFIO) will be passed in for gpasid_bind/unbind operation. IOMMU needs some knowledge to check the PASID ownership, hence add an interface for those components to tell the PASID owner. In latest kernel design, PASID ownership is managed by IOASID set where the PASID is allocated from. This patch adds support for setting ioasid set ID to the domains used for nesting/vSVA. Subsequent SVA operations will check the PASID against its IOASID set for proper ownership. Cc: Kevin Tian <kevin.tian@intel.com> CC: Jacob Pan <jacob.jun.pan@linux.intel.com> Cc: Alex Williamson <alex.williamson@redhat.com> Cc: Eric Auger <eric.auger@redhat.com> Cc: Jean-Philippe Brucker <jean-philippe@linaro.org> Cc: Joerg Roedel <joro@8bytes.org> Cc: Lu Baolu <baolu.lu@linux.intel.com> Signed-off-by: Liu Yi L <yi.l.liu@intel.com> Signed-off-by: Jacob Pan <jacob.jun.pan@linux.intel.com> --- v5 -> v6: *) address comments against v5 from Eric Auger. v4 -> v5: *) address comments from Eric Auger. --- drivers/iommu/intel/iommu.c | 23 +++++++++++++++++++++++ include/linux/intel-iommu.h | 4 ++++ include/linux/iommu.h | 1 + 3 files changed, 28 insertions(+) diff --git a/drivers/iommu/intel/iommu.c b/drivers/iommu/intel/iommu.c index ed4b71c..b2fe54e 100644 --- a/drivers/iommu/intel/iommu.c +++ b/drivers/iommu/intel/iommu.c @@ -1793,6 +1793,7 @@ static struct dmar_domain *alloc_domain(int flags) if (first_level_by_default()) domain->flags |= DOMAIN_FLAG_USE_FIRST_LEVEL; domain->has_iotlb_device = false; + domain->ioasid_sid = INVALID_IOASID_SET; INIT_LIST_HEAD(&domain->devices); return domain; @@ -6040,6 +6041,28 @@ intel_iommu_domain_set_attr(struct iommu_domain *domain, } spin_unlock_irqrestore(&device_domain_lock, flags); break; + case DOMAIN_ATTR_IOASID_SID: + { + int sid = *(int *)data; + + spin_lock_irqsave(&device_domain_lock, flags); + if (!(dmar_domain->flags & DOMAIN_FLAG_NESTING_MODE)) { + ret = -ENODEV; + spin_unlock_irqrestore(&device_domain_lock, flags); + break; + } + if (dmar_domain->ioasid_sid != INVALID_IOASID_SET && + dmar_domain->ioasid_sid != sid) { + pr_warn_ratelimited("multi ioasid_set (%d:%d) setting", + dmar_domain->ioasid_sid, sid); + ret = -EBUSY; + spin_unlock_irqrestore(&device_domain_lock, flags); + break; + } + dmar_domain->ioasid_sid = sid; + spin_unlock_irqrestore(&device_domain_lock, flags); + break; + } default: ret = -EINVAL; break; diff --git a/include/linux/intel-iommu.h b/include/linux/intel-iommu.h index 3f23c26..0d0ab32 100644 --- a/include/linux/intel-iommu.h +++ b/include/linux/intel-iommu.h @@ -549,6 +549,10 @@ struct dmar_domain { 2 == 1GiB, 3 == 512GiB, 4 == 1TiB */ u64 max_addr; /* maximum mapped address */ + int ioasid_sid; /* + * the ioasid set which tracks all + * PASIDs used by the domain. + */ int default_pasid; /* * The default pasid used for non-SVM * traffic on mediated devices. diff --git a/include/linux/iommu.h b/include/linux/iommu.h index 4a02c9e..b1ff702 100644 --- a/include/linux/iommu.h +++ b/include/linux/iommu.h @@ -124,6 +124,7 @@ enum iommu_attr { DOMAIN_ATTR_FSL_PAMUV1, DOMAIN_ATTR_NESTING, /* two stages of translation */ DOMAIN_ATTR_DMA_USE_FLUSH_QUEUE, + DOMAIN_ATTR_IOASID_SID, DOMAIN_ATTR_MAX, }; -- 2.7.4
WARNING: multiple messages have this Message-ID (diff)
From: Liu Yi L <yi.l.liu@intel.com> To: alex.williamson@redhat.com, eric.auger@redhat.com, baolu.lu@linux.intel.com, joro@8bytes.org Cc: jean-philippe@linaro.org, kevin.tian@intel.com, ashok.raj@intel.com, kvm@vger.kernel.org, stefanha@gmail.com, jun.j.tian@intel.com, iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org, yi.y.sun@intel.com, hao.wu@intel.com Subject: [PATCH v6 06/15] iommu/vt-d: Support setting ioasid set to domain Date: Mon, 27 Jul 2020 23:27:35 -0700 [thread overview] Message-ID: <1595917664-33276-7-git-send-email-yi.l.liu@intel.com> (raw) In-Reply-To: <1595917664-33276-1-git-send-email-yi.l.liu@intel.com> From IOMMU p.o.v., PASIDs allocated and managed by external components (e.g. VFIO) will be passed in for gpasid_bind/unbind operation. IOMMU needs some knowledge to check the PASID ownership, hence add an interface for those components to tell the PASID owner. In latest kernel design, PASID ownership is managed by IOASID set where the PASID is allocated from. This patch adds support for setting ioasid set ID to the domains used for nesting/vSVA. Subsequent SVA operations will check the PASID against its IOASID set for proper ownership. Cc: Kevin Tian <kevin.tian@intel.com> CC: Jacob Pan <jacob.jun.pan@linux.intel.com> Cc: Alex Williamson <alex.williamson@redhat.com> Cc: Eric Auger <eric.auger@redhat.com> Cc: Jean-Philippe Brucker <jean-philippe@linaro.org> Cc: Joerg Roedel <joro@8bytes.org> Cc: Lu Baolu <baolu.lu@linux.intel.com> Signed-off-by: Liu Yi L <yi.l.liu@intel.com> Signed-off-by: Jacob Pan <jacob.jun.pan@linux.intel.com> --- v5 -> v6: *) address comments against v5 from Eric Auger. v4 -> v5: *) address comments from Eric Auger. --- drivers/iommu/intel/iommu.c | 23 +++++++++++++++++++++++ include/linux/intel-iommu.h | 4 ++++ include/linux/iommu.h | 1 + 3 files changed, 28 insertions(+) diff --git a/drivers/iommu/intel/iommu.c b/drivers/iommu/intel/iommu.c index ed4b71c..b2fe54e 100644 --- a/drivers/iommu/intel/iommu.c +++ b/drivers/iommu/intel/iommu.c @@ -1793,6 +1793,7 @@ static struct dmar_domain *alloc_domain(int flags) if (first_level_by_default()) domain->flags |= DOMAIN_FLAG_USE_FIRST_LEVEL; domain->has_iotlb_device = false; + domain->ioasid_sid = INVALID_IOASID_SET; INIT_LIST_HEAD(&domain->devices); return domain; @@ -6040,6 +6041,28 @@ intel_iommu_domain_set_attr(struct iommu_domain *domain, } spin_unlock_irqrestore(&device_domain_lock, flags); break; + case DOMAIN_ATTR_IOASID_SID: + { + int sid = *(int *)data; + + spin_lock_irqsave(&device_domain_lock, flags); + if (!(dmar_domain->flags & DOMAIN_FLAG_NESTING_MODE)) { + ret = -ENODEV; + spin_unlock_irqrestore(&device_domain_lock, flags); + break; + } + if (dmar_domain->ioasid_sid != INVALID_IOASID_SET && + dmar_domain->ioasid_sid != sid) { + pr_warn_ratelimited("multi ioasid_set (%d:%d) setting", + dmar_domain->ioasid_sid, sid); + ret = -EBUSY; + spin_unlock_irqrestore(&device_domain_lock, flags); + break; + } + dmar_domain->ioasid_sid = sid; + spin_unlock_irqrestore(&device_domain_lock, flags); + break; + } default: ret = -EINVAL; break; diff --git a/include/linux/intel-iommu.h b/include/linux/intel-iommu.h index 3f23c26..0d0ab32 100644 --- a/include/linux/intel-iommu.h +++ b/include/linux/intel-iommu.h @@ -549,6 +549,10 @@ struct dmar_domain { 2 == 1GiB, 3 == 512GiB, 4 == 1TiB */ u64 max_addr; /* maximum mapped address */ + int ioasid_sid; /* + * the ioasid set which tracks all + * PASIDs used by the domain. + */ int default_pasid; /* * The default pasid used for non-SVM * traffic on mediated devices. diff --git a/include/linux/iommu.h b/include/linux/iommu.h index 4a02c9e..b1ff702 100644 --- a/include/linux/iommu.h +++ b/include/linux/iommu.h @@ -124,6 +124,7 @@ enum iommu_attr { DOMAIN_ATTR_FSL_PAMUV1, DOMAIN_ATTR_NESTING, /* two stages of translation */ DOMAIN_ATTR_DMA_USE_FLUSH_QUEUE, + DOMAIN_ATTR_IOASID_SID, DOMAIN_ATTR_MAX, }; -- 2.7.4 _______________________________________________ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu
next prev parent reply other threads:[~2020-07-28 6:22 UTC|newest] Thread overview: 114+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-07-28 6:27 [PATCH v6 00/15] vfio: expose virtual Shared Virtual Addressing to VMs Liu Yi L 2020-07-28 6:27 ` Liu Yi L 2020-07-28 6:27 ` [PATCH v6 01/15] vfio/type1: Refactor vfio_iommu_type1_ioctl() Liu Yi L 2020-07-28 6:27 ` Liu Yi L 2020-07-28 15:53 ` Alex Williamson 2020-07-28 15:53 ` Alex Williamson 2020-07-29 2:20 ` Liu, Yi L 2020-07-29 2:20 ` Liu, Yi L 2020-07-28 6:27 ` [PATCH v6 02/15] iommu: Report domain nesting info Liu Yi L 2020-07-28 6:27 ` Liu Yi L 2020-08-13 12:52 ` Auger Eric 2020-08-13 12:52 ` Auger Eric 2020-08-14 7:15 ` Liu, Yi L 2020-08-14 7:15 ` Liu, Yi L 2020-08-16 12:40 ` Auger Eric 2020-08-16 12:40 ` Auger Eric 2020-08-18 4:21 ` Jacob Pan 2020-08-18 4:21 ` Jacob Pan 2020-08-18 6:59 ` Auger Eric 2020-08-18 6:59 ` Auger Eric 2020-07-28 6:27 ` [PATCH v6 03/15] iommu/smmu: Report empty " Liu Yi L 2020-07-28 6:27 ` Liu Yi L 2020-07-28 6:27 ` [PATCH v6 04/15] vfio/type1: Report iommu nesting info to userspace Liu Yi L 2020-07-28 6:27 ` Liu Yi L 2020-08-13 13:19 ` Auger Eric 2020-08-13 13:19 ` Auger Eric 2020-08-14 7:36 ` Liu, Yi L 2020-08-14 7:36 ` Liu, Yi L 2020-08-20 19:52 ` Alex Williamson 2020-08-20 19:52 ` Alex Williamson 2020-08-21 0:52 ` Liu, Yi L 2020-08-21 0:52 ` Liu, Yi L 2020-07-28 6:27 ` [PATCH v6 05/15] vfio: Add PASID allocation/free support Liu Yi L 2020-07-28 6:27 ` Liu Yi L 2020-08-13 15:07 ` Auger Eric 2020-08-13 15:07 ` Auger Eric 2020-08-14 7:40 ` Liu, Yi L 2020-08-14 7:40 ` Liu, Yi L 2020-07-28 6:27 ` Liu Yi L [this message] 2020-07-28 6:27 ` [PATCH v6 06/15] iommu/vt-d: Support setting ioasid set to domain Liu Yi L 2020-08-13 15:06 ` Auger Eric 2020-08-13 15:06 ` Auger Eric 2020-08-14 8:04 ` Liu, Yi L 2020-08-14 8:04 ` Liu, Yi L 2020-08-16 12:42 ` Auger Eric 2020-08-16 12:42 ` Auger Eric 2020-07-28 6:27 ` [PATCH v6 07/15] vfio/type1: Add VFIO_IOMMU_PASID_REQUEST (alloc/free) Liu Yi L 2020-07-28 6:27 ` Liu Yi L 2020-08-15 16:30 ` Auger Eric 2020-08-15 16:30 ` Auger Eric 2020-08-17 5:23 ` Liu, Yi L 2020-08-17 5:23 ` Liu, Yi L 2020-08-20 20:51 ` Alex Williamson 2020-08-20 20:51 ` Alex Williamson 2020-08-21 0:37 ` Liu, Yi L 2020-08-21 0:37 ` Liu, Yi L 2020-08-21 1:49 ` Alex Williamson 2020-08-21 1:49 ` Alex Williamson 2020-08-21 2:18 ` Liu, Yi L 2020-08-21 2:18 ` Liu, Yi L 2020-07-28 6:27 ` [PATCH v6 08/15] iommu: Pass domain to sva_unbind_gpasid() Liu Yi L 2020-07-28 6:27 ` Liu Yi L 2020-08-20 21:06 ` Alex Williamson 2020-08-20 21:06 ` Alex Williamson 2020-08-21 0:18 ` Liu, Yi L 2020-08-21 0:18 ` Liu, Yi L 2020-08-21 13:09 ` Auger Eric 2020-08-21 13:09 ` Auger Eric 2020-07-28 6:27 ` [PATCH v6 09/15] iommu/vt-d: Check ownership for PASIDs from user-space Liu Yi L 2020-07-28 6:27 ` Liu Yi L 2020-08-15 16:30 ` Auger Eric 2020-08-15 16:30 ` Auger Eric 2020-08-17 5:38 ` Liu, Yi L 2020-08-17 5:38 ` Liu, Yi L 2020-07-28 6:27 ` [PATCH v6 10/15] vfio/type1: Support binding guest page tables to PASID Liu Yi L 2020-07-28 6:27 ` Liu Yi L 2020-08-16 11:29 ` Auger Eric 2020-08-16 11:29 ` Auger Eric 2020-08-17 6:30 ` Liu, Yi L 2020-08-17 6:30 ` Liu, Yi L 2020-07-28 6:27 ` [PATCH v6 11/15] vfio/type1: Allow invalidating first-level/stage IOMMU cache Liu Yi L 2020-07-28 6:27 ` Liu Yi L 2020-08-16 11:35 ` Auger Eric 2020-08-16 11:35 ` Auger Eric 2020-08-17 6:30 ` Liu, Yi L 2020-08-17 6:30 ` Liu, Yi L 2020-07-28 6:27 ` [PATCH v6 12/15] vfio/type1: Add vSVA support for IOMMU-backed mdevs Liu Yi L 2020-07-28 6:27 ` Liu Yi L 2020-08-20 21:48 ` Alex Williamson 2020-08-20 21:48 ` Alex Williamson 2020-08-21 0:53 ` Liu, Yi L 2020-08-21 0:53 ` Liu, Yi L 2020-07-28 6:27 ` [PATCH v6 13/15] vfio/pci: Expose PCIe PASID capability to guest Liu Yi L 2020-07-28 6:27 ` Liu Yi L 2020-07-28 6:27 ` [PATCH v6 14/15] vfio: Document dual stage control Liu Yi L 2020-07-28 6:27 ` Liu Yi L 2020-08-16 11:51 ` Auger Eric 2020-08-16 11:51 ` Auger Eric 2020-08-17 7:00 ` Liu, Yi L 2020-08-17 7:00 ` Liu, Yi L 2020-08-17 7:40 ` Eric Auger 2020-08-17 7:40 ` Eric Auger 2020-08-17 7:43 ` Liu, Yi L 2020-08-17 7:43 ` Liu, Yi L 2020-07-28 6:27 ` [PATCH v6 15/15] iommu/vt-d: Support reporting nesting capability info Liu Yi L 2020-07-28 6:27 ` Liu Yi L 2020-08-16 12:01 ` Auger Eric 2020-08-16 12:01 ` Auger Eric 2020-08-17 7:05 ` Liu, Yi L 2020-08-17 7:05 ` Liu, Yi L 2020-08-17 7:42 ` Auger Eric 2020-08-17 7:42 ` Auger Eric 2020-08-17 7:45 ` Liu, Yi L 2020-08-17 7:45 ` Liu, Yi L
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1595917664-33276-7-git-send-email-yi.l.liu@intel.com \ --to=yi.l.liu@intel.com \ --cc=alex.williamson@redhat.com \ --cc=ashok.raj@intel.com \ --cc=baolu.lu@linux.intel.com \ --cc=eric.auger@redhat.com \ --cc=hao.wu@intel.com \ --cc=iommu@lists.linux-foundation.org \ --cc=jacob.jun.pan@linux.intel.com \ --cc=jean-philippe@linaro.org \ --cc=joro@8bytes.org \ --cc=jun.j.tian@intel.com \ --cc=kevin.tian@intel.com \ --cc=kvm@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=peterx@redhat.com \ --cc=stefanha@gmail.com \ --cc=yi.y.sun@intel.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.