From: "Jernej Škrabec" <jernej.skrabec@siol.net>
To: linux-sunxi@googlegroups.com, laurent.pinchart@ideasonboard.com
Cc: maxime.ripard@bootlin.com, wens@csie.org, robh+dt@kernel.org,
sboyd@kernel.org, airlied@linux.ie, architt@codeaurora.org,
a.hajda@samsung.com, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org,
dri-devel@lists.freedesktop.org
Subject: Re: [linux-sunxi] Re: [PATCH v2 15/29] drm/bridge/synopsys: dw-hdmi: Enable workaround for v2.12a
Date: Mon, 15 Oct 2018 19:43:44 +0200 [thread overview]
Message-ID: <1599508.L0GctDr0rS@jernej-laptop> (raw)
In-Reply-To: <3616158.EzHeIcd69b@avalon>
Hi,
Dne torek, 09. oktober 2018 ob 19:40:44 CEST je Laurent Pinchart napisal(a):
> Hi Jernej,
>
> Thank you for the patch.
>
> On Sunday, 7 October 2018 12:38:51 EEST Jernej Skrabec wrote:
> > It turns out that even new DW HDMI controllers exhibits same magenta
> > line issues as older versions.
> >
> > Enable workaround for v2.12a.
>
> This doesn't affect the platforms I maintain, so I can't really test this,
> but I'm wondering whether there could be other platforms using a v2.12a DW
> HDMI that wouldn't need the workaround.
>
> My platforms use a previous version, namely v2.01a. The workaround for that
> version has been enabled by
>
> commit 9c305eb442f3b371fc722ade827bbf673514123e
> Author: Neil Armstrong <narmstrong@baylibre.com>
> Date: Fri Feb 23 12:44:37 2018 +0100
>
> drm: bridge: dw-hdmi: Fix overflow workaround for Amlogic Meson GX SoCs
>
> I haven't paid too much attention to the patch back then, and have now
> double- checked the HDMI output on R-Car Gen3. Enabling the workaround
> doesn't cause any regression, and reverting the commit doesn't cause any
> issue either. I thus wonder whether we shouldn't enable the workaround with
> count = 1 in the default case instead of adding new IP core versions to the
> list. It would be nice if someone from Synopsys could comment on this.
I was thinking about that too, or even having parameter in dw_hdmi_plat_data
which would tell how many times to repeat workaround procedure for a specific
platform. But this might be an overkill.
Best regards,
Jernej
>
> > Reviewed-by: Chen-Yu Tsai <wens@csie.org>
> > Signed-off-by: Jernej Skrabec <jernej.skrabec@siol.net>
> > ---
> >
> > drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c
> > b/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c index
> > 5971976284bf..df1c7a2d6961 100644
> > --- a/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c
> > +++ b/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c
> > @@ -1664,6 +1664,7 @@ static void dw_hdmi_clear_overflow(struct dw_hdmi
> >
> > *hdmi) case 0x131a:
> > case 0x132a:
> >
> > case 0x201a:
> > + case 0x212a:
> > count = 1;
> > break;
> >
> > default:
WARNING: multiple messages have this Message-ID (diff)
From: "Jernej Škrabec" <jernej.skrabec-gGgVlfcn5nU@public.gmane.org>
To: linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org,
laurent.pinchart-ryLnwIuWjnjg/C1BVhZhaw@public.gmane.org
Cc: maxime.ripard-LDxbnhwyfcJBDgjK7y7TUQ@public.gmane.org,
wens-jdAy2FN1RRM@public.gmane.org,
robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
sboyd-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
airlied-cv59FeDIM0c@public.gmane.org,
architt-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org,
a.hajda-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-clk-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org
Subject: Re: Re: [PATCH v2 15/29] drm/bridge/synopsys: dw-hdmi: Enable workaround for v2.12a
Date: Mon, 15 Oct 2018 19:43:44 +0200 [thread overview]
Message-ID: <1599508.L0GctDr0rS@jernej-laptop> (raw)
In-Reply-To: <3616158.EzHeIcd69b@avalon>
Hi,
Dne torek, 09. oktober 2018 ob 19:40:44 CEST je Laurent Pinchart napisal(a):
> Hi Jernej,
>
> Thank you for the patch.
>
> On Sunday, 7 October 2018 12:38:51 EEST Jernej Skrabec wrote:
> > It turns out that even new DW HDMI controllers exhibits same magenta
> > line issues as older versions.
> >
> > Enable workaround for v2.12a.
>
> This doesn't affect the platforms I maintain, so I can't really test this,
> but I'm wondering whether there could be other platforms using a v2.12a DW
> HDMI that wouldn't need the workaround.
>
> My platforms use a previous version, namely v2.01a. The workaround for that
> version has been enabled by
>
> commit 9c305eb442f3b371fc722ade827bbf673514123e
> Author: Neil Armstrong <narmstrong-rdvid1DuHRBWk0Htik3J/w@public.gmane.org>
> Date: Fri Feb 23 12:44:37 2018 +0100
>
> drm: bridge: dw-hdmi: Fix overflow workaround for Amlogic Meson GX SoCs
>
> I haven't paid too much attention to the patch back then, and have now
> double- checked the HDMI output on R-Car Gen3. Enabling the workaround
> doesn't cause any regression, and reverting the commit doesn't cause any
> issue either. I thus wonder whether we shouldn't enable the workaround with
> count = 1 in the default case instead of adding new IP core versions to the
> list. It would be nice if someone from Synopsys could comment on this.
I was thinking about that too, or even having parameter in dw_hdmi_plat_data
which would tell how many times to repeat workaround procedure for a specific
platform. But this might be an overkill.
Best regards,
Jernej
>
> > Reviewed-by: Chen-Yu Tsai <wens-jdAy2FN1RRM@public.gmane.org>
> > Signed-off-by: Jernej Skrabec <jernej.skrabec-gGgVlfcn5nU@public.gmane.org>
> > ---
> >
> > drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c
> > b/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c index
> > 5971976284bf..df1c7a2d6961 100644
> > --- a/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c
> > +++ b/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c
> > @@ -1664,6 +1664,7 @@ static void dw_hdmi_clear_overflow(struct dw_hdmi
> >
> > *hdmi) case 0x131a:
> > case 0x132a:
> >
> > case 0x201a:
> > + case 0x212a:
> > count = 1;
> > break;
> >
> > default:
WARNING: multiple messages have this Message-ID (diff)
From: jernej.skrabec@siol.net (Jernej Škrabec)
To: linux-arm-kernel@lists.infradead.org
Subject: [linux-sunxi] Re: [PATCH v2 15/29] drm/bridge/synopsys: dw-hdmi: Enable workaround for v2.12a
Date: Mon, 15 Oct 2018 19:43:44 +0200 [thread overview]
Message-ID: <1599508.L0GctDr0rS@jernej-laptop> (raw)
In-Reply-To: <3616158.EzHeIcd69b@avalon>
Hi,
Dne torek, 09. oktober 2018 ob 19:40:44 CEST je Laurent Pinchart napisal(a):
> Hi Jernej,
>
> Thank you for the patch.
>
> On Sunday, 7 October 2018 12:38:51 EEST Jernej Skrabec wrote:
> > It turns out that even new DW HDMI controllers exhibits same magenta
> > line issues as older versions.
> >
> > Enable workaround for v2.12a.
>
> This doesn't affect the platforms I maintain, so I can't really test this,
> but I'm wondering whether there could be other platforms using a v2.12a DW
> HDMI that wouldn't need the workaround.
>
> My platforms use a previous version, namely v2.01a. The workaround for that
> version has been enabled by
>
> commit 9c305eb442f3b371fc722ade827bbf673514123e
> Author: Neil Armstrong <narmstrong@baylibre.com>
> Date: Fri Feb 23 12:44:37 2018 +0100
>
> drm: bridge: dw-hdmi: Fix overflow workaround for Amlogic Meson GX SoCs
>
> I haven't paid too much attention to the patch back then, and have now
> double- checked the HDMI output on R-Car Gen3. Enabling the workaround
> doesn't cause any regression, and reverting the commit doesn't cause any
> issue either. I thus wonder whether we shouldn't enable the workaround with
> count = 1 in the default case instead of adding new IP core versions to the
> list. It would be nice if someone from Synopsys could comment on this.
I was thinking about that too, or even having parameter in dw_hdmi_plat_data
which would tell how many times to repeat workaround procedure for a specific
platform. But this might be an overkill.
Best regards,
Jernej
>
> > Reviewed-by: Chen-Yu Tsai <wens@csie.org>
> > Signed-off-by: Jernej Skrabec <jernej.skrabec@siol.net>
> > ---
> >
> > drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c
> > b/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c index
> > 5971976284bf..df1c7a2d6961 100644
> > --- a/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c
> > +++ b/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c
> > @@ -1664,6 +1664,7 @@ static void dw_hdmi_clear_overflow(struct dw_hdmi
> >
> > *hdmi) case 0x131a:
> > case 0x132a:
> >
> > case 0x201a:
> > + case 0x212a:
> > count = 1;
> > break;
> >
> > default:
next prev parent reply other threads:[~2018-10-15 17:43 UTC|newest]
Thread overview: 155+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-07 9:38 [PATCH v2 00/29] Allwinner H6 DE3 and HDMI support Jernej Skrabec
2018-10-07 9:38 ` Jernej Skrabec
2018-10-07 9:38 ` Jernej Skrabec
2018-10-07 9:38 ` [PATCH v2 01/29] dt-bindings: bus: add H6 DE3 bus binding Jernej Skrabec
2018-10-07 9:38 ` Jernej Skrabec
2018-10-07 9:38 ` Jernej Skrabec
2018-10-08 8:31 ` Maxime Ripard
2018-10-08 8:31 ` Maxime Ripard
2018-10-08 8:31 ` Maxime Ripard
2018-10-08 14:25 ` Jernej Škrabec
2018-10-08 14:25 ` Jernej Škrabec
2018-10-08 14:25 ` Jernej Škrabec
2018-10-07 9:38 ` [PATCH v2 02/29] clk: sunxi-ng: Adjust MP clock parent rate when allowed Jernej Skrabec
2018-10-07 9:38 ` Jernej Skrabec
2018-10-07 9:38 ` Jernej Skrabec
2018-10-07 9:38 ` [PATCH v2 03/29] clk: sunxi-ng: Use u64 for calculation of NM rate Jernej Skrabec
2018-10-07 9:38 ` Jernej Skrabec
2018-10-07 9:38 ` Jernej Skrabec
2018-10-07 9:38 ` [PATCH v2 04/29] clk: sunxi-ng: h6: Set video PLLs limits Jernej Skrabec
2018-10-07 9:38 ` Jernej Skrabec
2018-10-07 9:38 ` Jernej Skrabec
2018-10-12 8:13 ` [linux-sunxi] " Jagan Teki
2018-10-12 8:13 ` Jagan Teki
2018-10-12 8:13 ` Jagan Teki
2018-10-12 9:03 ` [linux-sunxi] " Chen-Yu Tsai
2018-10-12 9:03 ` Chen-Yu Tsai
2018-10-12 9:03 ` Chen-Yu Tsai
2018-10-07 9:38 ` [PATCH v2 05/29] dt-bindings: clock: sun8i-de2: Add H6 DE3 clock description Jernej Skrabec
2018-10-07 9:38 ` Jernej Skrabec
2018-10-07 9:38 ` Jernej Skrabec
2018-10-07 9:38 ` [PATCH v2 06/29] clk: sunxi-ng: Add support for H6 DE3 clocks Jernej Skrabec
2018-10-07 9:38 ` Jernej Skrabec
2018-10-07 9:38 ` Jernej Skrabec
2018-10-07 9:38 ` [PATCH v2 07/29] dt-bindings: display: sun4i-drm: Add H6 display engine compatibles Jernej Skrabec
2018-10-07 9:38 ` Jernej Skrabec
2018-10-07 9:38 ` Jernej Skrabec
2018-10-07 9:38 ` [PATCH v2 08/29] drm/sun4i: Add compatible for H6 display engine Jernej Skrabec
2018-10-07 9:38 ` Jernej Skrabec
2018-10-07 9:38 ` Jernej Skrabec
2018-10-07 9:38 ` [PATCH v2 09/29] drm/sun4i: Rework DE2 register defines Jernej Skrabec
2018-10-07 9:38 ` Jernej Skrabec
2018-10-07 9:38 ` Jernej Skrabec
2018-10-07 9:38 ` [PATCH v2 10/29] drm/sun4i: Rename DE2 registers related macros Jernej Skrabec
2018-10-07 9:38 ` Jernej Skrabec
2018-10-07 9:38 ` Jernej Skrabec
2018-10-08 10:18 ` Maxime Ripard
2018-10-08 10:18 ` Maxime Ripard
2018-10-08 10:18 ` Maxime Ripard
2018-10-08 14:28 ` Jernej Škrabec
2018-10-08 14:28 ` Jernej Škrabec
2018-10-08 14:28 ` Jernej Škrabec
2018-10-09 15:53 ` Maxime Ripard
2018-10-09 15:53 ` Maxime Ripard
2018-10-09 15:53 ` Maxime Ripard
2018-10-07 9:38 ` [PATCH v2 11/29] drm/sun4i: Fix DE2 mixer size Jernej Skrabec
2018-10-07 9:38 ` Jernej Skrabec
2018-10-07 9:38 ` Jernej Skrabec
2018-10-07 9:38 ` [PATCH v2 12/29] drm/sun4i: Disable unused DE2 sub-engines Jernej Skrabec
2018-10-07 9:38 ` Jernej Skrabec
2018-10-07 9:38 ` Jernej Skrabec
2018-10-07 9:38 ` [PATCH v2 13/29] drm/sun4i: Add basic support for DE3 Jernej Skrabec
2018-10-07 9:38 ` Jernej Skrabec
2018-10-07 9:38 ` Jernej Skrabec
2018-10-07 9:38 ` [PATCH v2 14/29] drm/sun4i: Add support for H6 DE3 mixer 0 Jernej Skrabec
2018-10-07 9:38 ` Jernej Skrabec
2018-10-07 9:38 ` Jernej Skrabec
2018-10-07 9:38 ` [PATCH v2 15/29] drm/bridge/synopsys: dw-hdmi: Enable workaround for v2.12a Jernej Skrabec
2018-10-07 9:38 ` Jernej Skrabec
2018-10-07 9:38 ` Jernej Skrabec
2018-10-09 17:40 ` Laurent Pinchart
2018-10-09 17:40 ` Laurent Pinchart
2018-10-09 17:40 ` Laurent Pinchart
2018-10-09 17:56 ` Ilia Mirkin
2018-10-09 17:56 ` Ilia Mirkin
2018-10-09 17:56 ` Ilia Mirkin
2018-10-09 21:23 ` Russell King - ARM Linux
2018-10-09 21:23 ` Russell King - ARM Linux
2018-10-15 17:43 ` Jernej Škrabec [this message]
2018-10-15 17:43 ` [linux-sunxi] " Jernej Škrabec
2018-10-15 17:43 ` Jernej Škrabec
2018-10-07 9:38 ` [PATCH v2 16/29] drm/sun4i: Not all DW HDMI controllers has scrambled addresses Jernej Skrabec
2018-10-07 9:38 ` Jernej Skrabec
2018-10-07 9:38 ` Jernej Skrabec
2018-10-07 9:38 ` [PATCH v2 17/29] drm/sun4i: dw-hdmi: Make mode_valid function configurable Jernej Skrabec
2018-10-07 9:38 ` Jernej Skrabec
2018-10-07 9:38 ` Jernej Skrabec
2018-10-07 9:38 ` [PATCH v2 18/29] drm/sun4i: dw-hdmi: Add quirk for setting TMDS clock Jernej Skrabec
2018-10-07 9:38 ` Jernej Skrabec
2018-10-07 9:38 ` Jernej Skrabec
2018-10-08 9:14 ` Maxime Ripard
2018-10-08 9:14 ` Maxime Ripard
2018-10-08 9:14 ` Maxime Ripard
2018-10-08 15:09 ` Jernej Škrabec
2018-10-08 15:09 ` Jernej Škrabec
2018-10-08 15:09 ` Jernej Škrabec
2018-10-09 9:14 ` Maxime Ripard
2018-10-09 9:14 ` Maxime Ripard
2018-10-09 9:14 ` Maxime Ripard
2018-10-07 9:38 ` [PATCH v2 19/29] dt-bindings: display: sunxi: add DT binding for Allwinner H6 DW HDMI Jernej Skrabec
2018-10-07 9:38 ` Jernej Skrabec
2018-10-07 9:38 ` Jernej Skrabec
2018-10-07 9:38 ` [PATCH v2 20/29] drm/sun4i: Add support for H6 DW HDMI controller Jernej Skrabec
2018-10-07 9:38 ` Jernej Skrabec
2018-10-07 9:38 ` Jernej Skrabec
2018-10-07 9:38 ` [PATCH v2 21/29] drm/sun4i: dw-hdmi-phy: Reorder quirks by family Jernej Skrabec
2018-10-07 9:38 ` Jernej Skrabec
2018-10-07 9:38 ` Jernej Skrabec
2018-10-07 9:38 ` [PATCH v2 22/29] drm/sun4i: Add support for Synopsys HDMI PHY Jernej Skrabec
2018-10-07 9:38 ` Jernej Skrabec
2018-10-07 9:38 ` Jernej Skrabec
2018-10-07 9:38 ` [PATCH v2 23/29] drm/sun4i: Add support for H6 " Jernej Skrabec
2018-10-07 9:38 ` Jernej Skrabec
2018-10-07 9:38 ` Jernej Skrabec
2018-10-07 9:39 ` [PATCH v2 24/29] drm/sun4i: Initialize registers in tcon-top driver Jernej Skrabec
2018-10-07 9:39 ` Jernej Skrabec
2018-10-07 9:39 ` Jernej Skrabec
2018-10-07 9:39 ` [PATCH v2 25/29] drm: sun4i: add quirks for TCON TOP Jernej Skrabec
2018-10-07 9:39 ` Jernej Skrabec
2018-10-07 9:39 ` Jernej Skrabec
2018-10-08 8:51 ` Maxime Ripard
2018-10-08 8:51 ` Maxime Ripard
2018-10-08 8:51 ` Maxime Ripard
2018-10-08 9:06 ` Chen-Yu Tsai
2018-10-08 9:06 ` Chen-Yu Tsai
2018-10-08 9:06 ` Chen-Yu Tsai
2018-10-08 10:20 ` Maxime Ripard
2018-10-08 10:20 ` Maxime Ripard
2018-10-08 10:20 ` Maxime Ripard
2018-10-08 10:50 ` Chen-Yu Tsai
2018-10-08 10:50 ` Chen-Yu Tsai
2018-10-08 10:50 ` Chen-Yu Tsai
2018-10-08 12:33 ` Maxime Ripard
2018-10-08 12:33 ` Maxime Ripard
2018-10-08 12:33 ` Maxime Ripard
2018-10-08 13:10 ` Chen-Yu Tsai
2018-10-08 13:10 ` Chen-Yu Tsai
2018-10-08 13:10 ` Chen-Yu Tsai
2018-10-08 14:30 ` Jernej Škrabec
2018-10-08 14:30 ` Jernej Škrabec
2018-10-08 14:30 ` Jernej Škrabec
2018-10-07 9:39 ` [PATCH v2 26/29] dt-bindings: display: sun4i-drm: document H6 " Jernej Skrabec
2018-10-07 9:39 ` Jernej Skrabec
2018-10-07 9:39 ` Jernej Skrabec
2018-10-07 9:39 ` [PATCH v2 27/29] drm: sun4i: add support for " Jernej Skrabec
2018-10-07 9:39 ` Jernej Skrabec
2018-10-07 9:39 ` Jernej Skrabec
2018-10-07 9:39 ` [PATCH v2 28/29] arm64: dts: allwinner: h6: Add HDMI pipeline Jernej Skrabec
2018-10-07 9:39 ` Jernej Skrabec
2018-10-07 9:39 ` Jernej Skrabec
2018-10-07 9:39 ` [PATCH v2 29/29] arm64: dts: allwinner: h6: Enable HDMI output on Pine H64 board Jernej Skrabec
2018-10-07 9:39 ` Jernej Skrabec
2018-10-07 9:39 ` Jernej Skrabec
2018-10-07 9:50 ` [linux-sunxi] [PATCH v2 00/29] Allwinner H6 DE3 and HDMI support Jernej Škrabec
2018-10-07 9:50 ` Jernej Škrabec
2018-10-07 9:50 ` Jernej Škrabec
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1599508.L0GctDr0rS@jernej-laptop \
--to=jernej.skrabec@siol.net \
--cc=a.hajda@samsung.com \
--cc=airlied@linux.ie \
--cc=architt@codeaurora.org \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sunxi@googlegroups.com \
--cc=maxime.ripard@bootlin.com \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.