From: Stephen Smalley <stephen.smalley.work@gmail.com>
To: Casey Schaufler <casey@schaufler-ca.com>,
casey.schaufler@intel.com, jmorris@namei.org,
linux-security-module@vger.kernel.org, selinux@vger.kernel.org
Cc: john.johansen@canonical.com, linux-audit@redhat.com, sds@tycho.nsa.gov
Subject: Re: [PATCH v19 20/23] Audit: Add new record for multiple process LSM attributes
Date: Mon, 27 Jul 2020 15:04:19 -0400 [thread overview]
Message-ID: <15b96494-c4ca-bf2f-0158-d28183d51aef@gmail.com> (raw)
In-Reply-To: <20200724203226.16374-21-casey@schaufler-ca.com>
On 7/24/20 4:32 PM, Casey Schaufler wrote:
> Create a new audit record type to contain the subject information
> when there are multiple security modules that require such data.
> This record is linked with the same timestamp and serial number.
> The record is produced only in cases where there is more than one
> security module with a process "context".
>
> Before this change the only audit events that required multiple
> records were syscall events. Several non-syscall events include
> subject contexts, so the use of audit_context data has been expanded
> as necessary.
>
> Signed-off-by: Casey Schaufler <casey@schaufler-ca.com>
> Cc: linux-audit@redhat.com
> ---
> diff --git a/include/net/xfrm.h b/include/net/xfrm.h
> index c7d213c9f9d8..930432c3912e 100644
> --- a/include/net/xfrm.h
> +++ b/include/net/xfrm.h
> @@ -672,11 +672,13 @@ static inline struct audit_buffer *xfrm_audit_start(const char *op)
>
> if (audit_enabled == AUDIT_OFF)
> return NULL;
> + audit_stamp_context(audit_context());
> audit_buf = audit_log_start(audit_context(), GFP_ATOMIC,
> AUDIT_MAC_IPSEC_EVENT);
> if (audit_buf == NULL)
> return NULL;
> audit_log_format(audit_buf, "op=%s", op);
> + audit_log_lsm(NULL, false);
Notice that the audit_log_start() call above specified GFP_ATOMIC. But
your audit_log_lsm() uses GFP_KERNEL. You'll either need to always use
GFP_ATOMIC in audit_log_lsm() or pass in the gfp flags there. Make sure
you test with CONFIG_DEBUG_ATOMIC_SLEEP=y and check your dmesg output.
WARNING: multiple messages have this Message-ID (diff)
From: Stephen Smalley <stephen.smalley.work@gmail.com>
To: Casey Schaufler <casey@schaufler-ca.com>,
casey.schaufler@intel.com, jmorris@namei.org,
linux-security-module@vger.kernel.org, selinux@vger.kernel.org
Cc: john.johansen@canonical.com, sds@tycho.nsa.gov, linux-audit@redhat.com
Subject: Re: [PATCH v19 20/23] Audit: Add new record for multiple process LSM attributes
Date: Mon, 27 Jul 2020 15:04:19 -0400 [thread overview]
Message-ID: <15b96494-c4ca-bf2f-0158-d28183d51aef@gmail.com> (raw)
In-Reply-To: <20200724203226.16374-21-casey@schaufler-ca.com>
On 7/24/20 4:32 PM, Casey Schaufler wrote:
> Create a new audit record type to contain the subject information
> when there are multiple security modules that require such data.
> This record is linked with the same timestamp and serial number.
> The record is produced only in cases where there is more than one
> security module with a process "context".
>
> Before this change the only audit events that required multiple
> records were syscall events. Several non-syscall events include
> subject contexts, so the use of audit_context data has been expanded
> as necessary.
>
> Signed-off-by: Casey Schaufler <casey@schaufler-ca.com>
> Cc: linux-audit@redhat.com
> ---
> diff --git a/include/net/xfrm.h b/include/net/xfrm.h
> index c7d213c9f9d8..930432c3912e 100644
> --- a/include/net/xfrm.h
> +++ b/include/net/xfrm.h
> @@ -672,11 +672,13 @@ static inline struct audit_buffer *xfrm_audit_start(const char *op)
>
> if (audit_enabled == AUDIT_OFF)
> return NULL;
> + audit_stamp_context(audit_context());
> audit_buf = audit_log_start(audit_context(), GFP_ATOMIC,
> AUDIT_MAC_IPSEC_EVENT);
> if (audit_buf == NULL)
> return NULL;
> audit_log_format(audit_buf, "op=%s", op);
> + audit_log_lsm(NULL, false);
Notice that the audit_log_start() call above specified GFP_ATOMIC. But
your audit_log_lsm() uses GFP_KERNEL. You'll either need to always use
GFP_ATOMIC in audit_log_lsm() or pass in the gfp flags there. Make sure
you test with CONFIG_DEBUG_ATOMIC_SLEEP=y and check your dmesg output.
--
Linux-audit mailing list
Linux-audit@redhat.com
https://www.redhat.com/mailman/listinfo/linux-audit
next prev parent reply other threads:[~2020-07-27 19:04 UTC|newest]
Thread overview: 92+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20200724203226.16374-1-casey.ref@schaufler-ca.com>
2020-07-24 20:32 ` [PATCH v19 00/23] LSM: Module stacking for AppArmor Casey Schaufler
2020-07-24 20:32 ` Casey Schaufler
2020-07-24 20:32 ` [PATCH v19 01/23] LSM: Infrastructure management of the sock security Casey Schaufler
2020-07-24 20:32 ` Casey Schaufler
2020-07-24 20:32 ` [PATCH v19 02/23] LSM: Create and manage the lsmblob data structure Casey Schaufler
2020-07-24 20:32 ` Casey Schaufler
2020-07-27 16:12 ` Stephen Smalley
2020-07-27 16:12 ` Stephen Smalley
2020-07-27 21:04 ` Casey Schaufler
2020-07-27 21:04 ` Casey Schaufler
2020-07-28 19:50 ` John Johansen
2020-07-28 19:50 ` John Johansen
2020-07-24 20:32 ` [PATCH v19 03/23] LSM: Use lsmblob in security_audit_rule_match Casey Schaufler
2020-07-24 20:32 ` Casey Schaufler
2020-07-24 20:32 ` [PATCH v19 04/23] LSM: Use lsmblob in security_kernel_act_as Casey Schaufler
2020-07-24 20:32 ` Casey Schaufler
2020-07-28 10:34 ` John Johansen
2020-07-28 10:34 ` John Johansen
2020-07-24 20:32 ` [PATCH v19 05/23] net: Prepare UDS for security module stacking Casey Schaufler
2020-07-24 20:32 ` Casey Schaufler
2020-07-28 10:57 ` John Johansen
2020-07-28 10:57 ` John Johansen
2020-07-24 20:32 ` [PATCH v19 06/23] LSM: Use lsmblob in security_secctx_to_secid Casey Schaufler
2020-07-24 20:32 ` Casey Schaufler
2020-07-28 11:11 ` John Johansen
2020-07-28 11:11 ` John Johansen
2020-07-28 23:41 ` Casey Schaufler
2020-07-28 23:41 ` Casey Schaufler
2020-07-29 0:30 ` John Johansen
2020-07-29 0:30 ` John Johansen
2020-07-24 20:32 ` [PATCH v19 07/23] LSM: Use lsmblob in security_secid_to_secctx Casey Schaufler
2020-07-24 20:32 ` Casey Schaufler
2020-07-24 20:32 ` [PATCH v19 08/23] LSM: Use lsmblob in security_ipc_getsecid Casey Schaufler
2020-07-24 20:32 ` Casey Schaufler
2020-07-24 20:32 ` [PATCH v19 09/23] LSM: Use lsmblob in security_task_getsecid Casey Schaufler
2020-07-24 20:32 ` Casey Schaufler
2020-07-24 20:32 ` [PATCH v19 10/23] LSM: Use lsmblob in security_inode_getsecid Casey Schaufler
2020-07-24 20:32 ` Casey Schaufler
2020-07-24 20:32 ` [PATCH v19 11/23] LSM: Use lsmblob in security_cred_getsecid Casey Schaufler
2020-07-24 20:32 ` Casey Schaufler
2020-07-24 20:32 ` [PATCH v19 12/23] IMA: Change internal interfaces to use lsmblobs Casey Schaufler
2020-07-24 20:32 ` Casey Schaufler
2020-07-24 20:32 ` [PATCH v19 13/23] LSM: Specify which LSM to display Casey Schaufler
2020-07-24 20:32 ` Casey Schaufler
2020-07-27 20:36 ` James Morris
2020-07-27 20:36 ` James Morris
2020-07-27 20:40 ` John Johansen
2020-07-27 20:40 ` John Johansen
2020-07-28 18:29 ` John Johansen
2020-07-28 18:29 ` John Johansen
2020-07-24 20:32 ` [PATCH v19 14/23] LSM: Ensure the correct LSM context releaser Casey Schaufler
2020-07-24 20:32 ` Casey Schaufler
2020-07-24 20:32 ` [PATCH v19 15/23] LSM: Use lsmcontext in security_secid_to_secctx Casey Schaufler
2020-07-24 20:32 ` Casey Schaufler
2020-07-28 20:13 ` John Johansen
2020-07-28 20:13 ` John Johansen
2020-07-24 20:32 ` [PATCH v19 16/23] LSM: Use lsmcontext in security_inode_getsecctx Casey Schaufler
2020-07-24 20:32 ` Casey Schaufler
2020-07-28 20:28 ` John Johansen
2020-07-28 20:28 ` John Johansen
2020-07-24 20:32 ` [PATCH v19 17/23] LSM: security_secid_to_secctx in netlink netfilter Casey Schaufler
2020-07-24 20:32 ` Casey Schaufler
2020-07-27 20:37 ` James Morris
2020-07-27 20:37 ` James Morris
2020-07-24 20:32 ` [PATCH v19 18/23] NET: Store LSM netlabel data in a lsmblob Casey Schaufler
2020-07-24 20:32 ` Casey Schaufler
2020-07-24 20:32 ` [PATCH v19 19/23] LSM: Verify LSM display sanity in binder Casey Schaufler
2020-07-24 20:32 ` Casey Schaufler
2020-07-30 8:40 ` John Johansen
2020-07-30 8:40 ` John Johansen
2020-07-24 20:32 ` [PATCH v19 20/23] Audit: Add new record for multiple process LSM attributes Casey Schaufler
2020-07-24 20:32 ` Casey Schaufler
2020-07-27 19:04 ` Stephen Smalley [this message]
2020-07-27 19:04 ` Stephen Smalley
2020-07-24 20:32 ` [PATCH v19 21/23] Audit: Add a new record for multiple object " Casey Schaufler
2020-07-24 20:32 ` Casey Schaufler
2020-07-27 20:40 ` James Morris
2020-07-27 20:40 ` James Morris
2020-07-24 20:32 ` [PATCH v19 22/23] LSM: Add /proc attr entry for full LSM context Casey Schaufler
2020-07-24 20:32 ` Casey Schaufler
2020-07-30 10:03 ` John Johansen
2020-07-30 10:03 ` John Johansen
2020-07-30 20:44 ` Casey Schaufler
2020-07-30 20:44 ` Casey Schaufler
2020-07-30 20:57 ` John Johansen
2020-07-30 20:57 ` John Johansen
2020-07-30 22:22 ` Casey Schaufler
2020-07-30 22:22 ` Casey Schaufler
2020-07-24 20:32 ` [PATCH v19 23/23] AppArmor: Remove the exclusive flag Casey Schaufler
2020-07-24 20:32 ` Casey Schaufler
2020-07-30 9:23 ` John Johansen
2020-07-30 9:23 ` John Johansen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=15b96494-c4ca-bf2f-0158-d28183d51aef@gmail.com \
--to=stephen.smalley.work@gmail.com \
--cc=casey.schaufler@intel.com \
--cc=casey@schaufler-ca.com \
--cc=jmorris@namei.org \
--cc=john.johansen@canonical.com \
--cc=linux-audit@redhat.com \
--cc=linux-security-module@vger.kernel.org \
--cc=sds@tycho.nsa.gov \
--cc=selinux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.