From: Zenghui Yu <yuzenghui@huawei.com>
To: Auger Eric <eric.auger@redhat.com>
Cc: Marc Zyngier <maz@kernel.org>, <eric.auger.pro@gmail.com>,
<kvmarm@lists.cs.columbia.edu>, <kvm@vger.kernel.org>,
<qemu-devel@nongnu.org>, <qemu-arm@nongnu.org>,
<drjones@redhat.com>, <andre.przywara@arm.com>,
<peter.maydell@linaro.org>, <alexandru.elisei@arm.com>,
<thuth@redhat.com>
Subject: Re: [kvm-unit-tests PATCH v5 10/13] arm/arm64: ITS: INT functional tests
Date: Fri, 13 Mar 2020 09:55:29 +0800 [thread overview]
Message-ID: <160015aa-f5d7-2fdc-8d06-1322af241896@huawei.com> (raw)
In-Reply-To: <acc652b7-f331-1e48-160c-f07e0e5283b3@redhat.com>
Hi Eric,
On 2020/3/12 17:59, Auger Eric wrote:
> Hi Zenghui,
>
> On 3/12/20 10:19 AM, Zenghui Yu wrote:
>> On 2020/3/11 22:00, Marc Zyngier wrote:
>>> That is still a problem with the ITS. There is no architectural way
>>> to report an error, even if the error numbers are architected...
>>>
>>> One thing we could do though is to implement the stall model (as
>>> described
>>> in 5.3.2). It still doesn't give us the error, but at least the command
>>> queue would stop on detecting an error.
>>
>> It would be interesting to see the buggy guest's behavior under the
>> stall mode. I've used the following diff (absolutely *not* a formal
>> patch, don't handle CREADR.Stalled and CWRITER.Retry at all) to have
>> a try, and caught another command error in the 'its-trigger' test.
>>
>> logs/its-trigger.log:
>> " INT dev_id=2 event_id=20
>> lib/arm64/gic-v3-its-cmd.c:194: assert failed: false: INT timeout! "
>>
>> dmesg:
>> [13297.711958] ------------[ cut here ]------------
>> [13297.711964] ITS command error encoding 0x10307
>>
>> It's the last INT test in test_its_trigger() who has triggered this
>> error, Eric?
>
> Yes it may be the culprit. Anyway I removed the collection unmap in v6.
I forgot to mention that this is based on your v6. I'll reply to it.
>
> By the way are you OK now with v6? I think Drew plans to send a pull
> request by the end of this week.
Sorry I haven't looked at it yet (v5 already looks good except for
some minor issues).
Thanks,
Zenghui
WARNING: multiple messages have this Message-ID (diff)
From: Zenghui Yu <yuzenghui@huawei.com>
To: Auger Eric <eric.auger@redhat.com>
Cc: peter.maydell@linaro.org, drjones@redhat.com,
kvm@vger.kernel.org, Marc Zyngier <maz@kernel.org>,
qemu-devel@nongnu.org, qemu-arm@nongnu.org,
andre.przywara@arm.com, thuth@redhat.com,
alexandru.elisei@arm.com, kvmarm@lists.cs.columbia.edu,
eric.auger.pro@gmail.com
Subject: Re: [kvm-unit-tests PATCH v5 10/13] arm/arm64: ITS: INT functional tests
Date: Fri, 13 Mar 2020 09:55:29 +0800 [thread overview]
Message-ID: <160015aa-f5d7-2fdc-8d06-1322af241896@huawei.com> (raw)
In-Reply-To: <acc652b7-f331-1e48-160c-f07e0e5283b3@redhat.com>
Hi Eric,
On 2020/3/12 17:59, Auger Eric wrote:
> Hi Zenghui,
>
> On 3/12/20 10:19 AM, Zenghui Yu wrote:
>> On 2020/3/11 22:00, Marc Zyngier wrote:
>>> That is still a problem with the ITS. There is no architectural way
>>> to report an error, even if the error numbers are architected...
>>>
>>> One thing we could do though is to implement the stall model (as
>>> described
>>> in 5.3.2). It still doesn't give us the error, but at least the command
>>> queue would stop on detecting an error.
>>
>> It would be interesting to see the buggy guest's behavior under the
>> stall mode. I've used the following diff (absolutely *not* a formal
>> patch, don't handle CREADR.Stalled and CWRITER.Retry at all) to have
>> a try, and caught another command error in the 'its-trigger' test.
>>
>> logs/its-trigger.log:
>> " INT dev_id=2 event_id=20
>> lib/arm64/gic-v3-its-cmd.c:194: assert failed: false: INT timeout! "
>>
>> dmesg:
>> [13297.711958] ------------[ cut here ]------------
>> [13297.711964] ITS command error encoding 0x10307
>>
>> It's the last INT test in test_its_trigger() who has triggered this
>> error, Eric?
>
> Yes it may be the culprit. Anyway I removed the collection unmap in v6.
I forgot to mention that this is based on your v6. I'll reply to it.
>
> By the way are you OK now with v6? I think Drew plans to send a pull
> request by the end of this week.
Sorry I haven't looked at it yet (v5 already looks good except for
some minor issues).
Thanks,
Zenghui
WARNING: multiple messages have this Message-ID (diff)
From: Zenghui Yu <yuzenghui@huawei.com>
To: Auger Eric <eric.auger@redhat.com>
Cc: kvm@vger.kernel.org, Marc Zyngier <maz@kernel.org>,
qemu-devel@nongnu.org, qemu-arm@nongnu.org,
andre.przywara@arm.com, thuth@redhat.com,
kvmarm@lists.cs.columbia.edu, eric.auger.pro@gmail.com
Subject: Re: [kvm-unit-tests PATCH v5 10/13] arm/arm64: ITS: INT functional tests
Date: Fri, 13 Mar 2020 09:55:29 +0800 [thread overview]
Message-ID: <160015aa-f5d7-2fdc-8d06-1322af241896@huawei.com> (raw)
In-Reply-To: <acc652b7-f331-1e48-160c-f07e0e5283b3@redhat.com>
Hi Eric,
On 2020/3/12 17:59, Auger Eric wrote:
> Hi Zenghui,
>
> On 3/12/20 10:19 AM, Zenghui Yu wrote:
>> On 2020/3/11 22:00, Marc Zyngier wrote:
>>> That is still a problem with the ITS. There is no architectural way
>>> to report an error, even if the error numbers are architected...
>>>
>>> One thing we could do though is to implement the stall model (as
>>> described
>>> in 5.3.2). It still doesn't give us the error, but at least the command
>>> queue would stop on detecting an error.
>>
>> It would be interesting to see the buggy guest's behavior under the
>> stall mode. I've used the following diff (absolutely *not* a formal
>> patch, don't handle CREADR.Stalled and CWRITER.Retry at all) to have
>> a try, and caught another command error in the 'its-trigger' test.
>>
>> logs/its-trigger.log:
>> " INT dev_id=2 event_id=20
>> lib/arm64/gic-v3-its-cmd.c:194: assert failed: false: INT timeout! "
>>
>> dmesg:
>> [13297.711958] ------------[ cut here ]------------
>> [13297.711964] ITS command error encoding 0x10307
>>
>> It's the last INT test in test_its_trigger() who has triggered this
>> error, Eric?
>
> Yes it may be the culprit. Anyway I removed the collection unmap in v6.
I forgot to mention that this is based on your v6. I'll reply to it.
>
> By the way are you OK now with v6? I think Drew plans to send a pull
> request by the end of this week.
Sorry I haven't looked at it yet (v5 already looks good except for
some minor issues).
Thanks,
Zenghui
_______________________________________________
kvmarm mailing list
kvmarm@lists.cs.columbia.edu
https://lists.cs.columbia.edu/mailman/listinfo/kvmarm
next prev parent reply other threads:[~2020-03-13 1:55 UTC|newest]
Thread overview: 83+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-10 14:53 [kvm-unit-tests PATCH v5 00/13] arm/arm64: Add ITS tests Eric Auger
2020-03-10 14:53 ` Eric Auger
2020-03-10 14:53 ` Eric Auger
2020-03-10 14:53 ` [kvm-unit-tests PATCH v5 01/13] libcflat: Add other size defines Eric Auger
2020-03-10 14:53 ` Eric Auger
2020-03-10 14:53 ` Eric Auger
2020-03-10 14:53 ` [kvm-unit-tests PATCH v5 02/13] page_alloc: Introduce get_order() Eric Auger
2020-03-10 14:53 ` Eric Auger
2020-03-10 14:53 ` Eric Auger
2020-03-10 14:54 ` [kvm-unit-tests PATCH v5 03/13] arm/arm64: gic: Introduce setup_irq() helper Eric Auger
2020-03-10 14:54 ` Eric Auger
2020-03-10 14:54 ` Eric Auger
2020-03-10 14:54 ` [kvm-unit-tests PATCH v5 04/13] arm/arm64: gicv3: Add some re-distributor defines Eric Auger
2020-03-10 14:54 ` Eric Auger
2020-03-10 14:54 ` Eric Auger
2020-03-10 14:54 ` [kvm-unit-tests PATCH v5 05/13] arm/arm64: gicv3: Set the LPI config and pending tables Eric Auger
2020-03-10 14:54 ` Eric Auger
2020-03-10 14:54 ` Eric Auger
2020-03-11 6:42 ` Zenghui Yu
2020-03-11 6:42 ` Zenghui Yu
2020-03-11 6:42 ` Zenghui Yu
2020-03-11 9:07 ` Auger Eric
2020-03-11 9:07 ` Auger Eric
2020-03-10 14:54 ` [kvm-unit-tests PATCH v5 06/13] arm/arm64: ITS: Introspection tests Eric Auger
2020-03-10 14:54 ` Eric Auger
2020-03-10 14:54 ` Eric Auger
2020-03-11 8:37 ` Zenghui Yu
2020-03-11 8:37 ` Zenghui Yu
2020-03-11 8:37 ` Zenghui Yu
2020-03-11 9:29 ` Auger Eric
2020-03-11 9:29 ` Auger Eric
2020-03-11 9:29 ` Auger Eric
2020-03-10 14:54 ` [kvm-unit-tests PATCH v5 07/13] arm/arm64: ITS: its_enable_defaults Eric Auger
2020-03-10 14:54 ` Eric Auger
2020-03-10 14:54 ` Eric Auger
2020-03-11 8:46 ` Zenghui Yu
2020-03-11 8:46 ` Zenghui Yu
2020-03-11 8:46 ` Zenghui Yu
2020-03-10 14:54 ` [kvm-unit-tests PATCH v5 08/13] arm/arm64: ITS: Device and collection Initialization Eric Auger
2020-03-10 14:54 ` Eric Auger
2020-03-10 14:54 ` Eric Auger
2020-03-10 14:54 ` [kvm-unit-tests PATCH v5 09/13] arm/arm64: ITS: Commands Eric Auger
2020-03-10 14:54 ` Eric Auger
2020-03-10 14:54 ` Eric Auger
2020-03-11 9:09 ` Zenghui Yu
2020-03-11 9:09 ` Zenghui Yu
2020-03-11 9:09 ` Zenghui Yu
2020-03-10 14:54 ` [kvm-unit-tests PATCH v5 10/13] arm/arm64: ITS: INT functional tests Eric Auger
2020-03-10 14:54 ` Eric Auger
2020-03-10 14:54 ` Eric Auger
2020-03-11 11:59 ` Zenghui Yu
2020-03-11 11:59 ` Zenghui Yu
2020-03-11 11:59 ` Zenghui Yu
2020-03-11 13:48 ` Auger Eric
2020-03-11 13:48 ` Auger Eric
2020-03-11 13:48 ` Auger Eric
2020-03-11 14:00 ` Marc Zyngier
2020-03-11 14:00 ` Marc Zyngier
2020-03-11 14:00 ` Marc Zyngier
2020-03-12 9:19 ` Zenghui Yu
2020-03-12 9:19 ` Zenghui Yu
2020-03-12 9:19 ` Zenghui Yu
2020-03-12 9:59 ` Auger Eric
2020-03-12 9:59 ` Auger Eric
2020-03-12 9:59 ` Auger Eric
2020-03-13 1:55 ` Zenghui Yu [this message]
2020-03-13 1:55 ` Zenghui Yu
2020-03-13 1:55 ` Zenghui Yu
2020-03-10 14:54 ` [kvm-unit-tests PATCH v5 11/13] arm/run: Allow Migration tests Eric Auger
2020-03-10 14:54 ` Eric Auger
2020-03-10 14:54 ` Eric Auger
2020-03-10 14:54 ` [kvm-unit-tests PATCH v5 12/13] arm/arm64: ITS: migration tests Eric Auger
2020-03-10 14:54 ` Eric Auger
2020-03-10 14:54 ` Eric Auger
2020-03-10 14:54 ` [kvm-unit-tests PATCH v5 13/13] arm/arm64: ITS: pending table migration test Eric Auger
2020-03-10 14:54 ` Eric Auger
2020-03-10 14:54 ` Eric Auger
2020-03-11 12:07 ` Zenghui Yu
2020-03-11 12:07 ` Zenghui Yu
2020-03-11 12:07 ` Zenghui Yu
2020-03-11 13:49 ` Auger Eric
2020-03-11 13:49 ` Auger Eric
2020-03-11 13:49 ` Auger Eric
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=160015aa-f5d7-2fdc-8d06-1322af241896@huawei.com \
--to=yuzenghui@huawei.com \
--cc=alexandru.elisei@arm.com \
--cc=andre.przywara@arm.com \
--cc=drjones@redhat.com \
--cc=eric.auger.pro@gmail.com \
--cc=eric.auger@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=kvmarm@lists.cs.columbia.edu \
--cc=maz@kernel.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.