From: Auger Eric <eric.auger@redhat.com>
To: Zenghui Yu <yuzenghui@huawei.com>,
eric.auger.pro@gmail.com, maz@kernel.org,
kvmarm@lists.cs.columbia.edu, kvm@vger.kernel.org,
qemu-devel@nongnu.org, qemu-arm@nongnu.org
Cc: drjones@redhat.com, andre.przywara@arm.com,
peter.maydell@linaro.org, alexandru.elisei@arm.com,
thuth@redhat.com
Subject: Re: [kvm-unit-tests PATCH v5 06/13] arm/arm64: ITS: Introspection tests
Date: Wed, 11 Mar 2020 10:29:36 +0100 [thread overview]
Message-ID: <7fc207fe-b761-6d24-0c14-896154023420@redhat.com> (raw)
In-Reply-To: <83ffda30-e0dc-7fbf-1775-bc45a308acb4@huawei.com>
Hi Zenghui,
On 3/11/20 9:37 AM, Zenghui Yu wrote:
> Hi Eric,
>
> On 2020/3/10 22:54, Eric Auger wrote:
>> +#define GITS_TYPER_PLPIS BIT(0)
>> +#define GITS_TYPER_VLPIS BIT(1)
>> +#define GITS_TYPER_ITT_ENTRY_SIZE GENMASK_ULL(7, 4)
>> +#define GITS_TYPER_ITT_ENTRY_SIZE_SHIFT 4
>> +#define GITS_TYPER_IDBITS GENMASK_ULL(8, 12)
>
> Note that this should be GENMASK_ULL(12, 8).
definitively
Eric
>
>> +#define GITS_TYPER_IDBITS_SHIFT 8
>> +#define GITS_TYPER_DEVBITS GENMASK_ULL(13, 17)
>
> (17, 13)
>
>> +#define GITS_TYPER_DEVBITS_SHIFT 13
>> +#define GITS_TYPER_PTA BIT(19)
>> +#define GITS_TYPER_CIDBITS GENMASK_ULL(32, 35)
>
> (35, 32)
>
>> +#define GITS_TYPER_CIDBITS_SHIFT 32
>> +#define GITS_TYPER_CIL BIT(36)
>
> And please use tab for all of them.
>
>
> Thanks,
> Zenghui
>
WARNING: multiple messages have this Message-ID (diff)
From: Auger Eric <eric.auger@redhat.com>
To: Zenghui Yu <yuzenghui@huawei.com>,
eric.auger.pro@gmail.com, maz@kernel.org,
kvmarm@lists.cs.columbia.edu, kvm@vger.kernel.org,
qemu-devel@nongnu.org, qemu-arm@nongnu.org
Cc: andre.przywara@arm.com, drjones@redhat.com,
alexandru.elisei@arm.com, thuth@redhat.com,
peter.maydell@linaro.org
Subject: Re: [kvm-unit-tests PATCH v5 06/13] arm/arm64: ITS: Introspection tests
Date: Wed, 11 Mar 2020 10:29:36 +0100 [thread overview]
Message-ID: <7fc207fe-b761-6d24-0c14-896154023420@redhat.com> (raw)
In-Reply-To: <83ffda30-e0dc-7fbf-1775-bc45a308acb4@huawei.com>
Hi Zenghui,
On 3/11/20 9:37 AM, Zenghui Yu wrote:
> Hi Eric,
>
> On 2020/3/10 22:54, Eric Auger wrote:
>> +#define GITS_TYPER_PLPIS BIT(0)
>> +#define GITS_TYPER_VLPIS BIT(1)
>> +#define GITS_TYPER_ITT_ENTRY_SIZE GENMASK_ULL(7, 4)
>> +#define GITS_TYPER_ITT_ENTRY_SIZE_SHIFT 4
>> +#define GITS_TYPER_IDBITS GENMASK_ULL(8, 12)
>
> Note that this should be GENMASK_ULL(12, 8).
definitively
Eric
>
>> +#define GITS_TYPER_IDBITS_SHIFT 8
>> +#define GITS_TYPER_DEVBITS GENMASK_ULL(13, 17)
>
> (17, 13)
>
>> +#define GITS_TYPER_DEVBITS_SHIFT 13
>> +#define GITS_TYPER_PTA BIT(19)
>> +#define GITS_TYPER_CIDBITS GENMASK_ULL(32, 35)
>
> (35, 32)
>
>> +#define GITS_TYPER_CIDBITS_SHIFT 32
>> +#define GITS_TYPER_CIL BIT(36)
>
> And please use tab for all of them.
>
>
> Thanks,
> Zenghui
>
WARNING: multiple messages have this Message-ID (diff)
From: Auger Eric <eric.auger@redhat.com>
To: Zenghui Yu <yuzenghui@huawei.com>,
eric.auger.pro@gmail.com, maz@kernel.org,
kvmarm@lists.cs.columbia.edu, kvm@vger.kernel.org,
qemu-devel@nongnu.org, qemu-arm@nongnu.org
Cc: andre.przywara@arm.com, thuth@redhat.com
Subject: Re: [kvm-unit-tests PATCH v5 06/13] arm/arm64: ITS: Introspection tests
Date: Wed, 11 Mar 2020 10:29:36 +0100 [thread overview]
Message-ID: <7fc207fe-b761-6d24-0c14-896154023420@redhat.com> (raw)
In-Reply-To: <83ffda30-e0dc-7fbf-1775-bc45a308acb4@huawei.com>
Hi Zenghui,
On 3/11/20 9:37 AM, Zenghui Yu wrote:
> Hi Eric,
>
> On 2020/3/10 22:54, Eric Auger wrote:
>> +#define GITS_TYPER_PLPIS BIT(0)
>> +#define GITS_TYPER_VLPIS BIT(1)
>> +#define GITS_TYPER_ITT_ENTRY_SIZE GENMASK_ULL(7, 4)
>> +#define GITS_TYPER_ITT_ENTRY_SIZE_SHIFT 4
>> +#define GITS_TYPER_IDBITS GENMASK_ULL(8, 12)
>
> Note that this should be GENMASK_ULL(12, 8).
definitively
Eric
>
>> +#define GITS_TYPER_IDBITS_SHIFT 8
>> +#define GITS_TYPER_DEVBITS GENMASK_ULL(13, 17)
>
> (17, 13)
>
>> +#define GITS_TYPER_DEVBITS_SHIFT 13
>> +#define GITS_TYPER_PTA BIT(19)
>> +#define GITS_TYPER_CIDBITS GENMASK_ULL(32, 35)
>
> (35, 32)
>
>> +#define GITS_TYPER_CIDBITS_SHIFT 32
>> +#define GITS_TYPER_CIL BIT(36)
>
> And please use tab for all of them.
>
>
> Thanks,
> Zenghui
>
_______________________________________________
kvmarm mailing list
kvmarm@lists.cs.columbia.edu
https://lists.cs.columbia.edu/mailman/listinfo/kvmarm
next prev parent reply other threads:[~2020-03-11 9:29 UTC|newest]
Thread overview: 83+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-10 14:53 [kvm-unit-tests PATCH v5 00/13] arm/arm64: Add ITS tests Eric Auger
2020-03-10 14:53 ` Eric Auger
2020-03-10 14:53 ` Eric Auger
2020-03-10 14:53 ` [kvm-unit-tests PATCH v5 01/13] libcflat: Add other size defines Eric Auger
2020-03-10 14:53 ` Eric Auger
2020-03-10 14:53 ` Eric Auger
2020-03-10 14:53 ` [kvm-unit-tests PATCH v5 02/13] page_alloc: Introduce get_order() Eric Auger
2020-03-10 14:53 ` Eric Auger
2020-03-10 14:53 ` Eric Auger
2020-03-10 14:54 ` [kvm-unit-tests PATCH v5 03/13] arm/arm64: gic: Introduce setup_irq() helper Eric Auger
2020-03-10 14:54 ` Eric Auger
2020-03-10 14:54 ` Eric Auger
2020-03-10 14:54 ` [kvm-unit-tests PATCH v5 04/13] arm/arm64: gicv3: Add some re-distributor defines Eric Auger
2020-03-10 14:54 ` Eric Auger
2020-03-10 14:54 ` Eric Auger
2020-03-10 14:54 ` [kvm-unit-tests PATCH v5 05/13] arm/arm64: gicv3: Set the LPI config and pending tables Eric Auger
2020-03-10 14:54 ` Eric Auger
2020-03-10 14:54 ` Eric Auger
2020-03-11 6:42 ` Zenghui Yu
2020-03-11 6:42 ` Zenghui Yu
2020-03-11 6:42 ` Zenghui Yu
2020-03-11 9:07 ` Auger Eric
2020-03-11 9:07 ` Auger Eric
2020-03-10 14:54 ` [kvm-unit-tests PATCH v5 06/13] arm/arm64: ITS: Introspection tests Eric Auger
2020-03-10 14:54 ` Eric Auger
2020-03-10 14:54 ` Eric Auger
2020-03-11 8:37 ` Zenghui Yu
2020-03-11 8:37 ` Zenghui Yu
2020-03-11 8:37 ` Zenghui Yu
2020-03-11 9:29 ` Auger Eric [this message]
2020-03-11 9:29 ` Auger Eric
2020-03-11 9:29 ` Auger Eric
2020-03-10 14:54 ` [kvm-unit-tests PATCH v5 07/13] arm/arm64: ITS: its_enable_defaults Eric Auger
2020-03-10 14:54 ` Eric Auger
2020-03-10 14:54 ` Eric Auger
2020-03-11 8:46 ` Zenghui Yu
2020-03-11 8:46 ` Zenghui Yu
2020-03-11 8:46 ` Zenghui Yu
2020-03-10 14:54 ` [kvm-unit-tests PATCH v5 08/13] arm/arm64: ITS: Device and collection Initialization Eric Auger
2020-03-10 14:54 ` Eric Auger
2020-03-10 14:54 ` Eric Auger
2020-03-10 14:54 ` [kvm-unit-tests PATCH v5 09/13] arm/arm64: ITS: Commands Eric Auger
2020-03-10 14:54 ` Eric Auger
2020-03-10 14:54 ` Eric Auger
2020-03-11 9:09 ` Zenghui Yu
2020-03-11 9:09 ` Zenghui Yu
2020-03-11 9:09 ` Zenghui Yu
2020-03-10 14:54 ` [kvm-unit-tests PATCH v5 10/13] arm/arm64: ITS: INT functional tests Eric Auger
2020-03-10 14:54 ` Eric Auger
2020-03-10 14:54 ` Eric Auger
2020-03-11 11:59 ` Zenghui Yu
2020-03-11 11:59 ` Zenghui Yu
2020-03-11 11:59 ` Zenghui Yu
2020-03-11 13:48 ` Auger Eric
2020-03-11 13:48 ` Auger Eric
2020-03-11 13:48 ` Auger Eric
2020-03-11 14:00 ` Marc Zyngier
2020-03-11 14:00 ` Marc Zyngier
2020-03-11 14:00 ` Marc Zyngier
2020-03-12 9:19 ` Zenghui Yu
2020-03-12 9:19 ` Zenghui Yu
2020-03-12 9:19 ` Zenghui Yu
2020-03-12 9:59 ` Auger Eric
2020-03-12 9:59 ` Auger Eric
2020-03-12 9:59 ` Auger Eric
2020-03-13 1:55 ` Zenghui Yu
2020-03-13 1:55 ` Zenghui Yu
2020-03-13 1:55 ` Zenghui Yu
2020-03-10 14:54 ` [kvm-unit-tests PATCH v5 11/13] arm/run: Allow Migration tests Eric Auger
2020-03-10 14:54 ` Eric Auger
2020-03-10 14:54 ` Eric Auger
2020-03-10 14:54 ` [kvm-unit-tests PATCH v5 12/13] arm/arm64: ITS: migration tests Eric Auger
2020-03-10 14:54 ` Eric Auger
2020-03-10 14:54 ` Eric Auger
2020-03-10 14:54 ` [kvm-unit-tests PATCH v5 13/13] arm/arm64: ITS: pending table migration test Eric Auger
2020-03-10 14:54 ` Eric Auger
2020-03-10 14:54 ` Eric Auger
2020-03-11 12:07 ` Zenghui Yu
2020-03-11 12:07 ` Zenghui Yu
2020-03-11 12:07 ` Zenghui Yu
2020-03-11 13:49 ` Auger Eric
2020-03-11 13:49 ` Auger Eric
2020-03-11 13:49 ` Auger Eric
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7fc207fe-b761-6d24-0c14-896154023420@redhat.com \
--to=eric.auger@redhat.com \
--cc=alexandru.elisei@arm.com \
--cc=andre.przywara@arm.com \
--cc=drjones@redhat.com \
--cc=eric.auger.pro@gmail.com \
--cc=kvm@vger.kernel.org \
--cc=kvmarm@lists.cs.columbia.edu \
--cc=maz@kernel.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
--cc=yuzenghui@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.