Re: [PATCH v1 1/2] arm64: dts: mt6779: Support devapc

From: Neal Liu <neal.liu@mediatek.com>
To: Rob Herring <robh+dt@kernel.org>, Will Deacon <will@kernel.org>,
	"Catalin Marinas" <catalin.marinas@arm.com>,
	Matthias Brugger <matthias.bgg@gmail.com>
Cc: "Neal Liu" <neal.liu@mediatek.com>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>,
	"linux-mediatek@lists.infradead.org"
	<linux-mediatek@lists.infradead.org>,
	lkml <linux-kernel@vger.kernel.org>,
	"Hanks Chen (陳彥廷)" <Hanks.Chen@mediatek.com>,
	"Jackson-kt Chang (張國澤)" <Jackson-kt.Chang@mediatek.com>,
	wsd_upstream <wsd_upstream@mediatek.com>
Subject: Re: [PATCH v1 1/2] arm64: dts: mt6779: Support devapc
Date: Wed, 23 Dec 2020 17:52:32 +0800	[thread overview]
Message-ID: <1608717152.29691.1.camel@mtkswgap22> (raw)
In-Reply-To: <1608713092-26952-2-git-send-email-neal.liu@mediatek.com>

+add comments & reviewed-by Hanks

On Wed, 2020-12-23 at 16:44 +0800, Neal Liu wrote:

Support DEVAPC on MT6779 platforms by adding device node.

Reviewed-by: Hanks Chen <hanks.chen@mediatek.com>
> Signed-off-by: Neal Liu <neal.liu@mediatek.com>
> ---
>  arch/arm64/boot/dts/mediatek/mt6779.dtsi |    8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/mediatek/mt6779.dtsi b/arch/arm64/boot/dts/mediatek/mt6779.dtsi
> index 370f309..52ecfc7 100644
> --- a/arch/arm64/boot/dts/mediatek/mt6779.dtsi
> +++ b/arch/arm64/boot/dts/mediatek/mt6779.dtsi
> @@ -189,6 +189,14 @@
>  			#clock-cells = <1>;
>  		};
>  
> +		devapc: devapc@10207000 {
> +			compatible = "mediatek,mt6779-devapc";
> +			reg = <0 0x10207000 0 0x1000>;
> +			interrupts = <GIC_SPI 168 IRQ_TYPE_LEVEL_LOW>;
> +			clocks = <&infracfg_ao CLK_INFRA_DEVICE_APC>;
> +			clock-names = "devapc-infra-clock";
> +		};
> +
>  		uart0: serial@11002000 {
>  			compatible = "mediatek,mt6779-uart",
>  				     "mediatek,mt6577-uart";