From: Arnd Bergmann <arnd@kernel.org>
To: Matthias Brugger <matthias.bgg@gmail.com>
Cc: Neal Liu <neal.liu@mediatek.com>,
Rob Herring <robh+dt@kernel.org>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will@kernel.org>, SoC Team <soc@kernel.org>,
DTML <devicetree@vger.kernel.org>,
wsd_upstream <wsd_upstream@mediatek.com>,
Hanks Chen <Hanks.Chen@mediatek.com>,
lkml <linux-kernel@vger.kernel.org>,
"moderated list:ARM/Mediatek SoC..."
<linux-mediatek@lists.infradead.org>,
Jackson-kt Chang <Jackson-kt.Chang@mediatek.com>,
Linux ARM <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v1 2/2] arm64: configs: Support DEVAPC on MediaTek platforms
Date: Sun, 31 Jan 2021 23:23:17 +0100 [thread overview]
Message-ID: <CAK8P3a1DLX6y5GM3O7+T0gMH_JLRp6nUkHFZc4Shjn_bTKWWSw@mail.gmail.com> (raw)
In-Reply-To: <68442164-d649-aee0-cfe8-c9ebb868612d@gmail.com>
On Sun, Jan 31, 2021 at 3:07 PM Matthias Brugger <matthias.bgg@gmail.com> wrote:
> On 23/12/2020 09:44, Neal Liu wrote:
> > Support DEVAPC on MediaTek platforms by enabling CONFIG_MTK_DEVAPC.
> >
> > Signed-off-by: Neal Liu <neal.liu@mediatek.com>
> > ---
> > arch/arm64/configs/defconfig | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
> > index 17a2df6..a373776 100644
> > --- a/arch/arm64/configs/defconfig
> > +++ b/arch/arm64/configs/defconfig
> > @@ -257,6 +257,7 @@ CONFIG_MTD_NAND_MARVELL=y
> > CONFIG_MTD_NAND_FSL_IFC=y
> > CONFIG_MTD_NAND_QCOM=y
> > CONFIG_MTD_SPI_NOR=y
> > +CONFIG_MTK_DEVAPC=m
> > CONFIG_SPI_CADENCE_QUADSPI=y
> > CONFIG_BLK_DEV_LOOP=y
> > CONFIG_BLK_DEV_NBD=m
> >
>
> From my understanding, defconfig is for a minimal config that allows to boot a
> machine. As MTK_DEVAPC is a rather exotic driver to detect bus access
> violations, I think it's not a good candidate for inclusion in defconfig.
>
> In any case, I added the SoC maintainer, so that they can correct me, if I'm
> wrong :)
I generally don't mind adding platform specific drivers as loadable modules
even if they are somewhat obscure. For built-in drivers, this is
different though,
as those have a noticeable impact on other platforms.
I haven't kept track of what this particular driver does, but from the Kconfig
description, I'd say it should get enabled in defconfig.
Arnd
WARNING: multiple messages have this Message-ID (diff)
From: Arnd Bergmann <arnd@kernel.org>
To: Matthias Brugger <matthias.bgg@gmail.com>
Cc: DTML <devicetree@vger.kernel.org>,
wsd_upstream <wsd_upstream@mediatek.com>,
Catalin Marinas <catalin.marinas@arm.com>,
Hanks Chen <Hanks.Chen@mediatek.com>,
lkml <linux-kernel@vger.kernel.org>, SoC Team <soc@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Neal Liu <neal.liu@mediatek.com>,
Linux ARM <linux-arm-kernel@lists.infradead.org>,
"moderated list:ARM/Mediatek SoC..."
<linux-mediatek@lists.infradead.org>,
Will Deacon <will@kernel.org>,
Jackson-kt Chang <Jackson-kt.Chang@mediatek.com>
Subject: Re: [PATCH v1 2/2] arm64: configs: Support DEVAPC on MediaTek platforms
Date: Sun, 31 Jan 2021 23:23:17 +0100 [thread overview]
Message-ID: <CAK8P3a1DLX6y5GM3O7+T0gMH_JLRp6nUkHFZc4Shjn_bTKWWSw@mail.gmail.com> (raw)
Message-ID: <20210131222317.YHPPoIwQtlHsA_ZEgoPXdU9XRWRDfcJeMH5n3YOVWqE@z> (raw)
In-Reply-To: <68442164-d649-aee0-cfe8-c9ebb868612d@gmail.com>
On Sun, Jan 31, 2021 at 3:07 PM Matthias Brugger <matthias.bgg@gmail.com> wrote:
> On 23/12/2020 09:44, Neal Liu wrote:
> > Support DEVAPC on MediaTek platforms by enabling CONFIG_MTK_DEVAPC.
> >
> > Signed-off-by: Neal Liu <neal.liu@mediatek.com>
> > ---
> > arch/arm64/configs/defconfig | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
> > index 17a2df6..a373776 100644
> > --- a/arch/arm64/configs/defconfig
> > +++ b/arch/arm64/configs/defconfig
> > @@ -257,6 +257,7 @@ CONFIG_MTD_NAND_MARVELL=y
> > CONFIG_MTD_NAND_FSL_IFC=y
> > CONFIG_MTD_NAND_QCOM=y
> > CONFIG_MTD_SPI_NOR=y
> > +CONFIG_MTK_DEVAPC=m
> > CONFIG_SPI_CADENCE_QUADSPI=y
> > CONFIG_BLK_DEV_LOOP=y
> > CONFIG_BLK_DEV_NBD=m
> >
>
> From my understanding, defconfig is for a minimal config that allows to boot a
> machine. As MTK_DEVAPC is a rather exotic driver to detect bus access
> violations, I think it's not a good candidate for inclusion in defconfig.
>
> In any case, I added the SoC maintainer, so that they can correct me, if I'm
> wrong :)
I generally don't mind adding platform specific drivers as loadable modules
even if they are somewhat obscure. For built-in drivers, this is
different though,
as those have a noticeable impact on other platforms.
I haven't kept track of what this particular driver does, but from the Kconfig
description, I'd say it should get enabled in defconfig.
Arnd
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
WARNING: multiple messages have this Message-ID (diff)
From: Arnd Bergmann <arnd@kernel.org>
To: Matthias Brugger <matthias.bgg@gmail.com>
Cc: DTML <devicetree@vger.kernel.org>,
wsd_upstream <wsd_upstream@mediatek.com>,
Catalin Marinas <catalin.marinas@arm.com>,
Hanks Chen <Hanks.Chen@mediatek.com>,
lkml <linux-kernel@vger.kernel.org>, SoC Team <soc@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Neal Liu <neal.liu@mediatek.com>,
Linux ARM <linux-arm-kernel@lists.infradead.org>,
"moderated list:ARM/Mediatek SoC..."
<linux-mediatek@lists.infradead.org>,
Will Deacon <will@kernel.org>,
Jackson-kt Chang <Jackson-kt.Chang@mediatek.com>
Subject: Re: [PATCH v1 2/2] arm64: configs: Support DEVAPC on MediaTek platforms
Date: Sun, 31 Jan 2021 23:23:17 +0100 [thread overview]
Message-ID: <CAK8P3a1DLX6y5GM3O7+T0gMH_JLRp6nUkHFZc4Shjn_bTKWWSw@mail.gmail.com> (raw)
Message-ID: <20210131222317.atJy4aTb2PFWIQSOWTt9R4wWvBt4skbKWLJnWNtEikg@z> (raw)
In-Reply-To: <68442164-d649-aee0-cfe8-c9ebb868612d@gmail.com>
On Sun, Jan 31, 2021 at 3:07 PM Matthias Brugger <matthias.bgg@gmail.com> wrote:
> On 23/12/2020 09:44, Neal Liu wrote:
> > Support DEVAPC on MediaTek platforms by enabling CONFIG_MTK_DEVAPC.
> >
> > Signed-off-by: Neal Liu <neal.liu@mediatek.com>
> > ---
> > arch/arm64/configs/defconfig | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
> > index 17a2df6..a373776 100644
> > --- a/arch/arm64/configs/defconfig
> > +++ b/arch/arm64/configs/defconfig
> > @@ -257,6 +257,7 @@ CONFIG_MTD_NAND_MARVELL=y
> > CONFIG_MTD_NAND_FSL_IFC=y
> > CONFIG_MTD_NAND_QCOM=y
> > CONFIG_MTD_SPI_NOR=y
> > +CONFIG_MTK_DEVAPC=m
> > CONFIG_SPI_CADENCE_QUADSPI=y
> > CONFIG_BLK_DEV_LOOP=y
> > CONFIG_BLK_DEV_NBD=m
> >
>
> From my understanding, defconfig is for a minimal config that allows to boot a
> machine. As MTK_DEVAPC is a rather exotic driver to detect bus access
> violations, I think it's not a good candidate for inclusion in defconfig.
>
> In any case, I added the SoC maintainer, so that they can correct me, if I'm
> wrong :)
I generally don't mind adding platform specific drivers as loadable modules
even if they are somewhat obscure. For built-in drivers, this is
different though,
as those have a noticeable impact on other platforms.
I haven't kept track of what this particular driver does, but from the Kconfig
description, I'd say it should get enabled in defconfig.
Arnd
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-01-31 22:23 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-23 8:44 [PATCH v1 0/2] arm64: Support devapc on MediaTek MT6779 platform Neal Liu
2020-12-23 8:44 ` Neal Liu
2020-12-23 8:44 ` Neal Liu
2020-12-23 8:44 ` [PATCH v1 1/2] arm64: dts: mt6779: Support devapc Neal Liu
2020-12-23 8:44 ` Neal Liu
2020-12-23 8:44 ` Neal Liu
2020-12-23 9:52 ` Neal Liu
2020-12-23 9:52 ` Neal Liu
2020-12-23 9:52 ` Neal Liu
2020-12-23 8:44 ` [PATCH v1 2/2] arm64: configs: Support DEVAPC on MediaTek platforms Neal Liu
2020-12-23 8:44 ` Neal Liu
2020-12-23 8:44 ` Neal Liu
2021-01-31 14:07 ` Matthias Brugger
2021-01-31 22:23 ` Arnd Bergmann [this message]
2021-01-31 22:23 ` Arnd Bergmann
2021-01-31 22:23 ` Arnd Bergmann
2021-02-01 8:50 ` Matthias Brugger
2021-02-01 8:50 ` Matthias Brugger
2021-02-01 8:50 ` Matthias Brugger
2021-02-01 8:50 ` Matthias Brugger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAK8P3a1DLX6y5GM3O7+T0gMH_JLRp6nUkHFZc4Shjn_bTKWWSw@mail.gmail.com \
--to=arnd@kernel.org \
--cc=Hanks.Chen@mediatek.com \
--cc=Jackson-kt.Chang@mediatek.com \
--cc=catalin.marinas@arm.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=neal.liu@mediatek.com \
--cc=robh+dt@kernel.org \
--cc=soc@kernel.org \
--cc=will@kernel.org \
--cc=wsd_upstream@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.