All of lore.kernel.org
 help / color / mirror / Atom feed
From: Yicong Yang <yangyicong@hisilicon.com>
To: <gregkh@linuxfoundation.org>, <jdelvare@suse.com>,
	<linux@roeck-us.net>, <giometti@enneenne.com>,
	<abbotti@mev.co.uk>, <hsweeten@visionengravers.com>,
	<kw@linux.com>, <helgaas@kernel.org>,
	<linux-kernel@vger.kernel.org>, <linux-pm@vger.kernel.org>,
	<linux-hwmon@vger.kernel.org>, <devel@driverdev.osuosl.org>,
	<linux-kbuild@vger.kernel.org>, <masahiroy@kernel.org>,
	<michal.lkml@markovi.net>
Cc: <prime.zeng@huawei.com>, <yangyicong@hisilicon.com>,
	<linuxarm@openeuler.org>
Subject: [PATCH 0/4] Use subdir-ccflags-* to inherit debug flag
Date: Fri, 5 Feb 2021 17:44:11 +0800	[thread overview]
Message-ID: <1612518255-23052-1-git-send-email-yangyicong@hisilicon.com> (raw)

Few drivers use ccflags-* in their top directory to enable
-DDEBUG, but don't have config options to enable debug
in the sub-directories. They should want the subdirectories
inherit the debug flag from the top.

Use subdir-ccflags-* instead of ccflags-* to inherit the debug
settings from Kconfig when traversing subdirectories.

We primarily find this issue when debugging PCIe and other
drivers may also have this issues. Previous discussion can
be find at
https://lore.kernel.org/linux-pci/1612438215-33105-1-git-send-email-yangyicong@hisilicon.com/

Junhao He (4):
  driver core: Use subdir-ccflags-* to inherit debug flag
  hwmon: Use subdir-ccflags-* to inherit debug flag
  pps: Use subdir-ccflags-* to inherit debug flag
  staging: comedi: Use subdir-ccflags-* to inherit debug flag

 drivers/base/Makefile                         | 2 +-
 drivers/base/power/Makefile                   | 2 --
 drivers/hwmon/Makefile                        | 2 +-
 drivers/pps/Makefile                          | 2 +-
 drivers/staging/comedi/Makefile               | 2 +-
 drivers/staging/comedi/drivers/Makefile       | 1 -
 drivers/staging/comedi/drivers/tests/Makefile | 2 --
 drivers/staging/comedi/kcomedilib/Makefile    | 2 --
 8 files changed, 4 insertions(+), 11 deletions(-)

-- 
2.8.1


WARNING: multiple messages have this Message-ID (diff)
From: Yicong Yang <yangyicong@hisilicon.com>
To: <gregkh@linuxfoundation.org>, <jdelvare@suse.com>,
	<linux@roeck-us.net>, <giometti@enneenne.com>,
	<abbotti@mev.co.uk>, <hsweeten@visionengravers.com>,
	 <kw@linux.com>, <helgaas@kernel.org>,
	<linux-kernel@vger.kernel.org>, <linux-pm@vger.kernel.org>,
	<linux-hwmon@vger.kernel.org>, <devel@driverdev.osuosl.org>,
	<linux-kbuild@vger.kernel.org>, <masahiroy@kernel.org>,
	<michal.lkml@markovi.net>
Cc: linuxarm@openeuler.org, prime.zeng@huawei.com, yangyicong@hisilicon.com
Subject: [PATCH 0/4] Use subdir-ccflags-* to inherit debug flag
Date: Fri, 5 Feb 2021 17:44:11 +0800	[thread overview]
Message-ID: <1612518255-23052-1-git-send-email-yangyicong@hisilicon.com> (raw)

Few drivers use ccflags-* in their top directory to enable
-DDEBUG, but don't have config options to enable debug
in the sub-directories. They should want the subdirectories
inherit the debug flag from the top.

Use subdir-ccflags-* instead of ccflags-* to inherit the debug
settings from Kconfig when traversing subdirectories.

We primarily find this issue when debugging PCIe and other
drivers may also have this issues. Previous discussion can
be find at
https://lore.kernel.org/linux-pci/1612438215-33105-1-git-send-email-yangyicong@hisilicon.com/

Junhao He (4):
  driver core: Use subdir-ccflags-* to inherit debug flag
  hwmon: Use subdir-ccflags-* to inherit debug flag
  pps: Use subdir-ccflags-* to inherit debug flag
  staging: comedi: Use subdir-ccflags-* to inherit debug flag

 drivers/base/Makefile                         | 2 +-
 drivers/base/power/Makefile                   | 2 --
 drivers/hwmon/Makefile                        | 2 +-
 drivers/pps/Makefile                          | 2 +-
 drivers/staging/comedi/Makefile               | 2 +-
 drivers/staging/comedi/drivers/Makefile       | 1 -
 drivers/staging/comedi/drivers/tests/Makefile | 2 --
 drivers/staging/comedi/kcomedilib/Makefile    | 2 --
 8 files changed, 4 insertions(+), 11 deletions(-)

-- 
2.8.1

_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

             reply	other threads:[~2021-02-05  9:51 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-05  9:44 Yicong Yang [this message]
2021-02-05  9:44 ` [PATCH 0/4] Use subdir-ccflags-* to inherit debug flag Yicong Yang
2021-02-05  9:44 ` [PATCH 1/4] driver core: " Yicong Yang
2021-02-05  9:44   ` Yicong Yang
2021-02-05  9:53   ` Greg KH
2021-02-05  9:53     ` Greg KH
2021-02-08 10:44     ` Yicong Yang
2021-02-08 10:44       ` Yicong Yang
2021-02-08 10:47       ` Greg KH
2021-02-08 10:47         ` Greg KH
2021-02-08 13:09         ` Yicong Yang
2021-02-08 13:09           ` Yicong Yang
2021-02-10 11:42           ` Daniel Thompson
2021-02-10 11:42             ` Daniel Thompson
2021-02-24  9:56             ` Yicong Yang
2021-02-24  9:56               ` Yicong Yang
2021-02-05  9:44 ` [PATCH 2/4] hwmon: " Yicong Yang
2021-02-05  9:44   ` Yicong Yang
2021-02-05 18:28   ` Guenter Roeck
2021-02-05 18:28     ` Guenter Roeck
2021-02-05 20:08     ` Bjorn Helgaas
2021-02-05 20:08       ` Bjorn Helgaas
2021-02-08 10:51       ` Yicong Yang
2021-02-08 10:51         ` Yicong Yang
2021-02-08 21:00       ` Guenter Roeck
2021-02-08 21:00         ` Guenter Roeck
2021-02-05  9:44 ` [PATCH 3/4] pps: " Yicong Yang
2021-02-05  9:44   ` Yicong Yang
2021-02-05  9:44 ` [PATCH 4/4] staging: comedi: " Yicong Yang
2021-02-05  9:44   ` Yicong Yang
2021-02-05  9:54   ` Greg KH
2021-02-05  9:54     ` Greg KH
2021-02-06  0:52     ` Masahiro Yamada
2021-02-06  0:52       ` Masahiro Yamada

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1612518255-23052-1-git-send-email-yangyicong@hisilicon.com \
    --to=yangyicong@hisilicon.com \
    --cc=abbotti@mev.co.uk \
    --cc=devel@driverdev.osuosl.org \
    --cc=giometti@enneenne.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=helgaas@kernel.org \
    --cc=hsweeten@visionengravers.com \
    --cc=jdelvare@suse.com \
    --cc=kw@linux.com \
    --cc=linux-hwmon@vger.kernel.org \
    --cc=linux-kbuild@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=linuxarm@openeuler.org \
    --cc=masahiroy@kernel.org \
    --cc=michal.lkml@markovi.net \
    --cc=prime.zeng@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.