From: Greg KH <gregkh@linuxfoundation.org>
To: Yicong Yang <yangyicong@hisilicon.com>
Cc: jdelvare@suse.com, linux@roeck-us.net, giometti@enneenne.com,
abbotti@mev.co.uk, hsweeten@visionengravers.com, kw@linux.com,
helgaas@kernel.org, linux-kernel@vger.kernel.org,
linux-pm@vger.kernel.org, linux-hwmon@vger.kernel.org,
devel@driverdev.osuosl.org, linux-kbuild@vger.kernel.org,
masahiroy@kernel.org, michal.lkml@markovi.net,
linuxarm@openeuler.org, prime.zeng@huawei.com
Subject: Re: [PATCH 1/4] driver core: Use subdir-ccflags-* to inherit debug flag
Date: Mon, 8 Feb 2021 11:47:19 +0100 [thread overview]
Message-ID: <YCEWtxYgbRPET4Sr@kroah.com> (raw)
In-Reply-To: <08017751-a1be-ea07-50de-73d14ab6d57e@hisilicon.com>
On Mon, Feb 08, 2021 at 06:44:52PM +0800, Yicong Yang wrote:
> Hi Greg,
>
> On 2021/2/5 17:53, Greg KH wrote:
> > On Fri, Feb 05, 2021 at 05:44:12PM +0800, Yicong Yang wrote:
> >> From: Junhao He <hejunhao2@hisilicon.com>
> >>
> >> Use subdir-ccflags-* instead of ccflags-* to inherit the debug
> >> settings from Kconfig when traversing subdirectories.
> >
> > That says what you do, but not _why_ you are doing it.
>
> i'll illustrate the reason and reword the commit.
>
> >
> > What does this offer in benefit of the existing way? What is it fixing?
> > Why do this "churn"?
>
> currently we have added ccflags-$(CONFIG_DEBUG_DRIVER) := -DDEBUG in the Makefile
> of driver/base and driver/base/power, but not in the subdirectory
> driver/base/firmware_loader. we cannot turn the debug on for subdirectory
> firmware_loader if we config DEBUG_DRIVER and there is no kconfig option
> for the it.
Is that necessary? Does that directory need it?
thanks,
greg k-h
WARNING: multiple messages have this Message-ID (diff)
From: Greg KH <gregkh@linuxfoundation.org>
To: Yicong Yang <yangyicong@hisilicon.com>
Cc: linux-hwmon@vger.kernel.org, kw@linux.com, giometti@enneenne.com,
jdelvare@suse.com, prime.zeng@huawei.com,
linux-pm@vger.kernel.org, masahiroy@kernel.org,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org,
linux-kbuild@vger.kernel.org, linuxarm@openeuler.org,
abbotti@mev.co.uk, michal.lkml@markovi.net, helgaas@kernel.org,
linux@roeck-us.net
Subject: Re: [PATCH 1/4] driver core: Use subdir-ccflags-* to inherit debug flag
Date: Mon, 8 Feb 2021 11:47:19 +0100 [thread overview]
Message-ID: <YCEWtxYgbRPET4Sr@kroah.com> (raw)
In-Reply-To: <08017751-a1be-ea07-50de-73d14ab6d57e@hisilicon.com>
On Mon, Feb 08, 2021 at 06:44:52PM +0800, Yicong Yang wrote:
> Hi Greg,
>
> On 2021/2/5 17:53, Greg KH wrote:
> > On Fri, Feb 05, 2021 at 05:44:12PM +0800, Yicong Yang wrote:
> >> From: Junhao He <hejunhao2@hisilicon.com>
> >>
> >> Use subdir-ccflags-* instead of ccflags-* to inherit the debug
> >> settings from Kconfig when traversing subdirectories.
> >
> > That says what you do, but not _why_ you are doing it.
>
> i'll illustrate the reason and reword the commit.
>
> >
> > What does this offer in benefit of the existing way? What is it fixing?
> > Why do this "churn"?
>
> currently we have added ccflags-$(CONFIG_DEBUG_DRIVER) := -DDEBUG in the Makefile
> of driver/base and driver/base/power, but not in the subdirectory
> driver/base/firmware_loader. we cannot turn the debug on for subdirectory
> firmware_loader if we config DEBUG_DRIVER and there is no kconfig option
> for the it.
Is that necessary? Does that directory need it?
thanks,
greg k-h
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
next prev parent reply other threads:[~2021-02-08 10:54 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-05 9:44 [PATCH 0/4] Use subdir-ccflags-* to inherit debug flag Yicong Yang
2021-02-05 9:44 ` Yicong Yang
2021-02-05 9:44 ` [PATCH 1/4] driver core: " Yicong Yang
2021-02-05 9:44 ` Yicong Yang
2021-02-05 9:53 ` Greg KH
2021-02-05 9:53 ` Greg KH
2021-02-08 10:44 ` Yicong Yang
2021-02-08 10:44 ` Yicong Yang
2021-02-08 10:47 ` Greg KH [this message]
2021-02-08 10:47 ` Greg KH
2021-02-08 13:09 ` Yicong Yang
2021-02-08 13:09 ` Yicong Yang
2021-02-10 11:42 ` Daniel Thompson
2021-02-10 11:42 ` Daniel Thompson
2021-02-24 9:56 ` Yicong Yang
2021-02-24 9:56 ` Yicong Yang
2021-02-05 9:44 ` [PATCH 2/4] hwmon: " Yicong Yang
2021-02-05 9:44 ` Yicong Yang
2021-02-05 18:28 ` Guenter Roeck
2021-02-05 18:28 ` Guenter Roeck
2021-02-05 20:08 ` Bjorn Helgaas
2021-02-05 20:08 ` Bjorn Helgaas
2021-02-08 10:51 ` Yicong Yang
2021-02-08 10:51 ` Yicong Yang
2021-02-08 21:00 ` Guenter Roeck
2021-02-08 21:00 ` Guenter Roeck
2021-02-05 9:44 ` [PATCH 3/4] pps: " Yicong Yang
2021-02-05 9:44 ` Yicong Yang
2021-02-05 9:44 ` [PATCH 4/4] staging: comedi: " Yicong Yang
2021-02-05 9:44 ` Yicong Yang
2021-02-05 9:54 ` Greg KH
2021-02-05 9:54 ` Greg KH
2021-02-06 0:52 ` Masahiro Yamada
2021-02-06 0:52 ` Masahiro Yamada
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YCEWtxYgbRPET4Sr@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=abbotti@mev.co.uk \
--cc=devel@driverdev.osuosl.org \
--cc=giometti@enneenne.com \
--cc=helgaas@kernel.org \
--cc=hsweeten@visionengravers.com \
--cc=jdelvare@suse.com \
--cc=kw@linux.com \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=linuxarm@openeuler.org \
--cc=masahiroy@kernel.org \
--cc=michal.lkml@markovi.net \
--cc=prime.zeng@huawei.com \
--cc=yangyicong@hisilicon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.