From: Kees Cook <keescook@chromium.org>
To: Nick Desaulniers <ndesaulniers@google.com>
Cc: Kees Cook <keescook@chromium.org>,
Catalin Marinas <catalin.marinas@arm.com>,
Vasily Gorbik <gor@linux.ibm.com>,
Ard Biesheuvel <ardb@kernel.org>,
Rasmus Villemoes <linux@rasmusvillemoes.dk>,
linux-arm-kernel@lists.infradead.org,
Nathan Chancellor <nathan@kernel.org>,
Fangrui Song <maskray@google.com>,
linux-kbuild@vger.kernel.org, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-s390@vger.kernel.org,
Peter Oberparleiter <oberpar@linux.ibm.com>,
Borislav Petkov <bp@alien8.de>,
Luc Van Oostenryck <luc.vanoostenryck@gmail.com>,
Marco Elver <elver@google.com>,
Christian Borntraeger <borntraeger@de.ibm.com>,
Masahiro Yamada <masahiroy@kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
Heiko Carstens <hca@linux.ibm.com>,
Andrew Morton <akpm@linux-foundation.org>,
Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>,
Dmitry Vyukov <dvyukov@google.com>,
Bill Wendling <wcw@google.com>, Arnd Bergmann <arnd@arndb.de>,
johannes.berg@intel.com, clang-built-linux@googlegroups.com,
Jonathan Corbet <corbet@lwn.net>, Martin Liska <mliska@suse.cz>,
linux-toolchains@vger.kernel.org, x86@kernel.org,
Sami Tolvanen <samitolvanen@google.com>,
Will Deacon <will@kernel.org>
Subject: Re: [PATCH v2 0/3] no_profile fn attr and Kconfig for GCOV+PGO
Date: Tue, 22 Jun 2021 23:15:50 -0700 [thread overview]
Message-ID: <162442894704.2888450.8087873021886781652.b4-ty@chromium.org> (raw)
In-Reply-To: <20210621231822.2848305-1-ndesaulniers@google.com>
On Mon, 21 Jun 2021 16:18:19 -0700, Nick Desaulniers wrote:
> The kernel has been using noinstr for correctness to politely request
> that the compiler avoid adding various forms of instrumentation to
> certain functions.
>
> GCOV and PGO can both instrument functions, yet the function attribute
> to disable such instrumentation (no_profile_instrument_function) was not
> being used to suppress such implementation. Also, clang only just
> recently gained support for no_profile_instrument_function. GCC has
> supported that since 7.1+.
>
> [...]
Applied to for-next/clang/features, thanks!
[1/3] compiler_attributes.h: define __no_profile, add to noinstr
https://git.kernel.org/kees/c/380d53c45ff2
[2/3] compiler_attributes.h: cleanups for GCC 4.9+
https://git.kernel.org/kees/c/ae4d682dfd33
[3/3] Kconfig: add ARCH_WANTS_NO_INSTR+CC_HAS_NO_PROFILE_FN_ATTR, depend on for GCOV and PGO
https://git.kernel.org/kees/c/51c2ee6d121c
Note that I've tweaked the series slightly to move the PGO Kconfig change into
the PGO patch.
--
Kees Cook
WARNING: multiple messages have this Message-ID (diff)
From: Kees Cook <keescook@chromium.org>
To: Nick Desaulniers <ndesaulniers@google.com>
Cc: Kees Cook <keescook@chromium.org>,
Catalin Marinas <catalin.marinas@arm.com>,
Vasily Gorbik <gor@linux.ibm.com>,
Ard Biesheuvel <ardb@kernel.org>,
Rasmus Villemoes <linux@rasmusvillemoes.dk>,
linux-arm-kernel@lists.infradead.org,
Nathan Chancellor <nathan@kernel.org>,
Fangrui Song <maskray@google.com>,
linux-kbuild@vger.kernel.org, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-s390@vger.kernel.org,
Peter Oberparleiter <oberpar@linux.ibm.com>,
Borislav Petkov <bp@alien8.de>,
Luc Van Oostenryck <luc.vanoostenryck@gmail.com>,
Marco Elver <elver@google.com>,
Christian Borntraeger <borntraeger@de.ibm.com>,
Masahiro Yamada <masahiroy@kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
Heiko Carstens <hca@linux.ibm.com>,
Andrew Morton <akpm@linux-foundation.org>,
Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>,
Dmitry Vyukov <dvyukov@google.com>,
Bill Wendling <wcw@google.com>, Arnd Bergmann <arnd@arndb.de>,
johannes.berg@intel.com, clang-built-linux@googlegroups.com,
Jonathan Corbet <corbet@lwn.net>, Martin Liska <mliska@suse.cz>,
linux-toolchains@vger.kernel.org, x86@kernel.org,
Sami Tolvanen <samitolvanen@google.com>,
Will Deacon <will@kernel.org>
Subject: Re: [PATCH v2 0/3] no_profile fn attr and Kconfig for GCOV+PGO
Date: Tue, 22 Jun 2021 23:15:50 -0700 [thread overview]
Message-ID: <162442894704.2888450.8087873021886781652.b4-ty@chromium.org> (raw)
In-Reply-To: <20210621231822.2848305-1-ndesaulniers@google.com>
On Mon, 21 Jun 2021 16:18:19 -0700, Nick Desaulniers wrote:
> The kernel has been using noinstr for correctness to politely request
> that the compiler avoid adding various forms of instrumentation to
> certain functions.
>
> GCOV and PGO can both instrument functions, yet the function attribute
> to disable such instrumentation (no_profile_instrument_function) was not
> being used to suppress such implementation. Also, clang only just
> recently gained support for no_profile_instrument_function. GCC has
> supported that since 7.1+.
>
> [...]
Applied to for-next/clang/features, thanks!
[1/3] compiler_attributes.h: define __no_profile, add to noinstr
https://git.kernel.org/kees/c/380d53c45ff2
[2/3] compiler_attributes.h: cleanups for GCC 4.9+
https://git.kernel.org/kees/c/ae4d682dfd33
[3/3] Kconfig: add ARCH_WANTS_NO_INSTR+CC_HAS_NO_PROFILE_FN_ATTR, depend on for GCOV and PGO
https://git.kernel.org/kees/c/51c2ee6d121c
Note that I've tweaked the series slightly to move the PGO Kconfig change into
the PGO patch.
--
Kees Cook
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-06-23 6:17 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-21 23:18 [PATCH v2 0/3] no_profile fn attr and Kconfig for GCOV+PGO Nick Desaulniers
2021-06-21 23:18 ` Nick Desaulniers
2021-06-21 23:18 ` [PATCH v2 1/3] compiler_attributes.h: define __no_profile, add to noinstr Nick Desaulniers
2021-06-21 23:18 ` Nick Desaulniers
2021-06-21 23:41 ` Nathan Chancellor
2021-06-21 23:41 ` Nathan Chancellor
2021-06-21 23:18 ` [PATCH v2 2/3] compiler_attributes.h: cleanups for GCC 4.9+ Nick Desaulniers
2021-06-21 23:18 ` Nick Desaulniers
2021-06-21 23:31 ` Miguel Ojeda
2021-06-21 23:31 ` Miguel Ojeda
2021-06-21 23:42 ` Nathan Chancellor
2021-06-21 23:42 ` Nathan Chancellor
2021-06-21 23:18 ` [PATCH v2 3/3] Kconfig: add ARCH_WANTS_NO_INSTR+CC_HAS_NO_PROFILE_FN_ATTR, depend on for GCOV and PGO Nick Desaulniers
2021-06-21 23:18 ` Nick Desaulniers
2021-06-21 23:45 ` Nathan Chancellor
2021-06-21 23:45 ` Nathan Chancellor
2021-06-22 7:25 ` Peter Zijlstra
2021-06-22 7:25 ` Peter Zijlstra
2021-06-22 8:09 ` Marco Elver
2021-06-22 8:09 ` Marco Elver
2021-06-22 9:05 ` Mark Rutland
2021-06-22 9:05 ` Mark Rutland
2021-06-22 11:10 ` Will Deacon
2021-06-22 11:10 ` Will Deacon
2021-06-22 9:33 ` Heiko Carstens
2021-06-22 9:33 ` Heiko Carstens
2021-06-22 9:35 ` Peter Oberparleiter
2021-06-22 9:35 ` Peter Oberparleiter
2021-06-22 7:25 ` [PATCH v2 0/3] no_profile fn attr and Kconfig for GCOV+PGO Peter Zijlstra
2021-06-22 7:25 ` Peter Zijlstra
2021-06-22 18:19 ` Kees Cook
2021-06-22 18:19 ` Kees Cook
2021-06-23 6:15 ` Kees Cook [this message]
2021-06-23 6:15 ` Kees Cook
2021-06-24 19:36 ` Nick Desaulniers
2021-06-24 19:36 ` Nick Desaulniers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=162442894704.2888450.8087873021886781652.b4-ty@chromium.org \
--to=keescook@chromium.org \
--cc=akpm@linux-foundation.org \
--cc=ardb@kernel.org \
--cc=arnd@arndb.de \
--cc=borntraeger@de.ibm.com \
--cc=bp@alien8.de \
--cc=catalin.marinas@arm.com \
--cc=clang-built-linux@googlegroups.com \
--cc=corbet@lwn.net \
--cc=dvyukov@google.com \
--cc=elver@google.com \
--cc=gor@linux.ibm.com \
--cc=hca@linux.ibm.com \
--cc=johannes.berg@intel.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=linux-toolchains@vger.kernel.org \
--cc=linux@rasmusvillemoes.dk \
--cc=luc.vanoostenryck@gmail.com \
--cc=masahiroy@kernel.org \
--cc=maskray@google.com \
--cc=miguel.ojeda.sandonis@gmail.com \
--cc=mliska@suse.cz \
--cc=nathan@kernel.org \
--cc=ndesaulniers@google.com \
--cc=oberpar@linux.ibm.com \
--cc=peterz@infradead.org \
--cc=samitolvanen@google.com \
--cc=wcw@google.com \
--cc=will@kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.