From: Mark Rutland <mark.rutland@arm.com> To: Nick Desaulniers <ndesaulniers@google.com>, Catalin Marinas <catalin.marinas@arm.com>, Will Deacon <will@kernel.org> Cc: Kees Cook <keescook@chromium.org>, Peter Zijlstra <peterz@infradead.org>, Bill Wendling <wcw@google.com>, Sami Tolvanen <samitolvanen@google.com>, Peter Oberparleiter <oberpar@linux.ibm.com>, Masahiro Yamada <masahiroy@kernel.org>, Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>, Nathan Chancellor <nathan@kernel.org>, Luc Van Oostenryck <luc.vanoostenryck@gmail.com>, Ard Biesheuvel <ardb@kernel.org>, Arnd Bergmann <arnd@arndb.de>, Andrew Morton <akpm@linux-foundation.org>, Rasmus Villemoes <linux@rasmusvillemoes.dk>, linux-kernel@vger.kernel.org, clang-built-linux@googlegroups.com, x86@kernel.org, Borislav Petkov <bp@alien8.de>, Martin Liska <mliska@suse.cz>, Marco Elver <elver@google.com>, Jonathan Corbet <corbet@lwn.net>, Fangrui Song <maskray@google.com>, linux-doc@vger.kernel.org, linux-kbuild@vger.kernel.org, Dmitry Vyukov <dvyukov@google.com>, johannes.berg@intel.com, linux-toolchains@vger.kernel.org, Heiko Carstens <hca@linux.ibm.com>, Vasily Gorbik <gor@linux.ibm.com>, Christian Borntraeger <borntraeger@de.ibm.com>, linux-s390@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v2 3/3] Kconfig: add ARCH_WANTS_NO_INSTR+CC_HAS_NO_PROFILE_FN_ATTR, depend on for GCOV and PGO Date: Tue, 22 Jun 2021 10:05:40 +0100 [thread overview] Message-ID: <20210622090540.GA67232@C02TD0UTHF1T.local> (raw) In-Reply-To: <20210621231822.2848305-4-ndesaulniers@google.com> On Mon, Jun 21, 2021 at 04:18:22PM -0700, Nick Desaulniers wrote: > We don't want compiler instrumentation to touch noinstr functions, which > are annotated with the no_profile_instrument_function function > attribute. Add a Kconfig test for this and make PGO and GCOV depend on > it. > > If an architecture is using noinstr, it should denote that via this > Kconfig value. That makes Kconfigs that depend on noinstr able to > express dependencies in an architecturally agnostic way. > > Cc: Masahiro Yamada <masahiroy@kernel.org> > Cc: Peter Oberparleiter <oberpar@linux.ibm.com> > Link: https://lore.kernel.org/lkml/YMTn9yjuemKFLbws@hirez.programming.kicks-ass.net/ > Link: https://lore.kernel.org/lkml/YMcssV%2Fn5IBGv4f0@hirez.programming.kicks-ass.net/ > Suggested-by: Nathan Chancellor <nathan@kernel.org> > Suggested-by: Peter Zijlstra <peterz@infradead.org> > Signed-off-by: Nick Desaulniers <ndesaulniers@google.com> FWIW, this looks good to me: Acked-by: Mark Rutland <mark.rutland@arm.com> Catalin, Will, are you happy iwth the arm64 bit? Thanks, Makr. > --- > Changes V1 -> V2: > * Add ARCH_WANTS_NO_INSTR > * Change depdendencies to be !ARCH_WANTS_NO_INSTR || CC_HAS_NO_PROFILE_FN_ATTR > rather than list architectures explicitly, as per Nathan. > * s/no_profile/no_profile_instrument_function/ > > arch/Kconfig | 7 +++++++ > arch/arm64/Kconfig | 1 + > arch/s390/Kconfig | 1 + > arch/x86/Kconfig | 1 + > init/Kconfig | 3 +++ > kernel/gcov/Kconfig | 1 + > kernel/pgo/Kconfig | 3 ++- > 7 files changed, 16 insertions(+), 1 deletion(-) > > diff --git a/arch/Kconfig b/arch/Kconfig > index 2b4109b0edee..2113c6b3b801 100644 > --- a/arch/Kconfig > +++ b/arch/Kconfig > @@ -285,6 +285,13 @@ config ARCH_THREAD_STACK_ALLOCATOR > config ARCH_WANTS_DYNAMIC_TASK_STRUCT > bool > > +config ARCH_WANTS_NO_INSTR > + bool > + help > + An architecure should select this if the noinstr macro is being used on > + functions to denote that the toolchain should avoid instrumenting such > + functions and is required for correctness. > + > config ARCH_32BIT_OFF_T > bool > depends on !64BIT > diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig > index 9f1d8566bbf9..39bf982b06f8 100644 > --- a/arch/arm64/Kconfig > +++ b/arch/arm64/Kconfig > @@ -93,6 +93,7 @@ config ARM64 > select ARCH_WANT_FRAME_POINTERS > select ARCH_WANT_HUGE_PMD_SHARE if ARM64_4K_PAGES || (ARM64_16K_PAGES && !ARM64_VA_BITS_36) > select ARCH_WANT_LD_ORPHAN_WARN > + select ARCH_WANTS_NO_INSTR > select ARCH_HAS_UBSAN_SANITIZE_ALL > select ARM_AMBA > select ARM_ARCH_TIMER > diff --git a/arch/s390/Kconfig b/arch/s390/Kconfig > index b4c7c34069f8..bd60310f33b9 100644 > --- a/arch/s390/Kconfig > +++ b/arch/s390/Kconfig > @@ -117,6 +117,7 @@ config S390 > select ARCH_USE_BUILTIN_BSWAP > select ARCH_USE_CMPXCHG_LOCKREF > select ARCH_WANTS_DYNAMIC_TASK_STRUCT > + select ARCH_WANTS_NO_INSTR > select ARCH_WANT_DEFAULT_BPF_JIT > select ARCH_WANT_IPC_PARSE_VERSION > select BUILDTIME_TABLE_SORT > diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig > index da43fd046149..7d6a44bb9b0e 100644 > --- a/arch/x86/Kconfig > +++ b/arch/x86/Kconfig > @@ -114,6 +114,7 @@ config X86 > select ARCH_WANT_BATCHED_UNMAP_TLB_FLUSH > select ARCH_WANT_DEFAULT_BPF_JIT if X86_64 > select ARCH_WANTS_DYNAMIC_TASK_STRUCT > + select ARCH_WANTS_NO_INSTR > select ARCH_WANT_HUGE_PMD_SHARE > select ARCH_WANT_LD_ORPHAN_WARN > select ARCH_WANTS_THP_SWAP if X86_64 > diff --git a/init/Kconfig b/init/Kconfig > index 1ea12c64e4c9..31397a7a45fb 100644 > --- a/init/Kconfig > +++ b/init/Kconfig > @@ -83,6 +83,9 @@ config TOOLS_SUPPORT_RELR > config CC_HAS_ASM_INLINE > def_bool $(success,echo 'void foo(void) { asm inline (""); }' | $(CC) -x c - -c -o /dev/null) > > +config CC_HAS_NO_PROFILE_FN_ATTR > + def_bool $(success,echo '__attribute__((no_profile_instrument_function)) int x();' | $(CC) -x c - -c -o /dev/null -Werror) > + > config CONSTRUCTORS > bool > > diff --git a/kernel/gcov/Kconfig b/kernel/gcov/Kconfig > index 58f87a3092f3..053447183ac5 100644 > --- a/kernel/gcov/Kconfig > +++ b/kernel/gcov/Kconfig > @@ -5,6 +5,7 @@ config GCOV_KERNEL > bool "Enable gcov-based kernel profiling" > depends on DEBUG_FS > depends on !CC_IS_CLANG || CLANG_VERSION >= 110000 > + depends on !ARCH_WANTS_NO_INSTR || CC_HAS_NO_PROFILE_FN_ATTR > select CONSTRUCTORS > default n > help > diff --git a/kernel/pgo/Kconfig b/kernel/pgo/Kconfig > index d2053df1111c..ce7fe04f303d 100644 > --- a/kernel/pgo/Kconfig > +++ b/kernel/pgo/Kconfig > @@ -8,7 +8,8 @@ config PGO_CLANG > bool "Enable clang's PGO-based kernel profiling" > depends on DEBUG_FS > depends on ARCH_SUPPORTS_PGO_CLANG > - depends on CC_IS_CLANG && CLANG_VERSION >= 120000 > + depends on CC_IS_CLANG > + depends on !ARCH_WANTS_NO_INSTR || CC_HAS_NO_PROFILE_FN_ATTR > help > This option enables clang's PGO (Profile Guided Optimization) based > code profiling to better optimize the kernel. > -- > 2.32.0.288.g62a8d224e6-goog >
WARNING: multiple messages have this Message-ID (diff)
From: Mark Rutland <mark.rutland@arm.com> To: Nick Desaulniers <ndesaulniers@google.com>, Catalin Marinas <catalin.marinas@arm.com>, Will Deacon <will@kernel.org> Cc: Kees Cook <keescook@chromium.org>, Peter Zijlstra <peterz@infradead.org>, Bill Wendling <wcw@google.com>, Sami Tolvanen <samitolvanen@google.com>, Peter Oberparleiter <oberpar@linux.ibm.com>, Masahiro Yamada <masahiroy@kernel.org>, Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>, Nathan Chancellor <nathan@kernel.org>, Luc Van Oostenryck <luc.vanoostenryck@gmail.com>, Ard Biesheuvel <ardb@kernel.org>, Arnd Bergmann <arnd@arndb.de>, Andrew Morton <akpm@linux-foundation.org>, Rasmus Villemoes <linux@rasmusvillemoes.dk>, linux-kernel@vger.kernel.org, clang-built-linux@googlegroups.com, x86@kernel.org, Borislav Petkov <bp@alien8.de>, Martin Liska <mliska@suse.cz>, Marco Elver <elver@google.com>, Jonathan Corbet <corbet@lwn.net>, Fangrui Song <maskray@google.com>, linux-doc@vger.kernel.org, linux-kbuild@vger.kernel.org, Dmitry Vyukov <dvyukov@google.com>, johannes.berg@intel.com, linux-toolchains@vger.kernel.org, Heiko Carstens <hca@linux.ibm.com>, Vasily Gorbik <gor@linux.ibm.com>, Christian Borntraeger <borntraeger@de.ibm.com>, linux-s390@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v2 3/3] Kconfig: add ARCH_WANTS_NO_INSTR+CC_HAS_NO_PROFILE_FN_ATTR, depend on for GCOV and PGO Date: Tue, 22 Jun 2021 10:05:40 +0100 [thread overview] Message-ID: <20210622090540.GA67232@C02TD0UTHF1T.local> (raw) In-Reply-To: <20210621231822.2848305-4-ndesaulniers@google.com> On Mon, Jun 21, 2021 at 04:18:22PM -0700, Nick Desaulniers wrote: > We don't want compiler instrumentation to touch noinstr functions, which > are annotated with the no_profile_instrument_function function > attribute. Add a Kconfig test for this and make PGO and GCOV depend on > it. > > If an architecture is using noinstr, it should denote that via this > Kconfig value. That makes Kconfigs that depend on noinstr able to > express dependencies in an architecturally agnostic way. > > Cc: Masahiro Yamada <masahiroy@kernel.org> > Cc: Peter Oberparleiter <oberpar@linux.ibm.com> > Link: https://lore.kernel.org/lkml/YMTn9yjuemKFLbws@hirez.programming.kicks-ass.net/ > Link: https://lore.kernel.org/lkml/YMcssV%2Fn5IBGv4f0@hirez.programming.kicks-ass.net/ > Suggested-by: Nathan Chancellor <nathan@kernel.org> > Suggested-by: Peter Zijlstra <peterz@infradead.org> > Signed-off-by: Nick Desaulniers <ndesaulniers@google.com> FWIW, this looks good to me: Acked-by: Mark Rutland <mark.rutland@arm.com> Catalin, Will, are you happy iwth the arm64 bit? Thanks, Makr. > --- > Changes V1 -> V2: > * Add ARCH_WANTS_NO_INSTR > * Change depdendencies to be !ARCH_WANTS_NO_INSTR || CC_HAS_NO_PROFILE_FN_ATTR > rather than list architectures explicitly, as per Nathan. > * s/no_profile/no_profile_instrument_function/ > > arch/Kconfig | 7 +++++++ > arch/arm64/Kconfig | 1 + > arch/s390/Kconfig | 1 + > arch/x86/Kconfig | 1 + > init/Kconfig | 3 +++ > kernel/gcov/Kconfig | 1 + > kernel/pgo/Kconfig | 3 ++- > 7 files changed, 16 insertions(+), 1 deletion(-) > > diff --git a/arch/Kconfig b/arch/Kconfig > index 2b4109b0edee..2113c6b3b801 100644 > --- a/arch/Kconfig > +++ b/arch/Kconfig > @@ -285,6 +285,13 @@ config ARCH_THREAD_STACK_ALLOCATOR > config ARCH_WANTS_DYNAMIC_TASK_STRUCT > bool > > +config ARCH_WANTS_NO_INSTR > + bool > + help > + An architecure should select this if the noinstr macro is being used on > + functions to denote that the toolchain should avoid instrumenting such > + functions and is required for correctness. > + > config ARCH_32BIT_OFF_T > bool > depends on !64BIT > diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig > index 9f1d8566bbf9..39bf982b06f8 100644 > --- a/arch/arm64/Kconfig > +++ b/arch/arm64/Kconfig > @@ -93,6 +93,7 @@ config ARM64 > select ARCH_WANT_FRAME_POINTERS > select ARCH_WANT_HUGE_PMD_SHARE if ARM64_4K_PAGES || (ARM64_16K_PAGES && !ARM64_VA_BITS_36) > select ARCH_WANT_LD_ORPHAN_WARN > + select ARCH_WANTS_NO_INSTR > select ARCH_HAS_UBSAN_SANITIZE_ALL > select ARM_AMBA > select ARM_ARCH_TIMER > diff --git a/arch/s390/Kconfig b/arch/s390/Kconfig > index b4c7c34069f8..bd60310f33b9 100644 > --- a/arch/s390/Kconfig > +++ b/arch/s390/Kconfig > @@ -117,6 +117,7 @@ config S390 > select ARCH_USE_BUILTIN_BSWAP > select ARCH_USE_CMPXCHG_LOCKREF > select ARCH_WANTS_DYNAMIC_TASK_STRUCT > + select ARCH_WANTS_NO_INSTR > select ARCH_WANT_DEFAULT_BPF_JIT > select ARCH_WANT_IPC_PARSE_VERSION > select BUILDTIME_TABLE_SORT > diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig > index da43fd046149..7d6a44bb9b0e 100644 > --- a/arch/x86/Kconfig > +++ b/arch/x86/Kconfig > @@ -114,6 +114,7 @@ config X86 > select ARCH_WANT_BATCHED_UNMAP_TLB_FLUSH > select ARCH_WANT_DEFAULT_BPF_JIT if X86_64 > select ARCH_WANTS_DYNAMIC_TASK_STRUCT > + select ARCH_WANTS_NO_INSTR > select ARCH_WANT_HUGE_PMD_SHARE > select ARCH_WANT_LD_ORPHAN_WARN > select ARCH_WANTS_THP_SWAP if X86_64 > diff --git a/init/Kconfig b/init/Kconfig > index 1ea12c64e4c9..31397a7a45fb 100644 > --- a/init/Kconfig > +++ b/init/Kconfig > @@ -83,6 +83,9 @@ config TOOLS_SUPPORT_RELR > config CC_HAS_ASM_INLINE > def_bool $(success,echo 'void foo(void) { asm inline (""); }' | $(CC) -x c - -c -o /dev/null) > > +config CC_HAS_NO_PROFILE_FN_ATTR > + def_bool $(success,echo '__attribute__((no_profile_instrument_function)) int x();' | $(CC) -x c - -c -o /dev/null -Werror) > + > config CONSTRUCTORS > bool > > diff --git a/kernel/gcov/Kconfig b/kernel/gcov/Kconfig > index 58f87a3092f3..053447183ac5 100644 > --- a/kernel/gcov/Kconfig > +++ b/kernel/gcov/Kconfig > @@ -5,6 +5,7 @@ config GCOV_KERNEL > bool "Enable gcov-based kernel profiling" > depends on DEBUG_FS > depends on !CC_IS_CLANG || CLANG_VERSION >= 110000 > + depends on !ARCH_WANTS_NO_INSTR || CC_HAS_NO_PROFILE_FN_ATTR > select CONSTRUCTORS > default n > help > diff --git a/kernel/pgo/Kconfig b/kernel/pgo/Kconfig > index d2053df1111c..ce7fe04f303d 100644 > --- a/kernel/pgo/Kconfig > +++ b/kernel/pgo/Kconfig > @@ -8,7 +8,8 @@ config PGO_CLANG > bool "Enable clang's PGO-based kernel profiling" > depends on DEBUG_FS > depends on ARCH_SUPPORTS_PGO_CLANG > - depends on CC_IS_CLANG && CLANG_VERSION >= 120000 > + depends on CC_IS_CLANG > + depends on !ARCH_WANTS_NO_INSTR || CC_HAS_NO_PROFILE_FN_ATTR > help > This option enables clang's PGO (Profile Guided Optimization) based > code profiling to better optimize the kernel. > -- > 2.32.0.288.g62a8d224e6-goog > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-06-22 9:06 UTC|newest] Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-06-21 23:18 [PATCH v2 0/3] no_profile fn attr and Kconfig for GCOV+PGO Nick Desaulniers 2021-06-21 23:18 ` Nick Desaulniers 2021-06-21 23:18 ` [PATCH v2 1/3] compiler_attributes.h: define __no_profile, add to noinstr Nick Desaulniers 2021-06-21 23:18 ` Nick Desaulniers 2021-06-21 23:41 ` Nathan Chancellor 2021-06-21 23:41 ` Nathan Chancellor 2021-06-21 23:18 ` [PATCH v2 2/3] compiler_attributes.h: cleanups for GCC 4.9+ Nick Desaulniers 2021-06-21 23:18 ` Nick Desaulniers 2021-06-21 23:31 ` Miguel Ojeda 2021-06-21 23:31 ` Miguel Ojeda 2021-06-21 23:42 ` Nathan Chancellor 2021-06-21 23:42 ` Nathan Chancellor 2021-06-21 23:18 ` [PATCH v2 3/3] Kconfig: add ARCH_WANTS_NO_INSTR+CC_HAS_NO_PROFILE_FN_ATTR, depend on for GCOV and PGO Nick Desaulniers 2021-06-21 23:18 ` Nick Desaulniers 2021-06-21 23:45 ` Nathan Chancellor 2021-06-21 23:45 ` Nathan Chancellor 2021-06-22 7:25 ` Peter Zijlstra 2021-06-22 7:25 ` Peter Zijlstra 2021-06-22 8:09 ` Marco Elver 2021-06-22 8:09 ` Marco Elver 2021-06-22 9:05 ` Mark Rutland [this message] 2021-06-22 9:05 ` Mark Rutland 2021-06-22 11:10 ` Will Deacon 2021-06-22 11:10 ` Will Deacon 2021-06-22 9:33 ` Heiko Carstens 2021-06-22 9:33 ` Heiko Carstens 2021-06-22 9:35 ` Peter Oberparleiter 2021-06-22 9:35 ` Peter Oberparleiter 2021-06-22 7:25 ` [PATCH v2 0/3] no_profile fn attr and Kconfig for GCOV+PGO Peter Zijlstra 2021-06-22 7:25 ` Peter Zijlstra 2021-06-22 18:19 ` Kees Cook 2021-06-22 18:19 ` Kees Cook 2021-06-23 6:15 ` Kees Cook 2021-06-23 6:15 ` Kees Cook 2021-06-24 19:36 ` Nick Desaulniers 2021-06-24 19:36 ` Nick Desaulniers
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20210622090540.GA67232@C02TD0UTHF1T.local \ --to=mark.rutland@arm.com \ --cc=akpm@linux-foundation.org \ --cc=ardb@kernel.org \ --cc=arnd@arndb.de \ --cc=borntraeger@de.ibm.com \ --cc=bp@alien8.de \ --cc=catalin.marinas@arm.com \ --cc=clang-built-linux@googlegroups.com \ --cc=corbet@lwn.net \ --cc=dvyukov@google.com \ --cc=elver@google.com \ --cc=gor@linux.ibm.com \ --cc=hca@linux.ibm.com \ --cc=johannes.berg@intel.com \ --cc=keescook@chromium.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-doc@vger.kernel.org \ --cc=linux-kbuild@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-s390@vger.kernel.org \ --cc=linux-toolchains@vger.kernel.org \ --cc=linux@rasmusvillemoes.dk \ --cc=luc.vanoostenryck@gmail.com \ --cc=masahiroy@kernel.org \ --cc=maskray@google.com \ --cc=miguel.ojeda.sandonis@gmail.com \ --cc=mliska@suse.cz \ --cc=nathan@kernel.org \ --cc=ndesaulniers@google.com \ --cc=oberpar@linux.ibm.com \ --cc=peterz@infradead.org \ --cc=samitolvanen@google.com \ --cc=wcw@google.com \ --cc=will@kernel.org \ --cc=x86@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.