Re: [PATCH v11 1/6] dt-bindings: remoteproc: Add Xilinx RPU subsystem bindings

From: Rob Herring <robh@kernel.org>
To: Tanmay Shah <tanmay.shah@amd.com>
Cc: krzysztof.kozlowski+dt@linaro.org,
	linux-arm-kernel@lists.infradead.org, andersson@kernel.org,
	linux-remoteproc@vger.kernel.org, michal.simek@amd.com,
	mathieu.poirier@linaro.org, robh+dt@kernel.org,
	devicetree@vger.kernel.org, bill.mills@linaro.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v11 1/6] dt-bindings: remoteproc: Add Xilinx RPU subsystem bindings
Date: Sun, 20 Nov 2022 10:18:40 -0600	[thread overview]
Message-ID: <166896111895.3153827.4429879978680534697.robh@kernel.org> (raw)
In-Reply-To: <20221114233940.2096237-2-tanmay.shah@amd.com>


On Mon, 14 Nov 2022 15:39:35 -0800, Tanmay Shah wrote:
> Xilinx ZynqMP platform has dual-core ARM Cortex R5 Realtime Processing
> Unit(RPU) subsystem. This patch adds dt-bindings for RPU subsystem
> (cluster).
> 
> Signed-off-by: Tanmay Shah <tanmay.shah@amd.com>
> ---
> 
> Changes in v11:
>   - rename binding filename to match with compatible string
>   - change $id: value accordingly as well
> 
> Changes in v10:
>   - rename example node to remoteproc
> 
> Changes in v9:
>   - remove power-domains property description
>   - fix nitpicks in description of other properties
> 
> Changes in v8:
>   - Add 'items:' for sram property
> 
> Changes in v7:
>   - Add minItems in sram property
> 
> Changes in v6:
>   - Add maxItems to sram and memory-region property
> 
> Changes in v5:
>   - Add constraints of the possible values of xlnx,cluster-mode property
>   - fix description of power-domains property for r5 core
>   - Remove reg, address-cells and size-cells properties as it is not required
>   - Fix description of mboxes property
>   - Add description of each memory-region and remove old .txt binding link
>     reference in the description
> 
> Changes in v4:
>   - Add memory-region, mboxes and mbox-names properties in example
> 
> Changes in v3:
>   - None
> 
>  .../remoteproc/xlnx,zynqmp-r5fss.yaml         | 135 ++++++++++++++++++
>  include/dt-bindings/power/xlnx-zynqmp-power.h |   6 +
>  2 files changed, 141 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/remoteproc/xlnx,zynqmp-r5fss.yaml
> 

Reviewed-by: Rob Herring <robh@kernel.org>