From: Mathieu Poirier <mathieu.poirier@linaro.org> To: Michal Simek <michal.simek@amd.com> Cc: Tanmay Shah <tanmay.shah@amd.com>, andersson@kernel.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, bill.mills@linaro.org, linux-remoteproc@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v11 2/6] arm64: dts: xilinx: zynqmp: Add RPU subsystem device node Date: Fri, 25 Nov 2022 09:13:47 -0700 [thread overview] Message-ID: <20221125161347.GA764010@p14s> (raw) In-Reply-To: <90fbb273-510b-279f-1582-8336136c5a0c@amd.com> On Fri, Nov 25, 2022 at 10:22:47AM +0100, Michal Simek wrote: > > > On 11/15/22 00:39, Tanmay Shah wrote: > > RPU subsystem can be configured in cluster-mode or split mode. > > Also each r5 core has separate power domains. > > > > Signed-off-by: Tanmay Shah <tanmay.shah@amd.com> > > --- > > > > Changes in v11: > > - None > > > > Changes in v10: > > - Rename node name to remoteproc > > > > Changes in v9: > > - remove unused labels > > > > Changes in v8: > > - None > > > > Changes in v7: > > - None > > > > Changes in v6: > > - None > > > > Changes in v5: > > - Remove optional reg property from r5fss node > > - Move r5fss node out of axi node > > > > Changes in v4: > > - Add reserved memory region node and use it in RPU subsystem node > > > > Changes in v3: > > - Fix checkpatch.pl style warning > > > > arch/arm64/boot/dts/xilinx/zynqmp.dtsi | 33 ++++++++++++++++++++++++++ > > 1 file changed, 33 insertions(+) > > > > diff --git a/arch/arm64/boot/dts/xilinx/zynqmp.dtsi b/arch/arm64/boot/dts/xilinx/zynqmp.dtsi > > index a549265e55f6..c0f60833c0ae 100644 > > --- a/arch/arm64/boot/dts/xilinx/zynqmp.dtsi > > +++ b/arch/arm64/boot/dts/xilinx/zynqmp.dtsi > > @@ -100,6 +100,22 @@ opp03 { > > }; > > }; > > + reserved-memory { > > + #address-cells = <2>; > > + #size-cells = <2>; > > + ranges; > > + > > + rproc_0_fw_image: memory@3ed00000 { > > + no-map; > > + reg = <0x0 0x3ed00000 0x0 0x40000>; > > + }; > > + > > + rproc_1_fw_image: memory@3ef00000 { > > + no-map; > > + reg = <0x0 0x3ef00000 0x0 0x40000>; > > + }; > > + }; > > + > > zynqmp_ipi: zynqmp_ipi { > > compatible = "xlnx,zynqmp-ipi-mailbox"; > > interrupt-parent = <&gic>; > > @@ -203,6 +219,23 @@ fpga_full: fpga-full { > > ranges; > > }; > > + remoteproc { > > + compatible = "xlnx,zynqmp-r5fss"; > > + xlnx,cluster-mode = <1>; > > + > > + r5f-0 { > > + compatible = "xlnx,zynqmp-r5f"; > > + power-domains = <&zynqmp_firmware PD_RPU_0>; > > + memory-region = <&rproc_0_fw_image>; > > + }; > > + > > + r5f-1 { > > + compatible = "xlnx,zynqmp-r5f"; > > + power-domains = <&zynqmp_firmware PD_RPU_1>; > > + memory-region = <&rproc_1_fw_image>; > > + }; > > + }; > > + > > amba: axi { > > compatible = "simple-bus"; > > #address-cells = <2>; > > Matthieu: If you want to take this via your tree here is mine. > > Acked-by: Michal Simek <michal.simek@amd.com> I have applied the whole set. Thanks, Mathieu > > In another case I will queue it for next release when dt binding is applied. > > Thanks, > Michal
WARNING: multiple messages have this Message-ID (diff)
From: Mathieu Poirier <mathieu.poirier@linaro.org> To: Michal Simek <michal.simek@amd.com> Cc: Tanmay Shah <tanmay.shah@amd.com>, andersson@kernel.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, bill.mills@linaro.org, linux-remoteproc@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v11 2/6] arm64: dts: xilinx: zynqmp: Add RPU subsystem device node Date: Fri, 25 Nov 2022 09:13:47 -0700 [thread overview] Message-ID: <20221125161347.GA764010@p14s> (raw) In-Reply-To: <90fbb273-510b-279f-1582-8336136c5a0c@amd.com> On Fri, Nov 25, 2022 at 10:22:47AM +0100, Michal Simek wrote: > > > On 11/15/22 00:39, Tanmay Shah wrote: > > RPU subsystem can be configured in cluster-mode or split mode. > > Also each r5 core has separate power domains. > > > > Signed-off-by: Tanmay Shah <tanmay.shah@amd.com> > > --- > > > > Changes in v11: > > - None > > > > Changes in v10: > > - Rename node name to remoteproc > > > > Changes in v9: > > - remove unused labels > > > > Changes in v8: > > - None > > > > Changes in v7: > > - None > > > > Changes in v6: > > - None > > > > Changes in v5: > > - Remove optional reg property from r5fss node > > - Move r5fss node out of axi node > > > > Changes in v4: > > - Add reserved memory region node and use it in RPU subsystem node > > > > Changes in v3: > > - Fix checkpatch.pl style warning > > > > arch/arm64/boot/dts/xilinx/zynqmp.dtsi | 33 ++++++++++++++++++++++++++ > > 1 file changed, 33 insertions(+) > > > > diff --git a/arch/arm64/boot/dts/xilinx/zynqmp.dtsi b/arch/arm64/boot/dts/xilinx/zynqmp.dtsi > > index a549265e55f6..c0f60833c0ae 100644 > > --- a/arch/arm64/boot/dts/xilinx/zynqmp.dtsi > > +++ b/arch/arm64/boot/dts/xilinx/zynqmp.dtsi > > @@ -100,6 +100,22 @@ opp03 { > > }; > > }; > > + reserved-memory { > > + #address-cells = <2>; > > + #size-cells = <2>; > > + ranges; > > + > > + rproc_0_fw_image: memory@3ed00000 { > > + no-map; > > + reg = <0x0 0x3ed00000 0x0 0x40000>; > > + }; > > + > > + rproc_1_fw_image: memory@3ef00000 { > > + no-map; > > + reg = <0x0 0x3ef00000 0x0 0x40000>; > > + }; > > + }; > > + > > zynqmp_ipi: zynqmp_ipi { > > compatible = "xlnx,zynqmp-ipi-mailbox"; > > interrupt-parent = <&gic>; > > @@ -203,6 +219,23 @@ fpga_full: fpga-full { > > ranges; > > }; > > + remoteproc { > > + compatible = "xlnx,zynqmp-r5fss"; > > + xlnx,cluster-mode = <1>; > > + > > + r5f-0 { > > + compatible = "xlnx,zynqmp-r5f"; > > + power-domains = <&zynqmp_firmware PD_RPU_0>; > > + memory-region = <&rproc_0_fw_image>; > > + }; > > + > > + r5f-1 { > > + compatible = "xlnx,zynqmp-r5f"; > > + power-domains = <&zynqmp_firmware PD_RPU_1>; > > + memory-region = <&rproc_1_fw_image>; > > + }; > > + }; > > + > > amba: axi { > > compatible = "simple-bus"; > > #address-cells = <2>; > > Matthieu: If you want to take this via your tree here is mine. > > Acked-by: Michal Simek <michal.simek@amd.com> I have applied the whole set. Thanks, Mathieu > > In another case I will queue it for next release when dt binding is applied. > > Thanks, > Michal _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-11-25 16:13 UTC|newest] Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-11-14 23:39 [PATCH v11 0/6] Add Xilinx RPU subsystem support Tanmay Shah 2022-11-14 23:39 ` Tanmay Shah 2022-11-14 23:39 ` [PATCH v11 1/6] dt-bindings: remoteproc: Add Xilinx RPU subsystem bindings Tanmay Shah 2022-11-14 23:39 ` Tanmay Shah 2022-11-20 16:18 ` Rob Herring 2022-11-20 16:18 ` Rob Herring 2022-11-14 23:39 ` [PATCH v11 2/6] arm64: dts: xilinx: zynqmp: Add RPU subsystem device node Tanmay Shah 2022-11-14 23:39 ` Tanmay Shah 2022-11-25 9:22 ` Michal Simek 2022-11-25 9:22 ` Michal Simek 2022-11-25 16:13 ` Mathieu Poirier [this message] 2022-11-25 16:13 ` Mathieu Poirier 2022-11-14 23:39 ` [PATCH v11 3/6] firmware: xilinx: Add ZynqMP firmware ioctl enums for RPU configuration Tanmay Shah 2022-11-14 23:39 ` Tanmay Shah 2022-11-14 23:39 ` [PATCH v11 4/6] firmware: xilinx: Add shutdown/wakeup APIs Tanmay Shah 2022-11-14 23:39 ` Tanmay Shah 2022-11-25 9:24 ` Michal Simek 2022-11-25 9:24 ` Michal Simek 2022-11-14 23:39 ` [PATCH v11 5/6] firmware: xilinx: Add RPU configuration APIs Tanmay Shah 2022-11-14 23:39 ` Tanmay Shah 2022-11-25 9:25 ` Michal Simek 2022-11-25 9:25 ` Michal Simek 2022-11-14 23:39 ` [PATCH v11 6/6] drivers: remoteproc: Add Xilinx r5 remoteproc driver Tanmay Shah 2022-11-14 23:39 ` Tanmay Shah 2022-11-16 18:38 ` [PATCH v11 0/6] Add Xilinx RPU subsystem support Mathieu Poirier 2022-11-16 18:38 ` Mathieu Poirier 2022-11-16 20:46 ` Tanmay Shah 2022-11-16 20:46 ` Tanmay Shah 2022-11-20 16:22 ` Rob Herring 2022-11-20 16:22 ` Rob Herring 2022-11-20 16:26 ` Rob Herring 2022-11-20 16:26 ` Rob Herring
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20221125161347.GA764010@p14s \ --to=mathieu.poirier@linaro.org \ --cc=andersson@kernel.org \ --cc=bill.mills@linaro.org \ --cc=devicetree@vger.kernel.org \ --cc=krzysztof.kozlowski+dt@linaro.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-remoteproc@vger.kernel.org \ --cc=michal.simek@amd.com \ --cc=robh+dt@kernel.org \ --cc=tanmay.shah@amd.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.