Re: [PATCH v11 2/5] dt-bindings: msm/dp: add data-lanes and link-frequencies property

From: Rob Herring <robh@kernel.org>
To: Kuogee Hsieh <quic_khsieh@quicinc.com>
Cc: vkoul@kernel.org, daniel@ffwll.ch, konrad.dybcio@somainline.org,
	robh+dt@kernel.org, dmitry.baryshkov@linaro.org,
	freedreno@lists.freedesktop.org, agross@kernel.org,
	dianders@chromium.org, dri-devel@lists.freedesktop.org,
	swboyd@chromium.org, linux-kernel@vger.kernel.org,
	robdclark@gmail.com, devicetree@vger.kernel.org,
	quic_sbillaka@quicinc.com, krzysztof.kozlowski+dt@linaro.org,
	linux-arm-msm@vger.kernel.org, airlied@linux.ie,
	quic_abhinavk@quicinc.com, andersson@kernel.org,
	airlied@gmail.com, sean@poorly.run
Subject: Re: [PATCH v11 2/5] dt-bindings: msm/dp: add data-lanes and link-frequencies property
Date: Fri, 09 Dec 2022 06:14:49 -0600	[thread overview]
Message-ID: <167058798233.2819544.12292613321491007286.robh@kernel.org> (raw)
In-Reply-To: <1670539015-11808-3-git-send-email-quic_khsieh@quicinc.com>

On Thu, 08 Dec 2022 14:36:52 -0800, Kuogee Hsieh wrote:
> Add both data-lanes and link-frequencies property into endpoint
> 
> Changes in v7:
> -- split yaml out of dtsi patch
> -- link-frequencies from link rate to symbol rate
> -- deprecation of old data-lanes property
> 
> Changes in v8:
> -- correct Bjorn mail address to kernel.org
> 
> Changes in v10:
> -- add menu item to data-lanes and link-frequecnis
> 
> Changes in v11:
> -- add endpoint property at port@1
> 
> Signed-off-by: Kuogee Hsieh <quic_khsieh@quicinc.com>`
> ---
>  .../bindings/display/msm/dp-controller.yaml        | 27 ++++++++++++++++++++++
>  1 file changed, 27 insertions(+)
> 

My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):

yamllint warnings/errors:

dtschema/dtc warnings/errors:
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/display/msm/dp-controller.yaml: properties:required: ['port@0', 'port@1'] is not of type 'object', 'boolean'
	from schema $id: http://json-schema.org/draft-07/schema#
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/display/msm/dp-controller.yaml: properties: 'required' should not be valid under {'$ref': '#/definitions/json-schema-prop-names'}
	hint: A json-schema keyword was found instead of a DT property name.
	from schema $id: http://devicetree.org/meta-schemas/keywords.yaml#
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/display/msm/dp-controller.yaml: ignoring, error in schema: properties: required
Documentation/devicetree/bindings/display/msm/dp-controller.example.dtb:0:0: /example-0/displayport-controller@ae90000: failed to match any schema with compatible: ['qcom,sc7180-dp']

doc reference errors (make refcheckdocs):

See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/1670539015-11808-3-git-send-email-quic_khsieh@quicinc.com

The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.