From: Kuogee Hsieh <quic_khsieh@quicinc.com> To: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>, <dri-devel@lists.freedesktop.org>, <robdclark@gmail.com>, <sean@poorly.run>, <swboyd@chromium.org>, <dianders@chromium.org>, <vkoul@kernel.org>, <daniel@ffwll.ch>, <airlied@linux.ie>, <agross@kernel.org>, <andersson@kernel.org>, <konrad.dybcio@somainline.org>, <robh+dt@kernel.org>, <krzysztof.kozlowski+dt@linaro.org>, <devicetree@vger.kernel.org>, <airlied@gmail.com> Cc: linux-arm-msm@vger.kernel.org, quic_sbillaka@quicinc.com, freedreno@lists.freedesktop.org, quic_abhinavk@quicinc.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH v11 2/5] dt-bindings: msm/dp: add data-lanes and link-frequencies property Date: Thu, 8 Dec 2022 15:38:24 -0800 [thread overview] Message-ID: <5aa16223-dbf6-996c-1985-794302dcce91@quicinc.com> (raw) In-Reply-To: <5a3865ed-8847-db04-3d60-f35438250bef@linaro.org> On 12/8/2022 3:33 PM, Dmitry Baryshkov wrote: > On 09/12/2022 00:36, Kuogee Hsieh wrote: >> Add both data-lanes and link-frequencies property into endpoint >> >> Changes in v7: >> -- split yaml out of dtsi patch >> -- link-frequencies from link rate to symbol rate >> -- deprecation of old data-lanes property >> >> Changes in v8: >> -- correct Bjorn mail address to kernel.org >> >> Changes in v10: >> -- add menu item to data-lanes and link-frequecnis >> >> Changes in v11: >> -- add endpoint property at port@1 >> >> Signed-off-by: Kuogee Hsieh <quic_khsieh@quicinc.com>` > > Applying: dt-bindings: msm/dp: add data-lanes and link-frequencies > property > .git/rebase-apply/patch:47: trailing whitespace. > > .git/rebase-apply/patch:51: trailing whitespace. > > > Also the dt_binding_check fails with an error for this schema. And > after fixing the error in the schema I faced an example validation > error. Did you check that the schema is correct and that the example > validates against the schema? yes, but i run "make dt_binding_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/display/msm/dp-controller.yaml" at mu v5.15 branch since "make dt_binding_check" does not work at msm-next branch. But I did not check trainiling whitespace this time. > >> --- >> .../bindings/display/msm/dp-controller.yaml | 27 >> ++++++++++++++++++++++ >> 1 file changed, 27 insertions(+) >> >> diff --git >> a/Documentation/devicetree/bindings/display/msm/dp-controller.yaml >> b/Documentation/devicetree/bindings/display/msm/dp-controller.yaml >> index f2515af..2a7fdef8 100644 >> --- a/Documentation/devicetree/bindings/display/msm/dp-controller.yaml >> +++ b/Documentation/devicetree/bindings/display/msm/dp-controller.yaml >> @@ -81,6 +81,7 @@ properties: >> data-lanes: >> $ref: /schemas/types.yaml#/definitions/uint32-array >> + deprecated: true >> minItems: 1 >> maxItems: 4 >> items: >> @@ -96,6 +97,7 @@ properties: >> ports: >> $ref: /schemas/graph.yaml#/properties/ports >> + >> properties: >> port@0: >> $ref: /schemas/graph.yaml#/properties/port >> @@ -105,6 +107,29 @@ properties: >> $ref: /schemas/graph.yaml#/properties/port >> description: Output endpoint of the controller >> + properties: >> + endpoint: >> + $ref: /schemas/media/video-interfaces.yaml# >> + >> + properties: >> + remote-endpoint: true > > PLease add empty lines between the property definitions > >> + data-lanes: >> + $ref: /schemas/types.yaml#/definitions/uint32-array > > This is already a part of video-interfaces, so you don't need $ref > >> + minItems: 1 >> + maxItems: 4 >> + items: >> + maximum: 3 > > enum: [0, 1, 2, 3] > >> + link-frequencies: >> + $ref: /schemas/types.yaml#/definitions/uint64-array >> + minItems: 1 >> + maxItems: 4 >> + items: >> + maximum: 8100000000 > > I think we can have enum here too. > >> + >> + required: >> + - port@0 >> + - port@1 >> + >> required: >> - compatible >> - reg >> @@ -193,6 +218,8 @@ examples: >> reg = <1>; >> endpoint { >> remote-endpoint = <&typec>; >> + data-lanes = <0 1>; >> + link-frequencies = /bits/ 64 <1620000000 >> 2700000000 5400000000 8100000000>; >> }; >> }; >> }; >
WARNING: multiple messages have this Message-ID (diff)
From: Kuogee Hsieh <quic_khsieh@quicinc.com> To: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>, <dri-devel@lists.freedesktop.org>, <robdclark@gmail.com>, <sean@poorly.run>, <swboyd@chromium.org>, <dianders@chromium.org>, <vkoul@kernel.org>, <daniel@ffwll.ch>, <airlied@linux.ie>, <agross@kernel.org>, <andersson@kernel.org>, <konrad.dybcio@somainline.org>, <robh+dt@kernel.org>, <krzysztof.kozlowski+dt@linaro.org>, <devicetree@vger.kernel.org>, <airlied@gmail.com> Cc: <quic_abhinavk@quicinc.com>, <quic_sbillaka@quicinc.com>, <freedreno@lists.freedesktop.org>, <linux-arm-msm@vger.kernel.org>, <linux-kernel@vger.kernel.org> Subject: Re: [PATCH v11 2/5] dt-bindings: msm/dp: add data-lanes and link-frequencies property Date: Thu, 8 Dec 2022 15:38:24 -0800 [thread overview] Message-ID: <5aa16223-dbf6-996c-1985-794302dcce91@quicinc.com> (raw) In-Reply-To: <5a3865ed-8847-db04-3d60-f35438250bef@linaro.org> On 12/8/2022 3:33 PM, Dmitry Baryshkov wrote: > On 09/12/2022 00:36, Kuogee Hsieh wrote: >> Add both data-lanes and link-frequencies property into endpoint >> >> Changes in v7: >> -- split yaml out of dtsi patch >> -- link-frequencies from link rate to symbol rate >> -- deprecation of old data-lanes property >> >> Changes in v8: >> -- correct Bjorn mail address to kernel.org >> >> Changes in v10: >> -- add menu item to data-lanes and link-frequecnis >> >> Changes in v11: >> -- add endpoint property at port@1 >> >> Signed-off-by: Kuogee Hsieh <quic_khsieh@quicinc.com>` > > Applying: dt-bindings: msm/dp: add data-lanes and link-frequencies > property > .git/rebase-apply/patch:47: trailing whitespace. > > .git/rebase-apply/patch:51: trailing whitespace. > > > Also the dt_binding_check fails with an error for this schema. And > after fixing the error in the schema I faced an example validation > error. Did you check that the schema is correct and that the example > validates against the schema? yes, but i run "make dt_binding_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/display/msm/dp-controller.yaml" at mu v5.15 branch since "make dt_binding_check" does not work at msm-next branch. But I did not check trainiling whitespace this time. > >> --- >> .../bindings/display/msm/dp-controller.yaml | 27 >> ++++++++++++++++++++++ >> 1 file changed, 27 insertions(+) >> >> diff --git >> a/Documentation/devicetree/bindings/display/msm/dp-controller.yaml >> b/Documentation/devicetree/bindings/display/msm/dp-controller.yaml >> index f2515af..2a7fdef8 100644 >> --- a/Documentation/devicetree/bindings/display/msm/dp-controller.yaml >> +++ b/Documentation/devicetree/bindings/display/msm/dp-controller.yaml >> @@ -81,6 +81,7 @@ properties: >> data-lanes: >> $ref: /schemas/types.yaml#/definitions/uint32-array >> + deprecated: true >> minItems: 1 >> maxItems: 4 >> items: >> @@ -96,6 +97,7 @@ properties: >> ports: >> $ref: /schemas/graph.yaml#/properties/ports >> + >> properties: >> port@0: >> $ref: /schemas/graph.yaml#/properties/port >> @@ -105,6 +107,29 @@ properties: >> $ref: /schemas/graph.yaml#/properties/port >> description: Output endpoint of the controller >> + properties: >> + endpoint: >> + $ref: /schemas/media/video-interfaces.yaml# >> + >> + properties: >> + remote-endpoint: true > > PLease add empty lines between the property definitions > >> + data-lanes: >> + $ref: /schemas/types.yaml#/definitions/uint32-array > > This is already a part of video-interfaces, so you don't need $ref > >> + minItems: 1 >> + maxItems: 4 >> + items: >> + maximum: 3 > > enum: [0, 1, 2, 3] > >> + link-frequencies: >> + $ref: /schemas/types.yaml#/definitions/uint64-array >> + minItems: 1 >> + maxItems: 4 >> + items: >> + maximum: 8100000000 > > I think we can have enum here too. > >> + >> + required: >> + - port@0 >> + - port@1 >> + >> required: >> - compatible >> - reg >> @@ -193,6 +218,8 @@ examples: >> reg = <1>; >> endpoint { >> remote-endpoint = <&typec>; >> + data-lanes = <0 1>; >> + link-frequencies = /bits/ 64 <1620000000 >> 2700000000 5400000000 8100000000>; >> }; >> }; >> }; >
next prev parent reply other threads:[~2022-12-08 23:38 UTC|newest] Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-12-08 22:36 [PATCH v11 0/5] Add data-lanes and link-frequencies to dp_out endpoint Kuogee Hsieh 2022-12-08 22:36 ` Kuogee Hsieh 2022-12-08 22:36 ` [PATCH v11 1/5] arm64: dts: qcom: add data-lanes and link-freuencies into " Kuogee Hsieh 2022-12-08 22:36 ` Kuogee Hsieh 2022-12-09 14:57 ` Krzysztof Kozlowski 2022-12-09 14:57 ` Krzysztof Kozlowski 2022-12-08 22:36 ` [PATCH v11 2/5] dt-bindings: msm/dp: add data-lanes and link-frequencies property Kuogee Hsieh 2022-12-08 22:36 ` Kuogee Hsieh 2022-12-08 23:33 ` Dmitry Baryshkov 2022-12-08 23:33 ` Dmitry Baryshkov 2022-12-08 23:38 ` Kuogee Hsieh [this message] 2022-12-08 23:38 ` Kuogee Hsieh 2022-12-09 0:11 ` Dmitry Baryshkov 2022-12-09 0:11 ` Dmitry Baryshkov 2022-12-09 0:22 ` Kuogee Hsieh 2022-12-09 0:22 ` Kuogee Hsieh 2022-12-09 0:35 ` Dmitry Baryshkov 2022-12-09 0:35 ` Dmitry Baryshkov 2022-12-12 17:51 ` Kuogee Hsieh 2022-12-12 17:51 ` Kuogee Hsieh 2022-12-12 22:35 ` Dmitry Baryshkov 2022-12-12 22:35 ` Dmitry Baryshkov 2022-12-12 23:41 ` Abhinav Kumar 2022-12-12 23:41 ` Abhinav Kumar 2022-12-13 1:02 ` Dmitry Baryshkov 2022-12-13 1:02 ` Dmitry Baryshkov 2022-12-13 13:13 ` Krzysztof Kozlowski 2022-12-13 13:13 ` Krzysztof Kozlowski 2022-12-13 17:31 ` [Freedreno] " Abhinav Kumar 2022-12-13 17:31 ` Abhinav Kumar 2022-12-13 19:22 ` Krzysztof Kozlowski 2022-12-13 19:22 ` Krzysztof Kozlowski 2022-12-09 14:59 ` Krzysztof Kozlowski 2022-12-09 14:59 ` Krzysztof Kozlowski 2022-12-09 12:14 ` Rob Herring 2022-12-09 12:14 ` Rob Herring 2022-12-08 22:36 ` [PATCH v11 3/5] drm/msm/dp: parser data-lanes as property of dp_out endpoint Kuogee Hsieh 2022-12-08 22:36 ` Kuogee Hsieh 2022-12-08 22:36 ` [PATCH v11 4/5] drm/msm/dp: parser link-frequencies " Kuogee Hsieh 2022-12-08 22:36 ` Kuogee Hsieh 2022-12-08 23:17 ` Dmitry Baryshkov 2022-12-08 23:17 ` Dmitry Baryshkov 2022-12-10 3:57 ` kernel test robot 2022-12-10 3:57 ` kernel test robot 2022-12-08 22:36 ` [PATCH v11 5/5] drm/msm/dp: add support of max dp link rate Kuogee Hsieh 2022-12-08 22:36 ` Kuogee Hsieh
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=5aa16223-dbf6-996c-1985-794302dcce91@quicinc.com \ --to=quic_khsieh@quicinc.com \ --cc=agross@kernel.org \ --cc=airlied@gmail.com \ --cc=airlied@linux.ie \ --cc=andersson@kernel.org \ --cc=daniel@ffwll.ch \ --cc=devicetree@vger.kernel.org \ --cc=dianders@chromium.org \ --cc=dmitry.baryshkov@linaro.org \ --cc=dri-devel@lists.freedesktop.org \ --cc=freedreno@lists.freedesktop.org \ --cc=konrad.dybcio@somainline.org \ --cc=krzysztof.kozlowski+dt@linaro.org \ --cc=linux-arm-msm@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=quic_abhinavk@quicinc.com \ --cc=quic_sbillaka@quicinc.com \ --cc=robdclark@gmail.com \ --cc=robh+dt@kernel.org \ --cc=sean@poorly.run \ --cc=swboyd@chromium.org \ --cc=vkoul@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.