From: Konrad Dybcio <konrad.dybcio@linaro.org>
To: Mark Brown <broonie@kernel.org>, Bartosz Golaszewski <brgl@bgdev.pl>
Cc: Marcel Holtmann <marcel@holtmann.org>,
Luiz Augusto von Dentz <luiz.dentz@gmail.com>,
"David S . Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>, Kalle Valo <kvalo@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Liam Girdwood <lgirdwood@gmail.com>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will@kernel.org>,
Bjorn Helgaas <bhelgaas@google.com>,
Saravana Kannan <saravanak@google.com>,
Geert Uytterhoeven <geert+renesas@glider.be>,
Arnd Bergmann <arnd@arndb.de>,
Neil Armstrong <neil.armstrong@linaro.org>,
Marek Szyprowski <m.szyprowski@samsung.com>,
Alex Elder <elder@linaro.org>,
Srini Kandagatla <srinivas.kandagatla@linaro.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Abel Vesa <abel.vesa@linaro.org>,
Manivannan Sadhasivam <mani@kernel.org>,
Lukas Wunner <lukas@wunner.de>,
Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
linux-bluetooth@vger.kernel.org, netdev@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-wireless@vger.kernel.org, linux-arm-msm@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, linux-pci@vger.kernel.org,
linux-pm@vger.kernel.org,
Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
Subject: Re: [PATCH v5 14/18] PCI/pwrctl: add a power control driver for WCN7850
Date: Tue, 20 Feb 2024 22:21:04 +0100 [thread overview]
Message-ID: <17bbd9ae-0282-430e-947b-e6fb08c53af7@linaro.org> (raw)
In-Reply-To: <ea08a286-ff53-4d58-ae41-38cca151508c@sirena.org.uk>
On 20.02.2024 13:47, Mark Brown wrote:
> On Tue, Feb 20, 2024 at 12:22:42PM +0100, Bartosz Golaszewski wrote:
>> On Mon, Feb 19, 2024 at 6:50 PM Mark Brown <broonie@kernel.org> wrote:
>>> On Fri, Feb 16, 2024 at 09:32:11PM +0100, Bartosz Golaszewski wrote:
>
>>>> +static struct pci_pwrctl_wcn7850_vreg pci_pwrctl_wcn7850_vregs[] = {
>>>> + {
>>>> + .name = "vdd",
>>>> + .load_uA = 16000,
>>>> + },
>
>>> I know a bunch of the QC stuff includes these load numbers but are they
>>> actually doing anything constructive? It keeps coming up that they're
>>> causing a bunch of work and it's not clear that they have any great
>>> effect on modern systems.
>
>> Yes, we have what is called a high-power mode and a low-power mode in
>> regulators and these values are used to determine which one to use.
>
> Are you *sure* this actually happens (and that the regulators don't
> figure it out by themselves), especially given that the consumers are
> just specifying the load once rather than varying it dynamically at
> runtime which is supposed to be the use case for this API? This API is
> intended to be used dynamically, if the regulator always needs to be in
> a particular mode just configure that statically.
*AFAIU*
The regulators aggregate the requested current (there may be
multiple consumers) and then it's decided if it's high enough
to jump into HPM.
Konrad
WARNING: multiple messages have this Message-ID (diff)
From: Konrad Dybcio <konrad.dybcio@linaro.org>
To: Mark Brown <broonie@kernel.org>, Bartosz Golaszewski <brgl@bgdev.pl>
Cc: Marcel Holtmann <marcel@holtmann.org>,
Luiz Augusto von Dentz <luiz.dentz@gmail.com>,
"David S . Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>, Kalle Valo <kvalo@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Liam Girdwood <lgirdwood@gmail.com>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will@kernel.org>,
Bjorn Helgaas <bhelgaas@google.com>,
Saravana Kannan <saravanak@google.com>,
Geert Uytterhoeven <geert+renesas@glider.be>,
Arnd Bergmann <arnd@arndb.de>,
Neil Armstrong <neil.armstrong@linaro.org>,
Marek Szyprowski <m.szyprowski@samsung.com>,
Alex Elder <elder@linaro.org>,
Srini Kandagatla <srinivas.kandagatla@linaro.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Abel Vesa <abel.vesa@linaro.org>,
Manivannan Sadhasivam <mani@kernel.org>,
Lukas Wunner <lukas@wunner.de>,
Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
linux-bluetooth@vger.kernel.org, netdev@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-wireless@vger.kernel.org, linux-arm-msm@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, linux-pci@vger.kernel.org,
linux-pm@vger.kernel.org,
Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
Subject: Re: [PATCH v5 14/18] PCI/pwrctl: add a power control driver for WCN7850
Date: Tue, 20 Feb 2024 22:21:04 +0100 [thread overview]
Message-ID: <17bbd9ae-0282-430e-947b-e6fb08c53af7@linaro.org> (raw)
In-Reply-To: <ea08a286-ff53-4d58-ae41-38cca151508c@sirena.org.uk>
On 20.02.2024 13:47, Mark Brown wrote:
> On Tue, Feb 20, 2024 at 12:22:42PM +0100, Bartosz Golaszewski wrote:
>> On Mon, Feb 19, 2024 at 6:50 PM Mark Brown <broonie@kernel.org> wrote:
>>> On Fri, Feb 16, 2024 at 09:32:11PM +0100, Bartosz Golaszewski wrote:
>
>>>> +static struct pci_pwrctl_wcn7850_vreg pci_pwrctl_wcn7850_vregs[] = {
>>>> + {
>>>> + .name = "vdd",
>>>> + .load_uA = 16000,
>>>> + },
>
>>> I know a bunch of the QC stuff includes these load numbers but are they
>>> actually doing anything constructive? It keeps coming up that they're
>>> causing a bunch of work and it's not clear that they have any great
>>> effect on modern systems.
>
>> Yes, we have what is called a high-power mode and a low-power mode in
>> regulators and these values are used to determine which one to use.
>
> Are you *sure* this actually happens (and that the regulators don't
> figure it out by themselves), especially given that the consumers are
> just specifying the load once rather than varying it dynamically at
> runtime which is supposed to be the use case for this API? This API is
> intended to be used dynamically, if the regulator always needs to be in
> a particular mode just configure that statically.
*AFAIU*
The regulators aggregate the requested current (there may be
multiple consumers) and then it's decided if it's high enough
to jump into HPM.
Konrad
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2024-02-20 21:21 UTC|newest]
Thread overview: 159+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-16 20:31 [PATCH v5 00/18] power: sequencing: implement the subsystem and add first users Bartosz Golaszewski
2024-02-16 20:31 ` Bartosz Golaszewski
2024-02-16 20:31 ` [PATCH v5 01/18] of: Add cleanup.h based auto release via __free(device_node) markings Bartosz Golaszewski
2024-02-16 20:31 ` Bartosz Golaszewski
2024-02-16 20:36 ` power: sequencing: implement the subsystem and add first users bluez.test.bot
2024-02-16 20:31 ` [PATCH v5 02/18] arm64: defconfig: enable ath12k as a module Bartosz Golaszewski
2024-02-16 20:31 ` Bartosz Golaszewski
2024-02-19 7:31 ` Krzysztof Kozlowski
2024-02-19 7:31 ` Krzysztof Kozlowski
2024-02-19 7:56 ` Bartosz Golaszewski
2024-02-19 7:56 ` Bartosz Golaszewski
2024-02-16 20:32 ` [PATCH v5 03/18] dt-bindings: regulator: describe the PMU module of the QCA6390 package Bartosz Golaszewski
2024-02-16 20:32 ` Bartosz Golaszewski
2024-02-17 15:48 ` Mark Brown
2024-02-17 15:48 ` Mark Brown
2024-02-17 18:32 ` Bartosz Golaszewski
2024-02-17 18:32 ` Bartosz Golaszewski
2024-02-17 20:43 ` Mark Brown
2024-02-17 20:43 ` Mark Brown
2024-02-19 7:32 ` Krzysztof Kozlowski
2024-02-19 7:32 ` Krzysztof Kozlowski
2024-02-19 12:53 ` Bartosz Golaszewski
2024-02-19 12:53 ` Bartosz Golaszewski
2024-02-19 21:23 ` Krzysztof Kozlowski
2024-02-19 21:23 ` Krzysztof Kozlowski
2024-02-19 7:34 ` Krzysztof Kozlowski
2024-02-19 7:34 ` Krzysztof Kozlowski
2024-02-16 20:32 ` [PATCH v5 04/18] dt-bindings: net: bluetooth: qualcomm: describe regulators for QCA6390 Bartosz Golaszewski
2024-02-16 20:32 ` Bartosz Golaszewski
2024-02-19 7:34 ` Krzysztof Kozlowski
2024-02-19 7:34 ` Krzysztof Kozlowski
2024-02-16 20:32 ` [PATCH v5 05/18] dt-bindings: new: wireless: qcom,ath11k: describe the ath11k on QCA6390 Bartosz Golaszewski
2024-02-16 20:32 ` Bartosz Golaszewski
2024-02-16 20:32 ` [PATCH v5 06/18] dt-bindings: new: wireless: describe the ath12k PCI module Bartosz Golaszewski
2024-02-16 20:32 ` Bartosz Golaszewski
2024-02-17 6:34 ` Kalle Valo
2024-02-17 6:34 ` Kalle Valo
2024-02-17 18:30 ` Bartosz Golaszewski
2024-02-17 18:30 ` Bartosz Golaszewski
2024-02-17 20:02 ` Jeff Johnson
2024-02-17 20:02 ` Jeff Johnson
2024-02-19 7:38 ` Krzysztof Kozlowski
2024-02-19 7:38 ` Krzysztof Kozlowski
2024-02-22 23:56 ` Rob Herring
2024-02-22 23:56 ` Rob Herring
2024-02-16 20:32 ` [PATCH v5 07/18] arm64: dts: qcom: sm8550-qrd: add the Wifi node Bartosz Golaszewski
2024-02-16 20:32 ` Bartosz Golaszewski
2024-02-16 20:32 ` [PATCH v5 08/18] arm64: dts: qcom: sm8650-qrd: " Bartosz Golaszewski
2024-02-16 20:32 ` Bartosz Golaszewski
2024-02-16 23:09 ` Dmitry Baryshkov
2024-02-16 23:09 ` Dmitry Baryshkov
2024-02-17 18:53 ` Bartosz Golaszewski
2024-02-17 18:53 ` Bartosz Golaszewski
2024-02-16 20:32 ` [PATCH v5 09/18] arm64: dts: qcom: qrb5165-rb5: model the PMU of the QCA6391 Bartosz Golaszewski
2024-02-16 20:32 ` Bartosz Golaszewski
2024-02-19 18:03 ` Mark Brown
2024-02-19 18:03 ` Mark Brown
2024-02-19 18:48 ` Bartosz Golaszewski
2024-02-19 18:48 ` Bartosz Golaszewski
2024-02-19 19:59 ` Mark Brown
2024-02-19 19:59 ` Mark Brown
2024-02-20 11:16 ` Bartosz Golaszewski
2024-02-20 11:16 ` Bartosz Golaszewski
2024-02-20 13:31 ` Mark Brown
2024-02-20 13:31 ` Mark Brown
2024-02-20 13:38 ` Bartosz Golaszewski
2024-02-20 13:38 ` Bartosz Golaszewski
2024-02-20 13:48 ` Mark Brown
2024-02-20 13:48 ` Mark Brown
2024-02-20 13:51 ` Bartosz Golaszewski
2024-02-20 13:51 ` Bartosz Golaszewski
2024-02-20 14:10 ` Mark Brown
2024-02-20 14:10 ` Mark Brown
2024-02-20 16:30 ` Dmitry Baryshkov
2024-02-20 16:30 ` Dmitry Baryshkov
2024-02-20 17:53 ` Bartosz Golaszewski
2024-02-20 17:53 ` Bartosz Golaszewski
2024-02-20 18:11 ` Dmitry Baryshkov
2024-02-20 18:11 ` Dmitry Baryshkov
2024-02-16 20:32 ` [PATCH v5 10/18] PCI: hold the rescan mutex when scanning for the first time Bartosz Golaszewski
2024-02-16 20:32 ` Bartosz Golaszewski
2024-02-16 20:32 ` [PATCH v5 11/18] PCI/pwrctl: reuse the OF node for power controlled devices Bartosz Golaszewski
2024-02-16 20:32 ` Bartosz Golaszewski
2024-02-16 20:32 ` [PATCH v5 12/18] PCI/pwrctl: create platform devices for child OF nodes of the port node Bartosz Golaszewski
2024-02-16 20:32 ` Bartosz Golaszewski
2024-02-16 20:32 ` [PATCH v5 13/18] PCI/pwrctl: add PCI power control core code Bartosz Golaszewski
2024-02-16 20:32 ` Bartosz Golaszewski
2024-02-16 20:32 ` [PATCH v5 14/18] PCI/pwrctl: add a power control driver for WCN7850 Bartosz Golaszewski
2024-02-16 20:32 ` Bartosz Golaszewski
2024-02-18 12:25 ` kernel test robot
2024-02-19 17:49 ` Mark Brown
2024-02-19 17:49 ` Mark Brown
2024-02-20 11:22 ` Bartosz Golaszewski
2024-02-20 11:22 ` Bartosz Golaszewski
2024-02-20 12:47 ` Mark Brown
2024-02-20 12:47 ` Mark Brown
2024-02-20 21:21 ` Konrad Dybcio [this message]
2024-02-20 21:21 ` Konrad Dybcio
2024-02-20 23:44 ` Mark Brown
2024-02-20 23:44 ` Mark Brown
2024-02-22 9:22 ` Bartosz Golaszewski
2024-02-22 9:22 ` Bartosz Golaszewski
2024-02-22 12:21 ` Mark Brown
2024-02-22 12:21 ` Mark Brown
2024-02-22 12:26 ` Bartosz Golaszewski
2024-02-22 12:26 ` Bartosz Golaszewski
2024-02-22 13:15 ` Mark Brown
2024-02-22 13:15 ` Mark Brown
2024-02-22 13:26 ` Bartosz Golaszewski
2024-02-22 13:26 ` Bartosz Golaszewski
2024-02-16 20:32 ` [PATCH v5 15/18] power: sequencing: implement the pwrseq core Bartosz Golaszewski
2024-02-16 20:32 ` Bartosz Golaszewski
2024-02-18 16:26 ` kernel test robot
2024-02-16 20:32 ` [PATCH v5 16/18] power: pwrseq: add a driver for the QCA6390 PMU module Bartosz Golaszewski
2024-02-16 20:32 ` Bartosz Golaszewski
2024-02-16 23:17 ` Dmitry Baryshkov
2024-02-16 23:17 ` Dmitry Baryshkov
2024-02-17 19:09 ` Bartosz Golaszewski
2024-02-17 19:09 ` Bartosz Golaszewski
2024-02-16 20:32 ` [PATCH v5 17/18] Bluetooth: qca: use the power sequencer for QCA6390 Bartosz Golaszewski
2024-02-16 20:32 ` Bartosz Golaszewski
2024-02-16 20:32 ` [PATCH v5 18/18] PCI/pwrctl: add a PCI power control driver for power sequenced devices Bartosz Golaszewski
2024-02-16 20:32 ` Bartosz Golaszewski
2024-02-18 12:53 ` [PATCH v5 00/18] power: sequencing: implement the subsystem and add first users Dmitry Baryshkov
2024-02-18 12:53 ` Dmitry Baryshkov
2024-02-19 8:14 ` Neil Armstrong
2024-02-19 8:14 ` Neil Armstrong
2024-02-19 9:22 ` Dmitry Baryshkov
2024-02-19 9:22 ` Dmitry Baryshkov
2024-02-19 9:42 ` neil.armstrong
2024-02-19 9:42 ` neil.armstrong
2024-02-19 10:26 ` Dmitry Baryshkov
2024-02-19 10:26 ` Dmitry Baryshkov
2024-02-19 12:23 ` Bartosz Golaszewski
2024-02-19 12:23 ` Bartosz Golaszewski
2024-02-19 12:33 ` Dmitry Baryshkov
2024-02-19 12:33 ` Dmitry Baryshkov
2024-02-19 17:18 ` neil.armstrong
2024-02-19 17:18 ` neil.armstrong
2024-02-19 22:21 ` Dmitry Baryshkov
2024-02-19 22:21 ` Dmitry Baryshkov
2024-02-22 11:00 ` Bartosz Golaszewski
2024-02-22 11:00 ` Bartosz Golaszewski
2024-02-22 11:26 ` Dmitry Baryshkov
2024-02-22 11:26 ` Dmitry Baryshkov
2024-02-22 12:27 ` Bartosz Golaszewski
2024-02-22 12:27 ` Bartosz Golaszewski
2024-02-22 12:47 ` Dmitry Baryshkov
2024-02-22 12:47 ` Dmitry Baryshkov
2024-02-22 12:50 ` Bartosz Golaszewski
2024-02-22 12:50 ` Bartosz Golaszewski
2024-02-22 13:46 ` neil.armstrong
2024-02-22 13:46 ` neil.armstrong
2024-02-24 8:52 ` Krzysztof Kozlowski
2024-02-24 8:52 ` Krzysztof Kozlowski
2024-02-19 8:16 ` Neil Armstrong
2024-02-19 8:16 ` Neil Armstrong
2024-03-05 12:50 ` Amit Pundir
2024-03-05 12:50 ` Amit Pundir
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=17bbd9ae-0282-430e-947b-e6fb08c53af7@linaro.org \
--to=konrad.dybcio@linaro.org \
--cc=abel.vesa@linaro.org \
--cc=andersson@kernel.org \
--cc=arnd@arndb.de \
--cc=bartosz.golaszewski@linaro.org \
--cc=bhelgaas@google.com \
--cc=brgl@bgdev.pl \
--cc=broonie@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=conor+dt@kernel.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=edumazet@google.com \
--cc=elder@linaro.org \
--cc=geert+renesas@glider.be \
--cc=gregkh@linuxfoundation.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=kuba@kernel.org \
--cc=kvalo@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-bluetooth@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=luiz.dentz@gmail.com \
--cc=lukas@wunner.de \
--cc=m.szyprowski@samsung.com \
--cc=mani@kernel.org \
--cc=marcel@holtmann.org \
--cc=neil.armstrong@linaro.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=robh@kernel.org \
--cc=saravanak@google.com \
--cc=srinivas.kandagatla@linaro.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.