From: "Enrico Weigelt, metux IT consult" <lkml@metux.net>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-serial@vger.kernel.org
Cc: Kukjin Kim <kgene@kernel.org>,
Krzysztof Kozlowski <krzk@kernel.org>,
Hyunki Koo <kkoos00@naver.com>,
HYUN-KI KOO <hyunki00.koo@samsung.com>,
Shinbeom Choi <sbeom.choi@samsung.com>,
Jiri Slaby <jslaby@suse.com>,
linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 02/10] tty: serial: samsung_tty: fix build warning
Date: Wed, 11 Dec 2019 12:01:28 +0100 [thread overview]
Message-ID: <181db297-2865-5b34-6ef1-e410babaf3bb@metux.net> (raw)
In-Reply-To: <20191210143706.3928480-2-gregkh@linuxfoundation.org>
On 10.12.19 15:36, Greg Kroah-Hartman wrote:
Hi,
> diff --git a/drivers/tty/serial/samsung_tty.c b/drivers/tty/serial/samsung_tty.c
> index 83fd51607741..67c5a84d0a26 100644
> --- a/drivers/tty/serial/samsung_tty.c
> +++ b/drivers/tty/serial/samsung_tty.c
> @@ -1851,7 +1851,10 @@ static int s3c24xx_serial_init_port(struct s3c24xx_uart_port *ourport,
>
> /* Device driver serial port probe */
>
> +#ifdef CONFIG_OF
> static const struct of_device_id s3c24xx_uart_dt_match[];
> +#endif
> +
By the way: I've got some patch for conditionally declaring of match
tables (including MODULE_DEVICE_TABE() call), so such ifdef's aren't
needed anymore.
Would you like to see it ?
(IIRC already posted it quite some time ago, but probably went
unnoticed)
--mtx
---
Enrico Weigelt, metux IT consult
Free software and Linux embedded engineering
info@metux.net -- +49-151-27565287
WARNING: multiple messages have this Message-ID (diff)
From: "Enrico Weigelt, metux IT consult" <lkml@metux.net>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-serial@vger.kernel.org
Cc: linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org,
Krzysztof Kozlowski <krzk@kernel.org>,
Shinbeom Choi <sbeom.choi@samsung.com>,
Hyunki Koo <kkoos00@naver.com>, Kukjin Kim <kgene@kernel.org>,
linux-arm-kernel@lists.infradead.org,
Jiri Slaby <jslaby@suse.com>,
HYUN-KI KOO <hyunki00.koo@samsung.com>
Subject: Re: [PATCH 02/10] tty: serial: samsung_tty: fix build warning
Date: Wed, 11 Dec 2019 12:01:28 +0100 [thread overview]
Message-ID: <181db297-2865-5b34-6ef1-e410babaf3bb@metux.net> (raw)
In-Reply-To: <20191210143706.3928480-2-gregkh@linuxfoundation.org>
On 10.12.19 15:36, Greg Kroah-Hartman wrote:
Hi,
> diff --git a/drivers/tty/serial/samsung_tty.c b/drivers/tty/serial/samsung_tty.c
> index 83fd51607741..67c5a84d0a26 100644
> --- a/drivers/tty/serial/samsung_tty.c
> +++ b/drivers/tty/serial/samsung_tty.c
> @@ -1851,7 +1851,10 @@ static int s3c24xx_serial_init_port(struct s3c24xx_uart_port *ourport,
>
> /* Device driver serial port probe */
>
> +#ifdef CONFIG_OF
> static const struct of_device_id s3c24xx_uart_dt_match[];
> +#endif
> +
By the way: I've got some patch for conditionally declaring of match
tables (including MODULE_DEVICE_TABE() call), so such ifdef's aren't
needed anymore.
Would you like to see it ?
(IIRC already posted it quite some time ago, but probably went
unnoticed)
--mtx
---
Enrico Weigelt, metux IT consult
Free software and Linux embedded engineering
info@metux.net -- +49-151-27565287
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-12-11 11:02 UTC|newest]
Thread overview: 60+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-10 14:36 [PATCH 01/10] tty: serial: samsung: allow driver to be built by anyone Greg Kroah-Hartman
2019-12-10 14:36 ` Greg Kroah-Hartman
2019-12-10 14:36 ` [PATCH 02/10] tty: serial: samsung_tty: fix build warning Greg Kroah-Hartman
2019-12-10 14:36 ` Greg Kroah-Hartman
2019-12-10 14:48 ` Krzysztof Kozlowski
2019-12-10 14:48 ` Krzysztof Kozlowski
2019-12-11 11:01 ` Enrico Weigelt, metux IT consult [this message]
2019-12-11 11:01 ` Enrico Weigelt, metux IT consult
2019-12-11 12:13 ` Greg Kroah-Hartman
2019-12-11 12:13 ` Greg Kroah-Hartman
2019-12-10 14:36 ` [PATCH 03/10] tty: serial: samsung.h: fix up minor comment issues Greg Kroah-Hartman
2019-12-10 14:36 ` Greg Kroah-Hartman
2019-12-10 15:12 ` Krzysztof Kozlowski
2019-12-10 15:12 ` Krzysztof Kozlowski
2019-12-12 11:06 ` Greg Kroah-Hartman
2019-12-12 11:06 ` Greg Kroah-Hartman
2019-12-10 14:37 ` [PATCH 04/10] tty: serial: samsung.h: remove reset_port callback from struct s3c24xx_uart_info Greg Kroah-Hartman
2019-12-10 14:37 ` Greg Kroah-Hartman
2019-12-10 14:50 ` Krzysztof Kozlowski
2019-12-10 14:50 ` Krzysztof Kozlowski
2019-12-10 14:37 ` [PATCH 05/10] tty: serial: samsung_tty: delete samsung.h Greg Kroah-Hartman
2019-12-10 14:37 ` Greg Kroah-Hartman
2019-12-10 14:52 ` Krzysztof Kozlowski
2019-12-10 14:52 ` Krzysztof Kozlowski
2019-12-10 14:37 ` [PATCH 06/10] tty: serial: samsung_tty: drop unneded dbg() calls Greg Kroah-Hartman
2019-12-10 14:37 ` Greg Kroah-Hartman
2019-12-10 14:53 ` Krzysztof Kozlowski
2019-12-10 14:53 ` Krzysztof Kozlowski
2019-12-10 14:37 ` [PATCH 07/10] tty: serial: samsung_tty: use standard debugging macros Greg Kroah-Hartman
2019-12-10 14:37 ` Greg Kroah-Hartman
2019-12-10 15:10 ` Krzysztof Kozlowski
2019-12-10 15:10 ` Krzysztof Kozlowski
2019-12-10 14:37 ` [PATCH 08/10] tty: serial: samsung_tty: use 'unsigned int' not 'unsigned' Greg Kroah-Hartman
2019-12-10 14:37 ` Greg Kroah-Hartman
2019-12-10 15:10 ` Krzysztof Kozlowski
2019-12-10 15:10 ` Krzysztof Kozlowski
2019-12-10 15:12 ` Marc Gonzalez
2019-12-10 15:12 ` Marc Gonzalez
2019-12-12 11:08 ` Greg Kroah-Hartman
2019-12-12 11:08 ` Greg Kroah-Hartman
2019-12-12 16:09 ` Christoph Hellwig
2019-12-12 16:09 ` Christoph Hellwig
2019-12-12 16:12 ` Greg Kroah-Hartman
2019-12-12 16:12 ` Greg Kroah-Hartman
2019-12-19 9:25 ` Marc Gonzalez
2019-12-19 9:25 ` Marc Gonzalez
2019-12-10 14:37 ` [PATCH 09/10] tty: serial: samsung_tty: fix up minor comment formatting Greg Kroah-Hartman
2019-12-10 14:37 ` Greg Kroah-Hartman
2019-12-10 15:14 ` Krzysztof Kozlowski
2019-12-10 15:14 ` Krzysztof Kozlowski
2019-12-10 14:37 ` [PATCH 10/10] tty: serial: samsung_tty: fix blank line checkpatch warning Greg Kroah-Hartman
2019-12-10 14:37 ` Greg Kroah-Hartman
2019-12-10 15:13 ` Krzysztof Kozlowski
2019-12-10 15:13 ` Krzysztof Kozlowski
2019-12-12 11:09 ` Greg Kroah-Hartman
2019-12-12 11:09 ` Greg Kroah-Hartman
2019-12-10 14:46 ` [PATCH 01/10] tty: serial: samsung: allow driver to be built by anyone Krzysztof Kozlowski
2019-12-10 14:46 ` Krzysztof Kozlowski
2019-12-10 14:54 ` Greg Kroah-Hartman
2019-12-10 14:54 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=181db297-2865-5b34-6ef1-e410babaf3bb@metux.net \
--to=lkml@metux.net \
--cc=gregkh@linuxfoundation.org \
--cc=hyunki00.koo@samsung.com \
--cc=jslaby@suse.com \
--cc=kgene@kernel.org \
--cc=kkoos00@naver.com \
--cc=krzk@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=sbeom.choi@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.