From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Christoph Hellwig <hch@infradead.org>
Cc: Marc Gonzalez <marc.w.gonzalez@free.fr>,
LKML <linux-kernel@vger.kernel.org>,
Linux ARM <linux-arm-kernel@lists.infradead.org>,
linux-serial <linux-serial@vger.kernel.org>,
Jiri Slaby <jslaby@suse.com>
Subject: Re: [PATCH 08/10] tty: serial: samsung_tty: use 'unsigned int' not 'unsigned'
Date: Thu, 12 Dec 2019 17:12:34 +0100 [thread overview]
Message-ID: <20191212161234.GA1673430@kroah.com> (raw)
In-Reply-To: <20191212160949.GA10815@infradead.org>
On Thu, Dec 12, 2019 at 08:09:49AM -0800, Christoph Hellwig wrote:
> On Thu, Dec 12, 2019 at 12:08:34PM +0100, Greg Kroah-Hartman wrote:
> > Yes. It's a long-time checkpatch warning, it's good to be explicit for
> > this type of thing.
>
> There is literally no practical benefit going either way. It is
> just checkpatch forcing one personal opinion on people.
Fair enough, but, I was trying to align up the variables to be the same
type that was then used in a function call. That's the only reason I
made this change.
thanks,
greg k-h
WARNING: multiple messages have this Message-ID (diff)
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Christoph Hellwig <hch@infradead.org>
Cc: Jiri Slaby <jslaby@suse.com>,
linux-serial <linux-serial@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
Linux ARM <linux-arm-kernel@lists.infradead.org>,
Marc Gonzalez <marc.w.gonzalez@free.fr>
Subject: Re: [PATCH 08/10] tty: serial: samsung_tty: use 'unsigned int' not 'unsigned'
Date: Thu, 12 Dec 2019 17:12:34 +0100 [thread overview]
Message-ID: <20191212161234.GA1673430@kroah.com> (raw)
In-Reply-To: <20191212160949.GA10815@infradead.org>
On Thu, Dec 12, 2019 at 08:09:49AM -0800, Christoph Hellwig wrote:
> On Thu, Dec 12, 2019 at 12:08:34PM +0100, Greg Kroah-Hartman wrote:
> > Yes. It's a long-time checkpatch warning, it's good to be explicit for
> > this type of thing.
>
> There is literally no practical benefit going either way. It is
> just checkpatch forcing one personal opinion on people.
Fair enough, but, I was trying to align up the variables to be the same
type that was then used in a function call. That's the only reason I
made this change.
thanks,
greg k-h
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-12-12 16:12 UTC|newest]
Thread overview: 60+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-10 14:36 [PATCH 01/10] tty: serial: samsung: allow driver to be built by anyone Greg Kroah-Hartman
2019-12-10 14:36 ` Greg Kroah-Hartman
2019-12-10 14:36 ` [PATCH 02/10] tty: serial: samsung_tty: fix build warning Greg Kroah-Hartman
2019-12-10 14:36 ` Greg Kroah-Hartman
2019-12-10 14:48 ` Krzysztof Kozlowski
2019-12-10 14:48 ` Krzysztof Kozlowski
2019-12-11 11:01 ` Enrico Weigelt, metux IT consult
2019-12-11 11:01 ` Enrico Weigelt, metux IT consult
2019-12-11 12:13 ` Greg Kroah-Hartman
2019-12-11 12:13 ` Greg Kroah-Hartman
2019-12-10 14:36 ` [PATCH 03/10] tty: serial: samsung.h: fix up minor comment issues Greg Kroah-Hartman
2019-12-10 14:36 ` Greg Kroah-Hartman
2019-12-10 15:12 ` Krzysztof Kozlowski
2019-12-10 15:12 ` Krzysztof Kozlowski
2019-12-12 11:06 ` Greg Kroah-Hartman
2019-12-12 11:06 ` Greg Kroah-Hartman
2019-12-10 14:37 ` [PATCH 04/10] tty: serial: samsung.h: remove reset_port callback from struct s3c24xx_uart_info Greg Kroah-Hartman
2019-12-10 14:37 ` Greg Kroah-Hartman
2019-12-10 14:50 ` Krzysztof Kozlowski
2019-12-10 14:50 ` Krzysztof Kozlowski
2019-12-10 14:37 ` [PATCH 05/10] tty: serial: samsung_tty: delete samsung.h Greg Kroah-Hartman
2019-12-10 14:37 ` Greg Kroah-Hartman
2019-12-10 14:52 ` Krzysztof Kozlowski
2019-12-10 14:52 ` Krzysztof Kozlowski
2019-12-10 14:37 ` [PATCH 06/10] tty: serial: samsung_tty: drop unneded dbg() calls Greg Kroah-Hartman
2019-12-10 14:37 ` Greg Kroah-Hartman
2019-12-10 14:53 ` Krzysztof Kozlowski
2019-12-10 14:53 ` Krzysztof Kozlowski
2019-12-10 14:37 ` [PATCH 07/10] tty: serial: samsung_tty: use standard debugging macros Greg Kroah-Hartman
2019-12-10 14:37 ` Greg Kroah-Hartman
2019-12-10 15:10 ` Krzysztof Kozlowski
2019-12-10 15:10 ` Krzysztof Kozlowski
2019-12-10 14:37 ` [PATCH 08/10] tty: serial: samsung_tty: use 'unsigned int' not 'unsigned' Greg Kroah-Hartman
2019-12-10 14:37 ` Greg Kroah-Hartman
2019-12-10 15:10 ` Krzysztof Kozlowski
2019-12-10 15:10 ` Krzysztof Kozlowski
2019-12-10 15:12 ` Marc Gonzalez
2019-12-10 15:12 ` Marc Gonzalez
2019-12-12 11:08 ` Greg Kroah-Hartman
2019-12-12 11:08 ` Greg Kroah-Hartman
2019-12-12 16:09 ` Christoph Hellwig
2019-12-12 16:09 ` Christoph Hellwig
2019-12-12 16:12 ` Greg Kroah-Hartman [this message]
2019-12-12 16:12 ` Greg Kroah-Hartman
2019-12-19 9:25 ` Marc Gonzalez
2019-12-19 9:25 ` Marc Gonzalez
2019-12-10 14:37 ` [PATCH 09/10] tty: serial: samsung_tty: fix up minor comment formatting Greg Kroah-Hartman
2019-12-10 14:37 ` Greg Kroah-Hartman
2019-12-10 15:14 ` Krzysztof Kozlowski
2019-12-10 15:14 ` Krzysztof Kozlowski
2019-12-10 14:37 ` [PATCH 10/10] tty: serial: samsung_tty: fix blank line checkpatch warning Greg Kroah-Hartman
2019-12-10 14:37 ` Greg Kroah-Hartman
2019-12-10 15:13 ` Krzysztof Kozlowski
2019-12-10 15:13 ` Krzysztof Kozlowski
2019-12-12 11:09 ` Greg Kroah-Hartman
2019-12-12 11:09 ` Greg Kroah-Hartman
2019-12-10 14:46 ` [PATCH 01/10] tty: serial: samsung: allow driver to be built by anyone Krzysztof Kozlowski
2019-12-10 14:46 ` Krzysztof Kozlowski
2019-12-10 14:54 ` Greg Kroah-Hartman
2019-12-10 14:54 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191212161234.GA1673430@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=hch@infradead.org \
--cc=jslaby@suse.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=marc.w.gonzalez@free.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.