All of lore.kernel.org
 help / color / mirror / Atom feed
From: Vignesh Raghavendra <vigneshr@ti.com>
To: Pratyush Yadav <p.yadav@ti.com>, Mark Brown <broonie@kernel.org>,
	Rob Herring <robh+dt@kernel.org>, Nishanth Menon <nm@ti.com>,
	Tero Kristo <kristo@kernel.org>, <linux-spi@vger.kernel.org>,
	<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH 1/4] arm64: dts: ti: k3-j721e-mcu: Fix ospi compatible
Date: Thu, 1 Apr 2021 11:58:53 +0530	[thread overview]
Message-ID: <18b87b48-84b0-bae6-c5c3-6e849282302b@ti.com> (raw)
In-Reply-To: <20210326130034.15231-2-p.yadav@ti.com>



On 3/26/21 6:30 PM, Pratyush Yadav wrote:
> The TI specific compatible should be followed by the generic
> "cdns,qspi-nor" compatible.
> 
> Signed-off-by: Pratyush Yadav <p.yadav@ti.com>
> ---

Reviewed-by: Vignesh Raghavendra <vigneshr@ti.com>

>  arch/arm64/boot/dts/ti/k3-j721e-mcu-wakeup.dtsi | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/ti/k3-j721e-mcu-wakeup.dtsi b/arch/arm64/boot/dts/ti/k3-j721e-mcu-wakeup.dtsi
> index 6c44afae9187..d56e3475aee7 100644
> --- a/arch/arm64/boot/dts/ti/k3-j721e-mcu-wakeup.dtsi
> +++ b/arch/arm64/boot/dts/ti/k3-j721e-mcu-wakeup.dtsi
> @@ -180,7 +180,7 @@ fss: fss@47000000 {
>  		ranges;
>  
>  		ospi0: spi@47040000 {
> -			compatible = "ti,am654-ospi";
> +			compatible = "ti,am654-ospi", "cdns,qspi-nor";
>  			reg = <0x0 0x47040000 0x0 0x100>,
>  				<0x5 0x00000000 0x1 0x0000000>;
>  			interrupts = <GIC_SPI 840 IRQ_TYPE_LEVEL_HIGH>;
> @@ -197,7 +197,7 @@ ospi0: spi@47040000 {
>  		};
>  
>  		ospi1: spi@47050000 {
> -			compatible = "ti,am654-ospi";
> +			compatible = "ti,am654-ospi", "cdns,qspi-nor";
>  			reg = <0x0 0x47050000 0x0 0x100>,
>  				<0x7 0x00000000 0x1 0x00000000>;
>  			interrupts = <GIC_SPI 841 IRQ_TYPE_LEVEL_HIGH>;
> 

WARNING: multiple messages have this Message-ID (diff)
From: Vignesh Raghavendra <vigneshr@ti.com>
To: Pratyush Yadav <p.yadav@ti.com>, Mark Brown <broonie@kernel.org>,
	Rob Herring <robh+dt@kernel.org>, Nishanth Menon <nm@ti.com>,
	Tero Kristo <kristo@kernel.org>, <linux-spi@vger.kernel.org>,
	<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH 1/4] arm64: dts: ti: k3-j721e-mcu: Fix ospi compatible
Date: Thu, 1 Apr 2021 11:58:53 +0530	[thread overview]
Message-ID: <18b87b48-84b0-bae6-c5c3-6e849282302b@ti.com> (raw)
In-Reply-To: <20210326130034.15231-2-p.yadav@ti.com>



On 3/26/21 6:30 PM, Pratyush Yadav wrote:
> The TI specific compatible should be followed by the generic
> "cdns,qspi-nor" compatible.
> 
> Signed-off-by: Pratyush Yadav <p.yadav@ti.com>
> ---

Reviewed-by: Vignesh Raghavendra <vigneshr@ti.com>

>  arch/arm64/boot/dts/ti/k3-j721e-mcu-wakeup.dtsi | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/ti/k3-j721e-mcu-wakeup.dtsi b/arch/arm64/boot/dts/ti/k3-j721e-mcu-wakeup.dtsi
> index 6c44afae9187..d56e3475aee7 100644
> --- a/arch/arm64/boot/dts/ti/k3-j721e-mcu-wakeup.dtsi
> +++ b/arch/arm64/boot/dts/ti/k3-j721e-mcu-wakeup.dtsi
> @@ -180,7 +180,7 @@ fss: fss@47000000 {
>  		ranges;
>  
>  		ospi0: spi@47040000 {
> -			compatible = "ti,am654-ospi";
> +			compatible = "ti,am654-ospi", "cdns,qspi-nor";
>  			reg = <0x0 0x47040000 0x0 0x100>,
>  				<0x5 0x00000000 0x1 0x0000000>;
>  			interrupts = <GIC_SPI 840 IRQ_TYPE_LEVEL_HIGH>;
> @@ -197,7 +197,7 @@ ospi0: spi@47040000 {
>  		};
>  
>  		ospi1: spi@47050000 {
> -			compatible = "ti,am654-ospi";
> +			compatible = "ti,am654-ospi", "cdns,qspi-nor";
>  			reg = <0x0 0x47050000 0x0 0x100>,
>  				<0x7 0x00000000 0x1 0x00000000>;
>  			interrupts = <GIC_SPI 841 IRQ_TYPE_LEVEL_HIGH>;
> 

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2021-04-01  6:29 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-26 13:00 [PATCH 0/4] Convert Cadence QSPI bindings to yaml Pratyush Yadav
2021-03-26 13:00 ` Pratyush Yadav
2021-03-26 13:00 ` [PATCH 1/4] arm64: dts: ti: k3-j721e-mcu: Fix ospi compatible Pratyush Yadav
2021-03-26 13:00   ` Pratyush Yadav
2021-04-01  6:28   ` Vignesh Raghavendra [this message]
2021-04-01  6:28     ` Vignesh Raghavendra
2021-03-26 13:00 ` [PATCH 2/4] arm64: dts: ti: k3-j7200-mcu: " Pratyush Yadav
2021-03-26 13:00   ` Pratyush Yadav
2021-04-01  6:28   ` Vignesh Raghavendra
2021-04-01  6:28     ` Vignesh Raghavendra
2021-03-26 13:00 ` [PATCH 3/4] arm64: dts: ti: k3-am64-main: " Pratyush Yadav
2021-03-26 13:00   ` Pratyush Yadav
2021-04-01  6:29   ` Vignesh Raghavendra
2021-04-01  6:29     ` Vignesh Raghavendra
2021-03-26 13:00 ` [PATCH 4/4] dt-bindings: spi: Convert cadence-quadspi.txt to cadence-quadspi.yaml Pratyush Yadav
2021-03-26 13:00   ` Pratyush Yadav
2021-03-27 18:36   ` Rob Herring
2021-03-27 18:36     ` Rob Herring
2021-03-29 18:22     ` Pratyush Yadav
2021-03-29 18:22       ` Pratyush Yadav
2021-04-01  8:27       ` Vignesh Raghavendra
2021-04-01  8:27         ` Vignesh Raghavendra
2021-04-01  8:56         ` Pratyush Yadav
2021-04-01  8:56           ` Pratyush Yadav
2021-03-31 19:11   ` Mark Brown
2021-03-31 19:11     ` Mark Brown
2021-03-31 19:39     ` Pratyush Yadav
2021-03-31 19:39       ` Pratyush Yadav
2021-04-01 14:13       ` Mark Brown
2021-04-01 14:13         ` Mark Brown
2021-04-05  8:34         ` Pratyush Yadav
2021-04-05  8:34           ` Pratyush Yadav
2021-04-01 10:16 ` (subset) [PATCH 0/4] Convert Cadence QSPI bindings to yaml Mark Brown
2021-04-01 10:16   ` Mark Brown
2021-04-01 13:52 ` Nishanth Menon
2021-04-01 13:52   ` Nishanth Menon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=18b87b48-84b0-bae6-c5c3-6e849282302b@ti.com \
    --to=vigneshr@ti.com \
    --cc=broonie@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=kristo@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-spi@vger.kernel.org \
    --cc=nm@ti.com \
    --cc=p.yadav@ti.com \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.