From: Mark Brown <broonie@kernel.org>
To: Pratyush Yadav <p.yadav@ti.com>
Cc: Rob Herring <robh+dt@kernel.org>, Nishanth Menon <nm@ti.com>,
Tero Kristo <kristo@kernel.org>,
linux-spi@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
Vignesh Raghavendra <vigneshr@ti.com>
Subject: Re: [PATCH 4/4] dt-bindings: spi: Convert cadence-quadspi.txt to cadence-quadspi.yaml
Date: Thu, 1 Apr 2021 15:13:28 +0100 [thread overview]
Message-ID: <20210401141328.GH4758@sirena.org.uk> (raw)
In-Reply-To: <20210331193930.tzsvbjup3wpxmh26@ti.com>
[-- Attachment #1: Type: text/plain, Size: 1319 bytes --]
On Thu, Apr 01, 2021 at 01:09:32AM +0530, Pratyush Yadav wrote:
> I did take a look by running git log on
> Documentation/devicetree/bindings/spi/ and there is no single style
> being used. Using "dt-bindings: spi:" is a popular choice. Some other
> commits just use "spi:". And then some use "spi: dt-bindings:". The last
> commit to touch cadence-quadspi.txt (fcebca39938f) used the prefix
> "dt-bindings: spi:".
Yes, lots of people pick unfortunate subject lines for DT patches - that
doesn't mean it's good. I'm looking to see spi: same as for all other
SPI patches.
> So on the prefix front I think the subject is good enough. Of course, if
> you have any other preference then it can be re-worded but let's first
> be clear on what the expectation is. And then let's make sure to apply
> it to all future patches uniformly. This way future contributors won't
> have to take a guess on what the expected prefix is.
I do edit some percentage of patches, but some do slip through for
various reasons. There's also some things that just get completely
missed, especially if there isn't also a code patch nearby.
> Apart from the prefix is there anything else to improve? IMHO the
> subject is good enough but I'm open to suggestions.
There was the thing with constraints.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Mark Brown <broonie@kernel.org>
To: Pratyush Yadav <p.yadav@ti.com>
Cc: Rob Herring <robh+dt@kernel.org>, Nishanth Menon <nm@ti.com>,
Tero Kristo <kristo@kernel.org>,
linux-spi@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
Vignesh Raghavendra <vigneshr@ti.com>
Subject: Re: [PATCH 4/4] dt-bindings: spi: Convert cadence-quadspi.txt to cadence-quadspi.yaml
Date: Thu, 1 Apr 2021 15:13:28 +0100 [thread overview]
Message-ID: <20210401141328.GH4758@sirena.org.uk> (raw)
In-Reply-To: <20210331193930.tzsvbjup3wpxmh26@ti.com>
[-- Attachment #1.1: Type: text/plain, Size: 1319 bytes --]
On Thu, Apr 01, 2021 at 01:09:32AM +0530, Pratyush Yadav wrote:
> I did take a look by running git log on
> Documentation/devicetree/bindings/spi/ and there is no single style
> being used. Using "dt-bindings: spi:" is a popular choice. Some other
> commits just use "spi:". And then some use "spi: dt-bindings:". The last
> commit to touch cadence-quadspi.txt (fcebca39938f) used the prefix
> "dt-bindings: spi:".
Yes, lots of people pick unfortunate subject lines for DT patches - that
doesn't mean it's good. I'm looking to see spi: same as for all other
SPI patches.
> So on the prefix front I think the subject is good enough. Of course, if
> you have any other preference then it can be re-worded but let's first
> be clear on what the expectation is. And then let's make sure to apply
> it to all future patches uniformly. This way future contributors won't
> have to take a guess on what the expected prefix is.
I do edit some percentage of patches, but some do slip through for
various reasons. There's also some things that just get completely
missed, especially if there isn't also a code patch nearby.
> Apart from the prefix is there anything else to improve? IMHO the
> subject is good enough but I'm open to suggestions.
There was the thing with constraints.
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-04-01 18:07 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-26 13:00 [PATCH 0/4] Convert Cadence QSPI bindings to yaml Pratyush Yadav
2021-03-26 13:00 ` Pratyush Yadav
2021-03-26 13:00 ` [PATCH 1/4] arm64: dts: ti: k3-j721e-mcu: Fix ospi compatible Pratyush Yadav
2021-03-26 13:00 ` Pratyush Yadav
2021-04-01 6:28 ` Vignesh Raghavendra
2021-04-01 6:28 ` Vignesh Raghavendra
2021-03-26 13:00 ` [PATCH 2/4] arm64: dts: ti: k3-j7200-mcu: " Pratyush Yadav
2021-03-26 13:00 ` Pratyush Yadav
2021-04-01 6:28 ` Vignesh Raghavendra
2021-04-01 6:28 ` Vignesh Raghavendra
2021-03-26 13:00 ` [PATCH 3/4] arm64: dts: ti: k3-am64-main: " Pratyush Yadav
2021-03-26 13:00 ` Pratyush Yadav
2021-04-01 6:29 ` Vignesh Raghavendra
2021-04-01 6:29 ` Vignesh Raghavendra
2021-03-26 13:00 ` [PATCH 4/4] dt-bindings: spi: Convert cadence-quadspi.txt to cadence-quadspi.yaml Pratyush Yadav
2021-03-26 13:00 ` Pratyush Yadav
2021-03-27 18:36 ` Rob Herring
2021-03-27 18:36 ` Rob Herring
2021-03-29 18:22 ` Pratyush Yadav
2021-03-29 18:22 ` Pratyush Yadav
2021-04-01 8:27 ` Vignesh Raghavendra
2021-04-01 8:27 ` Vignesh Raghavendra
2021-04-01 8:56 ` Pratyush Yadav
2021-04-01 8:56 ` Pratyush Yadav
2021-03-31 19:11 ` Mark Brown
2021-03-31 19:11 ` Mark Brown
2021-03-31 19:39 ` Pratyush Yadav
2021-03-31 19:39 ` Pratyush Yadav
2021-04-01 14:13 ` Mark Brown [this message]
2021-04-01 14:13 ` Mark Brown
2021-04-05 8:34 ` Pratyush Yadav
2021-04-05 8:34 ` Pratyush Yadav
2021-04-01 10:16 ` (subset) [PATCH 0/4] Convert Cadence QSPI bindings to yaml Mark Brown
2021-04-01 10:16 ` Mark Brown
2021-04-01 13:52 ` Nishanth Menon
2021-04-01 13:52 ` Nishanth Menon
2021-03-29 1:14 [PATCH 4/4] dt-bindings: spi: Convert cadence-quadspi.txt to cadence-quadspi.yaml kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210401141328.GH4758@sirena.org.uk \
--to=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=kristo@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=nm@ti.com \
--cc=p.yadav@ti.com \
--cc=robh+dt@kernel.org \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.